From patchwork Tue Jul 3 16:46:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Palmer, Thomas" X-Patchwork-Id: 140992 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp1382252ljj; Tue, 3 Jul 2018 09:46:07 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIgaPBwEJboaf1lh8CyvyAQ5wvtBx2tdFfR8cHPAARMvnGPkD/cilBtB8gvSpgpb5lg5jok X-Received: by 2002:a17:902:b596:: with SMTP id a22-v6mr30392855pls.154.1530636367495; Tue, 03 Jul 2018 09:46:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530636367; cv=none; d=google.com; s=arc-20160816; b=LAUEEupQZvAoXTdA3TLAZJnFI/VbcRIH+zrugRQQMSj2EINYgolLVVIJWRniEnyPP0 7n+oFuE8PdRFrmPUXwO3I2UcTRyOny3FsXGbEScZhnLxFgXAzY06aJA3tzlrzFi6Z5AR 48HR+vIxlS6gcF4R/JJkhJd6loN5rhgQ6cb2uMQv1ibbP/mrNv+GlSyaCddoSYmiV6Oa tyUfCNbBD8Rc05RCA//RGM8YuQgQDIG51AOfCOjwtSirtaQltJm+F3He3uaTjViF9x/S iljft9qQvU0rQGRiUTEEI8WsCdwlce89mjK6opucX/IlpmeDnCV0rqGU6+HhCHNkAk1o DEJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:delivered-to :arc-authentication-results; bh=1x5OUwT5RBK5UuB0WJZmfQTmftfjHeZP4pePC86St5s=; b=hgGbkvugS/JQxs/d/I/ofjMVkPERatDe/kjaq2YaT0KBaL8BJQEYgRlhVRVP9C75sn DL1vfeAmo7eYzYBrCmg1Dtz2d4/VrBxlkSsUQp7knJ7Y4qE8kaMtmj/N67yKY6qrutp5 JVLobmt+GNsGZoV+xye12/i2xJDlCJzU/0g1FuYJ7vX5L7s8hneg+saUGHtc53TBbOW0 aRnxns3OxN/K/VvIWKjo6GeesVm0Bpzu6k8455uTfsxzzVyax13hHFZ0PYYK6iKkC4cK r0R6nfDSW2LuL9H8ph6BRl9CADmdX1027d2fPce5FVqVx+8TYPy5bITCQRmyGdjMTGPU uXAQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id b76-v6si1547184pfl.223.2018.07.03.09.46.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Jul 2018 09:46:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id CB99E20D7ADC7; Tue, 3 Jul 2018 09:46:06 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: None (no SPF record) identity=mailfrom; client-ip=15.241.140.75; helo=g4t3426.houston.hpe.com; envelope-from=thomas.palmer@hpe.com; receiver=edk2-devel@lists.01.org Received: from g4t3426.houston.hpe.com (g4t3426.houston.hpe.com [15.241.140.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AC881209605A5 for ; Tue, 3 Jul 2018 09:46:04 -0700 (PDT) Received: from arm-build-server.us.rdlabs.hpecorp.net (arm-build-server.us.rdlabs.hpecorp.net [16.84.24.54]) by g4t3426.houston.hpe.com (Postfix) with ESMTP id 56DE37E; Tue, 3 Jul 2018 16:46:03 +0000 (UTC) From: Thomas Palmer To: edk2-devel@lists.01.org Date: Tue, 3 Jul 2018 11:46:01 -0500 Message-Id: <1530636361-6450-1-git-send-email-thomas.palmer@hpe.com> X-Mailer: git-send-email 2.7.4 Subject: [edk2] [PATCH 1/1] MdeModulePkg/DisplayEngineDxe: Fix small InitializeDisplayEngine leak X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: eric.dong@intel.com, star.zeng@intel.com MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" After calling RegisterHotKey, the allocated memory in NewString should be freed. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Thomas Palmer --- MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.7.4 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Dandan Bi Signed-off-by: Thomas Palmer Reviewed-by: Star Zeng Reviewed-by: Dandan Bi Signed-off-by: Thomas Palmer diff --git a/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c b/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c index f2eac4d3fece..7390f954b67f 100644 --- a/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c +++ b/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c @@ -4221,11 +4221,13 @@ InitializeDisplayEngine ( NewString = HiiGetString (gHiiHandle, STRING_TOKEN (FUNCTION_TEN_STRING), NULL); ASSERT (NewString != NULL); FormBrowserEx2->RegisterHotKey (&HotKey, BROWSER_ACTION_SUBMIT, 0, NewString); + FreePool (NewString); HotKey.ScanCode = SCAN_F9; NewString = HiiGetString (gHiiHandle, STRING_TOKEN (FUNCTION_NINE_STRING), NULL); ASSERT (NewString != NULL); FormBrowserEx2->RegisterHotKey (&HotKey, BROWSER_ACTION_DEFAULT, EFI_HII_DEFAULT_CLASS_STANDARD, NewString); + FreePool (NewString); } return EFI_SUCCESS;