From patchwork Tue May 11 11:27:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leizhen \(ThunderTown\)" X-Patchwork-Id: 434197 Delivered-To: patch@linaro.org Received: by 2002:a02:c901:0:0:0:0:0 with SMTP id t1csp3730593jao; Tue, 11 May 2021 04:27:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxfYrK8MOs+efnROe5N8rDjRJ0S9/1eKH4VaUZIkRewRZXWgjz2cuAdiz7Nleht8pGZtxcj X-Received: by 2002:a17:906:c40f:: with SMTP id u15mr30625970ejz.11.1620732476582; Tue, 11 May 2021 04:27:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620732476; cv=none; d=google.com; s=arc-20160816; b=haUzDgV/CiNM32Mx9st3m0nwrLgiyeuB8xykxdh+yYUH19NSmWT7z9AgGcPVLF753s jb7Cl89Pgm3qe7Mihd9X1wf4A7sh+zlsSOsmS1iCiHTC5x97vLqkivnKazLUmGpQAJhk YLClN5dPMgmqJmpxdOzaqJvHs78PgKu89QtCBz4qhLeXMGtqwQ+39GJVMP5qxLlfi9ze QOjs18d0kmL6IEOzATit49BZFnn+iTItlXk2ikG5RuCfG2wxMmLtHYbD0AuaOBuNUpVU P5DfWUOv4396tWZOTsCVcsl+gRi63rHUhWunKTUxQ8tfW0ezVmnd9t8OxOnTbAXLPCAj sqyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=4JIPPi06yC7NiGPYbI0Mcyght6Ro/z6VQMkF80LXokE=; b=ceJ+Z1WvnZebPELv/ITW1T83xVwfVL61lELhMU6TRG87XHnjL2r3a2nj/ImNRiHokU JvAxzkBDQ+ueT37aG5mlKjbHAUKunjKNv4QT1lRuhlAI6XDpue9kd+gaCwbcUYxmDoio oWl51qYSgaexK9ysPtwZztMHUQ84pBSSo4NyssEbF66dfNeiLskWpJHAZpeeYcoGbQvZ ZPntoONP62p4rx4PyL1DXGzxdtX/9t3x2rbGTWj9uSjpyhKrORtZ07NvZvaHyHM+G9d+ HucmHeyRUUBK09/TWZ26mrpcdhkppd5hG3CNFMeSTZCkB7n2dbKtfnid+w1Yb0otLdIa A8qw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-samsung-soc-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-samsung-soc-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ay16si16607261edb.435.2021.05.11.04.27.56; Tue, 11 May 2021 04:27:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-samsung-soc-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-samsung-soc-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-samsung-soc-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230441AbhEKL3C (ORCPT + 4 others); Tue, 11 May 2021 07:29:02 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:2630 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231446AbhEKL3B (ORCPT ); Tue, 11 May 2021 07:29:01 -0400 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FfbDJ4wRvzPwvH; Tue, 11 May 2021 19:24:32 +0800 (CST) Received: from thunder-town.china.huawei.com (10.174.177.72) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.498.0; Tue, 11 May 2021 19:27:45 +0800 From: Zhen Lei To: Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , David Airlie , Daniel Vetter , Krzysztof Kozlowski , dri-devel , linux-samsung-soc , linux-arm-kernel CC: Zhen Lei Subject: [PATCH 1/1] drm/exynos/decon5433: Remove redundant error printing in exynos5433_decon_probe() Date: Tue, 11 May 2021 19:27:33 +0800 Message-ID: <20210511112733.5383-1-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.174.177.72] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org When devm_ioremap_resource() fails, a clear enough error message will be printed by its subfunction __devm_ioremap_resource(). The error information contains the device name, failure cause, and possibly resource information. Therefore, remove the error printing here to simplify code and reduce the binary size. Reported-by: Hulk Robot Signed-off-by: Zhen Lei --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.26.0.106.g9fadedd diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c index b9a4b7670a899a1..197b97341cad26c 100644 --- a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c +++ b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c @@ -815,10 +815,8 @@ static int exynos5433_decon_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); ctx->addr = devm_ioremap_resource(dev, res); - if (IS_ERR(ctx->addr)) { - dev_err(dev, "ioremap failed\n"); + if (IS_ERR(ctx->addr)) return PTR_ERR(ctx->addr); - } ret = decon_conf_irq(ctx, "vsync", decon_irq_handler, 0); if (ret < 0)