From patchwork Tue May 11 09:49:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leizhen \(ThunderTown\)" X-Patchwork-Id: 434188 Delivered-To: patch@linaro.org Received: by 2002:a02:c901:0:0:0:0:0 with SMTP id t1csp3660224jao; Tue, 11 May 2021 02:49:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJziRr3pz1b3kMZzeJOuG/lPfY/dgGA78tKBX8HVXRBdwpQvwjFEXr98bcvPZYR79dLxS/oZ X-Received: by 2002:aa7:cad4:: with SMTP id l20mr4722635edt.382.1620726582818; Tue, 11 May 2021 02:49:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620726582; cv=none; d=google.com; s=arc-20160816; b=gG0OTAjBiTvKix2ot+5Q+dJI/F9ujMFDB5NADASPz4P8iSWDlK5IvdAWsO2ewXBKO+ nerd7AzKnkOW4Ps6qekjnqcgzP/SAs9jPHmOZUFhzM96t4nRgevxmBpk9ncdfw2K5xEi G5S+EMoEcow5zUhIruHgBvBbg41LyMliVfLkQbzN05U6SMp/mGY0l/J5YMtBraTt4efg wVS6JWoqVNUVKmFMWe0jndUaAv9HUJxIvqqmO0lSbI7N1q0iNk9nXgci5ACItyit+iHG 29cVf6sNLs+/4Gcx6rfOE9KfMtVe9b/FQyIXf9U3iP4yDsoptXyGNsBXbj5JsJXqypuD KOSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=N9irwbda8DIj0jleaelEFgXJ1C0WA3cF+vmFC7xcJ3A=; b=oY7KeHBf46vR4vZOmBX2rKVJMdM4/eePbyna/IpyeBFLQGmPnlsJjSO8aYNEKMD/lg s1KGPT08U3a56rmUdUq+Jw9wLDhYxo71aCjpTJYJ7am3U4AB3kIMiDZd//E27DQ1/EiZ pI7zB+VQzCnApYo916iFGbzNT5B/i6OpHZTdvNXfQ+g6iP5MiTJV3+pZH2aJbr+0ach5 TM4bDq9O8u1+XxBV6UEyofRywmXYpTbhYT7G1ryEXT2YfZEDh9HogHde/KUvQy9KORmH GUw4eWC6k9z7BP9g8QSceNUVWXjiUNqD2mG7GGnHwiLD5/+Tb9HJ73N73nV0alpVT+pz 7nEA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-pm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g24si16733132ejd.476.2021.05.11.02.49.42; Tue, 11 May 2021 02:49:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-pm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-pm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231217AbhEKJur (ORCPT + 8 others); Tue, 11 May 2021 05:50:47 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:2484 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230520AbhEKJur (ORCPT ); Tue, 11 May 2021 05:50:47 -0400 Received: from dggeml701-chm.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4FfY402HwbzYk9j; Tue, 11 May 2021 17:47:12 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggeml701-chm.china.huawei.com (10.3.17.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Tue, 11 May 2021 17:49:24 +0800 Received: from thunder-town.china.huawei.com (10.174.177.72) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 11 May 2021 17:49:24 +0800 From: Zhen Lei To: Claudiu Beznea , Sebastian Reichel , Nicolas Ferre , "Alexandre Belloni" , Ludovic Desroches , linux-pm , linux-arm-kernel CC: Zhen Lei Subject: [PATCH 1/1] power: reset: at91-sama5d2_shdwc: Remove redundant error printing in at91_shdwc_probe() Date: Tue, 11 May 2021 17:49:19 +0800 Message-ID: <20210511094919.4885-1-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.174.177.72] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org When devm_ioremap_resource() fails, a clear enough error message will be printed by its subfunction __devm_ioremap_resource(). The error information contains the device name, failure cause, and possibly resource information. Therefore, remove the error printing here to simplify code and reduce the binary size. Reported-by: Hulk Robot Signed-off-by: Zhen Lei --- drivers/power/reset/at91-sama5d2_shdwc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.26.0.106.g9fadedd diff --git a/drivers/power/reset/at91-sama5d2_shdwc.c b/drivers/power/reset/at91-sama5d2_shdwc.c index 125e592af445e32..d8ecffe72f165cb 100644 --- a/drivers/power/reset/at91-sama5d2_shdwc.c +++ b/drivers/power/reset/at91-sama5d2_shdwc.c @@ -351,10 +351,8 @@ static int __init at91_shdwc_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); at91_shdwc->shdwc_base = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(at91_shdwc->shdwc_base)) { - dev_err(&pdev->dev, "Could not map reset controller address\n"); + if (IS_ERR(at91_shdwc->shdwc_base)) return PTR_ERR(at91_shdwc->shdwc_base); - } match = of_match_node(at91_shdwc_of_match, pdev->dev.of_node); at91_shdwc->rcfg = match->data;