From patchwork Sat May 8 13:17:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Skripkin X-Patchwork-Id: 432924 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED3C5C43460 for ; Sat, 8 May 2021 13:17:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CF1EC61456 for ; Sat, 8 May 2021 13:17:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231152AbhEHNSY (ORCPT ); Sat, 8 May 2021 09:18:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230438AbhEHNSU (ORCPT ); Sat, 8 May 2021 09:18:20 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4CA8C061574; Sat, 8 May 2021 06:17:16 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id w15so15054259ljo.10; Sat, 08 May 2021 06:17:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9Y3teniSGRQ0VOrXvsmVmKBJjGDITdl3HQv9AqHHKVM=; b=uiydmKVhHj4fc2Ul7DZWPG69vVbH7I5EBSw8mpeOLCH+uTfBJ0WC4NHAqr5+Fi9YHL +QkvyXT3E5mgBGFpQOu9dsYT1VHnEwGX7LnBG1ZBXtXpB2Oy2I7ng+ZTrXqN3+6wPjvU DnMICAhLurTzeHqppDfUdlGK+fcYP524QX3SfWhqIW/MdUER7aMchZAhM099WO2D9xWn UPz0y0/SUC4frt5zrdz4Y6Zgsb5AhEA/9U9eFIMbjpXhhgzwcxp99mUmjhLBxLcdEmtj iWWZoaZz/qS+N5GPPpLt+w3tQM4VzX25JFBTs0sqWm0rqCPPU4tvArU0wh/AE5+X0RC5 Ly1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9Y3teniSGRQ0VOrXvsmVmKBJjGDITdl3HQv9AqHHKVM=; b=mGALh0DhRaY3RpAy6yPoY8vzFnVll0JVpst5hGU82NIvw0JxzPEOCTEOZLxLnOSj2X +1MbbTruF8dh2y+fZWVgxRLwEDpNeWkEnc6EOg/5xhjOx9ky/+EK57wQ8O4Iu5OnCAqO cOU+AquCdq6rCBZeLoSnorv1NA4q8/lG6HZeYGUBWbqVBKozljjv5xEtaju3pPYtSkRi mboS0N8VRo0PDcjIzykuXVVkpU2y0ee/24jKwJ34O1X8zDSAdulSSwZ1ZZiUCKj/jOBK B7aCvU02zInoFTB6fpEpYKMAc/uCQrpLN7Rtr5utCV8dL4oYvcLcp4PXezuxwXsL45Q7 koWA== X-Gm-Message-State: AOAM531tcfPzC1PoPLwsM71Kc3Di7Bd021C7d3K4/tNh0dzWKJUE/VzS t4E3Mzgl/BnnJxb9MlHJzHN5BSYDuBPhIg== X-Google-Smtp-Source: ABdhPJwCrUuouKX7ZTNOggSFm6MybDemlvemuHTfoseX9ntL8SPfprKbrGyITBS/vfg8YmM3F/Fjcw== X-Received: by 2002:a2e:b5d6:: with SMTP id g22mr12108585ljn.423.1620479835253; Sat, 08 May 2021 06:17:15 -0700 (PDT) Received: from localhost.localdomain ([185.215.60.119]) by smtp.gmail.com with ESMTPSA id j10sm1636022lfb.176.2021.05.08.06.17.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 May 2021 06:17:14 -0700 (PDT) From: Pavel Skripkin To: mchehab@kernel.org, sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Pavel Skripkin Subject: [PATCH v4 1/3] staging: media: atomisp: remove useless breaks Date: Sat, 8 May 2021 16:17:12 +0300 Message-Id: <4b4a6ad1bc8fc1fd6aafc3e6cd7a4969890340c1.1620479607.git.paskripkin@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: References: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Breaks are not useful after a return, they can simply be removed. Signed-off-by: Pavel Skripkin --- .../pci/hive_isp_css_common/host/input_system.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c index 0f5a231672a8..fd82997b11cc 100644 --- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c +++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c @@ -904,16 +904,12 @@ static input_system_err_t input_system_configure_channel( break; case INPUT_SYSTEM_SOURCE_TPG: return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED; - break; case INPUT_SYSTEM_SOURCE_PRBS: return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED; - break; case INPUT_SYSTEM_SOURCE_FIFO: return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED; - break; default: return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED; - break; } if (error != INPUT_SYSTEM_ERR_NO_ERROR) return error; @@ -995,7 +991,6 @@ static input_system_err_t input_buffer_configuration(void) default: config.csi_buffer_flags[port] |= INPUT_SYSTEM_CFG_FLAG_CONFLICT; return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED; - break; } // Check acquisition buffer specified but set it later since it has to be unique. @@ -1032,7 +1027,6 @@ static input_system_err_t input_buffer_configuration(void) default: return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED; - break; } } else { config.csi_buffer_flags[port] = INPUT_SYSTEM_CFG_FLAG_BLOCKED; @@ -1319,7 +1313,6 @@ static input_system_err_t configuration_to_registers(void) default: return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED; - break; } // end of switch (source_type) @@ -1696,16 +1689,12 @@ static input_system_err_t input_system_configure_channel_sensor( break; case INPUT_SYSTEM_FIFO_CAPTURE_WITH_COUNTING: return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED; - break; case INPUT_SYSTEM_XMEM_CAPTURE: return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED; - break; case INPUT_SYSTEM_XMEM_ACQUIRE: return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED; - break; default: return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED; - break; } return INPUT_SYSTEM_ERR_NO_ERROR; } From patchwork Sat May 8 13:17:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Skripkin X-Patchwork-Id: 432727 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA921C433ED for ; Sat, 8 May 2021 13:17:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 95098613EE for ; Sat, 8 May 2021 13:17:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231180AbhEHNS1 (ORCPT ); Sat, 8 May 2021 09:18:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230438AbhEHNS0 (ORCPT ); Sat, 8 May 2021 09:18:26 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F324C061574; Sat, 8 May 2021 06:17:24 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id x2so16679664lff.10; Sat, 08 May 2021 06:17:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IqIPJJa374NLUqCHGDm7/7oqA7WluXXWMUnsKHbUjRk=; b=G7n5QwQnqlHWJUyZlWJbQbm69J5Xhdd4p7ykcNP16YHE3yjOhG5FWBrjAoQnm6mas7 lkFxD0jnTXMvr6+yXPBi5OXi3qQ+3ggbs14zLCSWTCcKQ9IdVMsA+NlymI8onhW20Cyt UPkEuJSpRezF7dyZ2pcktAYsHpwNCfNo+1+E8oaxujBDzfIaUQevAJimYHxvIXR1yfIe 5ekOlL8B7M/DCr1LeTbYOQWUuVCb6j5CmCEBZgrIp/IjDCzD1QL7Myb0TOj1ue00NdHc UWOrAZjg0/77+X0NgO7YE55qttsAANzaonkQnelWyJ6MJdvvBUBYb+wf6asVbkw5BE1K SgYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IqIPJJa374NLUqCHGDm7/7oqA7WluXXWMUnsKHbUjRk=; b=WRwUopakxu8Qf1E0IV1IdVk3VzanzhOi3Mj9QdYS/SnKyStvuQqde4wi6VC0eHDSLM m5OhiMdZWoQpLDzJlRrrN1cMESypeTUcevxpErB3HkaKJybNRAuXZRSkAqnO3twp4rZv 8FaWiRA8RM/jWz7ZlAcTETJHX5kkPVWA8URlb0cHYo34g0Duk8l2PSg6HTFLBmnD3Sde EffLxiy+gJfITeqzGS0UaecjpHHpLruEdafIoP08ZZpFE3qaqiiNxDjEP5y4NBEREvIY dasuSM6JhM4Rh7Mg4pJIZpuEBl4i1CQvG/9ezkYPV9E3GxrJQKnRj3iNy6kay182jXWD DcOQ== X-Gm-Message-State: AOAM533b1eFlCSh1dCEOHkbWNMqQwPFExqDJFxtZJiT2chBbrnH98B11 MP0BfwzTmP2TyRg9RqSK4MM= X-Google-Smtp-Source: ABdhPJx/fVUU6CXFP8zvE4NAJ35Rfkq3wppWAa7ttRNNi2uAeDj59oOGUAITF8ywkveV6DW0wKKELA== X-Received: by 2002:ac2:44da:: with SMTP id d26mr10291008lfm.522.1620479842624; Sat, 08 May 2021 06:17:22 -0700 (PDT) Received: from localhost.localdomain ([185.215.60.119]) by smtp.gmail.com with ESMTPSA id m25sm1646566lfo.279.2021.05.08.06.17.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 May 2021 06:17:22 -0700 (PDT) From: Pavel Skripkin To: mchehab@kernel.org, sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Pavel Skripkin Subject: [PATCH v4 2/3] staging: media: atomisp: remove dublicate code Date: Sat, 8 May 2021 16:17:20 +0300 Message-Id: <3944cd10bb5a64157781b1e0ef044c62c05f07c7.1620479607.git.paskripkin@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: References: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Removed dublicate returns and breaks inside switch statements and useless return after switch. Signed-off-by: Pavel Skripkin --- .../pci/hive_isp_css_common/host/input_system.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c index fd82997b11cc..76414b6b43c9 100644 --- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c +++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c @@ -903,11 +903,8 @@ static input_system_err_t input_system_configure_channel( error = input_system_configure_channel_sensor(channel); break; case INPUT_SYSTEM_SOURCE_TPG: - return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED; case INPUT_SYSTEM_SOURCE_PRBS: - return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED; case INPUT_SYSTEM_SOURCE_FIFO: - return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED; default: return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED; } @@ -1301,13 +1298,7 @@ static input_system_err_t configuration_to_registers(void) break; case INPUT_SYSTEM_SOURCE_TPG: - - break; - case INPUT_SYSTEM_SOURCE_PRBS: - - break; - case INPUT_SYSTEM_SOURCE_FIFO: break; @@ -1688,15 +1679,11 @@ static input_system_err_t input_system_configure_channel_sensor( break; case INPUT_SYSTEM_FIFO_CAPTURE_WITH_COUNTING: - return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED; case INPUT_SYSTEM_XMEM_CAPTURE: - return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED; case INPUT_SYSTEM_XMEM_ACQUIRE: - return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED; default: return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED; } - return INPUT_SYSTEM_ERR_NO_ERROR; } // Test flags and set structure. From patchwork Sat May 8 13:17:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Skripkin X-Patchwork-Id: 432923 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA0A6C43461 for ; Sat, 8 May 2021 13:17:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BBC216140F for ; Sat, 8 May 2021 13:17:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231211AbhEHNSf (ORCPT ); Sat, 8 May 2021 09:18:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230438AbhEHNSe (ORCPT ); Sat, 8 May 2021 09:18:34 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9EC3BC061574; Sat, 8 May 2021 06:17:32 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id c3so16694895lfs.7; Sat, 08 May 2021 06:17:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0S06plEE29isvKviL6ILjCR3CE2KnKhZ0925tx9PQpY=; b=vY+IMZPooRMjOtPm5pg/xrmZPiFE7w25mRru10XQXJx7kpiy86zCoQkgRV272+O5eP UlBN6eAkPBtuFPEL1/nyCsktpL9GAZjdkgoSa8cfLNQatGgQL067/vVDQeWStt6GMTCg mDAk3HBCAtg+TKrQM1FeBZ5GuKqNEmM5GQ/MssZb6bXxZo4zdZJZcQsSg0v551Hh+Vn6 VuxN+QhgE16k+xX32UeBUyPzE2Nyk2vfahYZj4VJbUWKDgtCOq5FPuDc0ffZmFFAVm/3 SmEmvo0Os3kGNapE9mKjxmSwoV6kJ8OZBfeJCPrLtgZdmx3WIwUprstbcN6nt+DhZ4ZZ FImQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0S06plEE29isvKviL6ILjCR3CE2KnKhZ0925tx9PQpY=; b=IOk0q10vYmRLButD/W2rc4FUoGsVxS2HrRrjCJbljYTiL+XZm2hI8eBKsUZA7fTMEM HMU0Cognx/yJNoQPtSWrcAvDImHq8+2odIlB8yMdAAKkfleu6smNItPzrqG1GTXW2U35 PG6Oania2QjlBQr2IguQ2V52w6YrTpzVwabNVE7WSnLIwRYsvE8cnru4kNrhW1dJYFTy aL3jzZ5LJQL+UCx/CtjcNBPL9OjXA7MApJ8c5eefPC8mxfTedEenNFDYP/tWT8wc6qsW cH3gJ60rT0k6DkZbRBhKsc7DcVVZF5yXxfKLoo+qKjzk2hDa5c1EbBNb3LZOsTUZcqfN HnYw== X-Gm-Message-State: AOAM530zrtTIxsAN2IjKIl4WRN+xd/FsCT9oBAkBc5Bi/1sBK97ts9gW D3Xm+n3HM+X49XmhXFWFYHQ= X-Google-Smtp-Source: ABdhPJxUUg5L8GCKluOA4tjn3sZ7XksIti9/Kt2rHubp3otdXglQ24KVBa0o2EuqHjI+TpxB7ke19Q== X-Received: by 2002:a19:f114:: with SMTP id p20mr7379795lfh.530.1620479851009; Sat, 08 May 2021 06:17:31 -0700 (PDT) Received: from localhost.localdomain ([185.215.60.119]) by smtp.gmail.com with ESMTPSA id b11sm1619390lfi.292.2021.05.08.06.17.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 May 2021 06:17:30 -0700 (PDT) From: Pavel Skripkin To: mchehab@kernel.org, sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Pavel Skripkin Subject: [PATCH v4 3/3] staging: media: atomisp: remove useless returns Date: Sat, 8 May 2021 16:17:27 +0300 Message-Id: <23a6984ddfb15ba38f6983381bb6fdaef3edd7d8.1620479607.git.paskripkin@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: References: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Returns are not useful at the end of void functions, they can simply be removed. Signed-off-by: Pavel Skripkin --- .../hive_isp_css_common/host/input_system.c | 38 ------------------- 1 file changed, 38 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c index 76414b6b43c9..8e085dda0c18 100644 --- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c +++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c @@ -174,8 +174,6 @@ void input_system_get_state( ctrl_unit_get_state(ID, sub_id, &state->ctrl_unit_state[sub_id - CTRL_UNIT0_ID]); } - - return; } void receiver_get_state( @@ -246,8 +244,6 @@ void receiver_get_state( _HRT_CSS_RECEIVER_BE_IRQ_STATUS_REG_IDX); state->be_irq_clear = receiver_reg_load(ID, _HRT_CSS_RECEIVER_BE_IRQ_CLEAR_REG_IDX); - - return; } bool is_mipi_format_yuv420( @@ -310,8 +306,6 @@ void receiver_set_compression( reg = ((field_id < 6) ? (val << (field_id * 5)) : (val << (( field_id - 6) * 5))); receiver_reg_store(ID, addr, reg); - - return; } void receiver_port_enable( @@ -330,7 +324,6 @@ void receiver_port_enable( receiver_port_reg_store(ID, port_ID, _HRT_CSS_RECEIVER_DEVICE_READY_REG_IDX, reg); - return; } bool is_receiver_port_enabled( @@ -349,7 +342,6 @@ void receiver_irq_enable( { receiver_port_reg_store(ID, port_ID, _HRT_CSS_RECEIVER_IRQ_ENABLE_REG_IDX, irq_info); - return; } rx_irq_info_t receiver_get_irq_info( @@ -367,7 +359,6 @@ void receiver_irq_clear( { receiver_port_reg_store(ID, port_ID, _HRT_CSS_RECEIVER_IRQ_STATUS_REG_IDX, irq_info); - return; } static inline void capture_unit_get_state( @@ -428,8 +419,6 @@ static inline void capture_unit_get_state( state->FSM_State_Info = input_system_sub_system_reg_load(ID, sub_id, CAPT_FSM_STATE_INFO_REG_ID); - - return; } static inline void acquisition_unit_get_state( @@ -478,8 +467,6 @@ static inline void acquisition_unit_get_state( state->Int_Cntr_Info = input_system_sub_system_reg_load(ID, sub_id, ACQ_INT_CNTR_INFO_REG_ID); - - return; } static inline void ctrl_unit_get_state( @@ -561,8 +548,6 @@ static inline void ctrl_unit_get_state( state->capt_reserve_one_mem_region = input_system_sub_system_reg_load(ID, sub_id, ISYS_CTRL_CAPT_RESERVE_ONE_MEM_REGION_REG_ID); - - return; } static inline void mipi_port_get_state( @@ -597,8 +582,6 @@ static inline void mipi_port_get_state( state->lane_sync_count[i] = (uint8_t)((state->sync_count) >> (i * 8)); state->lane_rx_count[i] = (uint8_t)((state->rx_count) >> (i * 8)); } - - return; } static inline void rx_channel_get_state( @@ -652,8 +635,6 @@ static inline void rx_channel_get_state( state->comp[i] = (mipi_compressor_t)(val & 0x07); state->pred[i] = (mipi_predictor_t)((val & 0x18) >> 3); } - - return; } // MW: "2400" in the name is not good, but this is to avoid a naming conflict @@ -672,8 +653,6 @@ static void receiver_rst( } // AM: Additional actions for stopping receiver? - - return; } //Single function to reset all the devices mapped via GP_DEVICE. @@ -722,8 +701,6 @@ static void gp_device_rst(const gp_device_ID_t ID) // gp_device_reg_store(ID, _REG_GP_SYNCGEN_FRAME_CNT_ADDR, ZERO); gp_device_reg_store(ID, _REG_GP_SOFT_RESET_ADDR, ZERO); // AM: Maybe this soft reset is not safe. - - return; } static void input_selector_cfg_for_sensor(const gp_device_ID_t ID) @@ -740,8 +717,6 @@ static void input_selector_cfg_for_sensor(const gp_device_ID_t ID) gp_device_reg_store(ID, _REG_GP_ISEL_SBAND_SEL_ADDR, ZERO); gp_device_reg_store(ID, _REG_GP_ISEL_SYNC_SEL_ADDR, ZERO); gp_device_reg_store(ID, _REG_GP_SOFT_RESET_ADDR, ZERO); - - return; } static void input_switch_rst(const gp_device_ID_t ID) @@ -760,8 +735,6 @@ static void input_switch_rst(const gp_device_ID_t ID) gp_device_reg_store(ID, _REG_GP_IFMT_input_switch_fsync_lut, ZERO); - - return; } static void input_switch_cfg( @@ -786,8 +759,6 @@ static void input_switch_cfg( gp_device_reg_store(ID, _REG_GP_IFMT_input_switch_fsync_lut, cfg->vsync_data_reg); - - return; } static void input_system_network_rst(const input_system_ID_t ID) @@ -843,8 +814,6 @@ static void input_system_network_rst(const input_system_ID_t ID) ISYS_CTRL_INIT_REG_ID, 1U); //AM: Is there any named constant? } - - return; } // Function that resets current configuration. @@ -1072,8 +1041,6 @@ static void capture_unit_configure( sub_id, CAPT_NUM_MEM_REGIONS_REG_ID, cfg->nof_mem_regs); - - return; } static void acquisition_unit_configure( @@ -1097,8 +1064,6 @@ static void acquisition_unit_configure( sub_id, ACQ_MEM_REGION_SIZE_REG_ID, cfg->mem_reg_size); - - return; } static void ctrl_unit_configure( @@ -1165,7 +1130,6 @@ static void ctrl_unit_configure( sub_id, ISYS_CTRL_CAPT_RESERVE_ONE_MEM_REGION_REG_ID, 0); - return; } static void input_system_network_configure( @@ -1223,8 +1187,6 @@ static void input_system_network_configure( sub_id, &cfg->ctrl_unit_cfg[sub_id - CTRL_UNIT0_ID]); } - - return; } static input_system_err_t configuration_to_registers(void)