From patchwork Mon Apr 19 19:13:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Deepak R Varma X-Patchwork-Id: 424195 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54C46C433ED for ; Mon, 19 Apr 2021 19:13:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 142096108B for ; Mon, 19 Apr 2021 19:13:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241300AbhDSTNz (ORCPT ); Mon, 19 Apr 2021 15:13:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237147AbhDSTNz (ORCPT ); Mon, 19 Apr 2021 15:13:55 -0400 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88B39C06174A; Mon, 19 Apr 2021 12:13:25 -0700 (PDT) Received: by mail-pf1-x430.google.com with SMTP id h15so6165787pfv.2; Mon, 19 Apr 2021 12:13:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Tqs2F9D8mtaZHkRU7hQLyOSiRNj0+PQwuNov0o/N/KU=; b=C67zAjvdiXktoow7fiG5fD7E8Gm0bf7rtMIGH6ghoWH03LF/buE0OP6oeED4euOl1J tqDAJK42DHdgukd9woXDI79P5D2qazrnnCk5/d3g43btaqUKkV8VTqcLoHyJDjHDB8PX Gr+mBjGaTuOOlFGpIadhfk2IVh9qqkuVkS/YXCTPgFV7FIbsrGq2H7u5G6UDMBzGNHfb JLvxm2PxBdfpu6TrHk5lw4rGzS6Bu+afXeINGUvE5+wLAz6lgrRH9wLOcOEEJkM6b/KD YHe/e85zQSDF19EpvCyd5afkh7x09IV+c8BrVft4f+BaGryKQII06G6gnIi1RSky9BcL bfzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Tqs2F9D8mtaZHkRU7hQLyOSiRNj0+PQwuNov0o/N/KU=; b=UMZt6Czfev+3uzUIYaFQ48/acvGOnrwJxoEbZN3ceUcie1gAvCl1kfM/t1loSuPPKa nD2LmYar4gNndyPaQfljWd2tUr7ArRodmsEM+GckXiGgXw2uzt48MPd+JEgN7WewJsAT 6NkpxFiFKFlmphjw/zxWTGGtNdkR5OHk7w047auW3oa9Q5Ew/sBwvrkqiPxv1Cjd/6ur QPgkvh3cocSYNIk88nxj4exe8ilmFhVvCforgvUS1DbPGCPZo4gx25J2UtoEAKxiLglV cJH5JDpAe5m+p5GFBdq1VQtHKhGAvlOSGWKjGhFu6WhtnWcL8moMGmwrFfcjqIIOg5mG 6z1g== X-Gm-Message-State: AOAM531KOl+IMGxHuMfJNRm45YVpDLKxciu0OTQMQDWAhtLrpynW/g3c 6lEhRB0pq6zfo8x1cOPTnMA= X-Google-Smtp-Source: ABdhPJwcLqrw+mCdkC06D+pMa5umJ4htdmFvgQdj8jdUmk41HJhIHxwQ63R/dKRGSPHQxlS5OqxAxw== X-Received: by 2002:a65:4082:: with SMTP id t2mr13432531pgp.396.1618859605171; Mon, 19 Apr 2021 12:13:25 -0700 (PDT) Received: from localhost ([103.241.225.98]) by smtp.gmail.com with ESMTPSA id n39sm10333086pfv.51.2021.04.19.12.13.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Apr 2021 12:13:24 -0700 (PDT) From: Deepak R Varma X-Google-Original-From: Deepak R Varma Date: Tue, 20 Apr 2021 00:43:19 +0530 To: Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: mh12gx2825@gmail.com Subject: [PATCH 2/6] staging: media: atomisp: balance braces around if...else block Message-ID: <71220662c5facd746e56288cc74786c96fa3c5a7.1618859059.git.drv@mailo.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Balance braces around the if else blocks as per the code style guidelines. Resolves checkpatch script CHECK / WARNING feedback messages. Signed-off-by: Deepak R Varma --- drivers/staging/media/atomisp/i2c/atomisp-gc0310.c | 4 ++-- drivers/staging/media/atomisp/i2c/atomisp-gc2235.c | 4 ++-- drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c | 4 ++-- drivers/staging/media/atomisp/i2c/atomisp-ov2680.c | 7 ++++--- drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 4 ++-- 5 files changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c b/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c index 6be3ee1d93a5..d68a2bcc9ae1 100644 --- a/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c +++ b/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c @@ -872,9 +872,9 @@ static int gc0310_s_power(struct v4l2_subdev *sd, int on) { int ret; - if (on == 0) + if (on == 0) { return power_down(sd); - else { + } else { ret = power_up(sd); if (!ret) return gc0310_init(sd); diff --git a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c index 6ba4a8adff7c..e722c639b60d 100644 --- a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c +++ b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c @@ -658,9 +658,9 @@ static int gc2235_s_power(struct v4l2_subdev *sd, int on) { int ret; - if (on == 0) + if (on == 0) { ret = power_down(sd); - else { + } else { ret = power_up(sd); if (!ret) ret = __gc2235_init(sd); diff --git a/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c b/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c index f5de81132177..465fc4468442 100644 --- a/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c +++ b/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c @@ -568,9 +568,9 @@ static int power_down(struct v4l2_subdev *sd) static int mt9m114_s_power(struct v4l2_subdev *sd, int power) { - if (power == 0) + if (power == 0) { return power_down(sd); - else { + } else { if (power_up(sd)) return -EINVAL; diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c index c90730513438..92c52431bd8f 100644 --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c @@ -461,11 +461,12 @@ static int ov2680_v_flip(struct v4l2_subdev *sd, s32 value) ret = ov2680_read_reg(client, 1, OV2680_FLIP_REG, &val); if (ret) return ret; - if (value) { + + if (value) val |= OV2680_FLIP_MIRROR_BIT_ENABLE; - } else { + else val &= ~OV2680_FLIP_MIRROR_BIT_ENABLE; - } + ret = ov2680_write_reg(client, 1, OV2680_FLIP_REG, val); if (ret) diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c index aec7392fd1de..d046a9804f63 100644 --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c @@ -772,9 +772,9 @@ static int ov2722_s_power(struct v4l2_subdev *sd, int on) { int ret; - if (on == 0) + if (on == 0) { return power_down(sd); - else { + } else { ret = power_up(sd); if (!ret) return ov2722_init(sd); From patchwork Mon Apr 19 19:15:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Deepak R Varma X-Patchwork-Id: 424194 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA0E0C433B4 for ; Mon, 19 Apr 2021 19:15:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D4D761354 for ; Mon, 19 Apr 2021 19:15:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241351AbhDSTPl (ORCPT ); Mon, 19 Apr 2021 15:15:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237147AbhDSTPk (ORCPT ); Mon, 19 Apr 2021 15:15:40 -0400 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3ABD1C06174A; Mon, 19 Apr 2021 12:15:10 -0700 (PDT) Received: by mail-pf1-x42f.google.com with SMTP id p67so18908400pfp.10; Mon, 19 Apr 2021 12:15:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=06QZL6AdNEJNLxU+QdyqLASrEfF3FlUiStWVtENL220=; b=l/n06LGrrmKMQk0UvGuADT3Nr2w8LGfmTVnDSOehCwSTSDzY1j8dPwa+Esu+wLly2h ILW3mXo0QqBU4uuXhw5l1w0K4JH4SeuvdZ4jPbS4XFwpIEFZI13yk4wTsftK4LS+DPpT MALfLXQRMqGBaRLuBCKPgWs2OHgPYqfxuhh1jjHm/GBV7UwNqPDClHYsQquu7HtXzE1p zV7hFHxIYz/4V52aB2Nmvj8FEJoU3cdXjcruJRE7lBLnTYb4Y5/ukzwLnRnKfzagVWOQ orkj+oD6AuwT9CDpmZqPV/o+AsEEsEf5sdZ3Ds9oLxNfomDDLzJDy1FBBvFbzK6nzxse NUsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=06QZL6AdNEJNLxU+QdyqLASrEfF3FlUiStWVtENL220=; b=HYBuJu9RTgauBrU5vd647lVL+i6rI/XcaMO8dlvvskhQj0oZhSu7qtdJCrhuQb56lG Pee8IMAMCywSTc2G4GtaI0VlnabEhpkLhkU7JnzPMBc3InHYInlYgfgyBj9NW9i6EmN6 fbofeUv7P/IQOzMFEERcDNFA7BP4LL+5azBmTPXM8pOAEMpA0KV3ysxBvFdz2+MnfFwn ZrlgaV5BmfwKFGducZbwJWYoDIJAiGhC30TbH2uuC/gti6Rd2FfMXeVoK/g9iVo+xVxl K0ejvtIKQ2hEqkYE5B4SJjYOJP+vi/60229GnwEzKobWTeJ3CQV4KktdTRQ/AnD4QF/g 5WQg== X-Gm-Message-State: AOAM531YSG1hYWuFH877dAFqfLhAFMRNSn7it9Y+8aeyZkiTpWSSEPaB vXJfbO9MrZp0ATwNyMF18lKeh9heBPM= X-Google-Smtp-Source: ABdhPJysS7sfKldg2q2aFgttLZYbRaeQvM92gADFLo6yShNhnVppLOcZzwFsUsRp3isAMiOV3WanPg== X-Received: by 2002:a62:3892:0:b029:250:4fac:7e30 with SMTP id f140-20020a6238920000b02902504fac7e30mr21475850pfa.81.1618859709696; Mon, 19 Apr 2021 12:15:09 -0700 (PDT) Received: from localhost ([103.241.225.98]) by smtp.gmail.com with ESMTPSA id x62sm13072884pfb.71.2021.04.19.12.15.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Apr 2021 12:15:09 -0700 (PDT) From: Deepak R Varma X-Google-Original-From: Deepak R Varma Date: Tue, 20 Apr 2021 00:45:04 +0530 To: Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: mh12gx2825@gmail.com Subject: [PATCH 4/6] staging: media: atomisp: reformat code comment blocks Message-ID: <7cf7b8253550460e7273c94bae005939000679fd.1618859059.git.drv@mailo.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Reformat code comment blocks according to the coding style guidelines. This resolves different checkpatch script WARNINGs around block comments. Signed-off-by: Deepak R Varma --- .../media/atomisp/i2c/atomisp-gc2235.c | 8 +++---- .../atomisp/i2c/atomisp-libmsrlisthelper.c | 3 ++- .../media/atomisp/i2c/atomisp-mt9m114.c | 22 +++++++++++-------- .../media/atomisp/i2c/atomisp-ov2680.c | 3 ++- 4 files changed, 21 insertions(+), 15 deletions(-) diff --git a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c index 548c572d3b57..a585d73665a6 100644 --- a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c +++ b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c @@ -747,10 +747,10 @@ static int startup(struct v4l2_subdev *sd) if (is_init == 0) { /* force gc2235 to do a reset in res change, otherwise it - * can not output normal after switching res. and it is not - * necessary for first time run up after power on, for the sack - * of performance - */ + * can not output normal after switching res. and it is not + * necessary for first time run up after power on, for the sack + * of performance + */ power_down(sd); power_up(sd); gc2235_write_reg_array(client, gc2235_init_settings); diff --git a/drivers/staging/media/atomisp/i2c/atomisp-libmsrlisthelper.c b/drivers/staging/media/atomisp/i2c/atomisp-libmsrlisthelper.c index b93c80471f22..750b3484eb19 100644 --- a/drivers/staging/media/atomisp/i2c/atomisp-libmsrlisthelper.c +++ b/drivers/staging/media/atomisp/i2c/atomisp-libmsrlisthelper.c @@ -57,7 +57,8 @@ static int set_msr_configuration(struct i2c_client *client, uint8_t *bufptr, * By convention, the first two bytes of actual data should be * understood as an address in the sensor address space (hibyte * followed by lobyte) where the remaining data in the sequence - * will be written. */ + * will be written. + */ u8 *ptr = bufptr; diff --git a/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c b/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c index 465fc4468442..160bb58ce708 100644 --- a/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c +++ b/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c @@ -478,7 +478,8 @@ static int gpio_ctrl(struct v4l2_subdev *sd, bool flag) /* Note: current modules wire only one GPIO signal (RESET#), * but the schematic wires up two to the connector. BIOS * versions have been unfortunately inconsistent with which - * ACPI index RESET# is on, so hit both */ + * ACPI index RESET# is on, so hit both + */ if (flag) { ret = dev->platform_data->gpio0_ctrl(sd, 0); @@ -1019,8 +1020,8 @@ static long mt9m114_s_exposure(struct v4l2_subdev *sd, dev->first_gain = AnalogGain; dev->first_diggain = DigitalGain; } - /* DigitalGain = 0x400 * (((u16) DigitalGain) >> 8) + - ((unsigned int)(0x400 * (((u16) DigitalGain) & 0xFF)) >>8); */ + /* DigitalGain = 0x400 * (((u16) DigitalGain) >> 8) + */ + /* ((unsigned int)(0x400 * (((u16) DigitalGain) & 0xFF)) >>8); */ /* set frame length */ if (FLines < coarse_integration + 6) @@ -1035,7 +1036,8 @@ static long mt9m114_s_exposure(struct v4l2_subdev *sd, /* set coarse integration */ /* 3A provide real exposure time. - should not translate to any value here. */ + * should not translate to any value here. + */ ret = mt9m114_write_reg(client, MISENSOR_16BIT, REG_EXPO_COARSE, (u16)(coarse_integration)); if (ret) { @@ -1044,7 +1046,7 @@ static long mt9m114_s_exposure(struct v4l2_subdev *sd, } /* - // set analog/digital gain + * set analog/digital gain switch(AnalogGain) { case 0: @@ -1069,8 +1071,9 @@ static long mt9m114_s_exposure(struct v4l2_subdev *sd, */ if (DigitalGain >= 16 || DigitalGain <= 1) DigitalGain = 1; - /* AnalogGainToWrite = - (u16)((DigitalGain << 12) | AnalogGainToWrite); */ + + /* AnalogGainToWrite = (u16)((DigitalGain << 12) | AnalogGainToWrite); + */ AnalogGainToWrite = (u16)((DigitalGain << 12) | (u16)AnalogGain); ret = mt9m114_write_reg(client, MISENSOR_16BIT, REG_GAIN, AnalogGainToWrite); @@ -1096,7 +1099,8 @@ static long mt9m114_ioctl(struct v4l2_subdev *sd, unsigned int cmd, void *arg) } /* This returns the exposure time being used. This should only be used - for filling in EXIF data, not for actual image processing. */ + * for filling in EXIF data, not for actual image processing. + */ static int mt9m114_g_exposure(struct v4l2_subdev *sd, s32 *value) { struct i2c_client *client = v4l2_get_subdevdata(sd); @@ -1297,7 +1301,7 @@ static int mt9m114_g_ev(struct v4l2_subdev *sd, s32 *val) /* Fake interface * mt9m114 now can not support 3a_lock -*/ + */ static int mt9m114_s_3a_lock(struct v4l2_subdev *sd, s32 val) { aaalock = val; diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c index c17615149f46..91dca275a08e 100644 --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c @@ -732,7 +732,8 @@ static int gpio_ctrl(struct v4l2_subdev *sd, bool flag) * existing integrations often wire two (reset/power_down) * because that is the way other sensors work. There is no * way to tell how it is wired internally, so existing - * firmwares expose both and we drive them symmetrically. */ + * firmwares expose both and we drive them symmetrically. + */ if (flag) { ret = dev->platform_data->gpio0_ctrl(sd, 1); usleep_range(10000, 15000); From patchwork Mon Apr 19 19:16:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Deepak R Varma X-Patchwork-Id: 424193 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6BD6C433B4 for ; Mon, 19 Apr 2021 19:16:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B9DED61107 for ; Mon, 19 Apr 2021 19:16:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241459AbhDSTRQ (ORCPT ); Mon, 19 Apr 2021 15:17:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241313AbhDSTRP (ORCPT ); Mon, 19 Apr 2021 15:17:15 -0400 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0007C06174A; Mon, 19 Apr 2021 12:16:45 -0700 (PDT) Received: by mail-pj1-x1032.google.com with SMTP id nk8so5341645pjb.3; Mon, 19 Apr 2021 12:16:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0WK8M0c904A+vC9fiAqfVaCp4aJcCTHCS/P40/Etu8g=; b=pJjBX/ZKn2oFj5S/D7unyBaOimlqx3++WSKnGiNkDS42f90dJWWpiN8LGKIcqVIbrr V+er0hwoPmFvwNdZPuIR8QjlwK1FjUS7ce34HtpjSYQmgdRddJnavfXve9ePJCQQyVCS qZX5wdcaVFrBzl052K32foSw56SJoYfg3am7SlklOkIKY9WWsjokTIF2zEH2WOwhMEb5 skzBBR2Qbl3NVPmQ67qjlQaDSYP+9Q0B4zo52dL3eeI3qHsDPSp/7t3vToBY/VQn52Bd EfUDcF/SDPEU/5FX3o4qB+0hFKHnSW/8CSqqwuRcqCxdOUMT8sk+3MSkp8ij6DD58PHA 1HRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0WK8M0c904A+vC9fiAqfVaCp4aJcCTHCS/P40/Etu8g=; b=AFSRWIUPqna1+qRRMLajmgEbYnvpaXG9kYBe3V7MDUe/OGn/tc0UgnSoW6JtADi4hm 5Fc6PMUwn472Hs1KBudypYElF334iATGd8jEkLdBjVxuURLrJirMgE9upXW/D+zmnSkr edehGlopjsknWxEEeIAryrDfKAyAP7b8Td/pY2fnxxTXVTo2MABlU19Dg9E4iNRCttPt CC49By/zh0f9Z2KUHDg83mAO3EA2evyxZ5IVc8CbdAeTwJvb6ipRoD28opx7jZWB+BiZ v3Y7MZANSZkZClujK2p5TM6Qp713sNftOUo/KzB9et1UKJ0l/SQkpTMxau5jf2j4EwsJ SHFg== X-Gm-Message-State: AOAM531MGNlOXO++tCINUBQvLWM/JK/VV4OJN+F8Hevz7y64+qSl0GXr uYrWbAfc1OSEdsK3kQyA7d8= X-Google-Smtp-Source: ABdhPJwfsaXul7oKNLaJXV7dO4RfRtUP23mpUHlOwgwJ/1RCFZSk0X8QLXmIDOQz2h0+bU8beBi5Fw== X-Received: by 2002:a17:90a:ca83:: with SMTP id y3mr653074pjt.191.1618859805475; Mon, 19 Apr 2021 12:16:45 -0700 (PDT) Received: from localhost ([103.241.225.98]) by smtp.gmail.com with ESMTPSA id o16sm7196271pfp.215.2021.04.19.12.16.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Apr 2021 12:16:45 -0700 (PDT) From: Deepak R Varma X-Google-Original-From: Deepak R Varma Date: Tue, 20 Apr 2021 00:46:40 +0530 To: Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: mh12gx2825@gmail.com Subject: [PATCH 6/6] staging: media: atomisp: use printk with KERN facility level Message-ID: <4947abeebc2cecca43137675519a2fb48577d3e5.1618859059.git.drv@mailo.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org printk() without KERN_ facility is flagged by checkpatch as a warning. It is better to use pr_info() which comes with an inbuilt KERN_INFO level. Signed-off-by: Deepak R Varma --- drivers/staging/media/atomisp/i2c/atomisp-gc0310.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c b/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c index b572551f1a0d..a0f3c5c32f94 100644 --- a/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c +++ b/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c @@ -1020,7 +1020,7 @@ static int gc0310_set_fmt(struct v4l2_subdev *sd, return -EINVAL; } - printk("%s: before gc0310_write_reg_array %s\n", __func__, + pr_info("%s: before gc0310_write_reg_array %s\n", __func__, gc0310_res[dev->fmt_idx].desc); ret = startup(sd); if (ret) {