From patchwork Mon Apr 19 09:01:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Foss X-Patchwork-Id: 423981 Delivered-To: patch@linaro.org Received: by 2002:a02:6a6f:0:0:0:0:0 with SMTP id m47csp2531362jaf; Mon, 19 Apr 2021 02:01:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw6NalclQyrHkHrQ6eqWOPY34NYwceIPAxX047gaD/zPTTU4zdm0Fv5QNDODW23Qz7x/XIv X-Received: by 2002:a63:d242:: with SMTP id t2mr10847708pgi.431.1618822903690; Mon, 19 Apr 2021 02:01:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618822903; cv=none; d=google.com; s=arc-20160816; b=Kxnxqpq0uYLJCN4ycDdB2wSD0V07K5SDpwt6ap5USp6me80glBAF6sTsxMRYfpsW+S L45gNtVrC0X0yTpCickCAn2Mld5UpL5WA5SVa5QERJCuo57dJjH4YNAMG1wjAjT8LXmg NE1LqmKA4WZvYTl147SDRqXOqJJqrYAaAho+pLgIrxESTui4h162WnpDIt9CfJzjA3xQ wc1Vr9gXffUo+8O2eXGdnPnozGlkgBRarIW87+wS4O1BPOolVLRFx2axdEd82LGAFERi lbomFuVISGslip7vfioE382GGZl8iLWHW+SgjgZCzoTaBxueWs7SYm5qw6WFv3+VUUVS TvZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:message-id:date:subject:to:from :dkim-signature:delivered-to; bh=JS6FNXDY0iUT0WjZnl+Z9iAzg5P4wOT6MKfkFL6Abt8=; b=Y7IRmz/ZwjgoEGeeQeeLWSeMX23MaBicJd/U6MHDVD/qTno55R0tmiToTSxjnYsmlx eHGNFuTcYGkfwBBjoQ+T4q9rTYOgo5DxNc4qQ+IaoVhJSQWRLTr+YL8NAhkMXwc0LyzU 1zczwG7RHZET4cOePwYGxY+JlctgXc2znFQg+yieo6MDyt1QQ52KsN3PWt2iA0KvVBd5 dpUZj4xUQZz/snuqRi09qgSugavgPPQr2bD8GJSqvhgHTzbOLeMgLkGV/26IdKdwLfQj DQWcssyJORVQgcgxbsnTtX7WJO3JTDXM3j4t/kFsnZ0urgrPiK3bWpwyFT0Cy63l3aw7 R2sw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=ZDkUmAfi; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id em19si15937688pjb.154.2021.04.19.02.01.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Apr 2021 02:01:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=ZDkUmAfi; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 834F689AFF; Mon, 19 Apr 2021 09:01:40 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by gabe.freedesktop.org (Postfix) with ESMTPS id F08D689AFF for ; Mon, 19 Apr 2021 09:01:39 +0000 (UTC) Received: by mail-wr1-x42a.google.com with SMTP id k26so16710140wrc.8 for ; Mon, 19 Apr 2021 02:01:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=TPqPD/BdKbOmQoY/69ahqiLeLy4W5bUr61Qz2mAbQO8=; b=ZDkUmAfiNr7vTw1GLZge+A/3lbdsF/wNvgIGrY/66IjAeb7JkxqkJ0G/3heyKx1bpy ay9fjir4M6WU7e+kYVMvUrsqazj1q+JJWXuwS7rAWPWy/6fiD2YD6c9S5M6mBDH+QAPM 5CXAQlIZx9XlaC2nvi9RbwwSyXIyUUKyvOOMiwChIzAAmagIFrLtJTjalX0x+tmZEGXW 1sn5VFCVXt5RVUfiUM+8virAYqShpxLwyVnqBlqIWHV0i2dp14zdWT53ZatA1FpK3zOg Y6Bt18WS4izwrTSxGNzo8Ijpk9pSeVB98ss4KuzYKF3AnhDVBij0OAR2VXMa6HwLR84p pW5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=TPqPD/BdKbOmQoY/69ahqiLeLy4W5bUr61Qz2mAbQO8=; b=Mmrm23wK++oPxXrhJrAGNkjJSE1aJkhFI0s70EDycfT0wq/n4vuAUnDHa11qQHVNKu YzBPk8Y+i8EO6XqsQrdYkxl5Y/JqZiXKYd0FXQui4FcnQHvKichTVkn7pR4mlcxz1uRP atl7yJVDealkwQ0uixCBg6dG0s+KOL/Au1dmZ1I0L7iIYYPPkTIWq+ET/O1dfHCCB1ci O97jpO3x39UCK9hf0aMiYg6NLjkc4xTDAemX256NoAXoiYTm46o0bcXPq6nzg2rTTrJc dGM39MuyunXSlto5QnrAQp0AXexh0B3OumFTHJgUAFWt6PQgyrVJdL/Q8tZgRfTfU363 jkzQ== X-Gm-Message-State: AOAM533N5hnQu49qQv7MICSIK9gvLRhdOUXf9UA8BwhtSe6Zk/ptfuP3 8Md0D2baWFLuDykdL3FrOJPNsA== X-Received: by 2002:a5d:5912:: with SMTP id v18mr13582443wrd.14.1618822898682; Mon, 19 Apr 2021 02:01:38 -0700 (PDT) Received: from localhost.localdomain ([2a02:2454:3e3:5f00:4e60:4ba6:c549:25f6]) by smtp.gmail.com with ESMTPSA id m14sm21477080wrh.28.2021.04.19.02.01.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Apr 2021 02:01:38 -0700 (PDT) From: Robert Foss To: a.hajda@samsung.com, narmstrong@baylibre.com, robert.foss@linaro.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@siol.net, airlied@linux.ie, daniel@ffwll.ch, cw00.choi@samsung.com, m.purski@samsung.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Masahiro Yamada , Randy Dunlap Subject: [PATCH v3] drm/bridge/sii8620: fix dependency on extcon Date: Mon, 19 Apr 2021 11:01:24 +0200 Message-Id: <20210419090124.153560-1-robert.foss@linaro.org> X-Mailer: git-send-email 2.31.0.30.g398dba342d.dirty MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel test robot Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The DRM_SIL_SII8620 kconfig has a weak `imply` dependency on EXTCON, which causes issues when sii8620 is built as a builtin and EXTCON is built as a module. The symptoms are 'undefined reference' errors caused by the symbols in EXTCON not being available to the sii8620 driver. Fixes: 688838442147 ("drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL") Signed-off-by: Robert Foss Reported-by: kernel test robot --- LKP reported issue: https://lore.kernel.org/lkml/202104040604.SSTe2Cxf-lkp@intel.com/ Changes since v1: - Fix typo on comment Changes since v2: - Randy: Changed from `depends` to `select` drivers/gpu/drm/bridge/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.31.0.30.g398dba342d.dirty _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel Acked-by: Randy Dunlap # build-tested Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Reviewed-by: Randy Dunlap diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig index 22a467abd3e9..70402da5cc70 100644 --- a/drivers/gpu/drm/bridge/Kconfig +++ b/drivers/gpu/drm/bridge/Kconfig @@ -169,7 +169,7 @@ config DRM_SIL_SII8620 tristate "Silicon Image SII8620 HDMI/MHL bridge" depends on OF select DRM_KMS_HELPER - imply EXTCON + select EXTCON depends on RC_CORE || !RC_CORE help Silicon Image SII8620 HDMI/MHL bridge chip driver.