From patchwork Thu Apr 15 12:23:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qiao Ma X-Patchwork-Id: 422022 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, UNPARSEABLE_RELAY, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91FD6C433B4 for ; Thu, 15 Apr 2021 12:24:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 534AB61139 for ; Thu, 15 Apr 2021 12:24:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232678AbhDOMYe (ORCPT ); Thu, 15 Apr 2021 08:24:34 -0400 Received: from out30-130.freemail.mail.aliyun.com ([115.124.30.130]:47796 "EHLO out30-130.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231391AbhDOMYd (ORCPT ); Thu, 15 Apr 2021 08:24:33 -0400 X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R121e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=alimailimapcm10staff010182156082; MF=mqaio@linux.alibaba.com; NM=1; PH=DS; RN=3; SR=0; TI=SMTPD_---0UVefpBC_1618489448; Received: from localhost(mailfrom:mqaio@linux.alibaba.com fp:SMTPD_---0UVefpBC_1618489448) by smtp.aliyun-inc.com(127.0.0.1); Thu, 15 Apr 2021 20:24:09 +0800 From: Qiao Ma To: linux-kselftest@vger.kernel.org Cc: shuah@kernel.org Subject: [PATCH] selftests: fix rp_filter testcase failure bug Date: Thu, 15 Apr 2021 20:23:34 +0800 Message-Id: X-Mailer: git-send-email 2.18.2 Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org The rp_filter testcase is used to test whether local packets redirected from dummy1 to lo could pass the checking of rp_filter. In fact, the packets passed the checking, but the testing process cannot receive any reply packets, leading to test failure. The reason is that the device dummy1 lacks ip address, caused the incorrect routing of reply packets. This patch adds ip address for dummy1 device. Signed-off-by: Qiao Ma --- tools/testing/selftests/net/fib_tests.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/net/fib_tests.sh b/tools/testing/selftests/net/fib_tests.sh index 2b5707738609..9a843ca0b913 100755 --- a/tools/testing/selftests/net/fib_tests.sh +++ b/tools/testing/selftests/net/fib_tests.sh @@ -448,6 +448,7 @@ fib_rp_filter_test() $IP link set dummy0 address 52:54:00:6a:c7:5e $IP link add dummy1 type dummy $IP link set dummy1 address 52:54:00:6a:c7:5e + $IP address add 198.51.101.1/24 dev dummy1 $IP link set dev dummy1 up $NS_EXEC sysctl -qw net.ipv4.conf.all.rp_filter=1 $NS_EXEC sysctl -qw net.ipv4.conf.all.accept_local=1