From patchwork Thu May 31 22:21:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suman Anna X-Patchwork-Id: 137441 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp186304lji; Thu, 31 May 2018 15:21:55 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIEJGvgOOVs2aFBCfr/CcEuafoep+pZ+XLewc/HCLChleIig7bnhUjHdURIMpkvVnpGxk2O X-Received: by 2002:a17:902:b7c4:: with SMTP id v4-v6mr8709300plz.188.1527805315249; Thu, 31 May 2018 15:21:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527805315; cv=none; d=google.com; s=arc-20160816; b=xrK7Sh7f3ZDCN3IQa36Yq43OpTsO3mC967ANtN81fnKlGgV/eFTRhMjwye8hZc9pmU efWHraGV3twALZc0dW1PzNqN9igprfTrzi7SPJCRCocSlIPOvVnvT58vYlcO0QSMHcB+ 1nlbhTpiTchlJwjnXW/sGhD4pBtn/FN58JCEXK3qEZTuNGPArd/w76umXF76YG0uvj4f /8M8cVp44s++HCtK8RbFvy0jed9nvX8LEMhGIONG0LEhqOG2ywEze7J2MAZQUwiTf5pG +sh1kA2yCcFayCxZ1JD0ipHwK4IiozcVSVhANJWHWQZIN4l7lYARh95ByVeu2vRxtqbs SVYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=EIuq/oa4cdncF+EX4NFUk03ag2Qbl1zv/ntt9+vg7dY=; b=ijGLdzrISK/VhIJ2j5ts+X2ksnrVu9YDGQaGwnNysXGgYEkfzqu4Xjvj2f4sk8xnJO ycHY1E+2sYpU1ayncjYiN5MwZ4zZ2B5o7uU/2J73308MWAPO9qWWQMQRIpcGCxxk83Qb itky7ZXlMashGLRp66iRH510rkORycs5dov983b6Tgtk50OvnD1Ib0mXstQ0kEBrjrZC SXEXLPPIZVmakykyTxREZ6ZaoPPh9s8VNIzt4xfuSSQzZm8ACu0uv5Z1i2abkwmX9i7J wk4fjoQJZ2hgGXSb08wjdTrOtbu2ZKNTEo5ZcVcKwH+vvsNzp+GE+ltd8gCLdB/BXc5U 3alQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=W3Mn/mb9; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t3-v6si36840338plo.554.2018.05.31.15.21.54; Thu, 31 May 2018 15:21:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=W3Mn/mb9; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750827AbeEaWVv (ORCPT + 10 others); Thu, 31 May 2018 18:21:51 -0400 Received: from lelnx193.ext.ti.com ([198.47.27.77]:31843 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750739AbeEaWVt (ORCPT ); Thu, 31 May 2018 18:21:49 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by lelnx193.ext.ti.com (8.15.1/8.15.1) with ESMTP id w4VMLl92021103; Thu, 31 May 2018 17:21:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1527805307; bh=EIuq/oa4cdncF+EX4NFUk03ag2Qbl1zv/ntt9+vg7dY=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=W3Mn/mb9A1VQmcw3DjF2+1Zq1JzXeSN61vmoTpGyw+yTRgiy0tVLAIP2ZRYr78m2y Fhjw9Rk/GF393qJHkV5xqm8CvXjiKkqrLzq93w4l2OshYGAeOh5J/kP+FLGZLd2LAE eZ9mw+bsmhvqH1Zzj/OjKw98+JOonAG0IZ4ches4= Received: from DLEE103.ent.ti.com (dlee103.ent.ti.com [157.170.170.33]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id w4VMLl6Y019463; Thu, 31 May 2018 17:21:47 -0500 Received: from DLEE103.ent.ti.com (157.170.170.33) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Thu, 31 May 2018 17:21:46 -0500 Received: from dflp32.itg.ti.com (10.64.6.15) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1466.3 via Frontend Transport; Thu, 31 May 2018 17:21:46 -0500 Received: from legion.dal.design.ti.com (legion.dal.design.ti.com [128.247.22.53]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id w4VMLkRX021218; Thu, 31 May 2018 17:21:46 -0500 Received: from localhost (irmo.dhcp.ti.com [128.247.58.153]) by legion.dal.design.ti.com (8.11.7p1+Sun/8.11.7) with ESMTP id w4VMLkx09904; Thu, 31 May 2018 17:21:46 -0500 (CDT) From: Suman Anna To: "Rafael J. Wysocki" CC: Viresh Kumar , Dave Gerlach , Tero Kristo , , , , Suman Anna , Zumeng Chen Subject: [PATCH v3 2/2] cpufreq: ti-cpufreq: Use devres managed API in probe() Date: Thu, 31 May 2018 17:21:44 -0500 Message-ID: <20180531222144.26739-3-s-anna@ti.com> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180531222144.26739-1-s-anna@ti.com> References: <20180531222144.26739-1-s-anna@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org The ti_cpufreq_probe() function uses regular kzalloc to allocate the ti_cpufreq_data structure and kfree for freeing this memory on failures. Simplify this code by using the devres managed API. Cc: Zumeng Chen Signed-off-by: Suman Anna Acked-by: Viresh Kumar --- drivers/cpufreq/ti-cpufreq.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) -- 2.17.0 diff --git a/drivers/cpufreq/ti-cpufreq.c b/drivers/cpufreq/ti-cpufreq.c index 896caba5dfe5..3f0e2a14895a 100644 --- a/drivers/cpufreq/ti-cpufreq.c +++ b/drivers/cpufreq/ti-cpufreq.c @@ -217,7 +217,7 @@ static int ti_cpufreq_probe(struct platform_device *pdev) if (!match) return -ENODEV; - opp_data = kzalloc(sizeof(*opp_data), GFP_KERNEL); + opp_data = devm_kzalloc(&pdev->dev, sizeof(*opp_data), GFP_KERNEL); if (!opp_data) return -ENOMEM; @@ -226,8 +226,7 @@ static int ti_cpufreq_probe(struct platform_device *pdev) opp_data->cpu_dev = get_cpu_device(0); if (!opp_data->cpu_dev) { pr_err("%s: Failed to get device for CPU0\n", __func__); - ret = -ENODEV; - goto free_opp_data; + return -ENODEV; } opp_data->opp_node = dev_pm_opp_of_get_opp_desc_node(opp_data->cpu_dev); @@ -285,8 +284,6 @@ static int ti_cpufreq_probe(struct platform_device *pdev) fail_put_node: of_node_put(opp_data->opp_node); -free_opp_data: - kfree(opp_data); return ret; }