From patchwork Mon May 28 15:57:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 137100 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp2992611lji; Mon, 28 May 2018 08:58:10 -0700 (PDT) X-Google-Smtp-Source: ADUXVKI1D8wUs3SHaPK+ccjYrjD8gsEBB5O9hqJ3ymSxpX9Tvd0ry533k0CHVZ5COftuqIyI+iP9 X-Received: by 2002:a65:6157:: with SMTP id o23-v6mr3587390pgv.310.1527523090058; Mon, 28 May 2018 08:58:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527523090; cv=none; d=google.com; s=arc-20160816; b=SjXUMgcn8PqfgnIgbAC8alngg9EJa8CVmJTk+u54XVfgMwgvkgaEx9VyTss0u8FxxN HiA61UaH0CAyLW/ZWocnSFpe2w914AGaPdzERKFxmxQ5WdmiUWB0y8W9ZNEzdmEyZnL4 qPsgOBxv+TW0BaDse9nIBbyb7ihHXqE69GbsriJt4b1FPhiUWCUlvini6KfLNoKuoFZr JsQCVkEoTdj9Ad8+pMf4PdKzXzJ9QG337IruVN1Pn4YvQn+yV9wzhjDtRAEl+79uTv+B oPfu6ReRSGZkWBurDavBRUc+nBZoukz0+Y3C04VxnUOSPGBasNIJIjfIifkEdJBYTzSl Y/kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=PttAM22WtibHIz0JXGqxwOqHDu9RokI6+qZP3GrPeRY=; b=WYjt0r4/NMqP1Lqt5kZ1zyPEvfB/EOG20Usbh1iAAT1kP1w8HNhp0RtGUWV1wD3XeQ NRg2PiN76He2N+0m0hCGV6TwPj97njN07GIhz9LytByZwhhSXw+T+aAU5d4Cm4iKdN1x e8JRXxpWPZjxcN+i7BKDrAAUBKgcylTYVtOGQeywGAsHGZNCI42swfqxfETRs/wXcOSn Hw+q980qi35xTDEZwABVNUTXJHzWumM6N9lG2LFspvdHMd2d/laxBH0wdm4uNBqDOxCi XtsAG5Tc8x9SpWiv0NG0J6wsS9rBbKRjss1fzMw/L6AHvB2w8ouZQCPr7fJwX5Ehb4ZM HCEw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 33-v6si29809151plq.348.2018.05.28.08.58.09; Mon, 28 May 2018 08:58:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932648AbeE1P6H (ORCPT + 30 others); Mon, 28 May 2018 11:58:07 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:51853 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932514AbeE1P57 (ORCPT ); Mon, 28 May 2018 11:57:59 -0400 Received: from wuerfel.lan ([95.208.111.237]) by mrelayeu.kundenserver.de (mreue102 [212.227.15.145]) with ESMTPA (Nemesis) id 0LnjYN-1fybpW0OgJ-00hv2H; Mon, 28 May 2018 17:57:53 +0200 From: Arnd Bergmann To: Jonathan Corbet , Mauro Carvalho Chehab Cc: Arnd Bergmann , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: marvel-ccic: mmp: select VIDEOBUF2_VMALLOC/DMA_CONTIG Date: Mon, 28 May 2018 17:57:00 +0200 Message-Id: <20180528155750.2932996-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K1:ZQzcHRr8P9ERWoBIrIhiZ5YJhWyjatN4LOsjPyDYe+mlOUrhMNJ 3GQD9mLwEoQYG2dn0ECPGuYKYteFNN706bY0wBzLuqngu66J/w4DeSCYsGeNG/133pvMQ9f C4hj5V2s0mMuRXKLPvssqUzvKCqgYk8CJm4wjrqOpUo2+e4DzI+Zk4QrtYU4Sq/9Edl1K9x ORYoe106Wsyvsh92OEi4g== X-UI-Out-Filterresults: notjunk:1; V01:K0:mfWvr8UnzzM=:4TUmrjO9lox72OODBSi0ea MSmHy9VCnzhThlyPwPy1OnQd2FKCxzeBVebSxc5T9e3XdFpBqRsoCUjFn44cenSDy7Jm1a41j uKCkbRDU5zBZB27La1t90J0VemRojo2vlRbgf+SIK1cZd+5XsEVK5ArTUeaahQvQAqlTa3atG C7k7lHnFN2FCrBMkrFtwbBfsR12ut+3FNcPQCQloKGcemzau1oKGvJYu4lkQeQ1RPPox26/VS 5hFc49JwzVQUSgJ+KGNs2ELYvhLmKiq/NURsaWJlKSGNJrcPPkxkX0lZL9nN7xcBD+Bw7eaL1 DYSToviE6A+hkPxHOLAI0LFOFDvUA2PWRnZg9IH8AU1Vys3tVEchlB9GmFyzC25Utraqql2tB jvLoBMztJQWA5Jc9QKGVytfiIehWSUG9HeXSteuPuSoNOXJiMghWaBEA/H5nn0gKmdU8Di/eh BCGOQwktxP7uCmoMeexEM7C5rCLWqduiJmaMvq6G/LjXe9AI8c01Luh08nnLmRq+whoKcf9mz LF2MCr9K7cGDu807SQoLaoUy3C4UONXMuMquc6pIEtwdCwmX+QFzzx4RIV/e5R/cIASmXax8Y 95JswAm0Uw/Q7WiRhQRFf8Az0xAp049PhUCAQdLxbooLGnr0aDPA6/XVusRZkl3MNqNZsJURd cQmkOke5LQF062LOX6mb6lxakNz0DHY9iikF/gEqiNpnMXHGdtaJSJROACSS1E9ShF2g= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Testing randconfig builds after the return of the mmp ccic driver shows a link error in some configurations: drivers/media/platform/marvell-ccic/mcam-core.o: In function `mccic_register': mcam-core.c:(.text+0x2e48): undefined reference to `vb2_dma_contig_memops' A closer look at the mcam-core.c file reveals that we need to select both VIDEOBUF2_DMA_CONTIG and VIDEOBUF2_VMALLOC, as already do for VIDEO_CAFE_CCIC. Fixes: 0a9c643c8faa ("media: marvel-ccic: re-enable mmp-driver build") Signed-off-by: Arnd Bergmann --- drivers/media/platform/marvell-ccic/Kconfig | 2 ++ 1 file changed, 2 insertions(+) -- 2.9.0 diff --git a/drivers/media/platform/marvell-ccic/Kconfig b/drivers/media/platform/marvell-ccic/Kconfig index 21dacef7c2fc..13cc6f2159d3 100644 --- a/drivers/media/platform/marvell-ccic/Kconfig +++ b/drivers/media/platform/marvell-ccic/Kconfig @@ -18,6 +18,8 @@ config VIDEO_MMP_CAMERA depends on ARCH_MMP || COMPILE_TEST select VIDEO_OV7670 select I2C_GPIO + select VIDEOBUF2_VMALLOC + select VIDEOBUF2_DMA_CONTIG select VIDEOBUF2_DMA_SG ---help--- This is a Video4Linux2 driver for the integrated camera