From patchwork Sat May 26 03:10:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 137004 Delivered-To: patches@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp318150lji; Fri, 25 May 2018 20:10:52 -0700 (PDT) X-Received: by 2002:a17:902:7c83:: with SMTP id y3-v6mr442689pll.51.1527304252520; Fri, 25 May 2018 20:10:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527304252; cv=none; d=google.com; s=arc-20160816; b=i0cpvDTekrsR2AA8LcVcIIksfxZt9tK4LLrVzZ+hKKwUTw2B2/VL9+2VZIVZTbaKei 2YldUi7RQIDq0eBwowXnCjr5wybryKsWPoiazX1eD4gOsuAHjDj4+EazMSBNqIdCPMl9 f69ll4j0AMSItXBTFElZOVEMMvjM1oU8P8PnU2Z0hTKceFVcjHSlfXRoGfd3bIAsEpQf Z4reRRt1DzBVScP7LD7n3vADrpIINGS9+DGU4lRQfGaokOiCZICtJGRsXhgif1KB8qei RTrZjh36KO/4MArpa+NETB9po9la1itxRxTgQtr57plWdZgGOn0HYZIRf2b51UUOVWeW nt0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=VK/9mMpC/1a8UbDOAds8KjsHvnHDwxxKwucQSsurm1o=; b=ourL4ocx20m2ahBMTQCvojs+/5yOrlnC6e5VeXDCWNtatwSbBBL/m6anopGYjzuK2/ n9Z8vCFtX6ANPR5poRl6bHY3xv6sS8jQGQ/gaXW5Xz8EbqcK8H70m4gvpXDOpPazd0VU Cw8HNfbD7Fnd2bjU4r8za0z3j94S3IghHYO4lZ+38z4/EaOPoVHF5aSxU0j59qNUSRAI sC0UKDEHX4MuteHXifdOHwQ0FBih7UHtVNAJJ2rKhNZqorOMr4uzsVVRr+V4dOn95nvQ +/Syp6LzKwQxIae3TNk7aFtEdBGRYNUAQK9Ja9IIUC02qV1R87Ti0Z1zJ8Lo9Fg2+DAR fd6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jAXLtTho; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id u11-v6sor1579761plr.12.2018.05.25.20.10.52 for (Google Transport Security); Fri, 25 May 2018 20:10:52 -0700 (PDT) Received-SPF: pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jAXLtTho; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=VK/9mMpC/1a8UbDOAds8KjsHvnHDwxxKwucQSsurm1o=; b=jAXLtThor9uKCmUvL53HO6b5gKh9yw8EkdlwjJ6Oc87h8OSt+3PaqYDzg2BXlQcVRD FyV5zbFbQopUWAoR+rZ7jB/Emgh8nfgaEMfYdtxYTaObl2RhaeFGex9mC1UATpOXUQqT 4MC9FBgMpskkkCZQwEsFoME3mmRvUk3Zx+gM0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=VK/9mMpC/1a8UbDOAds8KjsHvnHDwxxKwucQSsurm1o=; b=UEtdtG/da1dwG70JlR/29IM48B8gfHS6oUqd1iwxjQeMTlEfcXSNLquRSsAhxqVlkQ leRB0gWJSCDthJBIP20lN6Ve/OAPqBQx3cTXTPinAwLdj/0O2gYpf75AiO45/cnSN0aG lI+YNvAhhiZ2mojRGENsUNYuuJjSXY5WKttznieV7czh2C1EbjGenQYk7r3zEXohwOaz G6vpGOqCd3GsEU7tBWfINm5qKGnTwWEB88TK1qA4E5gKScdN66yQsNRSW/Nct9M8kNJO HWwIx3S4EQu+kDOXVpo1in2cMyUf9tTlApv3lfWfU3MTmPUP5Eppsha6joRfZ6xjN7Vq Wqpw== X-Gm-Message-State: ALKqPwcyM078BeiQJU+fCadQ5X5Kzgc8RpZQF5LROOfubYrChay83OQ0 lYhKmRtmBQ/lbJAAoqrNxOtsaOyX X-Google-Smtp-Source: AB8JxZrEIX1lMB8bSg1ALijagaS4ZavQSfyFPBmi9j87lIL+YdJGd0c+DSqxP2avlYpfnehUbx02Tg== X-Received: by 2002:a17:902:ab8b:: with SMTP id f11-v6mr4882682plr.372.1527304251888; Fri, 25 May 2018 20:10:51 -0700 (PDT) Return-Path: Received: from localhost.localdomain ([2601:1c2:600:5100:4e72:b9ff:fe99:466a]) by smtp.gmail.com with ESMTPSA id r90-v6sm64350872pfg.122.2018.05.25.20.10.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 25 May 2018 20:10:50 -0700 (PDT) From: John Stultz To: lkml Cc: John Stultz , Ryan Grachek , Wei Xu , Arnd Bergmann , Ulf Hansson , YongQin Liu , Leo Yan Subject: [PATCH] arm64: dts: hikey: Fix eMMC corruption regression Date: Fri, 25 May 2018 20:10:47 -0700 Message-Id: <1527304247-12868-1-git-send-email-john.stultz@linaro.org> X-Mailer: git-send-email 2.7.4 This patch is a partial revert of commit abd7d0972a19 ("arm64: dts: hikey: Enable HS200 mode on eMMC") which has been causing eMMC corruption on my HiKey board. Symptoms usually looked like: mmc_host mmc0: Bus speed (slot 0) = 24800000Hz (slot req 400000Hz, actual 400000HZ div = 31) ... mmc_host mmc0: Bus speed (slot 0) = 148800000Hz (slot req 150000000Hz, actual 148800000HZ div = 0) mmc0: new HS200 MMC card at address 0001 ... dwmmc_k3 f723d000.dwmmc0: Unexpected command timeout, state 3 mmc_host mmc0: Bus speed (slot 0) = 24800000Hz (slot req 400000Hz, actual 400000HZ div = 31) mmc_host mmc0: Bus speed (slot 0) = 148800000Hz (slot req 150000000Hz, actual 148800000HZ div = 0) mmc_host mmc0: Bus speed (slot 0) = 24800000Hz (slot req 400000Hz, actual 400000HZ div = 31) mmc_host mmc0: Bus speed (slot 0) = 148800000Hz (slot req 150000000Hz, actual 148800000HZ div = 0) mmc_host mmc0: Bus speed (slot 0) = 24800000Hz (slot req 400000Hz, actual 400000HZ div = 31) mmc_host mmc0: Bus speed (slot 0) = 148800000Hz (slot req 150000000Hz, actual 148800000HZ div = 0) print_req_error: I/O error, dev mmcblk0, sector 8810504 Aborting journal on device mmcblk0p10-8. mmc_host mmc0: Bus speed (slot 0) = 24800000Hz (slot req 400000Hz, actual 400000HZ div = 31) mmc_host mmc0: Bus speed (slot 0) = 148800000Hz (slot req 150000000Hz, actual 148800000HZ div = 0) mmc_host mmc0: Bus speed (slot 0) = 24800000Hz (slot req 400000Hz, actual 400000HZ div = 31) mmc_host mmc0: Bus speed (slot 0) = 148800000Hz (slot req 150000000Hz, actual 148800000HZ div = 0) mmc_host mmc0: Bus speed (slot 0) = 24800000Hz (slot req 400000Hz, actual 400000HZ div = 31) mmc_host mmc0: Bus speed (slot 0) = 148800000Hz (slot req 150000000Hz, actual 148800000HZ div = 0) mmc_host mmc0: Bus speed (slot 0) = 24800000Hz (slot req 400000Hz, actual 400000HZ div = 31) mmc_host mmc0: Bus speed (slot 0) = 148800000Hz (slot req 150000000Hz, actual 148800000HZ div = 0) EXT4-fs error (device mmcblk0p10): ext4_journal_check_start:61: Detected aborted journal EXT4-fs (mmcblk0p10): Remounting filesystem read-only And quite often this would result in a disk that wouldn't properly boot even with older kernels. It seems the max-frequency property added by the above patch is causing the problem, so remove it. Cc: Ryan Grachek Cc: Wei Xu Cc: Arnd Bergmann Cc: Ulf Hansson Cc: YongQin Liu Cc: Leo Yan Signed-off-by: John Stultz --- arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 - 1 file changed, 1 deletion(-) -- 2.7.4 Tested-by: Leo Yan diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts index 724a0d3..edb4ee0 100644 --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts @@ -299,7 +299,6 @@ /* GPIO blocks 16 thru 19 do not appear to be routed to pins */ dwmmc_0: dwmmc0@f723d000 { - max-frequency = <150000000>; cap-mmc-highspeed; mmc-hs200-1_8v; non-removable;