From patchwork Sat May 12 04:59:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 135630 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp1754310lji; Fri, 11 May 2018 22:06:21 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrprqxV84bpLX4pVzeid90OVtQ9g7M0DY/Gd2glPNvFb7Y7Zu2TAOF2BIBCs/pfkiuJOQVW X-Received: by 2002:a37:ea08:: with SMTP id t8-v6mr705535qkj.237.1526101581586; Fri, 11 May 2018 22:06:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526101581; cv=none; d=google.com; s=arc-20160816; b=wG6gcZ687gRoAZ+EbGjYnXJOs0uyyL8E7UmxWVYXIp6NfmRhFzTsZuWLBSFE6GxM3E glrFoQiythMinvws1pCphOwVguYBR7zqZ2h4X9sFISCNYMEAY72tbHYRJtu6Ok6X6WPa bU6UzQjUs1peZve1C5O9GFV/zgZwzsVSxXmBY5stmKCrLNUUVV6V6k1MO95i/ucdDroD YVqz5Sn+++sA9Blb209RWWVqtiZamRleqAcagQ548b6Nix/m/Jq0rFbPWv0IfQ9rNVEj T0hUQbGPTtl8VkRJPzUzxf7HuTi4e4maia+EYLOudNemcsMyXpT0oFo/aah7qHZRyUI6 4J2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=eZAmhtzlr57bSD2VFsORdpckLMPKmLOhkr3gHWfLPlM=; b=cUpBP45QLVxlcdb6xActa2yZ9zr/V48x2NKST6rUzu/p+npVlHFKPlqjJQ+D2MFALM Q9o3CZRRv1Lwpf28uxZpi0rmveRzg/ZAt9OHDpn+vcEBcMc/K7nODZKnRVaKB6fnPlki 5/K45bHKXBkmvJBVi48ZOL8sg26ZeSFykNRR1AR1Rfwk2EaZ3/cEhS5mQV18zPBXn59w jFdNFGAfg76yigV0PsmVELcS24mtusNQrLtRsMijRwsvGJoKa2K0PcVL3iEpU9B98KVa tChPPaLj/ASWkQTqiYiBiPFCZwkpsa29kskwzhEXQwttlYk3+FHioXzvUrTvy3zVPF2w ANEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=fDfFge2r; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id x188-v6si2062768qkd.121.2018.05.11.22.06.21 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 11 May 2018 22:06:21 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=fDfFge2r; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:45434 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fHMjc-0005Pw-UN for patch@linaro.org; Sat, 12 May 2018 01:06:20 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59939) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fHMdV-0007QO-BJ for qemu-devel@nongnu.org; Sat, 12 May 2018 01:00:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fHMdU-0007Kx-L4 for qemu-devel@nongnu.org; Sat, 12 May 2018 01:00:01 -0400 Received: from mail-pg0-x244.google.com ([2607:f8b0:400e:c05::244]:38716) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fHMdU-0007KU-Fy for qemu-devel@nongnu.org; Sat, 12 May 2018 01:00:00 -0400 Received: by mail-pg0-x244.google.com with SMTP id n9-v6so3245838pgq.5 for ; Fri, 11 May 2018 22:00:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=eZAmhtzlr57bSD2VFsORdpckLMPKmLOhkr3gHWfLPlM=; b=fDfFge2rc2L/7dRCbEhtgqoc4za0Ss2LvyYzassz//8827ZV/fHosGu+HeQoHA8zRE D35eur7LFalTPTgPcOH7RyABCMITbr7d8N59pvyO9h3KZr7CRAYqLynm10k9vQHRb6ed nOncylOHr8ufJv+W+OM4m4nTMWZ5j00wTbegg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=eZAmhtzlr57bSD2VFsORdpckLMPKmLOhkr3gHWfLPlM=; b=VcmcUk0I67aM8vW3NuL73wVYrnbFab+4Iey8Els15sUN3xseHvQqvYftRyqHPPT8rx KNeNfnGNkcxN0VSK3wMPpP2RYOA0S+seH//hAo74ut2yABVMq4Jt5hCmXmxqzwVAJT5A vJecdf/NS0Mdtp+05IoQ2GceTWjWqjpyZoNwwnnoUO/ALT3dX3YawxUg5zaH9GpcA/lO Hr0vDdt4qPEKon6umGGRiLAw5bzmhvj0RsYzWSzseuPmSVVlrfj1OmZXP3Bu/52FO/b+ dJTnptAHgFtVVLXSJj2l4RMcnns82w8c3JfplJ2y2TeQys92NLPsl3FyUsQpYDkSfKou tB9w== X-Gm-Message-State: ALKqPwfWUzisVOYZmEAGnE9H5d7tkZOEMxS/Ljvl+6Y4Sd2L47gL0/pH 32Wo1ANF/kXNMonSgP6upETvo/N9d+0= X-Received: by 2002:a62:d9d9:: with SMTP id b86-v6mr1688658pfl.41.1526101199077; Fri, 11 May 2018 21:59:59 -0700 (PDT) Received: from cloudburst.twiddle.net (97-113-2-170.tukw.qwest.net. [97.113.2.170]) by smtp.gmail.com with ESMTPSA id b5-v6sm7057551pgc.16.2018.05.11.21.59.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 May 2018 21:59:57 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Fri, 11 May 2018 21:59:43 -0700 Message-Id: <20180512045950.12386-5-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180512045950.12386-1-richard.henderson@linaro.org> References: <20180512045950.12386-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::244 Subject: [Qemu-devel] [PATCH 2/2] target/s390x: Fix brace Werror with clang 6.0.0 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cornelia Huck , David Hildenbrand , laurent@vivier.eu, Alexander Graf Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The warning is target/s390x/misc_helper.c:209:21: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces] SysIB sysib = { 0 }; ^ {} While the original code is correct, and technically exactly correct as per ISO C89, both GCC and Clang support plain empty set of braces as an extension. Cc: Alexander Graf Cc: David Hildenbrand Cc: Cornelia Huck Signed-off-by: Richard Henderson --- target/s390x/misc_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.0 Reviewed-by: David Hildenbrand diff --git a/target/s390x/misc_helper.c b/target/s390x/misc_helper.c index e0b23c1fd1..1f834f35ef 100644 --- a/target/s390x/misc_helper.c +++ b/target/s390x/misc_helper.c @@ -206,7 +206,7 @@ uint32_t HELPER(stsi)(CPUS390XState *env, uint64_t a0, uint64_t r0, uint64_t r1) const MachineState *ms = MACHINE(qdev_get_machine()); uint16_t total_cpus = 0, conf_cpus = 0, reserved_cpus = 0; S390CPU *cpu = s390_env_get_cpu(env); - SysIB sysib = { 0 }; + SysIB sysib = { }; int i, cc = 0; if ((r0 & STSI_R0_FC_MASK) > STSI_R0_FC_LEVEL_3) {