From patchwork Sat May 12 04:59:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 135624 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp1749920lji; Fri, 11 May 2018 22:00:27 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoCmW8xnwojbFvjlARR9miANaFG35+57YRS+wHQhOJV/7hO459u9p5pSLawfnBhAs/fmwev X-Received: by 2002:a0c:9e05:: with SMTP id p5-v6mr1130945qve.136.1526101227552; Fri, 11 May 2018 22:00:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526101227; cv=none; d=google.com; s=arc-20160816; b=WoRwffJcjdn32HBjv5zzZmSv82TlE4/eQ9TuZeTnCG1F/cSeeNRA4QxnX9Fg82SgMz wVqikW3LtLSuxe2B19jOehyHd/wpEpQv4vM1EFu7Bdt4jvqnc5uVP7o4cjmks2HyWnkI sR2Oz+IUctC6yRQVopCjMEcJcVQwkPrLYDnoz6Kw2zsjh68qNJbv3pxPTERTTK8cIogU a4xIZOgrKJKGWnLsEnUGjf4BveGd6GqwBLkonZK1mM77Wt6Wvti3BhdT5ZWAPfQtHKoX 3VOu7vk7iTM5xJJ0vAGTT1nQX0cAYPVury5HVIkeBCM1L+7BN2GE6Ztj/xyXiReU+aaS CKVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=HmV49nLJ6y8U9749KyeDAFR/zUCT5hZAmZM9azYZbHQ=; b=J1iP2GOQCUPJduae4frChuUcwr1CzzvTx/XAWYc4oUN6v3F1uc1V1VLluOja66IopC gNTTKcQZMcJHE5sLMuc2An3kPodDma2Taa0Nm77EVxTwB+Y/jDHr+qQuKLoKPPbeTbaL pFcy7fbJZfTIgCv6RGDwPhphqnwmuxdwAp2sc4iTGKUfI3cp3C7twxBKsah2SJJplMbP hUHsgdWZqBgV1DRGU/KHuQy+VTYTxtNleB0K6K5/Ws6fCdqyUfcUpR+lqH01VPUvq2m4 dopCwsgSw6uC5oDktMY60pn99r0bYm7vCLD//HbtAoRUghKmO4gOBfomNIsKmbVUk7AF CgTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=gQWwoYmh; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id h68-v6si1821570qkc.22.2018.05.11.22.00.27 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 11 May 2018 22:00:27 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=gQWwoYmh; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:45331 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fHMdu-0007W5-WE for patch@linaro.org; Sat, 12 May 2018 01:00:27 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59909) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fHMdU-0007Mv-2I for qemu-devel@nongnu.org; Sat, 12 May 2018 01:00:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fHMdR-0007K5-Vu for qemu-devel@nongnu.org; Sat, 12 May 2018 01:00:00 -0400 Received: from mail-pl0-x243.google.com ([2607:f8b0:400e:c01::243]:38183) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fHMdR-0007Jv-PT for qemu-devel@nongnu.org; Sat, 12 May 2018 00:59:57 -0400 Received: by mail-pl0-x243.google.com with SMTP id c11-v6so4377079plr.5 for ; Fri, 11 May 2018 21:59:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=HmV49nLJ6y8U9749KyeDAFR/zUCT5hZAmZM9azYZbHQ=; b=gQWwoYmh81GWPh0PRevxa8DYsTm2mxHrGOu+JJz8YAJ36mkT4hS+MCCczkFiZyQrW6 V6VMO0LjPsVvGO5WYT9DJiFihu+tjHp98aFZpH9+DzRacqgZPombMXCMK30CG+vTJZ3U ZKpo7SHEsNE+nj639lOvsAO5hd9BaZ7ojGu7k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=HmV49nLJ6y8U9749KyeDAFR/zUCT5hZAmZM9azYZbHQ=; b=K8ioPA9PE/V5myJp/iEUH7evxQ5InPo/dW9OHD8a5R7LfTvT+F63Mk5RErv3+GMwEc U/VJVf3NaeRmGXggO7VtL1XrczLVQQZ5o0hXYmB+dFcGFYvtY63u+PFzRbKnyEcT2DGD J7Idsxrk3qXO0+f6Ds44ZLNDs4QI/iqi3y/aq9ceD89V9kROguSb+xhIpy4ifHD0qaFj DJ7wIZh8ztfVLTVN7naBv7jybUEmgJGTHnSQVBUla31DYmov6CiX6nu0IMgPgYMMfk3l nU2maPk8jk3//lp4qz6+4tJ8h9ei2PB9OKKDFeBUICg3f95mVygXMBCTi+CAre/6eoIc gFXg== X-Gm-Message-State: ALKqPwdFser4drCRS6dmvTAstphnRPX8kYwo0AyTaDVsnzcIb+zEFqMC XQVG2lOefKCXlHkFth+cr7vNMpfGrRo= X-Received: by 2002:a17:902:343:: with SMTP id 61-v6mr1025604pld.39.1526101196429; Fri, 11 May 2018 21:59:56 -0700 (PDT) Received: from cloudburst.twiddle.net (97-113-2-170.tukw.qwest.net. [97.113.2.170]) by smtp.gmail.com with ESMTPSA id b5-v6sm7057551pgc.16.2018.05.11.21.59.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 May 2018 21:59:55 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Fri, 11 May 2018 21:59:41 -0700 Message-Id: <20180512045950.12386-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180512045950.12386-1-richard.henderson@linaro.org> References: <20180512045950.12386-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c01::243 Subject: [Qemu-devel] [PATCH 1/9] target/m68k: Use DISAS_NORETURN for exceptions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: laurent@vivier.eu Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The raise_exception helper does not return. Do not generate any code following that. Signed-off-by: Richard Henderson --- target/m68k/translate.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) -- 2.17.0 diff --git a/target/m68k/translate.c b/target/m68k/translate.c index 44a0ac4e2e..86404906e0 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -291,18 +291,18 @@ static void gen_jmp(DisasContext *s, TCGv dest) s->is_jmp = DISAS_JUMP; } -static void gen_raise_exception(int nr) +static void gen_exception(DisasContext *s, uint32_t dest, int nr) { - TCGv_i32 tmp = tcg_const_i32(nr); + TCGv_i32 tmp; + update_cc_op(s); + tcg_gen_movi_i32(QREG_PC, dest); + + tmp = tcg_const_i32(nr); gen_helper_raise_exception(cpu_env, tmp); tcg_temp_free_i32(tmp); -} -static void gen_exception(DisasContext *s, uint32_t where, int nr) -{ - gen_jmp_im(s, where); - gen_raise_exception(nr); + s->is_jmp = DISAS_NORETURN; } static inline void gen_addr_fault(DisasContext *s) @@ -6106,7 +6106,6 @@ void gen_intermediate_code(CPUState *cs, TranslationBlock *tb) if (unlikely(cpu_breakpoint_test(cs, dc->pc, BP_ANY))) { gen_exception(dc, dc->pc, EXCP_DEBUG); - dc->is_jmp = DISAS_JUMP; /* The address covered by the breakpoint must be included in [tb->pc, tb->pc + tb->size) in order to for it to be properly cleared -- thus we increment the PC here so that @@ -6150,6 +6149,7 @@ void gen_intermediate_code(CPUState *cs, TranslationBlock *tb) tcg_gen_exit_tb(0); break; case DISAS_TB_JUMP: + case DISAS_NORETURN: /* nothing more to generate */ break; } From patchwork Sat May 12 04:59:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 135628 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp1752436lji; Fri, 11 May 2018 22:03:43 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrL3gE/U6aXofxjjaJm08DeB7RAu9SYdhb0iyW5/bagdkLc5VVvUOn8fKFkfrNapxD7FBm3 X-Received: by 2002:ae9:c114:: with SMTP id z20-v6mr758615qki.118.1526101423787; Fri, 11 May 2018 22:03:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526101423; cv=none; d=google.com; s=arc-20160816; b=EfhRYRxhR0gBROSxlIU+Ip5f/POuxDZ7NJFIargOJiNt9JSPU6F8/qrm4Qe6d3znC+ 6lFwEQHm1w3UKHgegDUSHjuKfry9uThxwq3llfjEqRUnHXMApV+W3ELFy/TLke8HZcgs jBE1q8qr0cwRKiMVjucceCfLd+/0qBSu76z8BsCSlReSFrEbAHJBcJSLtToIXLR3SS+y ZWq+tXoQCREPVf1nFdur/bOWYZxQ21b2YnJguM/7+oWJ0RuKBeCLTDc6Y3aIGQf4+gXU aSOnCpUTKXPGFMnxZcHPhqWCrsGR0gcVuKvsTVz0wnJo6kSWtt7ApkaevQHvIpE8Vn3f tB3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=2h8oXQwE9h1EoJwXHIglzoEGED86c8Vcit+7NqxnS7A=; b=KT14ux/yJG+hfttqzBPfSrFwfQ+86mZ4YgwrP6jWxPTnayHM+6aoHKbwIFm3Zs48v0 V8jVitSELK5vaZzJIlxjcWymihAMFQLWR1421CY9tN8/3tlG6omcNNn4kBaztigURPE6 JzcKAQfw0re1g3Pip6fVa3f1UKF3MRnhQBGaFZDIwxPTDUlgPRc1vpi81c/Imyoa+SNW MksLkdcZ0COrBPadNBkAA634UXqQ+HZD3XWrmn7IzBs+3+f48fIn55vdjiKmfMdlQ8CA zoigOdlDCCYn98XoRNnMeZDwanv4eKc6QlqSV82NSYlJlKfirlLwLUxsZMHJzGE03lYT 3wEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=FqB1B/OZ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id b36-v6si1399493qtb.302.2018.05.11.22.03.43 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 11 May 2018 22:03:43 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=FqB1B/OZ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:45385 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fHMh5-00044x-7h for patch@linaro.org; Sat, 12 May 2018 01:03:43 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59911) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fHMdU-0007Mx-2M for qemu-devel@nongnu.org; Sat, 12 May 2018 01:00:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fHMdT-0007KM-0w for qemu-devel@nongnu.org; Sat, 12 May 2018 01:00:00 -0400 Received: from mail-pl0-x243.google.com ([2607:f8b0:400e:c01::243]:40834) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fHMdS-0007KD-RJ for qemu-devel@nongnu.org; Sat, 12 May 2018 00:59:58 -0400 Received: by mail-pl0-x243.google.com with SMTP id t12-v6so4372162plo.7 for ; Fri, 11 May 2018 21:59:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=2h8oXQwE9h1EoJwXHIglzoEGED86c8Vcit+7NqxnS7A=; b=FqB1B/OZ9wX/jIfD+n0/TuwtMh3YGPDfOoVgz170eRGqN4qQ8bxJ3vul6aTbWSzJYd GmybI/e4naCsGommgFFsKa8fwz8HYRMWuP7svnrli+6fwlqCuQmT2BIUmj53ggpfAAYm yi9IiM3VEkkInCRF9D+8EFTIGNG460kYwSDxM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=2h8oXQwE9h1EoJwXHIglzoEGED86c8Vcit+7NqxnS7A=; b=W5w90ehyOIBEnPLRF6urDlSw0XgOL9P4gPbm4MqpzlNtorMVfo2qbWYAGkgbEOYPpY pCz5G3271srMTNDXUE7hUuLMdOoYOSEpNWgxC0MAWPIr0cEVTa4aNilQgWF7ZeJmmrYm yFUzeHeWC1C3B9rBJAqqTg5Q+zqtDG6XAhANM8tlY7K/JtQcWgJMCZqB0lKZG2uDUKRP p9AgoWlDUea5kxBAha76ASDZaftH6SJ6Z0m8kxaRepq7GazSWxHJuQRXiNmaIknY/OzF YmcH93CHUPy+jAV+4bBF8nPpoIUIUjKqnK43AphLhkEytceqIiQ4ea/29Ie1BhlxWn1H b5uw== X-Gm-Message-State: ALKqPwd5hotNB9jB6B+ij7Nmn79yqSWSulSYLz4Src7MfE543KjHoHfA d2e3C021ED7vgbUuopJJrB9Y4AD1yJo= X-Received: by 2002:a17:902:a5c7:: with SMTP id t7-v6mr1015285plq.360.1526101197558; Fri, 11 May 2018 21:59:57 -0700 (PDT) Received: from cloudburst.twiddle.net (97-113-2-170.tukw.qwest.net. [97.113.2.170]) by smtp.gmail.com with ESMTPSA id b5-v6sm7057551pgc.16.2018.05.11.21.59.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 May 2018 21:59:56 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Fri, 11 May 2018 21:59:42 -0700 Message-Id: <20180512045950.12386-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180512045950.12386-1-richard.henderson@linaro.org> References: <20180512045950.12386-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c01::243 Subject: [Qemu-devel] [PATCH 2/9] target/m68k: Replace DISAS_TB_JUMP with DISAS_NORETURN X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: laurent@vivier.eu Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" We have exited the TB after using goto_tb; there is no distinction from DISAS_NORETURN. Signed-off-by: Richard Henderson --- target/m68k/translate.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.17.0 diff --git a/target/m68k/translate.c b/target/m68k/translate.c index 86404906e0..6ab24fac0b 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -199,7 +199,6 @@ static void do_writebacks(DisasContext *s) /* is_jmp field values */ #define DISAS_JUMP DISAS_TARGET_0 /* only pc was modified dynamically */ #define DISAS_UPDATE DISAS_TARGET_1 /* cpu state was modified dynamically */ -#define DISAS_TB_JUMP DISAS_TARGET_2 /* only pc was modified statically */ #define DISAS_JUMP_NEXT DISAS_TARGET_3 #if defined(CONFIG_USER_ONLY) @@ -1496,7 +1495,7 @@ static void gen_jmp_tb(DisasContext *s, int n, uint32_t dest) gen_jmp_im(s, dest); tcg_gen_exit_tb(0); } - s->is_jmp = DISAS_TB_JUMP; + s->is_jmp = DISAS_NORETURN; } DISAS_INSN(scc) @@ -6148,7 +6147,6 @@ void gen_intermediate_code(CPUState *cs, TranslationBlock *tb) /* indicate that the hash table must be used to find the next TB */ tcg_gen_exit_tb(0); break; - case DISAS_TB_JUMP: case DISAS_NORETURN: /* nothing more to generate */ break; From patchwork Sat May 12 04:59:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 135633 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp1756384lji; Fri, 11 May 2018 22:09:00 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqFy+zZe1Lvy4isi7qB3p3aFOaRtqpjhZbX11e4NKXLeGYewsaew8izWye3Hsy5cs01/Dy2 X-Received: by 2002:a37:18e5:: with SMTP id 98-v6mr710287qky.347.1526101740806; Fri, 11 May 2018 22:09:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526101740; cv=none; d=google.com; s=arc-20160816; b=aH5FGi+YYioFazFGeyeghoJ83SvJ+/fw/P5BqIzT0NoPNMJWMsafc5Pl4tJEY5cmdg /bSiWeOXh7Uji7VYpmhZX6VPm4AaK+VwHcuHV4ywiSdTrdclO3b/jNhiQAR1rFDhFGHW cJn6moNWPenH2jq5NwLIOSWev/1+UjTFbfSscqp3q8EkmoAW1bW6zXx5re0n4u/EYwjK uFIWRfhFAojYoQEENS0tklDsjVkZlRNbJ19hRU5iQltHEv4dJiEohAaG9PwDi0wUoZuR ua48x6kXQch5In4te5wPmivEQ/ah+4GE49QfEObbrlKvr6eOhbDB4lhIkUjgFg7OUYtX 55HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=tNTLnC9nTzAT6+eS/Qq74KyG9riiNWqgx1lt/ZK6vsM=; b=favCeQdRZRqDUMUacoUl17T7AmI74NLsx5ExuEm5YtpEv1nGEH3ll9QZQjdZ5qCP0u PhoTr32o3biRLGQe91Iep7M8EKkht6gLY1GfKWux7SEEJ3hptohLQy7yZuy5q+0HMa2y BTv7ol0qjz0VMeSW/tZr4PEl9pdWh4wiP+kJ1vjAxF/ImiGKwGmnAsVs7pUUGdGFqZ+H 74XtO+9iyddQo4aZYMPed88bE73J+mjhQYXTs/R9DFG1vjgzvkbDE530R4zJmE4dGwHo buJrPXw/quT+6o3hdTm6+T9pwaYqZLYRtmhNCGka7VIuTdi/LzZykyB9QLJHuks7SwrJ wMCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=SzKEZz1G; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id o62-v6si4627505qke.105.2018.05.11.22.09.00 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 11 May 2018 22:09:00 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=SzKEZz1G; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:45560 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fHMmC-0007Jt-6O for patch@linaro.org; Sat, 12 May 2018 01:09:00 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59950) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fHMdW-0007V1-Ft for qemu-devel@nongnu.org; Sat, 12 May 2018 01:00:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fHMdW-0007Lc-06 for qemu-devel@nongnu.org; Sat, 12 May 2018 01:00:02 -0400 Received: from mail-pf0-x243.google.com ([2607:f8b0:400e:c00::243]:43553) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fHMdV-0007LU-Rc for qemu-devel@nongnu.org; Sat, 12 May 2018 01:00:01 -0400 Received: by mail-pf0-x243.google.com with SMTP id j20-v6so3605225pff.10 for ; Fri, 11 May 2018 22:00:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=tNTLnC9nTzAT6+eS/Qq74KyG9riiNWqgx1lt/ZK6vsM=; b=SzKEZz1GvnX5hSGE3Z3Dqf7kq6hM9EKW0Zer47FiSSI/jzGb5VozPYEUOLaQvTJFIX Uf1ODqYsxYTgJOxPQbfmgSw33PMtQfLmXVfwV1Vd+GhPcOZQIGJ6rqvo7Zo6Y7kwrU13 y/ljR9HjjAHpIhXIiTKAmTO07qU0bEvr2SQIo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=tNTLnC9nTzAT6+eS/Qq74KyG9riiNWqgx1lt/ZK6vsM=; b=GSvc7DwUc4yQb+d1Cfp/5tHUj0uKsMyP2AyfmF3RgwcbexeGNH9GLODdYRA0s+/lj5 5PxIWp8jwagCHG7ACZcQNxLSyIUy2Ior1C8pC7gnGglJrGc/1b+ZA8E1uu200cjAuxzp Txwa5lJFACluLPXpzOWXohH5ig36ZJVijfyVgme93Vv4p7DIWIz3+AKYmHaEGSG5pLA+ EhEg5CP2byB8SE3RlqtrHjF6unipW670WBTOjC4iu/dvq3Z+LSwonuas0P+cTa/E5FJb SK5BGEXtdvQE28F0ZJ11gFVyzHklnt2YyD6fBoShnt8wffThzrjYtC/Cy3FHPA3pQMfV XBFQ== X-Gm-Message-State: ALKqPwdr1tArdu6zINAdsCNkmzdJ4SHuE0a4ADvXAyYCoJVfYch5s/8h 3D7YljRT0R6XnJc322AoqplmQD2M15M= X-Received: by 2002:a62:4708:: with SMTP id u8-v6mr1684651pfa.89.1526101200453; Fri, 11 May 2018 22:00:00 -0700 (PDT) Received: from cloudburst.twiddle.net (97-113-2-170.tukw.qwest.net. [97.113.2.170]) by smtp.gmail.com with ESMTPSA id b5-v6sm7057551pgc.16.2018.05.11.21.59.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 May 2018 21:59:59 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Fri, 11 May 2018 21:59:44 -0700 Message-Id: <20180512045950.12386-6-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180512045950.12386-1-richard.henderson@linaro.org> References: <20180512045950.12386-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::243 Subject: [Qemu-devel] [PATCH 3/9] target/m68k: Remove DISAS_JUMP_NEXT as unused X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: laurent@vivier.eu Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Richard Henderson --- target/m68k/translate.c | 1 - 1 file changed, 1 deletion(-) -- 2.17.0 diff --git a/target/m68k/translate.c b/target/m68k/translate.c index 6ab24fac0b..c795d8e64f 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -199,7 +199,6 @@ static void do_writebacks(DisasContext *s) /* is_jmp field values */ #define DISAS_JUMP DISAS_TARGET_0 /* only pc was modified dynamically */ #define DISAS_UPDATE DISAS_TARGET_1 /* cpu state was modified dynamically */ -#define DISAS_JUMP_NEXT DISAS_TARGET_3 #if defined(CONFIG_USER_ONLY) #define IS_USER(s) 1 From patchwork Sat May 12 04:59:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 135635 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp1756705lji; Fri, 11 May 2018 22:09:27 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpnU9ZckVSfGoBZoqIeONyqiuiv8eUjX5DPnYuQtwiNb6reiqu2ia1jgtFTGhKMWp4ppZPv X-Received: by 2002:ae9:dfc1:: with SMTP id t184-v6mr755086qkf.274.1526101767491; Fri, 11 May 2018 22:09:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526101767; cv=none; d=google.com; s=arc-20160816; b=po2LUK0GRUs5PjuNn0iNvEMFwpkJdmyuRhcTavA7IA0MnEO05Ir0iOmUGl7N0eoBjO dLQLpsO3ww/VbAvEyuO01uFCuDs/3093DTnGavR2SxWp1VuO2UpJH3Nv6lVG1LLMt3wQ bpi9Qn8ayCq/JdAx020BUJNp/VoYCmvw/43CSm8ahuOqyug5aFxFMdrHp/I4HYNHN0cT qG5f+AMaTdcaNpDBDr82YSij3bgyuU0axg/xkF6erJLxYAhZ3pBSM+0iSnrNe5j8GAub IFvSdLpxZWtLIHceLGtT0/YHWiY+xsX7UPbqHcdXtIt0D9Uc4WaRHg3WzMt2B+iJXkoh rp0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=TFZiFQHICSD7tSpPnk5VYIEXmQgj2zjPgKFhaAtzL7M=; b=U4/n490WmOZaJVUG8Ae9iHV3FMcMzTjl6Vg/Vc5M3pDESfAbOo15svW9evjl2zK8n0 e0qOeaMJ/Bananyng+pEPp8Chhn8jOugPrLFpkc2McJ1zykYSoasxUtkARPNvglZdgQA 79OSw3KUmgwtit3DrYXBh/T1R2YDtq8S1iu/2o+Ikq92/dd0ahKWX66GvK3QFpZ2NYpm KY/YtdKtvhR+989QoK3ttv7cBx3Y3/2lBTMUHzGOPLnmHWW6u4ceM4+cc0+mdlZzFpoB ZNgtP1xXxQV7X3MB7txOYq4TSW5JcIMSfaMSNWTYpKaxbLFNyJDNU5YE9XJQa+izZ8kr kZZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=PthcGckr; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id q1-v6si3549121qvo.243.2018.05.11.22.09.27 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 11 May 2018 22:09:27 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=PthcGckr; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:45590 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fHMmc-0006Uz-NU for patch@linaro.org; Sat, 12 May 2018 01:09:26 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59961) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fHMdX-0007cw-Ua for qemu-devel@nongnu.org; Sat, 12 May 2018 01:00:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fHMdX-0007Lx-7L for qemu-devel@nongnu.org; Sat, 12 May 2018 01:00:04 -0400 Received: from mail-pg0-x243.google.com ([2607:f8b0:400e:c05::243]:45876) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fHMdX-0007Lk-2h for qemu-devel@nongnu.org; Sat, 12 May 2018 01:00:03 -0400 Received: by mail-pg0-x243.google.com with SMTP id w3-v6so3243768pgv.12 for ; Fri, 11 May 2018 22:00:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=TFZiFQHICSD7tSpPnk5VYIEXmQgj2zjPgKFhaAtzL7M=; b=PthcGckrOkYZVdHbOZBUNTwRSCeTfjJkGsWoU8Bm67Rxqx7lHkFJFJAeuLwX17vJxV 4J129hnjfar2wMCBlJL9XWAqKU3dMEh7QRfORjsgcrPp9AFtaUqdZM796Nzjp/0bQe6f HJxBaeYtW5l/WYp7aWlv7fBbUkyGBomZRtyhY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=TFZiFQHICSD7tSpPnk5VYIEXmQgj2zjPgKFhaAtzL7M=; b=JfzIMZ5zHdEx90VuWdfRaZBknIBndKS7QBGE8rpASrL/QQOlz8+blAR+qZzR6nSefE JEm5WTTIlcltzXwlltq1PcWbj+NCtz1m5fv4CvivqS3zGxPzx9HdkW/FzOLyBsupTOol z8ewwMVqZPLIEltpZs8PQTcACE8BxLf6n/v1rdHEU09mVhy6noHD3R2S8dXyJbnjWRF0 GACe196onVy1pDayEx2GXKXGyFuof4TSWLV8e8+6PzQeWg3pDsYHzoDxNe6+36JTFeDH kdgtOOlsjFCcqBX6oXPNHpQKgakUsQ46x3Jch1ONS9lm3NUhtvQGw2s0jPuyqhoOLSVJ RrTQ== X-Gm-Message-State: ALKqPwd6CRul2jCKv6VoxuDiNI+qWK/kUDs7YqlI/jXmCwTElKT/UzsA RH/OLvWihdI1zHXJlRRiOzg2MBpBSZQ= X-Received: by 2002:a62:5d99:: with SMTP id n25-v6mr1668568pfj.143.1526101201638; Fri, 11 May 2018 22:00:01 -0700 (PDT) Received: from cloudburst.twiddle.net (97-113-2-170.tukw.qwest.net. [97.113.2.170]) by smtp.gmail.com with ESMTPSA id b5-v6sm7057551pgc.16.2018.05.11.22.00.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 May 2018 22:00:00 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Fri, 11 May 2018 21:59:45 -0700 Message-Id: <20180512045950.12386-7-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180512045950.12386-1-richard.henderson@linaro.org> References: <20180512045950.12386-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::243 Subject: [Qemu-devel] [PATCH 4/9] target/m68k: Use lookup_and_goto_tb for DISAS_JUMP X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: laurent@vivier.eu Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" These are all indirect or out-of-page direct jumps. We can indirectly chain to the next TB without going back to the main loop. Signed-off-by: Richard Henderson --- target/m68k/translate.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) -- 2.17.0 diff --git a/target/m68k/translate.c b/target/m68k/translate.c index c795d8e64f..80712ed0af 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -6139,8 +6139,11 @@ void gen_intermediate_code(CPUState *cs, TranslationBlock *tb) update_cc_op(dc); gen_jmp_tb(dc, 0, dc->pc); break; - default: case DISAS_JUMP: + /* We updated CC_OP and PC in gen_jmp/gen_jmp_im. */ + tcg_gen_lookup_and_goto_ptr(); + break; + default: case DISAS_UPDATE: update_cc_op(dc); /* indicate that the hash table must be used to find the next TB */