From patchwork Sat May 12 01:48:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 135615 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp1614931lji; Fri, 11 May 2018 18:50:56 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpLbDPykC29M62Leu5zne3AreI2hg+bSDaj84gAXlX9NgcLZsUFTLMfrCZSvhMbdnfRmNxY X-Received: by 2002:a37:7882:: with SMTP id t124-v6mr375074qkc.285.1526089856772; Fri, 11 May 2018 18:50:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526089856; cv=none; d=google.com; s=arc-20160816; b=Pa0NSldDy3PIcWZSi/+aLxu8GM81aB1H9yZIpnLDmaGK3Y2qDHAzMEuqp/UlRdjTqy 6uXxDWZIRl+wl6KhLn8LIZulvL9sY6Fm2QjOQjj71I1aW5QeUQwAgCLBIS0h9gOEu/z/ qU2MhoRl6SKVTXS0VBIzrFivWUPa+/jKJeLFJUWXb0cF57f+mIfgrsVbSxCMJP0RT6qM jOtaqgCVyezjBk7sGdpKKg2HCyXsdHNG2S8tN4qohW25GA4lICOzNNILTyCwry7obViT JkpnaBkhuLh2cceRY/6Ey1qh9PTwh72gz+r0yRGyXMqHO3tM73IQMGtI0NniBaLYAo2a 4LsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:message-id:date:to:from :dkim-signature:arc-authentication-results; bh=1Sjig7cqSKEc/X68uqFmV0Ebn8FWapUkj8SBPuKHvpY=; b=x8LqUUkakmQTU4IbIogoBHxV4wqAXAtwBcMFBqqddqZziWKWgjNyjiBouKX1gvy670 PurJ/ed6dGiQaN5ymSGf+R2XQhKeTe49fYj2xgYBDbvTnFWRpdIMBVTVhjp515LoqeFH 2UqFc/wVXzXCgE3Qql9luWQvt3Gs9hDyajTXCYF4n0rGF+RIpadV/YROnRHBSIJQlnbI 8Yq4CXywfSUQXYU7Oo20JnACbTVmbuxPzmvnXX5To/xg7gauzympEvl4w0IBs449/Q9+ DewnEpowCEjOc4OZxgopv53ADenhQRxTCXZ2y3QfFdPAIjL13A1ZzQ/Vim5YymIx7SM5 1mBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=PkRzHQG3; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id d48-v6si4424403qvd.193.2018.05.11.18.50.56 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 11 May 2018 18:50:56 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=PkRzHQG3; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:35257 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fHJgW-000749-Ac for patch@linaro.org; Fri, 11 May 2018 21:50:56 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44317) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fHJdp-000321-HB for qemu-devel@nongnu.org; Fri, 11 May 2018 21:48:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fHJdm-0007FJ-FX for qemu-devel@nongnu.org; Fri, 11 May 2018 21:48:09 -0400 Received: from mail-pl0-x241.google.com ([2607:f8b0:400e:c01::241]:34384) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fHJdm-0007ES-84 for qemu-devel@nongnu.org; Fri, 11 May 2018 21:48:06 -0400 Received: by mail-pl0-x241.google.com with SMTP id ay10-v6so4203186plb.1 for ; Fri, 11 May 2018 18:48:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=1Sjig7cqSKEc/X68uqFmV0Ebn8FWapUkj8SBPuKHvpY=; b=PkRzHQG3hIXaaNabtygY2OhEWWsd/tHnQyClfeXlqGNsjG2qq4WdfcoOHyypFhCqIg ynzGzEBJBcs8wq1rYwmQtnM6bi/u+Tz13gEI1cNPgB0cLjZQhWOBGmwIg5DCIL2zv/vY MnboAJT48Eehl73NuJQu9f6tgWCIk5y+JUTL4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=1Sjig7cqSKEc/X68uqFmV0Ebn8FWapUkj8SBPuKHvpY=; b=K/5yAGQ7Io9hxB6HkV+auS6mLVn4U8xdv6lXmHcr43m4ogEq8cjV8w4KPFP4YbXGar qt4PhgxtG5/fmgpKLxx4ZjbBGq1pVy0CCnKrO5z2WyAHJCyQUkEgh6R3kU3E+ACe4DaT ZCWzLx7i0gEipWp6AEiRao7WFiFoUbYFZIw1C9ZyCw0q9S2RaJU7ADtMK4TT0g1oKykk j7csJMhvY9zhirPQ800x6KmjLVBjGe2RWERCgCxSU85ysW32WkdfGNfVGWYzfZmxkb6S m6pyusmfvtSSgF3u6QoyiQAvKaavCgKrG8N9stpCPXmWMrIukEq1YuxTzlA9HDVV+T36 ks/w== X-Gm-Message-State: ALKqPwe8UTFBkwcEHY1VzbTtzyxM+NTwFkc7iwPiC1u6tI+iXdDmJ8IW mKqg5eq+1bmaJd2eWL/pbXxX48qUjF0= X-Received: by 2002:a17:902:b409:: with SMTP id x9-v6mr504528plr.180.1526089684583; Fri, 11 May 2018 18:48:04 -0700 (PDT) Received: from cloudburst.twiddle.net (97-113-2-170.tukw.qwest.net. [97.113.2.170]) by smtp.gmail.com with ESMTPSA id 23-v6sm13270443pfs.147.2018.05.11.18.48.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 May 2018 18:48:03 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Fri, 11 May 2018 18:48:00 -0700 Message-Id: <20180512014801.17566-1-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c01::241 Subject: [Qemu-devel] [PATCH 1/2] hw/virtio: Fix brace Werror with clang 6.0.0 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S . Tsirkin" Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The warning is hw/virtio/vhost-user.c:1319:26: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces] VhostUserMsg msg = { 0 }; ^ {} While the original code is correct, and technically exactly correct as per ISO C89, both GCC and Clang support plain empty set of braces as an extension. Cc: Michael S. Tsirkin Signed-off-by: Richard Henderson --- hw/virtio/vhost-user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.0 Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Eric Blake diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index 38da8692bb..b455fca394 100644 --- a/hw/virtio/vhost-user.c +++ b/hw/virtio/vhost-user.c @@ -1316,7 +1316,7 @@ static bool vhost_user_requires_shm_log(struct vhost_dev *dev) static int vhost_user_migration_done(struct vhost_dev *dev, char* mac_addr) { - VhostUserMsg msg = { 0 }; + VhostUserMsg msg = { }; assert(dev->vhost_ops->backend_type == VHOST_BACKEND_TYPE_USER); From patchwork Sat May 12 01:48:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 135614 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp1613142lji; Fri, 11 May 2018 18:48:25 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoHMA1SIWhrrd9sMuPSgruiws/zYK1LoqF7kdjB0ZYhVy3I4TVffCek/HPjndOHOhLpC74Y X-Received: by 2002:a37:2b12:: with SMTP id r18-v6mr372739qkh.152.1526089705219; Fri, 11 May 2018 18:48:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526089705; cv=none; d=google.com; s=arc-20160816; b=wgXcAfsFN764MXBhT00z66HgUfs3O6z0jm6FjnWYLVL+EGQvcbgOebskLvC+3xA6Yk Mpo9RXVCvHpWJQxsUKqB7tzDaWFuXEzzm5CwMqYYXNvPVfMoZvTsgpvKkWyhXMduTuA4 xVHcAArdru2RWE72osAWb64lzkKDWtla0G3jQ92XKbWutcZWiG3Xcd1CaFyw+Nmc8qh1 CeI4SiEKPx+I984olGtVeYvV4Cr3DgdPrqT07SG4w5Acb8qNDI0Ip8IXxR7iR9Tgsnku 5qHKTAf6tIruk5M1Rps3LupG+QnyBOctgrQvi0EBx4tmd+ufgO+qmee1bM65xPFMJKI3 Ssvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=eZAmhtzlr57bSD2VFsORdpckLMPKmLOhkr3gHWfLPlM=; b=cdGDcbR0AKgum0C9Yj5Tm5aKNo2zFexz3aQNkKM3BTuohwghkzuLJKVlihLC537ROk 7CdUl78X4YUotAi8eIRzkiZEiqtKx4OGsmFa6UWIHo/6zBkRA0wp/lK73Xisrmk2w8o1 +/iJofpqaZZ6+dZRKo1uz9VzsOKU1xzxmddpBMh5eqjaCegIrxNzyTFXCUBR/SGGNl4q THg7AYV9kBY/NpbliE543Sv9XyL5bF/oQFAquwg456hs5Z4OV011Y4ZNMCFaNZelSmXF ORtfc7lKRnabEjbfBLLkpKVXoSW8kwBdNXO5vRar3LyAd50Bm+21oVvT4KAVdmbj9quQ AHOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=GPV+NvdR; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id x13-v6si426605qtc.87.2018.05.11.18.48.25 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 11 May 2018 18:48:25 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=GPV+NvdR; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:35155 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fHJe4-0003Bm-Pf for patch@linaro.org; Fri, 11 May 2018 21:48:24 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44315) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fHJdp-00031y-Gc for qemu-devel@nongnu.org; Fri, 11 May 2018 21:48:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fHJdn-0007GS-M5 for qemu-devel@nongnu.org; Fri, 11 May 2018 21:48:09 -0400 Received: from mail-pl0-x242.google.com ([2607:f8b0:400e:c01::242]:35343) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fHJdn-0007Fp-Fl for qemu-devel@nongnu.org; Fri, 11 May 2018 21:48:07 -0400 Received: by mail-pl0-x242.google.com with SMTP id i5-v6so4204991plt.2 for ; Fri, 11 May 2018 18:48:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=eZAmhtzlr57bSD2VFsORdpckLMPKmLOhkr3gHWfLPlM=; b=GPV+NvdRvgpoeNhOmVI7N1EC6ZRFVlk/ZkFo3FxsEzni5v7IWL+wfdrFouRqAd9CrV mchj6C7KT9F3e5MZf33IGVNArpzRLWk/pkrWV7ToY/xuAIf9Ze7QKmljOnYHdcagI1YM INwy3BVLncNax9H5xF3S31WWgii2jUigMH6g8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=eZAmhtzlr57bSD2VFsORdpckLMPKmLOhkr3gHWfLPlM=; b=aZtwYryRKmgri+0O8Swvr5/6Qo9F7+AVqpcgcOXpQgLq56AOT6l2d/ijfFHKdMZeNb us2yOe2jXRu5kHg4b/0JQsEBYYRK3SxqhwzL/3H7jHyYHWN38roPdXyL/SEfTCT1XQvu 7YfE8dGXcIBYN/2nShkBRdTivyyATvgeKW7V9ggwlABTEiq01dlJZOi/eh+F+BjAMvgj H5nVGqGBf8RKsQCbJWA3splcuiPod8R2n0X7kikessqht6f/MrI/37iMV6bkgTVTo8aW Q3whpDSiHCB1Uvu1ivbbXAoIJPO1PDaZCvwFUNBwbdNSPcuk0UXRXgfZR39/PGEv9hxU o64Q== X-Gm-Message-State: ALKqPwe9NofQg4uuIJNm3L9hNaR/ZBYb/fGjrHFndOSVPoByPBzACILq sXAIuc023bPWzJeg1lp+8RGqsrlAZGc= X-Received: by 2002:a17:902:d20a:: with SMTP id t10-v6mr474754ply.364.1526089686116; Fri, 11 May 2018 18:48:06 -0700 (PDT) Received: from cloudburst.twiddle.net (97-113-2-170.tukw.qwest.net. [97.113.2.170]) by smtp.gmail.com with ESMTPSA id 23-v6sm13270443pfs.147.2018.05.11.18.48.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 May 2018 18:48:05 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Fri, 11 May 2018 18:48:01 -0700 Message-Id: <20180512014801.17566-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180512014801.17566-1-richard.henderson@linaro.org> References: <20180512014801.17566-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c01::242 Subject: [Qemu-devel] [PATCH 2/2] target/s390x: Fix brace Werror with clang 6.0.0 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cornelia Huck , Alexander Graf , David Hildenbrand Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The warning is target/s390x/misc_helper.c:209:21: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces] SysIB sysib = { 0 }; ^ {} While the original code is correct, and technically exactly correct as per ISO C89, both GCC and Clang support plain empty set of braces as an extension. Cc: Alexander Graf Cc: David Hildenbrand Cc: Cornelia Huck Signed-off-by: Richard Henderson --- target/s390x/misc_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.0 Reviewed-by: Philippe Mathieu-Daudé diff --git a/target/s390x/misc_helper.c b/target/s390x/misc_helper.c index e0b23c1fd1..1f834f35ef 100644 --- a/target/s390x/misc_helper.c +++ b/target/s390x/misc_helper.c @@ -206,7 +206,7 @@ uint32_t HELPER(stsi)(CPUS390XState *env, uint64_t a0, uint64_t r0, uint64_t r1) const MachineState *ms = MACHINE(qdev_get_machine()); uint16_t total_cpus = 0, conf_cpus = 0, reserved_cpus = 0; S390CPU *cpu = s390_env_get_cpu(env); - SysIB sysib = { 0 }; + SysIB sysib = { }; int i, cc = 0; if ((r0 & STSI_R0_FC_MASK) > STSI_R0_FC_LEVEL_3) {