From patchwork Mon Mar 22 18:58:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: nicolas saenz julienne X-Patchwork-Id: 406240 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5D81C433C1 for ; Mon, 22 Mar 2021 19:00:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7788A619A0 for ; Mon, 22 Mar 2021 19:00:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232118AbhCVS77 (ORCPT ); Mon, 22 Mar 2021 14:59:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:40128 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230091AbhCVS71 (ORCPT ); Mon, 22 Mar 2021 14:59:27 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6FCCB61994; Mon, 22 Mar 2021 18:59:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616439566; bh=WlVTEDge8a2sWi1YSIL9GHQT08rBMoQZeeSuGahDmm4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RaAg53L+LqoHwm+LT0HjGQ5rYxsxUuMG1d3ilweQGgHiRWwxLmzJ36II9eMGyzm96 V388kwNmgSef90LURzrBpjCBWx2tPd8yXqEjsgqAdPg8UEGOFeu9QA8XaCkHYwWdz/ htR5BgjklZO2zE4Kxrj52RJuejuYDYGwGV2I2ftvTVLPZIuSKbkBYmXOtRiquGmsng YcCHCGE2oohWT80QPiRpMrbz6JNqKZiWLTuqjUdhjkkkUhpD6lkdaMIErbPkx2yxjY CWxtKooosprYVrOLH4gYb5kKA5A7TkbGWuELuRCJeVoyt2uxL62CoJPnninquorhig up+/dd/Tm63TA== From: Nicolas Saenz Julienne To: linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Saenz Julienne , Ulf Hansson , Ray Jui , Scott Branden Cc: f.fainelli@gmail.com, phil@raspberrypi.com, tim.gover@raspberrypi.com, adrian.hunter@intel.com, alcooperx@gmail.com, nsaenzjulienne@suse.de, linux-kernel@vger.kernel.org, Rob Herring Subject: [PATCH 2/4] dt-bindings: mmc: iproc-sdhci: Add clock-frequency support Date: Mon, 22 Mar 2021 19:58:15 +0100 Message-Id: <20210322185816.27582-3-nsaenz@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210322185816.27582-1-nsaenz@kernel.org> References: <20210322185816.27582-1-nsaenz@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Users might want to choose a different clock frequency than whatever the bootloader provided at probe time. Add 'clock-frequency' bindings. Signed-off-by: Nicolas Saenz Julienne --- Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml b/Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml index 19d84f3ef9e6..9d0d97b2c0a7 100644 --- a/Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml +++ b/Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml @@ -35,6 +35,12 @@ properties: type: boolean description: Specifies that controller should use auto CMD12 + clock-frequency: + description: + Should be the frequency (in Hz) of the core clock. If this is specified + and the core clock is specified then we'll try to set the core clock to + this at probe time. + required: - compatible - reg From patchwork Mon Mar 22 18:58:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: nicolas saenz julienne X-Patchwork-Id: 406239 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46023C433E4 for ; Mon, 22 Mar 2021 19:00:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2270D619A6 for ; Mon, 22 Mar 2021 19:00:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232246AbhCVS77 (ORCPT ); Mon, 22 Mar 2021 14:59:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:40266 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232292AbhCVS7g (ORCPT ); Mon, 22 Mar 2021 14:59:36 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E84396199F; Mon, 22 Mar 2021 18:59:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616439572; bh=s6ymiQxwePb20Kp2RAPsG0nP87bGAxMicsdfeJT0mC0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ihW3OvOyJmZH+nfKxl3tTK7pmHcaotogYNZlucLYTpV+bfEmX8LFahc17He9AAf/m JYU76wRHhuZgoXBcm81UnVqOTWBZ7QZThqPjO/4o4m2uv3HZ6WNpmnNdzByFxdAbOa pCwMes1lQIQe1TQCu8sZKhVP9oXMINdp0rSi2DAkN+ZCzhG9xl1FueQeS7894UsLjE WRKkaByrfxKF3JudCMmXsq/0BfMly+vdsq6CPGsIJg2k7fJ8HB1lR1B5s5AgCPSPIY EPehDR2OZqWhTDuYF86UL5dX8fuH5bVa4VQo97ErS7g8gf1X86AP/Ax1gzrlWGgzvc unuKPEE9P1JFQ== From: Nicolas Saenz Julienne To: linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Saenz Julienne , Rob Herring , Nicolas Saenz Julienne Cc: f.fainelli@gmail.com, phil@raspberrypi.com, tim.gover@raspberrypi.com, adrian.hunter@intel.com, sbranden@broadcom.com, alcooperx@gmail.com, linux-kernel@vger.kernel.org, ulf.hansson@linaro.org Subject: [PATCH 4/4] ARM: dts: Fix-up EMMC2 controller's frequency Date: Mon, 22 Mar 2021 19:58:17 +0100 Message-Id: <20210322185816.27582-5-nsaenz@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210322185816.27582-1-nsaenz@kernel.org> References: <20210322185816.27582-1-nsaenz@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org From: Nicolas Saenz Julienne Force emmc2's frequency to 150MHz as the default 100MHz (set by FW) seems to interfere with the VPU clock when setup at frequencies bigger than 500MHz (a pretty common case). This ends up causing unwarranted SDHCI CMD hangs when no SD card is present. Signed-off-by: Nicolas Saenz Julienne --- arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts index 3b4ab947492a..9aa8408d9960 100644 --- a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts +++ b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts @@ -257,6 +257,12 @@ &emmc2 { vqmmc-supply = <&sd_io_1v8_reg>; vmmc-supply = <&sd_vcc_reg>; broken-cd; + /* + * Force the frequency to 150MHz as the default 100MHz seems to + * interfere with the VPU clock when setup at frequencies bigger than + * 500MHz, causing unwarranted CMD hangs. + */ + clock-frequency = <150000000>; status = "okay"; };