From patchwork Mon Mar 22 12:14:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 406128 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp3514550jai; Mon, 22 Mar 2021 05:15:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxWWsq5ZJN166C3kqXNbI9eRjdb5/wbFUYyLo21IKr+oTmpIx/IrmIvjKJlYCay90oWWm2u X-Received: by 2002:a17:906:5450:: with SMTP id d16mr19083146ejp.274.1616415357287; Mon, 22 Mar 2021 05:15:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616415357; cv=none; d=google.com; s=arc-20160816; b=YfYMJAxRe8/MHy0IBMl3HNlrkzY7aHZ3H4asBgI8JHKdvFu0qyOzAq0rerkDG/4oo6 GFR09lCjvUDjmBjIOPciu4Q9fnoSf+rplkXoAe4ta6XQFYkLC0qX2Nmru7aKJFCscDKX U698zZ9vfJp6nKkj+tXxztaU25hQ9skUb129Fv6zZrrYUiGinziiqw0iQd3ArypIWG3Q KZTzIzktSBEfHsQENJQ7KWxYLhZPLX8Ev4p/ypvaOTpQIWVuNHWQ/llqJjfMNHP6Rvww Z2gkA6mLYgNlj+8tHGjACdfegVW5dDowF07milBQM+4d1vovszn0pH4i1WpXvbDGEVzZ aFeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=/tyZRcAo+Mfvk8vb0ikdduA7YHF5Ym+jAlQ6gMWlfAA=; b=pmlSAhVPqfsVyKOtXqjMl/SDQJRY7B6U527WKS02EQg3IHfmHrzdeMsv7P+IJx2ZM9 aKUjr/4Sa+BpvE9yWS5AK+dvbYlbQfLR4NrbERPhMsLod//P+CAZmDm74w3XigBRxgmZ HlSgeEGpJ1fO5N6MNuxMFsZclBy0tzoa9jAUHH2gY5+Agc7NfzMHvGVnr/Jn+se3EDeu kQ73XZajMhCZfsxf6gUKJ74nOF5HQhYJZ0Fv5DwrLRq42b30dg7HWRMVAsKHLts5i6Nr jd8gnZbaM7ga4dFooKvkrszetu5wJS17IvY8WT6h9hVD1NgSHtl2fH2GyvACezBoptvF RigA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kWrFeu94; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id di21si10714312edb.524.2021.03.22.05.15.57; Mon, 22 Mar 2021 05:15:57 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kWrFeu94; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230372AbhCVMPe (ORCPT + 8 others); Mon, 22 Mar 2021 08:15:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:48856 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230319AbhCVMPB (ORCPT ); Mon, 22 Mar 2021 08:15:01 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 73A016196F; Mon, 22 Mar 2021 12:14:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616415300; bh=9XRfjBpAAKr1LuYTDPxAQk/Vc1HEIU4R46I0OKcvdyA=; h=From:To:Cc:Subject:Date:From; b=kWrFeu94yiks68xf9Su1xbk0lhpBE2tdzQhBZCjDfmibnTj7S8BNNPFioYPsgTJxX ZqG15QgONoDZCsHAq7x1CX4S2PsWZyEGHbFpaINZ0UqSaOLCmRkURQFIZPy0XxwWc7 zronma+/2bvp48sGebVqG7k8NdkQFqwVJWpFnmjWj04ResVi+Fx9dRhpGLnDdO32vh cbcP/xvg4vwGPBrG+k1zNRZIgE4ms1McyAGib5eGDzj1I3fIlG7p0XTmdWh27A9ISk Lw9kfTYpQlVcwZ/D2CiF7ivFhXIZ30/HMIrILQh5XEvUalbiq6XOd4AxnMNIENS1Fm tHR+u450YvznA== From: Arnd Bergmann To: netdev@vger.kernel.org, Karsten Keil Cc: Arnd Bergmann , Leon Romanovsky , linux-kernel@vger.kernel.org Subject: [PATCH net-next] [v2] misdn: avoid -Wempty-body warning Date: Mon, 22 Mar 2021 13:14:47 +0100 Message-Id: <20210322121453.653228-1-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Arnd Bergmann gcc warns about a pointless condition: drivers/isdn/hardware/mISDN/hfcmulti.c: In function 'hfcmulti_interrupt': drivers/isdn/hardware/mISDN/hfcmulti.c:2752:17: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body] 2752 | ; /* external IRQ */ As the check has no effect, just remove it. Suggested-by: Leon Romanovsky Signed-off-by: Arnd Bergmann --- v2: remove the line instead of adding {} --- drivers/isdn/hardware/mISDN/hfcmulti.c | 2 -- 1 file changed, 2 deletions(-) -- 2.29.2 Reviewed-by: Leon Romanovsky diff --git a/drivers/isdn/hardware/mISDN/hfcmulti.c b/drivers/isdn/hardware/mISDN/hfcmulti.c index 7013a3f08429..14092152b786 100644 --- a/drivers/isdn/hardware/mISDN/hfcmulti.c +++ b/drivers/isdn/hardware/mISDN/hfcmulti.c @@ -2748,8 +2748,6 @@ hfcmulti_interrupt(int intno, void *dev_id) if (hc->ctype != HFC_TYPE_E1) ph_state_irq(hc, r_irq_statech); } - if (status & V_EXT_IRQSTA) - ; /* external IRQ */ if (status & V_LOST_STA) { /* LOST IRQ */ HFC_outb(hc, R_INC_RES_FIFO, V_RES_LOST); /* clear irq! */