From patchwork Tue May 8 09:28:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marc Kleine-Budde X-Patchwork-Id: 135138 Delivered-To: patch@linaro.org Received: by 10.46.151.6 with SMTP id r6csp4155730lji; Tue, 8 May 2018 02:28:58 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrudSGLCHJ9S0rv/vx7s2isVCaw2XlzVifuGRAL8OCXYZueGyi1TZjEhoXAz5JmhqrC/N9c X-Received: by 2002:a63:6f82:: with SMTP id k124-v6mr31256948pgc.301.1525771738650; Tue, 08 May 2018 02:28:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525771738; cv=none; d=google.com; s=arc-20160816; b=wi+me+6Xv7hcsdMrjQWjsQNHCHPkBvl/DLEv7Cp51jGVH5ZwqLHjH6N1aLOM0V6TGo nY0uhlE3+GVeJJKeuOvse2OYw3qaWq7VtWR8PlwnryjRZJqcjtuH5RGlcPfB4aE+/D3Q 1SKZ7eeQ4yi6yD+p+l97a+OpYyqlJJvK1rVCudwJou3WTn//9c+3zmUJ+gZmsLybnAII luY/BiR0GCzkj3EkyrtxBYC2GliMu9QnFYFTYPIfqSENjLeZr29exaQZ88NfrUUebFvv UiQUq1csMbS17ZHyms38rwT9PfuctYzSETB/FaZma7TIINPjIFNVNNrDR7nBBxpKdqNv dx2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=h1PlK0SLthzc5o7yniq8E+ZryioDUYvm0KDkamfbg3g=; b=IkX19ZvJscMgVOi/vnNHPJbsvCwoIxlD8qZVzrBXIUb6iyaJRUxrpUwRWZstz9HSY/ j1MErhC4+4+j/IBrX7IS/OUp7gwYaXNtJN9QqHiqccblNOjEjavXI5BAFiYTScc7ciXa GMRxSe0Xhy93FumnO3NLUcizfkgyq0BaGT7AESc5ucTaWnAyDG5JdRJ5hBVkj7iLjP0p nHCfs7rqfvaY9hlc/LXKc+QqfcsR0rdbf2Ctt1QjT1k3EHxNfXeP2mO/rjzE5Uq28lTq Jc2QuV8g4N1j9gRdLBdKDUIa6cRJysNi7VDYKd5MdJvD053LD634k9L16U1BjP0QJUf/ hK0g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i61-v6si23027465plb.560.2018.05.08.02.28.58; Tue, 08 May 2018 02:28:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932232AbeEHJ2t (ORCPT + 29 others); Tue, 8 May 2018 05:28:49 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:49281 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932125AbeEHJ2n (ORCPT ); Tue, 8 May 2018 05:28:43 -0400 Received: from heimdall.vpn.pengutronix.de ([2001:67c:670:205:1d::14] helo=localhost.localdomain) by metis.ext.pengutronix.de with esmtp (Exim 4.89) (envelope-from ) id 1fFyvG-0006V7-5H; Tue, 08 May 2018 11:28:38 +0200 From: Marc Kleine-Budde To: netdev@vger.kernel.org Cc: davem@davemloft.net, linux-can@vger.kernel.org, kernel@pengutronix.de, Jakob Unterwurzacher , linux-kernel@vger.kernel.org, Marc Kleine-Budde Subject: [PATCH 1/7] can: dev: increase bus-off message severity Date: Tue, 8 May 2018 11:28:25 +0200 Message-Id: <20180508092831.28247-2-mkl@pengutronix.de> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180508092831.28247-1-mkl@pengutronix.de> References: <20180508092831.28247-1-mkl@pengutronix.de> X-SA-Exim-Connect-IP: 2001:67c:670:205:1d::14 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jakob Unterwurzacher bus-off is usually caused by hardware malfunction or configuration error (baud rate mismatch) and causes a complete loss of communication. Increase the "bus-off" message's severity from netdev_dbg() to netdev_info() to make it visible to the user. A can interface going into bus-off is similar in severity to ethernet's "Link is Down" message, which is also printed at info level. It is debatable whether the the "restarted" message should also be changed to netdev_info() to make the interface state changes comprehensible from the kernel log. I have chosen to keep the "restarted" message at dbg for now as the "bus-off" message should be enough for the user to notice and investigate the problem. Signed-off-by: Jakob Unterwurzacher Cc: linux-can@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Marc Kleine-Budde --- drivers/net/can/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.0 diff --git a/drivers/net/can/dev.c b/drivers/net/can/dev.c index b1779566c5bb..3c71f1cb205f 100644 --- a/drivers/net/can/dev.c +++ b/drivers/net/can/dev.c @@ -605,7 +605,7 @@ void can_bus_off(struct net_device *dev) { struct can_priv *priv = netdev_priv(dev); - netdev_dbg(dev, "bus-off\n"); + netdev_info(dev, "bus-off\n"); netif_carrier_off(dev);