From patchwork Wed Mar 17 09:31:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulf Hansson X-Patchwork-Id: 403110 Delivered-To: patches@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp305471jai; Wed, 17 Mar 2021 02:31:39 -0700 (PDT) X-Received: by 2002:ac2:41ce:: with SMTP id d14mr1771103lfi.451.1615973499120; Wed, 17 Mar 2021 02:31:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615973499; cv=none; d=google.com; s=arc-20160816; b=beEon2vmHr8znbUH/9k9l/OGhud9wekMoxFxN7pURRdRo+qTy2Kwr56m3jMujSxaiK ZSPU9EsnP1ZtZyi9gHzMjDlE0xRzppVk+8p8BOaFXQxs9NHmVMBug6JTb3ZQChy+DJGA Iez0msTTrih+5ADxnqumD3XybT0nswO5oHQg1MkxykTaBDB3b42m2jnvxbLeeR0epyKo C/hMPTFsx5QgG6++9bTwjVxi39XZIb6l0zBjdxbNfYOMJ+dxa6WdrX2R1L8SJthdM0rR VzfD2rUfOEiflpcfL7CrKQ5SqrHGNHsBSRTACDqXJGHc9ZUOqIFJCaxvylcg4G1EtDMx xW8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=j1JvQrYJAeTY2r8foioHnWU1JA8C4SZadDv1a3LsN+s=; b=DgUeAbCjp/p6dSrWq9fltbTU/MsB4kLuo9enB7dls6BSUv3H5S1K8jP2pUs3yLMcdb tMkG6yA8kpEVKKnV42aMP13H7NpC5jUV/H+OiAS9PGO83bPb+UmDrb6sHd2XN88J8+OT 5BXJFFJd7CuHXxtogYBvudFhyHCCd8XBdSqOR2tRUx2qxut0MJ6Y0tsROs6OHzmqTrNi JFGs6Tv8YNE8BL2JVwBMGvQWVfdbOVSnPSESP1laAjsCljnnbflyM1cdIBezeMGVdn3u WfVapZZSLuEmc2s8408qt9ubUpwdNVyy9o+J74fSZNPTLxiDXRBYLn/0FVtWSY1VQPoU 8BCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Dshl4/mL"; spf=pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.41 as permitted sender) smtp.mailfrom=ulf.hansson@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id t18sor8872343lja.38.2021.03.17.02.31.38 for (Google Transport Security); Wed, 17 Mar 2021 02:31:39 -0700 (PDT) Received-SPF: pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Dshl4/mL"; spf=pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.41 as permitted sender) smtp.mailfrom=ulf.hansson@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=j1JvQrYJAeTY2r8foioHnWU1JA8C4SZadDv1a3LsN+s=; b=Dshl4/mLY+2y8/eaHHS6lolq9b33VAfEGJy0pKnf7R52ed2jlnzPZ/tlMkPI6hsR2k imdlAfMONM6HW/2qZHOCPqFQcSRd2ij4NSrIYqCe7g9vaFz7bIqfO7SoYkz0hPgooduh 9ECFo7zKKRFwAGrvLLnnzdRDaOVy8ckKVbGGU5nG6nmVhDBpdfuYoREeBoDqlUQHn3gG pNw5l+LxEmZmGr4o/WO51IMmcR6N3E/EgyCt73T8ThcjsoaZpJpy4Yvp3Q0nl6a/LrHj sAIWX+GBIXFh+DPnfhWyj4DuUdnl5D8Cuq6gdFXcfsRfCATkdG1uu/F+7c9CZsbKJshv jvIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=j1JvQrYJAeTY2r8foioHnWU1JA8C4SZadDv1a3LsN+s=; b=M1/nBl3H7nmXZequ5vALy36cQ5yKyKFn0vn2yuHl9Rt2N9XtrRLnq6kXA4cTBJokQ5 J312EBCxj6Oy2fJqKfEfbzKrzL6UHvFpa+Tcffj39nxtPZuxH/SnEeiSYqZJbyQdIazd Gu+U49HEi/RwT+AgtB+5eN768ozq9I+b6mAtXBDrx9aeS3T9n5gx8iwLFyOJTvEuFJWy xKrhQm4VXH6qvAmWNXSCTSVOPFugUrrWgnMvBOUBc1X1GKBM9krwTECn/+TMIITFziqg +GckvnzsOf4VxnhmqggFc3Jji7BeWSOfmcv1gvBXP5e3tyJGPkf977otsZPhNxDcFqGq +pWw== X-Gm-Message-State: AOAM532djOB8+kKNBUT3A0hFu7QliCv6DKaPHKm7CC7qY/l2+QOL6Rvr rrKy0ooFYsL9Xod5QCyYVo8PRhpS X-Google-Smtp-Source: ABdhPJyNfuEMCSNz8/hVScTKZYXXn0qF+hw3di3P3T1w/Q0cuhs93WfGVDIH4QxfoZvt4zGMFnGyaQ== X-Received: by 2002:a2e:868e:: with SMTP id l14mr1853124lji.479.1615973498694; Wed, 17 Mar 2021 02:31:38 -0700 (PDT) Return-Path: Received: from localhost.localdomain (h-155-4-129-234.NA.cust.bahnhof.se. [155.4.129.234]) by smtp.gmail.com with ESMTPSA id j19sm3342054lfb.15.2021.03.17.02.31.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Mar 2021 02:31:37 -0700 (PDT) From: Ulf Hansson To: Shawn Guo , Dong Aisheng , Sascha Hauer Cc: Liu Ying , Peng Fan , NXP Linux Team , Ulf Hansson , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] firmware: imx: scu-pd: Update comments for single global power domain Date: Wed, 17 Mar 2021 10:31:17 +0100 Message-Id: <20210317093117.16091-1-ulf.hansson@linaro.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Since the introduction of the PM domain support for the scu-pd, the genpd framework has been continuously improved. More preciously, using a single global power domain can quite easily be deployed for imx platforms. To avoid confusions, let's therefore make an update to the comments about the missing pieces. Signed-off-by: Ulf Hansson --- drivers/firmware/imx/scu-pd.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) -- 2.25.1 diff --git a/drivers/firmware/imx/scu-pd.c b/drivers/firmware/imx/scu-pd.c index 08533ee67626..6e178a63442d 100644 --- a/drivers/firmware/imx/scu-pd.c +++ b/drivers/firmware/imx/scu-pd.c @@ -29,6 +29,10 @@ * The framework needs some proper extension to support multi power * domain cases. * + * Update: Genpd assigns the ->of_node for the virtual device before it + * invokes ->attach_dev() callback, hence parsing for device resources via + * DT should work fine. + * * 2. It also breaks most of current drivers as the driver probe sequence * behavior changed if removing ->power_on|off() callback and use * ->start() and ->stop() instead. genpd_dev_pm_attach will only power @@ -39,8 +43,11 @@ * domain enabled will trigger a HW access error. That means we need fix * most drivers probe sequence with proper runtime pm. * - * In summary, we need fix above two issue before being able to switch to - * the "single global power domain" way. + * Update: Runtime PM support isn't necessary. Instead, this can easily be + * fixed in drivers by adding a call to dev_pm_domain_start() during probe. + * + * In summary, the second part needs to be addressed via minor updates to the + * relevant drivers, before the "single global power domain" model can be used. * */