From patchwork Fri Mar 12 18:17:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Hancock X-Patchwork-Id: 398888 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC50DC4332E for ; Fri, 12 Mar 2021 18:18:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 89B8F64F4C for ; Fri, 12 Mar 2021 18:18:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232836AbhCLSR5 (ORCPT ); Fri, 12 Mar 2021 13:17:57 -0500 Received: from mx0d-0054df01.pphosted.com ([67.231.150.19]:5463 "EHLO mx0d-0054df01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232559AbhCLSRs (ORCPT ); Fri, 12 Mar 2021 13:17:48 -0500 Received: from pps.filterd (m0209000.ppops.net [127.0.0.1]) by mx0c-0054df01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 12CIEgPQ026793; Fri, 12 Mar 2021 13:17:41 -0500 Received: from can01-to1-obe.outbound.protection.outlook.com (mail-to1can01lp2051.outbound.protection.outlook.com [104.47.61.51]) by mx0c-0054df01.pphosted.com with ESMTP id 375yymhk0x-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 12 Mar 2021 13:17:41 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W5BO2WleM/xRkhsK3fwHurYSV1j0bLG4NDMwdC9VNcmyJUdU8b3z643hbFAuutCZGTy/eiQJt4vusgsGWmFHukxK/kMG1qKNcWmXvuxv3/4i5PIwWYoSljKFDC0FI7oKyz06TcH6CZ6IRmj+pxzvVoOtkoAZ6mo7DgOBoZO+2Rb+0jresNNTEQxZo04wEM6evTmLkuRPdMQRiBXBabk6Fv3mw2kO28dWtyohEgPbQySKu+WbU4PaC3TMQrpNhjDdHxWYkMF1aZ02lOd0dpMvG/5LYAITl3gmYocdjQFq8V/s12mhtw0IL/ykw+lehHJZ8Zg4Rtdv4k5Yie0X5MBd+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y7Zvi/oorIy4mTslUfQQatnXxwI40tGSvu8GL+ar32w=; b=ncKJCuhbiDAOa1fUUTNArdTi+sXE2wBR+HRMNSL/0lzfqnHNGK3v1CxQu7ABVUz3N01An6LRz+0U+TDNFsv7FxxTgGm1yfZD1nssTrQxjE1/plZlFsFGJF2IWgBWZCVDwVf9aoDuofQ31D+BTSjnkjB7RsicSBIX/EzRxQYUDCBWdUUFM7WBVNJ+fz7PAeEKbiGPgLq/YFzfWd9Q6ON5jx1ifIo+ax8gSoe+VnhChgLefwwOZTgLrFC/zvtJY3Ggx+T4mzysJ6/kw8FM9EZ8K2cLH+P1RnXusewXk4GeG27B5KdmBQ2m4vQLXfoow4LeUuvssanEuGLKlHbXzP4jjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=calian.com; dmarc=pass action=none header.from=calian.com; dkim=pass header.d=calian.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=calian.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y7Zvi/oorIy4mTslUfQQatnXxwI40tGSvu8GL+ar32w=; b=WYno4snHcFZdIReaIZJntDEWD8CFZxpOOWL+TpsVMdOaxeAUBvVA/JKGJlsd/enzr6ZCaxbFLkm6bHMe3c+AkhE6l0nwTs2R6wLPductXedcbflWTAQmX0l/yTH7pARc22o7KoYax4ZJjVXk2VK7acVSMrN8LIZnjVmBsTqevis= Authentication-Results: baylibre.com; dkim=none (message not signed) header.d=none; baylibre.com; dmarc=none action=none header.from=calian.com; Received: from YT1PR01MB3546.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:f::20) by YT1PR01MB4439.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:42::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.2; Fri, 12 Mar 2021 18:17:40 +0000 Received: from YT1PR01MB3546.CANPRD01.PROD.OUTLOOK.COM ([fe80::90d4:4d5b:b4c2:fdeb]) by YT1PR01MB3546.CANPRD01.PROD.OUTLOOK.COM ([fe80::90d4:4d5b:b4c2:fdeb%7]) with mapi id 15.20.3912.031; Fri, 12 Mar 2021 18:17:40 +0000 From: Robert Hancock To: mturquette@baylibre.com, sboyd@kernel.org Cc: mike.looijmans@topic.nl, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, Robert Hancock Subject: [PATCH v2 1/9] dt-bindings: clock: clk-si5341: Add new attributes Date: Fri, 12 Mar 2021 12:17:02 -0600 Message-Id: <20210312181710.3998978-2-robert.hancock@calian.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312181710.3998978-1-robert.hancock@calian.com> References: <20210312181710.3998978-1-robert.hancock@calian.com> X-Originating-IP: [204.83.154.189] X-ClientProxiedBy: MW3PR05CA0012.namprd05.prod.outlook.com (2603:10b6:303:2b::17) To YT1PR01MB3546.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:f::20) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (204.83.154.189) by MW3PR05CA0012.namprd05.prod.outlook.com (2603:10b6:303:2b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.10 via Frontend Transport; Fri, 12 Mar 2021 18:17:39 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 69d56df8-7620-4aa8-133a-08d8e5831f61 X-MS-TrafficTypeDiagnostic: YT1PR01MB4439: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KJSPWRW5wB2Xc8CD/8i7LWMyJdLfy5y7PxOXeUL30Jvi6WbpxZNljeff8kaXckXd3Ia0cnsqDtvrfaEkHtjg8et5FlfWbjzois5++jhVguvby6iB3YClecpfJyuCmIVg6DGMrftYg0tGjWJuWVJGSKH/uJ6l1kit3xPOYQUe5JHmfEm3SAO7aSshp6hGeJzKdRW86/GxfraR/qiAFwd2JIsRoj/1nmHgLSaGdqxNlDNA7bolr+kxBV0RiRf3TeNBYRR2laK0Q8RCGwJCPm5lKdOQCz3nSZr2D5O2j0uFaZUBiAZB023KXKhsJOnGMXvD+qXo03TAxJbZ8NIHLfpuY+X1toNpl67pMUMwc6bO4VfBUniBnGJ6h09kRu5vfDnxSmz9pp6E5tXEjAsp83IjnL2/WI3EH5i1YbZUlAp7jyTbTFnZ+j1ypuZklGilmNLfXi2+DSQCgtJ7U0kIpWauhRhprUF2J1698DckfHw58Av38pb4v9sfyXmdInquz8q98C6fmEYIJUOXYiXecGpBpu3dutNelQ+l18pD6QBSLnDUS2rHQiLG5RTnlgwqn0EIu5WiJKxqcLzO/awe+fYJpg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YT1PR01MB3546.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(4636009)(376002)(136003)(346002)(39850400004)(396003)(366004)(2616005)(8936002)(44832011)(8676002)(69590400012)(956004)(26005)(107886003)(16526019)(4326008)(36756003)(186003)(6486002)(2906002)(6666004)(83380400001)(86362001)(316002)(5660300002)(6506007)(478600001)(6512007)(66946007)(66556008)(66476007)(52116002)(1076003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: WZ+AzweR6QLau9+oB/UqxJqu11s04GOrYqo0Vm1cHX2qXvOHn8UnZaQ81weQmnAJXMztyKp1xHhKJLKzN4LzE9ac2uaCU6r+WBGx6Fwyv4730YybpeS4OHEamth4mzPKqEwoyRcD1ZyBwbRQYdcED+hDHY0oimjo1Jq+Nprr8RVyEI3v1sEuOy/UlvaQtoPO43+/G1KDyGegZSSIbC7u5Wv4yRyWM3NOds+4UscGWFSDQpUL+g2nyuC8p+AdiX3ZFl0owVzN0k+GY1OpGuLsu4K7lEXY+BueUbvKWTGVbtuwD2UY0wjfsPTgTymeS7MYFqjt8GQSxScfEl/fChf3JZY3Cz9CFJdTqxfG+x2iysMn+s0R6Fc/ZRRxbsRtePoaUZBK+h3tjACCMIk1I/Tsz5XPWPVDfz8r73LQvECbgXIx3Vck2jpa3K+uMH/SglGF7WSnleK7gXYGD+Zk2J3nxWd9LvryH0I1tssIEtkpQtc1+o2K5zsmd6fy2KoNsravGDQYgxe8t8UlfAQl+8OWTnWeEVxoYldS6LRHSs3F8zFBxVgT+N/n+sID00IhC+xdmGrYSz25KtSyY9jroj0ety5mz+Xjs/Y35bMbGmcVN48ENAiJGWq3+jQMKr/A/mY25LSQ4gYc+49S+pvFQ8lP8TbHJj88TCR3x8+RtXapePanOa5KlISafCuwMvvCKI0ADWJDSZp2HFUk0kDDqcp78ugayBetywu3NZ6IGWgVZzlnuru1Jc78sxxUJTfIbks51eSpCV2nz1DAbuSYDJ4rYhJZLwyt3rUfLo3yq6B3eUx5y6uMijPBy+vx33tuVGUft7+U06Y/hSQ2ufHqoqv27zXpHpdzJq2juxyxcmpM0DTBh3qXVG1H5VtLyZqGyBsan9GyAC82ooPAfvChAd3plux4+/J197Tece3WqhYRSXlyasqvMQI9vuHgQRxj6C+AWJt5Dz+EvoDfu3u1U7VUhn98/LmrZzbQbw668u5gwWgoUk936t6wzOqql9h+ejnFV/lhRzoOcl7K5ch7Y5NMd1Re81GNtIkNmKQM52g9EbBba3JIUZi83D2pCsqq26odvKnu5UOo2YEtr+p7J//vLXO8lmiNZZQJh3FUXxbR15gYhM+IIK930KMvOZ8DNVvHpSt7cbK2qsbJ8wVh5iUSwJOayqetPdrrOP9LxzEesvCDCn0BGTBBhOK9DwJo78pOMbeUUafPrFXihK/X+DDzMrHDBLMEjL3DYpPY5hV/8iIzgpURSqZ0gJusNsgHR7iKOkb+SxKkYg+c6Kg5RUYdP+KARxlfY9AiDTnHS8zSC3H8I64G/IW6+oFlA7h2+Ms2 X-OriginatorOrg: calian.com X-MS-Exchange-CrossTenant-Network-Message-Id: 69d56df8-7620-4aa8-133a-08d8e5831f61 X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB3546.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2021 18:17:40.4706 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 23b57807-562f-49ad-92c4-3bb0f07a1fdf X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2WBqK987jsg/6Gitmm3Jb2IsTaAOzbgHaeVJ8x/1HVwY7d/RkZ8/nt3Fxf/j27a0IW82Tk+g9DEpkTpzX2Ugs0GFIiqNYnhi2cdlKqBxRfA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT1PR01MB4439 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369, 18.0.761 definitions=2021-03-12_09:2021-03-12,2021-03-12 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 clxscore=1015 spamscore=0 suspectscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 mlxlogscore=999 impostorscore=0 malwarescore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103120134 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Add new silabs,xaxb-ext-clk and silabs,iovdd-33 properties. Changed vdd-supply on top-level node to optional since it is not actually used by the driver. Removed vdd-supply from output sub-nodes, as it was not supported by the driver and it is not easily possible to support this in that location with the kernel regulator infrastructure. Changed to have vddX-supply attributes for each output on the top-level device node. Signed-off-by: Robert Hancock --- .../devicetree/bindings/clock/silabs,si5341.txt | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/Documentation/devicetree/bindings/clock/silabs,si5341.txt b/Documentation/devicetree/bindings/clock/silabs,si5341.txt index 504cce3abe46..1cf7e002cb16 100644 --- a/Documentation/devicetree/bindings/clock/silabs,si5341.txt +++ b/Documentation/devicetree/bindings/clock/silabs,si5341.txt @@ -24,9 +24,8 @@ it. The device type, speed grade and revision are determined runtime by probing. -The driver currently only supports XTAL input mode, and does not support any -fancy input configurations. They can still be programmed into the chip and -the driver will leave them "as is". +The driver currently does not support any fancy input configurations. They can +still be programmed into the chip and the driver will leave them "as is". ==I2C device node== @@ -45,9 +44,9 @@ Required properties: corresponding to inputs. Use a fixed clock for the "xtal" input. At least one must be present. - clock-names: One of: "xtal", "in0", "in1", "in2" -- vdd-supply: Regulator node for VDD Optional properties: +- vdd-supply: Regulator node for VDD - vdda-supply: Regulator node for VDDA - vdds-supply: Regulator node for VDDS - silabs,pll-m-num, silabs,pll-m-den: Numerator and denominator for PLL @@ -60,7 +59,14 @@ Optional properties: be initialized, and always performs the soft-reset routine. Since this will temporarily stop all output clocks, don't do this if the chip is generating the CPU clock for example. +- silabs,xaxb-ext-clk: When present, indicates that the XA/XB pins are used + in EXTCLK (external reference clock) rather than XTAL (crystal) mode. - interrupts: Interrupt for INTRb pin. +- silabs,iovdd-33: When present, indicates that the I2C lines are using 3.3V + rather than 1.8V thresholds. +- vddX-supply (where X is an output index): Regulator node for VDD for the + specified output. The driver selects the output VDD_SEL setting based on this + voltage. - #address-cells: shall be set to 1. - #size-cells: shall be set to 0. @@ -77,8 +83,6 @@ Required child node properties: - reg: number of clock output. Optional child node properties: -- vdd-supply: Regulator node for VDD for this output. The driver selects default - values for common-mode and amplitude based on the voltage. - silabs,format: Output format, one of: 1 = differential (defaults to LVDS levels) 2 = low-power (defaults to HCSL levels) From patchwork Fri Mar 12 18:17:03 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Hancock X-Patchwork-Id: 398889 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EA38C433E9 for ; Fri, 12 Mar 2021 18:18:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6396364F45 for ; Fri, 12 Mar 2021 18:18:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232732AbhCLSR4 (ORCPT ); Fri, 12 Mar 2021 13:17:56 -0500 Received: from mx0c-0054df01.pphosted.com ([67.231.159.91]:45607 "EHLO mx0c-0054df01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232518AbhCLSRs (ORCPT ); Fri, 12 Mar 2021 13:17:48 -0500 Received: from pps.filterd (m0208999.ppops.net [127.0.0.1]) by mx0c-0054df01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 12CIBom2018929; Fri, 12 Mar 2021 13:17:43 -0500 Received: from can01-to1-obe.outbound.protection.outlook.com (mail-to1can01lp2057.outbound.protection.outlook.com [104.47.61.57]) by mx0c-0054df01.pphosted.com with ESMTP id 376besa3kc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 12 Mar 2021 13:17:42 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q6Kvd1a9at1hGKyBPp52gBkTGNx/RDWBVtRfvmj3iYACLGBrzhcO6uU1O5gKPF16JaIHb2xpQMjc3VgFh5pmQK7ObvStovM4zVhdJUqkwTTbc+aXoCMzSAgxPszFgJS8LbtBzEE/gu9VM2aFN34/nEFYJxgboQgmedRYExJRW5/oXfA7TF1I969d+JNa+Z5GxDUTWx5c4SKBNSJSgckWLOdSAfpuY+ERJO4nQwYV9gIzljMgW1EhtYi0LxxgWKnhKUY68KFU6MHdLsz+aB3+9WW4/oqFB2GM0FRGE+rtoUsCRXQSafgxPwgk1xdPF/gh/Egb8zZ661iscF8/amE92g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cEq4dvJRYs+77BkhYcPb2ofaxxtW6jdlmehqZboCYtk=; b=B6BbcTh/IIRT0A/9eyCK6PpvoMH6m4qu55DhgurZP/G3x9HEZVHSEIARSvPxUOSGTzGXt2m3VD5mvM3IE58DcwfhGy0oX7ATdfRGVXwur5+kf6DPXTQYRI7a8OIj4AKgYccDkR3wepZliE4+1cLAm7Be8uM4X7S5LrGTaWAZKXjnj50rbulqLvYA4wMvg82PPouz+ZwLLjbs10BMPLmrTpvSCOHFia6cKZQgERQ0b82+Ncv3BmJO6hbHypHfLM8loHO9yqIIbUrPqdTD96tFR0VO+4DfYo6L+dJq7S/ZEK7yl9yYu/MTbgqzEa2EsLTTVMiy+NAyt4l1NaItfzqBYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=calian.com; dmarc=pass action=none header.from=calian.com; dkim=pass header.d=calian.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=calian.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cEq4dvJRYs+77BkhYcPb2ofaxxtW6jdlmehqZboCYtk=; b=cZA2c4c+TtjPEE1e96vNAm4cw7fI1Z0j+l10dMCEDmpqeIUEpYqAYrx48izpdTjXCiEdtAmPSysOZG0gxMdnhaDs6usF7vvq+u/NHT1ZLNkKZZljsSXRk8PVdT7/r8XS5OVUIiKsVMSM1vFoWzya1b+e7eftVQCVfjnKNBHHmOQ= Authentication-Results: baylibre.com; dkim=none (message not signed) header.d=none; baylibre.com; dmarc=none action=none header.from=calian.com; Received: from YT1PR01MB3546.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:f::20) by YT1PR01MB4439.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:42::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.2; Fri, 12 Mar 2021 18:17:41 +0000 Received: from YT1PR01MB3546.CANPRD01.PROD.OUTLOOK.COM ([fe80::90d4:4d5b:b4c2:fdeb]) by YT1PR01MB3546.CANPRD01.PROD.OUTLOOK.COM ([fe80::90d4:4d5b:b4c2:fdeb%7]) with mapi id 15.20.3912.031; Fri, 12 Mar 2021 18:17:41 +0000 From: Robert Hancock To: mturquette@baylibre.com, sboyd@kernel.org Cc: mike.looijmans@topic.nl, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, Robert Hancock Subject: [PATCH v2 2/9] clk: si5341: Wait for DEVICE_READY on startup Date: Fri, 12 Mar 2021 12:17:03 -0600 Message-Id: <20210312181710.3998978-3-robert.hancock@calian.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312181710.3998978-1-robert.hancock@calian.com> References: <20210312181710.3998978-1-robert.hancock@calian.com> X-Originating-IP: [204.83.154.189] X-ClientProxiedBy: MW3PR05CA0012.namprd05.prod.outlook.com (2603:10b6:303:2b::17) To YT1PR01MB3546.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:f::20) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (204.83.154.189) by MW3PR05CA0012.namprd05.prod.outlook.com (2603:10b6:303:2b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.10 via Frontend Transport; Fri, 12 Mar 2021 18:17:40 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: eaf6ed84-09fe-49ab-77d7-08d8e583200e X-MS-TrafficTypeDiagnostic: YT1PR01MB4439: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: beQhd4+hPNomUAXTDiofHq1Ej7qt+VM+Wm50BNxr7iOtAyCzZEdaRyechgOovqnhHW0A1vRydEKbT9XADv45gn2Bq5pmwQ4FdC73i61iZgtbXOfqzZDrdTKqCYxRj5nRVHqQssRap21wxBgAWyrS90i18rdkYZEh1LB2YiBA7vGhBlMBhv84niSpIPRKuq9A/lzntFv4AbmgzYNL2VsSSdGBLJwy7odsr+PkVVGnJAryZfaWUtchahAbOclWneujjoGcYelkBjRE32KZHyphWq4Hj1mwyELF3G1l7ogIOP75t+LEv2jtG5A7HrdtNG7qTzceJW/jX1ohNBrQOBscFklrbGG6xPT2r8+0dXArOxEbOPmyauRysCY7n6DrXLETqe3o1OyQALgd+zGJRrawVmkh2Oz1ZeFI2DHR5fYituMafn+74Z5hOL9uaP41c4n6yIw4VAm8yuD6GUcFAmhwR4dPuxVGGnn2FJ5Y7MrlQtpow+UH/YJzIZ1fn7mVS7tTK73cd/y47uKmNGpNvcSIlY1JS/5f0QyxCO+X8a46GITytR8JxRQo9xtfYRCk324aTxmMTwLFiE+l7Ee6A5i47Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YT1PR01MB3546.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(4636009)(376002)(136003)(346002)(39850400004)(396003)(366004)(2616005)(8936002)(44832011)(8676002)(69590400012)(956004)(26005)(107886003)(16526019)(4326008)(36756003)(186003)(6486002)(2906002)(6666004)(83380400001)(86362001)(316002)(5660300002)(6506007)(478600001)(6512007)(66946007)(66556008)(66476007)(52116002)(1076003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: /Vwj9jFgPyw6ZeH0SNMvQGUEQeslH01FKVJ803Al9oLifbMx+0AINilg6ijahOFxXcGs3mVohlrK7zPaN7/GePDh9Ao5A1qw4gTMuPnytivekAoO+Kn0KCoisnbZd3111xOgIXdGobXyrwvVlACZOTt4HoNteoYsDXbsPyxWONLNdY9gCRsH2EJYw522KOlnxt5TVP32MD+3pnjk0ap3U/TfpYugvMpvfJLxxjOJtIVxpvx3uic5kKK72uI+2Ea5iCthwvKcqMZfOF8AZ3HKMQFPdEiFBWknB9AcNnrQzpN2rkZOYGrjGcLw/3re1Rkpfx5vpwdutQHeJRMBTTs6X8o/4gJ3X2UyM69Ji6J7cQDQY+IRpzM5g3pjhZ+AARNtrTGa0RTwnLuZl5CGmancpaqJRuEkvso7kr0jTplFxy2Z+N2c8+rOStL2z5naIQZYPvns5A7RACewocHG+ETuATQH1t3Mq9WxZi9pd0ctXF5VP1cr0s76tSVs2MhCzJT7rpx6o+L4NzCSF1On6h9uj7fVvUzeHBTqjHP+RroS3zrGFKJyDUXtGXyy97HRvtq0K/UI5gzAS6K1voMeFRRT3G/RyN6GVht2RLR5NfhWlZR4qhMud9PjFU7R3Yd/CJTK2C70xRDN+q9eCdC3iG3pma4q9qsXe/NMEyQcD10g7M/1JBLFCui8y1iX7/NaRkSLgvhS+KOKxWy0qLSWffq84U+7LbLOKsEGfIDrlRSJURX1DGHZo37OEJDWcxrD0oXXAnrwyc83InWFnays/8suuY0o5kv8Jm6cXT6QE8zDMd7mfAvAl2GY01NvnXpHVEk8jvl7s32pT1V5Tn0ntMdIiTHvt3iKrq22lbSPyUC7dBWlRA7vAHvJ487yhYpjyUeSrWBl6gEUwwz2NJvSZ1XxzVLR0xFjB79z2hwBiM1c713WpPM9IgeNtb6tK+HG5rD/b9inm0pUhosEFCX3EJmE+KDdMvziqXmVu1HA3n5IdZjDGksqrDELOhY+SB+iLvLcHd7aJSxbBVjctDnemUaB+bxHHb7xn2PtA8W4SceL5DnzoL5Rn1iXYfI6ZzlF0UEULMjHimgEkh9w3c/ILaNbvdjtpq3JJGixH+aQqNkCFtwe1OieuqdZxRWh52y5O6kDtgUXEF6ZzhQjeDMLcXmX4ih75UNqqU79BOnkICrTW8stFhY+WOvN0YX78r+x/wAK706nm6O+aNzOBKkB3TCyr11k/JcVNC+w9U3Vul8IcRSiKAdEJYMDpPq8FnlnsteKr+2qJsBLVWyBlTMVG9O8Iv3432rInC2lfvBIPMpQWq514U/cEiMOxz8UiSF5yJQI X-OriginatorOrg: calian.com X-MS-Exchange-CrossTenant-Network-Message-Id: eaf6ed84-09fe-49ab-77d7-08d8e583200e X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB3546.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2021 18:17:41.5589 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 23b57807-562f-49ad-92c4-3bb0f07a1fdf X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rZSRrKR2yCQYrBcb8ZBu6wrGEOUf9SrGG1f+shqGpZ7sP7uwbtZf+cbyM4soILwyLZQwrJZsd0LBKBDRb1d7BFrLdO8dNDGgwzEKeqkxx9U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT1PR01MB4439 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369, 18.0.761 definitions=2021-03-12_09:2021-03-12,2021-03-12 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 phishscore=0 priorityscore=1501 adultscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 mlxscore=0 suspectscore=0 clxscore=1015 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103120134 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The Si5341 datasheet warns that before accessing any other registers, including the PAGE register, we need to wait for the DEVICE_READY register to indicate the device is ready, or the process of the device loading its state from NVM can be corrupted. Wait for DEVICE_READY on startup before continuing initialization. This is done using a raw I2C register read prior to setting up regmap to avoid any potential unwanted automatic PAGE register accesses from regmap at this stage. Fixes: 3044a860fd ("clk: Add Si5341/Si5340 driver") Signed-off-by: Robert Hancock --- drivers/clk/clk-si5341.c | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/drivers/clk/clk-si5341.c b/drivers/clk/clk-si5341.c index e0446e66fa64..b8a960e927bc 100644 --- a/drivers/clk/clk-si5341.c +++ b/drivers/clk/clk-si5341.c @@ -94,6 +94,7 @@ struct clk_si5341_output_config { #define SI5341_STATUS 0x000C #define SI5341_SOFT_RST 0x001C #define SI5341_IN_SEL 0x0021 +#define SI5341_DEVICE_READY 0x00FE #define SI5341_XAXB_CFG 0x090E #define SI5341_IN_EN 0x0949 #define SI5341_INX_TO_PFD_EN 0x094A @@ -1189,6 +1190,32 @@ static const struct regmap_range_cfg si5341_regmap_ranges[] = { }, }; +static int si5341_wait_device_ready(struct i2c_client *client) +{ + int count; + + /* Datasheet warns: Any attempt to read or write any register other + * than DEVICE_READY before DEVICE_READY reads as 0x0F may corrupt the + * NVM programming and may corrupt the register contents, as they are + * read from NVM. Note that this includes accesses to the PAGE register. + * Also: DEVICE_READY is available on every register page, so no page + * change is needed to read it. + * Do this outside regmap to avoid automatic PAGE register access. + * May take up to 300ms to complete. + */ + for (count = 0; count < 15; ++count) { + s32 result = i2c_smbus_read_byte_data(client, + SI5341_DEVICE_READY); + if (result < 0) + return result; + if (result == 0x0F) + return 0; + msleep(20); + } + dev_err(&client->dev, "timeout waiting for DEVICE_READY\n"); + return -EIO; +} + static const struct regmap_config si5341_regmap_config = { .reg_bits = 8, .val_bits = 8, @@ -1385,6 +1412,11 @@ static int si5341_probe(struct i2c_client *client, data->i2c_client = client; + /* Must be done before otherwise touching hardware */ + err = si5341_wait_device_ready(client); + if (err) + return err; + for (i = 0; i < SI5341_NUM_INPUTS; ++i) { input = devm_clk_get(&client->dev, si5341_input_clock_names[i]); if (IS_ERR(input)) { From patchwork Fri Mar 12 18:17:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Hancock X-Patchwork-Id: 398887 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D151C432C3 for ; Fri, 12 Mar 2021 18:18:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 372B864F59 for ; Fri, 12 Mar 2021 18:18:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232943AbhCLSSA (ORCPT ); Fri, 12 Mar 2021 13:18:00 -0500 Received: from mx0c-0054df01.pphosted.com ([67.231.159.91]:46551 "EHLO mx0c-0054df01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232702AbhCLSRx (ORCPT ); Fri, 12 Mar 2021 13:17:53 -0500 Received: from pps.filterd (m0208999.ppops.net [127.0.0.1]) by mx0c-0054df01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 12CIBqjk018941; Fri, 12 Mar 2021 13:17:48 -0500 Received: from can01-qb1-obe.outbound.protection.outlook.com (mail-qb1can01lp2051.outbound.protection.outlook.com [104.47.60.51]) by mx0c-0054df01.pphosted.com with ESMTP id 376besa3kf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 12 Mar 2021 13:17:48 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G2UveiqgAOB10w+fgBl3xiWfTBg7Czl8MCww32Zib6YrgHeUaumbc/D/hSWJtEUKfc00NnGwCdzyqX/qbDaerNvhK2z5v3EOWgnNAfEDS9TAxj5KR/wjJpjq4j4Yd31xKUKENtd6uFGh2M8W+vgC9FJ24gWWduRRUJIbAASZXrVPQW2zFDi186HgpWCg/kJmj7MOr+6nAQPohTTPch/FZ0vKeslh/mUVIrZVsR2iMVlTCPWkgEve2QQ9Pe3M55GYvo6b3q7hme7rcz7tty/EHYEGr4/pWCEuMebsC/QEGm9hO9W56Qq9JIBK3DnZiRARU7uAWnexx+nWIhFleBT8nQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tdSwWEV4RbAI9uD10J0StMfnGHQ26PdsOansVSiTJvg=; b=BN3xzYqbZg4jzMIdLeeVhbHPwkmbvzCBJxrwXld/XhhC32z/WrMKGdU0ot2p01jciLEds1+TE+5wsOzFq8JXFfSBMuhFKoRoSweyHuwl92tKDoJvfHaZkILNkSlyqOijf3O0Gjwly7GeVTaQulsTPonbw2P81z6DCuGOXS4h7yQ4/YtZ2/GeZElytUIG8j9esW834SaDNRmjr8Ap88xeZxiS2BI4CPlhPm2pBZfNag/L/NYNkLBBi2tcy9Z7ZktmNXBud4Ge71C9nSSiEJ01aiygjXiZV2ItrXx53mhz22/8Si37RyIKM0mfqP3PGiOHa4fvCK36n73kJo04RTJ7WQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=calian.com; dmarc=pass action=none header.from=calian.com; dkim=pass header.d=calian.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=calian.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tdSwWEV4RbAI9uD10J0StMfnGHQ26PdsOansVSiTJvg=; b=MzX3XWhuPl5rRCMPqTMfeE6jJFsTNzhIxfzaJVD2n3LUBED4X37lbuUPL4VQ/CNzXwatyA6s2Mab+ldo4YqYupEw4RouqrWUKf7MiubRPjxKmoiGrMbJufIAX+9sU28DoGGSMOzcagihnUrdY1sUdX4Sq24cGdVPJoPHGKX6cyo= Authentication-Results: baylibre.com; dkim=none (message not signed) header.d=none; baylibre.com; dmarc=none action=none header.from=calian.com; Received: from YT1PR01MB3546.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:f::20) by YT1PR01MB4409.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:2b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.26; Fri, 12 Mar 2021 18:17:46 +0000 Received: from YT1PR01MB3546.CANPRD01.PROD.OUTLOOK.COM ([fe80::90d4:4d5b:b4c2:fdeb]) by YT1PR01MB3546.CANPRD01.PROD.OUTLOOK.COM ([fe80::90d4:4d5b:b4c2:fdeb%7]) with mapi id 15.20.3912.031; Fri, 12 Mar 2021 18:17:46 +0000 From: Robert Hancock To: mturquette@baylibre.com, sboyd@kernel.org Cc: mike.looijmans@topic.nl, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, Robert Hancock Subject: [PATCH v2 6/9] clk: si5341: Allow different output VDD_SEL values Date: Fri, 12 Mar 2021 12:17:07 -0600 Message-Id: <20210312181710.3998978-7-robert.hancock@calian.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312181710.3998978-1-robert.hancock@calian.com> References: <20210312181710.3998978-1-robert.hancock@calian.com> X-Originating-IP: [204.83.154.189] X-ClientProxiedBy: MW3PR05CA0012.namprd05.prod.outlook.com (2603:10b6:303:2b::17) To YT1PR01MB3546.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:f::20) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (204.83.154.189) by MW3PR05CA0012.namprd05.prod.outlook.com (2603:10b6:303:2b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.10 via Frontend Transport; Fri, 12 Mar 2021 18:17:45 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d33d205c-dd66-40b3-a0bf-08d8e58322d8 X-MS-TrafficTypeDiagnostic: YT1PR01MB4409: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:983; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: frQai8kG78j+9uUGdMxVQ/arV8W1584U3Zv42kHNMmQytIGhWNBsBhNvlS0U9Hr61fpRElazewVnVBsRz8zF62a92VJQFgEkNjiKtgcbbl5zA7Kvq12TH+LaHq3GAz7HGMmPbNtVnWmqHpbigEylHGoFdk9muSuHF+YLWD6vY1Z6DiOI6Nq4WOg669uIEfVG5bjTY/hA0U87wUE5JznkjhY/p+x1F5eKNaiORAdNtswUzx/5JPIAteZep0DAJFRwD2ZVZyk+8juPOixA6yDfVDP9hQsod7gn2vZvpoIsaSIFYk7rYYbx4MuKkhnRBS+jQiIeWkO12rY+4KxcsjnwqbvDWKcUnlPocK7p1oa0JzBgcTaAv+G9IUeX+dGnmY2MaPp0auFzfJZtykVZhGN4dOIOdLVLA94u4cU8aj78n1VpO310Rx/LqfClLdg/69HveDWD0YJJWkYPLdlDIIxotqysHrddLfqu5lOEnKv1HjPDJCh4z9Bw1WwJy3L2NZOonUBXjvSVqQEfy6giIIyW8TLaUokLGI8lxt9PdzlR8R3ZKs6IfJ5G6YprYwDyiMxKy31OhyWgKHEqrSSfZNE2EafiY39xQUJ6S2K2qT/XZjc= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YT1PR01MB3546.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(4636009)(136003)(39850400004)(346002)(396003)(376002)(366004)(69590400012)(186003)(44832011)(956004)(26005)(1076003)(16526019)(478600001)(52116002)(66476007)(6506007)(4326008)(83380400001)(66556008)(8936002)(316002)(2616005)(66946007)(5660300002)(8676002)(6666004)(86362001)(107886003)(6486002)(2906002)(36756003)(6512007)(461764006); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: yJ1KWYbI4HtrvID0p9Z3G+UwOKJSSarM8YlA9XyEMud9kBPFiYSNXISaxaBUUCcX+mOR+BVWlLzuVd4SCC2IouGKJLaiJQnf9BJfcthmRyYQ6XO2TKZxZy4++QvARmdCOnzqptrJ0e2B9OG+kXCZHNEOJSlB/VVXK6Ggonn9cb93aBq1mHPd0bzDjzbnu/o0uMhTMPmCdoquek5lHXukqcOUrhwS5wWT67wtQ10CoxBn33+x04vaPWE6fK7um+d7GL6ub4lA19MKk4lninkeG53cFm3t91jD2znGqp8J9l8ThTSaQwcdSHCgh9wQ5EOmKrWjBCi2q7oh1CuZ1di6eJyJbH2jEcguTtUPELzxmZO8HAo+9MVK2M6IutUvdawA6siC67xrNxN3+HlqmG+E8OCkwbJRKqxUAF+kAOmEHh5KAVqlmhfgKkMJhK/Af5bldFMwWPerEnP6y/CBv8KbZSt9OSI/D3dQmxI9KV0UTBobn+FAA0pYM0lLQ7SbhLfGII5g3Y/V+qgE2WxPNckkvGIP5Sr7jozDJVq/UyD2m03g5J1BdIf08ocE+hSwF6UUB4YE6GwYGRf5gvEkHM+zk8zSgB65M6k/Du/Q5uR22VGKix8hfKEkSGBqRxsoWUq7du+qLTWNcWVE98gptcwUxRCE6daTT9s3ZBc0DZaM7Vxo2VF2/78JO+xs0WXI1m+bgYGS5Jf1QJKyZU3tgwDLGpBpHiKc0SRigHDf+wZHdwLdWSgAFihqwv606UOA2zTzaHksazEDApIMcCHUNpzwFqXqFjfIABx0iaB3fzlvxeB/0qvfaiMplPY9VKHDSkoUY9a/d2HPMsL9Ugy1p/lYpaLJSRkOaOhMeeoitB6dPlhBRUwVvT9LVbVOvco15o5iobrq61FwMxsjaImnHo1iVoVOv2QpuFtRGl/ZnJTaXBm3WWm1tnwLgbyEHvFaQ0znBpglx1goq3EP2g1xFNAJnvrrOFbdL7Wj2Lg3+CuARXQ67LAMZ+HxsCPBKUSY1ZMXzaEleqoe39PxUhMmA0tkvjvplCY8TXP/J+F8lOzc/QaV/DAMAEE58G+a6Ei6M1L1gOgBRcwdH67ENvIjJzWa2hTr4ZGRmlhvZTu5GXEBxpZ5zcRO7fv8jCJxVIMn3HDXDjha9jKBTaJB3/U5DT+n4v3VM0wkG42CBkkYC03aYD6R3bipBuG50YWWsexbN40GkrR9I2bUqcpaRDSh1m/sxUiQ6wfuekQlXy05wV0vICZ59d573oOD/OqZukBNADfKYuEpakty3MbfQ2vCb42AwwN/LHpR1mWgWmgtayfi/yHNCvWyHc/Z3Vbk1kmIvpKp X-OriginatorOrg: calian.com X-MS-Exchange-CrossTenant-Network-Message-Id: d33d205c-dd66-40b3-a0bf-08d8e58322d8 X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB3546.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2021 18:17:46.2293 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 23b57807-562f-49ad-92c4-3bb0f07a1fdf X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bk/QmnE0LTEdsGZjWS5i2f8w5VKIheu1eZQdGo7mbBMtapfJIGvZ9SpzAiJpOE9J1cJ2RlJ3g2zaQpd6Ve1hQRwTh2zPvB3yG9rcUOzlz6E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT1PR01MB4409 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369, 18.0.761 definitions=2021-03-12_09:2021-03-12,2021-03-12 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 phishscore=0 priorityscore=1501 adultscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 mlxscore=0 suspectscore=0 clxscore=1015 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103120134 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The driver was not previously programming the VDD_SEL values for each output to indicate what external VDD voltage was used for each. Add ability to specify a regulator supplying the VDD pin for each output of the device. The voltage of the regulator is used to automatically set the VDD_SEL value appropriately. If no regulator is specified and the chip is being reconfigured, assume 2.5V which appears to be the chip default. Signed-off-by: Robert Hancock --- drivers/clk/clk-si5341.c | 136 +++++++++++++++++++++++++++++++-------- 1 file changed, 110 insertions(+), 26 deletions(-) diff --git a/drivers/clk/clk-si5341.c b/drivers/clk/clk-si5341.c index eb22f4fdbc6b..ed790a35eb83 100644 --- a/drivers/clk/clk-si5341.c +++ b/drivers/clk/clk-si5341.c @@ -19,6 +19,7 @@ #include #include #include +#include #include #include @@ -59,6 +60,7 @@ struct clk_si5341_synth { struct clk_si5341_output { struct clk_hw hw; struct clk_si5341 *data; + struct regulator *vdd_reg; u8 index; }; #define to_clk_si5341_output(_hw) \ @@ -84,6 +86,7 @@ struct clk_si5341 { struct clk_si5341_output_config { u8 out_format_drv_bits; u8 out_cm_ampl_bits; + u8 vdd_sel_bits; bool synth_master; bool always_on; }; @@ -136,6 +139,8 @@ struct clk_si5341_output_config { #define SI5341_OUT_R_REG(output) \ ((output)->data->reg_rdiv_offset[(output)->index]) +#define SI5341_OUT_MUX_VDD_SEL_MASK 0x38 + /* Synthesize N divider */ #define SI5341_SYNTH_N_NUM(x) (0x0302 + ((x) * 11)) #define SI5341_SYNTH_N_DEN(x) (0x0308 + ((x) * 11)) @@ -1248,11 +1253,11 @@ static const struct regmap_config si5341_regmap_config = { .volatile_table = &si5341_regmap_volatile, }; -static int si5341_dt_parse_dt(struct i2c_client *client, - struct clk_si5341_output_config *config) +static int si5341_dt_parse_dt(struct clk_si5341 *data, + struct clk_si5341_output_config *config) { struct device_node *child; - struct device_node *np = client->dev.of_node; + struct device_node *np = data->i2c_client->dev.of_node; u32 num; u32 val; @@ -1261,13 +1266,13 @@ static int si5341_dt_parse_dt(struct i2c_client *client, for_each_child_of_node(np, child) { if (of_property_read_u32(child, "reg", &num)) { - dev_err(&client->dev, "missing reg property of %s\n", + dev_err(&data->i2c_client->dev, "missing reg property of %s\n", child->name); goto put_child; } if (num >= SI5341_MAX_NUM_OUTPUTS) { - dev_err(&client->dev, "invalid clkout %d\n", num); + dev_err(&data->i2c_client->dev, "invalid clkout %d\n", num); goto put_child; } @@ -1286,7 +1291,7 @@ static int si5341_dt_parse_dt(struct i2c_client *client, config[num].out_format_drv_bits |= 0xc0; break; default: - dev_err(&client->dev, + dev_err(&data->i2c_client->dev, "invalid silabs,format %u for %u\n", val, num); goto put_child; @@ -1299,7 +1304,7 @@ static int si5341_dt_parse_dt(struct i2c_client *client, if (!of_property_read_u32(child, "silabs,common-mode", &val)) { if (val > 0xf) { - dev_err(&client->dev, + dev_err(&data->i2c_client->dev, "invalid silabs,common-mode %u\n", val); goto put_child; @@ -1310,7 +1315,7 @@ static int si5341_dt_parse_dt(struct i2c_client *client, if (!of_property_read_u32(child, "silabs,amplitude", &val)) { if (val > 0xf) { - dev_err(&client->dev, + dev_err(&data->i2c_client->dev, "invalid silabs,amplitude %u\n", val); goto put_child; @@ -1327,6 +1332,34 @@ static int si5341_dt_parse_dt(struct i2c_client *client, config[num].always_on = of_property_read_bool(child, "always-on"); + + config[num].vdd_sel_bits = 0x08; + if (data->clk[num].vdd_reg) { + int vdd = regulator_get_voltage(data->clk[num].vdd_reg); + + switch (vdd) { + case 3300000: + config[num].vdd_sel_bits |= 0 << 4; + break; + case 1800000: + config[num].vdd_sel_bits |= 1 << 4; + break; + case 2500000: + config[num].vdd_sel_bits |= 2 << 4; + break; + default: + dev_err(&data->i2c_client->dev, + "unsupported vdd voltage %d for %s\n", + vdd, child->name); + goto put_child; + } + } else { + /* chip seems to default to 2.5V when not set */ + dev_warn(&data->i2c_client->dev, + "no regulator set, defaulting vdd_sel to 2.5V for %s\n", + child->name); + config[num].vdd_sel_bits |= 2 << 4; + } } return 0; @@ -1452,9 +1485,33 @@ static int si5341_probe(struct i2c_client *client, } } - err = si5341_dt_parse_dt(client, config); + for (i = 0; i < SI5341_MAX_NUM_OUTPUTS; ++i) { + char reg_name[10]; + + snprintf(reg_name, sizeof(reg_name), "vdd%d", i); + data->clk[i].vdd_reg = devm_regulator_get_optional( + &client->dev, reg_name); + if (IS_ERR(data->clk[i].vdd_reg)) { + err = PTR_ERR(data->clk[i].vdd_reg); + data->clk[i].vdd_reg = NULL; + if (err == -ENODEV) + continue; + goto cleanup; + } else { + err = regulator_enable(data->clk[i].vdd_reg); + if (err) { + dev_err(&client->dev, + "failed to enable %s regulator: %d\n", + reg_name, err); + data->clk[i].vdd_reg = NULL; + goto cleanup; + } + } + } + + err = si5341_dt_parse_dt(data, config); if (err) - return err; + goto cleanup; if (of_property_read_string(client->dev.of_node, "clock-output-names", &init.name)) @@ -1462,21 +1519,23 @@ static int si5341_probe(struct i2c_client *client, root_clock_name = init.name; data->regmap = devm_regmap_init_i2c(client, &si5341_regmap_config); - if (IS_ERR(data->regmap)) - return PTR_ERR(data->regmap); + if (IS_ERR(data->regmap)) { + err = PTR_ERR(data->regmap); + goto cleanup; + } i2c_set_clientdata(client, data); err = si5341_probe_chip_id(data); if (err < 0) - return err; + goto cleanup; if (of_property_read_bool(client->dev.of_node, "silabs,reprogram")) { initialization_required = true; } else { err = si5341_is_programmed_already(data); if (err < 0) - return err; + goto cleanup; initialization_required = !err; } @@ -1485,11 +1544,11 @@ static int si5341_probe(struct i2c_client *client, /* Populate the regmap cache in preparation for "cache only" */ err = si5341_read_settings(data); if (err < 0) - return err; + goto cleanup; err = si5341_send_preamble(data); if (err < 0) - return err; + goto cleanup; /* * We intend to send all 'final' register values in a single @@ -1502,19 +1561,19 @@ static int si5341_probe(struct i2c_client *client, err = si5341_write_multiple(data, si5341_reg_defaults, ARRAY_SIZE(si5341_reg_defaults)); if (err < 0) - return err; + goto cleanup; } /* Input must be up and running at this point */ err = si5341_clk_select_active_input(data); if (err < 0) - return err; + goto cleanup; if (initialization_required) { /* PLL configuration is required */ err = si5341_initialize_pll(data); if (err < 0) - return err; + goto cleanup; } /* Register the PLL */ @@ -1527,7 +1586,7 @@ static int si5341_probe(struct i2c_client *client, err = devm_clk_hw_register(&client->dev, &data->hw); if (err) { dev_err(&client->dev, "clock registration failed\n"); - return err; + goto cleanup; } init.num_parents = 1; @@ -1564,13 +1623,17 @@ static int si5341_probe(struct i2c_client *client, regmap_write(data->regmap, SI5341_OUT_CM(&data->clk[i]), config[i].out_cm_ampl_bits); + regmap_update_bits(data->regmap, + SI5341_OUT_MUX_SEL(&data->clk[i]), + SI5341_OUT_MUX_VDD_SEL_MASK, + config[i].vdd_sel_bits); } err = devm_clk_hw_register(&client->dev, &data->clk[i].hw); kfree(init.name); /* clock framework made a copy of the name */ if (err) { dev_err(&client->dev, "output %u registration failed\n", i); - return err; + goto cleanup; } if (config[i].always_on) clk_prepare(data->clk[i].hw.clk); @@ -1580,7 +1643,7 @@ static int si5341_probe(struct i2c_client *client, data); if (err) { dev_err(&client->dev, "unable to add clk provider\n"); - return err; + goto cleanup; } if (initialization_required) { @@ -1588,11 +1651,11 @@ static int si5341_probe(struct i2c_client *client, regcache_cache_only(data->regmap, false); err = regcache_sync(data->regmap); if (err < 0) - return err; + goto cleanup; err = si5341_finalize_defaults(data); if (err < 0) - return err; + goto cleanup; } /* wait for device to report input clock present and PLL lock */ @@ -1601,14 +1664,14 @@ static int si5341_probe(struct i2c_client *client, 10000, 250000); if (err) { dev_err(&client->dev, "Error waiting for input clock or PLL lock\n"); - return err; + goto cleanup; } /* clear sticky alarm bits from initialization */ err = regmap_write(data->regmap, SI5341_STATUS_STICKY, 0); if (err) { dev_err(&client->dev, "unable to clear sticky status\n"); - return err; + goto cleanup; } /* Free the names, clk framework makes copies */ @@ -1616,6 +1679,26 @@ static int si5341_probe(struct i2c_client *client, devm_kfree(&client->dev, (void *)synth_clock_names[i]); return 0; + +cleanup: + for (i = 0; i < SI5341_MAX_NUM_OUTPUTS; ++i) { + if (data->clk[i].vdd_reg) + regulator_disable(data->clk[i].vdd_reg); + } + return err; +} + +static int si5341_remove(struct i2c_client *client) +{ + struct clk_si5341 *data = i2c_get_clientdata(client); + int i; + + for (i = 0; i < SI5341_MAX_NUM_OUTPUTS; ++i) { + if (data->clk[i].vdd_reg) + regulator_disable(data->clk[i].vdd_reg); + } + + return 0; } static const struct i2c_device_id si5341_id[] = { @@ -1644,6 +1727,7 @@ static struct i2c_driver si5341_driver = { .of_match_table = clk_si5341_of_match, }, .probe = si5341_probe, + .remove = si5341_remove, .id_table = si5341_id, }; module_i2c_driver(si5341_driver); From patchwork Fri Mar 12 18:17:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Hancock X-Patchwork-Id: 398886 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB585C4361B for ; Fri, 12 Mar 2021 18:18:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C4E5664F4C for ; Fri, 12 Mar 2021 18:18:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232949AbhCLSSA (ORCPT ); Fri, 12 Mar 2021 13:18:00 -0500 Received: from mx0c-0054df01.pphosted.com ([67.231.159.91]:53287 "EHLO mx0c-0054df01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231597AbhCLSRx (ORCPT ); Fri, 12 Mar 2021 13:17:53 -0500 Received: from pps.filterd (m0208999.ppops.net [127.0.0.1]) by mx0c-0054df01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 12CIBqjl018941; Fri, 12 Mar 2021 13:17:49 -0500 Received: from can01-qb1-obe.outbound.protection.outlook.com (mail-qb1can01lp2051.outbound.protection.outlook.com [104.47.60.51]) by mx0c-0054df01.pphosted.com with ESMTP id 376besa3kf-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 12 Mar 2021 13:17:48 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d66n3118fFXk3ejx1vcc3Y3pI3ymgWeeUZe3YgcKF3MIYOXeEWbfaBv+CBZNqCheYkyL4R40lkw1VCh7ejTDzFBV3rALFAjPzXJGx9/w892Ja5rgycz9JUVyH2FKIRrJXfpKFNz+0IOJWtTvCzTjGE6kSYToypCDKr/QwseUu41ehxGhB2VXMZBQ/Q0PnwoXhXT4V0jtrHKdlzSJDM/M6TpU4fJvgH9mi0fbukYSbG+HayKjLKprOPybQ4sKBM4qDrx7PuVfiCPrkpE2SnaO5oD2W3R+SE0Q55JeZfLPpviqlm6nIk76O7DERL6pDsyhPJCvlNgvcDrjwAYWoEiSWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s2OOLOgeQysfWi6kASonlVH+BiodlOoPpmUZSDaRqjk=; b=ECBUM9llcwsRbYTSIdU0cgTLK9954Wmw4+00LLeCCg97rvtvXe993DG9FutQtMrF+tQpV4P/0axWcCJSgE3soHnLyw3GzP+iPVT9F/Zk1W/5g4orS5QUiqjw7EUQv7mU2ti7bLe0tA+fGi3VCU3Jr67tdsF4uZAhyCIDMTaOB5MyE2GjImLwcE2P8crusq8MDAk6kDANrygd5C5bvMJHL2s0KaXOhOyG3vTZGliRqjz/g+T2Lk5SSOI5ZdBwgAC4L8QaZC8fBhVQDUT8cxD0+UODma4KsciTat8quLIPNfUZyNILvvQOs00bzFYXO50bTvr1A3vz0hMhK0YJUox/5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=calian.com; dmarc=pass action=none header.from=calian.com; dkim=pass header.d=calian.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=calian.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s2OOLOgeQysfWi6kASonlVH+BiodlOoPpmUZSDaRqjk=; b=cfuuBmconxmQh80PVOEJpE4RhA7DjCO54xVEPheHHUkAaD8ZMW8gcv1Z2E09RqBnAG03cRf0sYxk3NelR4I3xzHyUynybT8/Mz6rdaY18NfvPxYUCzBz38WyF+eNLTGfnN0xY8AoU6f+Izp4Ov2QU/MtjUfoMf0EiDfs3XGavkQ= Authentication-Results: baylibre.com; dkim=none (message not signed) header.d=none; baylibre.com; dmarc=none action=none header.from=calian.com; Received: from YT1PR01MB3546.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:f::20) by YT1PR01MB4409.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:2b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.26; Fri, 12 Mar 2021 18:17:47 +0000 Received: from YT1PR01MB3546.CANPRD01.PROD.OUTLOOK.COM ([fe80::90d4:4d5b:b4c2:fdeb]) by YT1PR01MB3546.CANPRD01.PROD.OUTLOOK.COM ([fe80::90d4:4d5b:b4c2:fdeb%7]) with mapi id 15.20.3912.031; Fri, 12 Mar 2021 18:17:47 +0000 From: Robert Hancock To: mturquette@baylibre.com, sboyd@kernel.org Cc: mike.looijmans@topic.nl, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, Robert Hancock Subject: [PATCH v2 7/9] clk: si5341: Add silabs,xaxb-ext-clk property Date: Fri, 12 Mar 2021 12:17:08 -0600 Message-Id: <20210312181710.3998978-8-robert.hancock@calian.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312181710.3998978-1-robert.hancock@calian.com> References: <20210312181710.3998978-1-robert.hancock@calian.com> X-Originating-IP: [204.83.154.189] X-ClientProxiedBy: MW3PR05CA0012.namprd05.prod.outlook.com (2603:10b6:303:2b::17) To YT1PR01MB3546.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:f::20) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (204.83.154.189) by MW3PR05CA0012.namprd05.prod.outlook.com (2603:10b6:303:2b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.10 via Frontend Transport; Fri, 12 Mar 2021 18:17:47 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d404ee14-f3d4-4a0a-10f3-08d8e58323d8 X-MS-TrafficTypeDiagnostic: YT1PR01MB4409: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IUVYbjjPICZGjc7BxoePzf+ZU7iG7CYL2AoRr1AOUEAlNKPlEMm9Uei5d0EKFRtoWxHCO3VPkxIkXyRQRTdCERpJOI/m/d1knxxABUUvF+OKPTM3BTrDvdK1BuBywVX/W2fHce8KYUJWYJUFR/7fJhdqSUcgr8CtQuIkZxwHIvpyzJ0EqB5mDeCETTx6reolxLY/nPCJgmjlYi5ITXoFiFbVuGsycxLxXsajcLNstYSQXPHLJxtLO5dvWL4xUNPeCgPTMw1aR/G77QW2Ak6EFoaTm3EKYOQ4/LrJ7Z/idpnQ3UMBhBLx0ywPTtsP86CoyjzQBQG53NgyxlWlwb6BuPhmBlOmvamRHyKdmYe6QD04X6gLS84Ypy7g2F7DFq6LoiARCh3xIEKxshAzAuHaH6pFu6sTEJ1ZgUI/7V67W9rzJPcNGomc4Nuj6lstOGp9WjfP9J5nNe0Eizx3JTL81bbi/BQYL9Gh1mNiOP0o0F8BhVS/BBqoeC6yyWXOUQQbTpz6JMC5beXCgSlICiIwO8zWgIp1eQqgG9NP7U8dkp4oruyf/zr8DSpbds13gq9muEAe2uqyNwDetTHKvvrPKw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YT1PR01MB3546.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(4636009)(136003)(39850400004)(346002)(396003)(376002)(366004)(69590400012)(186003)(44832011)(956004)(26005)(1076003)(16526019)(478600001)(52116002)(66476007)(6506007)(4326008)(83380400001)(66556008)(8936002)(316002)(2616005)(66946007)(5660300002)(8676002)(6666004)(86362001)(107886003)(6486002)(2906002)(36756003)(6512007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 4oN6eSqzc6zFRCT+mtkKNvYo5hh3x5MTlZ5S3ZaWJyNJ9TCuFT9Wlc7mbMpmtDQ1PAI/W3ZH12QsT2CrGZdVdqSmG2St0dVlDSdA0Eiy7CZu9DMxCo0ZDI7f29PtTdeBefkZQum+Z/kdD1ggkMlqTZejHTtcLb2FTFREcadB1HSi5MUjkf6D3ERb4/eyZ15OzJPgcY8HEC4+F/wsNmtozyf2h6VQgOkVMReYMClt9hXZgsxkpsiJErjnVeTxqp+qQVt+pFSRIMHf8kJJODuTXjDMnys+jou3OyslHibKjnnrawLVxcXEfwa5XWIz/GSAMELwlk55qx2J5oAlS1qVRjIt/2JCiJFLKaeu/HA8+2wrlLU2T5/K8SqjDXuQGEHUOsJ4ET/mRFpGAOlrT4S86WhNgXB1pzsTD8JEgVHyf85ZfRkiXI3VuqOtEg9GLJ1IN+0ZHpz2RtEzTG/DrUw4R12pOtY+5Nsuv5TekwdA4Xv9U7YzygmktP6jR1oUqlqFF1Ou2KiHbBdox16tTIwzKQth5g6DpNKR0K5Raof/joFOanBEOsMT5xqVYZLBuYBIQDQOBLN99X+MQXnlvN17HztDt2ZmydN1Yxnt4k/BZ+cZOi5+hN4S1594cyPzU3CAgMaUaE1+n7LfY0pcLV1kYf0/g7BdpMYHO/QJleJkVuYgwV8oq7skMAyhtUs/VlyZBVu1PeWbBO6/mx8rABj5DXp/Rul+a23GLkkpVPWRTeUrRpfL8d4K1F/v9sPMThMQC3iXmcuvxd1CuzgTRZ+cHw1SelLZ4FioXul59fLVZwYAho+I90V06JJQ+Ol9jlJNyyuUMgzE1dkm1Jxm5h340E5XtgAhPeJ1VhyuOtQdvimyRcCzl3Vd4ni7qhIdSByJnBDPZEoExh1kpLRuRR1kI4FAYUTUeox0n5Q8qqjiF1XMtgnW338TcsGF/rqzz8/d//p5L3Kof/Jss7qqFevFaspAcYJhe1uMTm7AZVpgBCYV5Psv42vzG7ceKruJF6W68JofezSnuN3cntqJjA5AXjsO93V14Fb67yCWq5npRNF6gqQUAWZJeg2ATxebAh6/yc0bJkLm0nWo6zLN7xyo5aTvUUqZGB8LqNoB5Dq0yqruK4QldCJHE7cs8p7SYEAuBy9oAr10nvgizAXKWeUkFlGpzR8a8ygLw8os9jQ/SFocBffmCVjqPslZpfa0bbHYsLRoQTdOLdJ3Nml6gF47dBdQ5FT1Z7smc0UbB1xKLBSlYyMmHSqLTrZdR+4inO4+syKT5FlsFwQG66Jg97kgT7ApTr4wSVjm9B3UTofQJNgRzvs2hm+yVmVvLKnJqjcj X-OriginatorOrg: calian.com X-MS-Exchange-CrossTenant-Network-Message-Id: d404ee14-f3d4-4a0a-10f3-08d8e58323d8 X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB3546.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2021 18:17:47.9183 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 23b57807-562f-49ad-92c4-3bb0f07a1fdf X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: u2xWBgsE+rrWCEFP2rOM6ATSxnXRqnS/kdHQ3TkFevJD9frhj7SLfCQ0ppUah1vgcuwvYVfBWfqUfNkRPgXB9kax+lSCgiewyQoHiEpYIPk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT1PR01MB4409 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369, 18.0.761 definitions=2021-03-12_09:2021-03-12,2021-03-12 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 phishscore=0 priorityscore=1501 adultscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 mlxscore=0 suspectscore=0 clxscore=1015 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103120134 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Add a property to allow specifying that the device XA/XB pins are used for an external clock input rather than for a clock crystal. Signed-off-by: Robert Hancock --- drivers/clk/clk-si5341.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/clk/clk-si5341.c b/drivers/clk/clk-si5341.c index ed790a35eb83..689f8c2b0b57 100644 --- a/drivers/clk/clk-si5341.c +++ b/drivers/clk/clk-si5341.c @@ -80,6 +80,7 @@ struct clk_si5341 { u8 num_outputs; u8 num_synth; u16 chip_id; + bool xaxb_ext_clk; }; #define to_clk_si5341(_hw) container_of(_hw, struct clk_si5341, hw) @@ -529,9 +530,11 @@ static int si5341_clk_reparent(struct clk_si5341 *data, u8 index) if (err < 0) return err; - /* Power up XTAL oscillator and buffer */ + /* Power up XTAL oscillator and buffer, select clock mode */ err = regmap_update_bits(data->regmap, SI5341_XAXB_CFG, - SI5341_XAXB_CFG_PDNB, SI5341_XAXB_CFG_PDNB); + SI5341_XAXB_CFG_PDNB | SI5341_XAXB_CFG_EXTCLK_EN, + SI5341_XAXB_CFG_PDNB | (data->xaxb_ext_clk ? + SI5341_XAXB_CFG_EXTCLK_EN : 0)); if (err < 0) return err; } @@ -1539,6 +1542,8 @@ static int si5341_probe(struct i2c_client *client, initialization_required = !err; } + data->xaxb_ext_clk = of_property_read_bool(client->dev.of_node, + "silabs,xaxb-ext-clk"); if (initialization_required) { /* Populate the regmap cache in preparation for "cache only" */ From patchwork Fri Mar 12 18:17:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Hancock X-Patchwork-Id: 398885 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C9B8C433E6 for ; Fri, 12 Mar 2021 18:18:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 705AA64F58 for ; Fri, 12 Mar 2021 18:18:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232951AbhCLSS2 (ORCPT ); Fri, 12 Mar 2021 13:18:28 -0500 Received: from mx0c-0054df01.pphosted.com ([67.231.159.91]:47104 "EHLO mx0c-0054df01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232740AbhCLSR5 (ORCPT ); Fri, 12 Mar 2021 13:17:57 -0500 Received: from pps.filterd (m0208999.ppops.net [127.0.0.1]) by mx0c-0054df01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 12CIBq94018951; Fri, 12 Mar 2021 13:17:50 -0500 Received: from can01-qb1-obe.outbound.protection.outlook.com (mail-qb1can01lp2058.outbound.protection.outlook.com [104.47.60.58]) by mx0c-0054df01.pphosted.com with ESMTP id 376besa3kh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 12 Mar 2021 13:17:50 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n/StQG6VCp3cmumLDbQbcC36dk92Qhu5B20vEsIGHETtnXe5pIiVAWuFma8J3xrRbxBCy8FNzI7QfJ++uIZDDOJ9++Ad60trAlcW6H6s1cIPsnSmbtEXpjLTn5kdI16RU/u2JH4IaU+YdZGsOlVOVkeK1g5KSKx5zbvndje9TGr5op6/bpWrmrdgb+X1WzCn4iP/+o5I2rj+NGkBYXULFQTlIjYIBE2g/bEC6CCeftygu5VXnJjBgAqJX+tD+CGxWdiIlVGUP0lOZ4pcimxFOBR9LJwe6VFaYOLoT9iIKzr5WmN8Tex10zfej4AIh/hCbeOpoTObbI98EWIgfz9U4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vhg+ydb2PbzLdBSyChmEHLHg2jAFYYhntmJ8CNVXyN4=; b=kou/V5vCnAD48R4D7dO5ZxOfYBphPZQCroB0r0NwG3Fofeoo1xzNlPz6DFsftX10XupQ3wEpAczDpgya8xivgE9cGbe8X1XCMjzeuC91BL6fCYFItbkzi13v/Yiwp3GiF3+n5hcKQsCYWCXR0kgImG5jHsZa92hvKua+RTrjGbFQCVH9LZKX3KzXUZbNXw28ifGMv1kbYXWP5hBcjchJdLDt/PJGxjMhKOuIjyANmDojlPo28hpVB8VQfVErefBvuPUBzTeN0Q6PCr55soRrFJvg/TEehAtNVRSLELnNQZoJqrLZz0Mt7TvvpxgTMc2mJqJHUj+1qN9i7aVq+KP+ug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=calian.com; dmarc=pass action=none header.from=calian.com; dkim=pass header.d=calian.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=calian.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vhg+ydb2PbzLdBSyChmEHLHg2jAFYYhntmJ8CNVXyN4=; b=2l16hacmPJOzkm6M55EW/5Zkv5z29wQmjslFVzloPGYsb1siy2JLRy91bsQ+3dMApvG+zSByjfFdG1Tup7w1uvcETRofjVTpkyD6aqzxlWK1RaTl/qvwBDQ7HzCsB2hvLUz/dqmxGC3QUXskk3GqotsBMzRgIlYKbJZm4esnpX8= Authentication-Results: baylibre.com; dkim=none (message not signed) header.d=none; baylibre.com; dmarc=none action=none header.from=calian.com; Received: from YT1PR01MB3546.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:f::20) by YT1PR01MB4409.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:2b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.26; Fri, 12 Mar 2021 18:17:49 +0000 Received: from YT1PR01MB3546.CANPRD01.PROD.OUTLOOK.COM ([fe80::90d4:4d5b:b4c2:fdeb]) by YT1PR01MB3546.CANPRD01.PROD.OUTLOOK.COM ([fe80::90d4:4d5b:b4c2:fdeb%7]) with mapi id 15.20.3912.031; Fri, 12 Mar 2021 18:17:49 +0000 From: Robert Hancock To: mturquette@baylibre.com, sboyd@kernel.org Cc: mike.looijmans@topic.nl, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, Robert Hancock Subject: [PATCH v2 8/9] clk: si5341: Add silabs,iovdd-33 property Date: Fri, 12 Mar 2021 12:17:09 -0600 Message-Id: <20210312181710.3998978-9-robert.hancock@calian.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312181710.3998978-1-robert.hancock@calian.com> References: <20210312181710.3998978-1-robert.hancock@calian.com> X-Originating-IP: [204.83.154.189] X-ClientProxiedBy: MW3PR05CA0012.namprd05.prod.outlook.com (2603:10b6:303:2b::17) To YT1PR01MB3546.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:f::20) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (204.83.154.189) by MW3PR05CA0012.namprd05.prod.outlook.com (2603:10b6:303:2b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.10 via Frontend Transport; Fri, 12 Mar 2021 18:17:48 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c8fbc1f8-2d2b-46ef-8fd1-08d8e5832482 X-MS-TrafficTypeDiagnostic: YT1PR01MB4409: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tSUNwR+TisXZZL5DY/SnnZvT7RXJy+BhaLyOLkBTcEjGksDHOuQILgE4mroRZ1a8OmgVzF8iLgRJJ0MzuNU1DvIdRwh7iX7OBtXnc8gfaMQJYk/E1jRn5chXmcdtxOvRVA1QHYnoSHcBcMb9WCpyYaNdnDHlHzIdhUCrjWf5ioPhKBGTC4LwUtfUE29kNQvtJ98oDTpR61PRMJsfos9ikqxLIoJ6QG1MtbsPs8u07eQ1srIHAYUhxfBQoW/IBZqCqvWHKbJsq/kTI1SOTUXjxlboLvR4/LZ0Y28VfOYWXVghyXnYzc75OLWRt+aZlBrqK6KeV+S+uAw5K3rIBaARxS8ZK9Mpa/Jfh3CvSotUKRTmiSY+7XAt4KzeQ5TzjpvzPU78GVhmNibXzv1KPEbaWF8K68njgD+KYlU8FTE8AMrVHDtpqfSd/H+bT9oozAsIfyvlC5P93V3YQUiihtGy+YMRxjwBd77XMMpWB65uY/sk5o1d0DgMuJddpc+NhIYsUaOARDrwII+g6upmWdJeqUfRWcQRw1mfYF1jqhZfgfFiqZMeOL6HAk7zyVAvThqLFgIv/ZEweWwonba0n3tDNA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YT1PR01MB3546.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(4636009)(136003)(39850400004)(346002)(396003)(376002)(366004)(69590400012)(186003)(44832011)(956004)(26005)(1076003)(16526019)(478600001)(52116002)(66476007)(6506007)(4326008)(83380400001)(66556008)(8936002)(316002)(2616005)(66946007)(5660300002)(8676002)(6666004)(86362001)(107886003)(6486002)(2906002)(36756003)(6512007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: W9S++6ZxdQBMS5k7oGyEbiNAWW2bUjreWWuvbEVuMSLjZLKvS2L0c4g0n9GGnB0N+KISp2K+Hxc1+iEYnrUTrmfpWfpeQXcGDeIepXJEo2jo2GEfqrOhhJhtliPswhYYYWZ8BQAoGAR0VWr7/ep/5CAo5R8jLPVVOyA7DeH9C9NAXH94UkatHDTCpfuyiHiy4mFwcKDbH1z8HQIa4BCl+5sWUvgtjDFqUPiozcpdl6b46Pju3vuj3WlQh7A22fjxRuCROicLtXB4E0y69gNzQXjmBbwXQ5JjegULlE4zs2sHQpdRy92oxf+LGEKzBaavOUnCwF86K8s0EHKzBee2xWFWw5AdDTM+JoVFwIH0ZwfD6ezCVFoo7UFuswqqMUx/xdWVs/4uwU75H/Zzycb0G0PoCdpIGMk8C9Ph7yn+z5ckckzwWk9Uws5304cAyQaeiWh6NEnNyz51Xo+GFghbAJ25jIPkJ47btkrtrJnNLWWSQYuGFhX+duB/QZWS0iCU/XBvZvBs79936491SAfZT15gSHVMv1B53v3IYNi7kr4ifK3iHAeKBs8wUalfkoAWM8up2VEgJ9IdKZSkDFanr/gRBs5VcD97MR5IYzzgTPCbGMcjtTmP8pSG3cRzDzq+KYSTI+GUkWe4vhJCfCpgO9W6LBvuFBqHpVKPl4ZZmhjLbri0dLy0q/C4eYlwmGhJfj7wb27xUfk2EG1Sf6JI8flinZEky3HtxpABhy3jqiF7/HLJ0hF/wTVRuX/YNsq+ZPDObDEszWdAyGk79ek2/JyDYSJP0LniYMw3cfNkYtarHEWUW85dm5w2dRWMY88RZCg6/Y9ouwLB5m0jWoxsjTi22f/5lpHDebbdbofHO+DDCiRkZ1Op5/nWGbEeM5NZiAWMPD1B8hjuu5GhobBEH4E+LMBXsYRXwA1KUAGS4jwafAaNt8Jl/oRSvJF6iwZYOyVJalVTMCf9vSdI/CwmGa53dN5E8tOsc7yz+o7GodojtSHIVaT8Hfrfmghejq/VzDyVtu4YYGl5FUPNMd9EyhxQVNu9P4g143nDqV7nu0qVq8OLsW6bCyAu2X/nzRtlOSd4kHkbDAwVvAfemKpRG6Lg659SUWGo/wzgCjO98ax4Tl1ZBq4WPH5o8z8AKfW8gYxnyVNx6/YndUbZM7/4bNldrSrnwBff6VuHDmwiJsDcV7/wZtCutJ95k6pHMmsjlh80FUr80yxucWucrYu+BYQTihG8cyGrvAEDNsalZSqFpA3J+FKqv1yeLYVe94Qzr24xm5PLxtD5xpEolMj4VwBYudFICOuVX/mlCa4VkYR6R0XOe+sM9H6HWG+RyV9O X-OriginatorOrg: calian.com X-MS-Exchange-CrossTenant-Network-Message-Id: c8fbc1f8-2d2b-46ef-8fd1-08d8e5832482 X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB3546.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2021 18:17:49.0437 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 23b57807-562f-49ad-92c4-3bb0f07a1fdf X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WrSA71gqRmAH7TLysigx+tYqsYrvdIOWrNhko0MKnhVSEG58Mzf22c4BJxO5U2hQy63ek43LLk5F2f6bzUlJ1Tiy8a2+3ZXGh83MzMJPUwY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT1PR01MB4409 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369, 18.0.761 definitions=2021-03-12_09:2021-03-12,2021-03-12 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 phishscore=0 priorityscore=1501 adultscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 mlxscore=0 suspectscore=0 clxscore=1015 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103120134 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Add a property to allow specifying that the external I2C IO pins are using 3.3V voltage thresholds rather than 1.8V. Signed-off-by: Robert Hancock --- drivers/clk/clk-si5341.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/clk/clk-si5341.c b/drivers/clk/clk-si5341.c index 689f8c2b0b57..966b034a318f 100644 --- a/drivers/clk/clk-si5341.c +++ b/drivers/clk/clk-si5341.c @@ -81,6 +81,7 @@ struct clk_si5341 { u8 num_synth; u16 chip_id; bool xaxb_ext_clk; + bool iovdd_33; }; #define to_clk_si5341(_hw) container_of(_hw, struct clk_si5341, hw) @@ -103,6 +104,7 @@ struct clk_si5341_output_config { #define SI5341_IN_SEL 0x0021 #define SI5341_DEVICE_READY 0x00FE #define SI5341_XAXB_CFG 0x090E +#define SI5341_IO_VDD_SEL 0x0943 #define SI5341_IN_EN 0x0949 #define SI5341_INX_TO_PFD_EN 0x094A @@ -351,7 +353,6 @@ static const struct si5341_reg_default si5341_reg_defaults[] = { { 0x0804, 0x00 }, /* Not in datasheet */ { 0x090E, 0x02 }, /* XAXB_EXTCLK_EN=0 XAXB_PDNB=1 (use XTAL) */ { 0x091C, 0x04 }, /* ZDM_EN=4 (Normal mode) */ - { 0x0943, 0x00 }, /* IO_VDD_SEL=0 (0=1v8, use 1=3v3) */ { 0x0949, 0x00 }, /* IN_EN (disable input clocks) */ { 0x094A, 0x00 }, /* INx_TO_PFD_EN (disabled) */ { 0x0A02, 0x00 }, /* Not in datasheet */ @@ -1160,6 +1161,11 @@ static int si5341_finalize_defaults(struct clk_si5341 *data) int res; u32 revision; + res = regmap_write(data->regmap, SI5341_IO_VDD_SEL, + data->iovdd_33 ? 1 : 0); + if (res < 0) + return res; + res = regmap_read(data->regmap, SI5341_DEVICE_REV, &revision); if (res < 0) return res; @@ -1544,6 +1550,8 @@ static int si5341_probe(struct i2c_client *client, } data->xaxb_ext_clk = of_property_read_bool(client->dev.of_node, "silabs,xaxb-ext-clk"); + data->iovdd_33 = of_property_read_bool(client->dev.of_node, + "silabs,iovdd-33"); if (initialization_required) { /* Populate the regmap cache in preparation for "cache only" */