From patchwork Mon Apr 23 12:41:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 133994 Delivered-To: patch@linaro.org Received: by 10.46.151.6 with SMTP id r6csp949984lji; Mon, 23 Apr 2018 05:42:04 -0700 (PDT) X-Google-Smtp-Source: AIpwx493AXKjrrv9tkchpznvxHCMPIRuzdQmIxawWEh0Nnzwiw7hM2jHuj9K3QYMjMA3LNFoWOOu X-Received: by 10.101.101.132 with SMTP id u4mr17270406pgv.260.1524487324543; Mon, 23 Apr 2018 05:42:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524487324; cv=none; d=google.com; s=arc-20160816; b=I5Hla2XbqIs9Ry4XdnQ4jV70aN2+dixQux4DScKAl5LQJYjm2iY/p/IzxZQqJpxm6g VAtvAtz7NZpxZhpqh0043pHEI26DLHripOrPr4K0XsieGM059CemUy2/Qhh1nhn/Ny1r xH6kLA7O6ja7jdLb242auWx/kSSAV741McflOeULFZT9clEaT0P+ssdLXwigIzeyWsQ+ yDGJ4hYqS1QAGJrk5cUXYETxlQFOwP/4vm7EXUtWZ5kA5l4ggNaDNy8jHqIQWksKFUqb 21hOEMA6ybhDfGMIUwGZzuor7eVI/XnlxHYSP3W58/9GypkzWDalnWL11x/FVf42uwQm ACWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=o3Nfz8TRGBKldp1ZMsDKLhUaER/cVEDFiibMEH4/3I0=; b=Hwq/IBRUNXreRZkecItvNdDR9f6wddrymTfyUTmEehvPqeD20Zkc1gNdZPzOVCOSrH JaQ5VjHkNxtFvgucskOP1BJu/KV2Pyirb1esndnZNcx3p6T3uXk9jMWDC2PliHdYlMu8 0rdq1zqUSnPvPS60ZVcPyLW8v7DcaszcYRS6Hug2fYv/YQL7ZFLj6LqRrhPKlowHa/ex H0YfmeUPaPhWzoOPui+v7VvJ8VUkZEF6bFfhZ7d/xMtzYLhWwqEGqSMp3OXXR9fV7iT1 ozT9VT2pyLy2pZyDykkOsEE+UrrLF2eSkEzBDmCVjDSrqrBviXEt5fgO9Sud3FExzDqt Zvjg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=xGWlrcoD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s7si9390770pgp.498.2018.04.23.05.42.04; Mon, 23 Apr 2018 05:42:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=xGWlrcoD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755124AbeDWMmA (ORCPT + 29 others); Mon, 23 Apr 2018 08:42:00 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:37776 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754968AbeDWMlz (ORCPT ); Mon, 23 Apr 2018 08:41:55 -0400 Received: by mail-wr0-f194.google.com with SMTP id c14-v6so748157wrd.4 for ; Mon, 23 Apr 2018 05:41:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=o3Nfz8TRGBKldp1ZMsDKLhUaER/cVEDFiibMEH4/3I0=; b=xGWlrcoD7lNkelRWlJg+JvD1HrU3PYp9MN8gmmmOOu1AP3A4oQY4muheqaXCrO9tp/ iJu2/DLlFBUjPWkWJKwT9TZ4+1JHXnAG9qFmirmQs2SY3FJ8ULeVjp1+H2sKy/pT8MiA vgLluYOGEm3hYDqe2hK5DSE90+txHcPGcIxbNMImAvbHLLLDc/zWdGGSrelrCXz3MRWO yBY2JO+SZMRkNoqQeQ8RYY1mneFPMgR6MptcG75MwIoEBOVBLptQwAiC6jnjp7Q1w+kd VtJ41p2EtRl7IT21zUN0tgPfI9Gh4bub5w2jmsllLuRDtro4lVEmOJ4x2aFpOIDdLEXe 4h9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=o3Nfz8TRGBKldp1ZMsDKLhUaER/cVEDFiibMEH4/3I0=; b=NbUteCDkN6qVgBT43b1bSzUE0NvoZWlw89h8EHd/sUHnK/Q7B9pcl+XU8g1y0Bbylu tAE7E1PU0AcaT7KDBwExOlq3Kgi8Xrj60pOtTI3FLiQ5TCo2Kexzj08IB6EpTqChcT1v 1icvsyI2JEy2DHLCkJ9tFw4b9FA2ScXF41uCxcO81cDIBWmMCnBKW+YQv/u5opY1xlk1 GVhT0VkdRRed1Fjt13VZ+rEUcEyMDRAfhSBPSFQIht4MM8U5QVj3r7Y6rHH3EtsT8tSi GyNCAE/V5Tt3klG9nyRNGZN5vi7a51GFwrGro7rF6XKK6mAoHfG9EeWRP2gTWI8hDKea Nhvw== X-Gm-Message-State: ALQs6tB+ThD5DRJ347QKhXTzyV+6ItGWRZm7T2atsaOoWRihWw72HkIp BnlI9HClQ76X3hazDkkc2WuykA== X-Received: by 10.28.26.83 with SMTP id a80mr9599474wma.36.1524487314153; Mon, 23 Apr 2018 05:41:54 -0700 (PDT) Received: from boomer.baylibre.local ([90.63.244.31]) by smtp.googlemail.com with ESMTPSA id e202sm8727927wma.43.2018.04.23.05.41.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Apr 2018 05:41:53 -0700 (PDT) From: Jerome Brunet To: Srinivas Kandagatla , Carlo Caione , Kevin Hilman Cc: Jerome Brunet , linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/3] nvmem: meson-efuse: remove econfig global Date: Mon, 23 Apr 2018 14:41:47 +0200 Message-Id: <20180423124149.3077-2-jbrunet@baylibre.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180423124149.3077-1-jbrunet@baylibre.com> References: <20180423124149.3077-1-jbrunet@baylibre.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Having a global structure holding a reference to the device structure is not very nice. Allocate the econfig instead and fill the nvmem information as before Reviewed-by: Kevin Hilman Signed-off-by: Jerome Brunet --- drivers/nvmem/meson-efuse.c | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) -- 2.14.3 diff --git a/drivers/nvmem/meson-efuse.c b/drivers/nvmem/meson-efuse.c index 71823d1403c5..2df9b0094f45 100644 --- a/drivers/nvmem/meson-efuse.c +++ b/drivers/nvmem/meson-efuse.c @@ -35,13 +35,6 @@ static int meson_efuse_read(void *context, unsigned int offset, return 0; } -static struct nvmem_config econfig = { - .name = "meson-efuse", - .stride = 1, - .word_size = 1, - .read_only = true, -}; - static const struct of_device_id meson_efuse_match[] = { { .compatible = "amlogic,meson-gxbb-efuse", }, { /* sentinel */ }, @@ -50,17 +43,27 @@ MODULE_DEVICE_TABLE(of, meson_efuse_match); static int meson_efuse_probe(struct platform_device *pdev) { + struct device *dev = &pdev->dev; struct nvmem_device *nvmem; + struct nvmem_config *econfig; unsigned int size; if (meson_sm_call(SM_EFUSE_USER_MAX, &size, 0, 0, 0, 0, 0) < 0) return -EINVAL; - econfig.dev = &pdev->dev; - econfig.reg_read = meson_efuse_read; - econfig.size = size; + econfig = devm_kzalloc(dev, sizeof(*econfig), GFP_KERNEL); + if (!econfig) + return -ENOMEM; + + econfig->dev = dev; + econfig->name = dev_name(dev); + econfig->stride = 1; + econfig->word_size = 1; + econfig->read_only = true; + econfig->reg_read = meson_efuse_read; + econfig->size = size; - nvmem = devm_nvmem_register(&pdev->dev, &econfig); + nvmem = devm_nvmem_register(&pdev->dev, econfig); return PTR_ERR_OR_ZERO(nvmem); } From patchwork Mon Apr 23 12:41:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 133996 Delivered-To: patch@linaro.org Received: by 10.46.151.6 with SMTP id r6csp950715lji; Mon, 23 Apr 2018 05:42:52 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/sZYadigZHFhVmXRAHppQ7zgOmELug5Lobrh8+j9nP3ahA72DB+teKu2AwLngu7/IXaG7k X-Received: by 10.98.14.7 with SMTP id w7mr19871530pfi.50.1524487371914; Mon, 23 Apr 2018 05:42:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524487371; cv=none; d=google.com; s=arc-20160816; b=iyumcHA9FSE4xMRFRXjdQ0dCsM7ubZxKerE6gYCV4wh8kE4pj2vg9AZLFVuWDEN6DK y177iDjSzC5TEih8Hg2NjgVgy8YX7nhXOfSCt5MyKjsi6wow2n3Xwi4mHxVZYj67GzEn eH1HK5R/j675cJv34i+6ERTy6f1xbHpn0htsA+pRMoNJOvvkwOF08fCjOsu8fcowJtjl IsiEYYHtamoxy+3/jv8KFax/oPo1KvfwssBgejQqm0Gif7XKcmM2zJCPDt9L3nSWokLS vQwECL+QSAaC/pUMV8Y6tfwTMfqzedTyjb76DVyspYgpl64dXtVvu6EQs3bbE4R5qTaX 45qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=gISxAmx/ETJHVuen3Y/cxb7AXwzejKuk/MupUIcEk0I=; b=0s72wU9UEnwGoZzO6eivCNUMrWjFwujRwREpawtte5mhqokydd47jtDGTdVNKEAwAg IZbkLKYcgmkbSfeX1tiper7LU4qZNvl9kSkFyci/b0DbJLnzX47uEMFWkn+V6eyKHupQ ZoeoeOShA3/Hxt2xeynWn9gme2fXzAAfEhjZijjXIEb7+UiwA5Ko+yZqS94PhVdbfDTi Dcmfhi30Bk+j//3aVaQZU9Si9rQynl9GrhE6aRyg8RoQj1NRPEVvKUDbIOhwzntrb0Oe J/9rUwwsk22KzeNchJKhuHhWS902XP7V02qjLP1ls6TyLZmk/pu8f5RSpalsV56z6FNY lBsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=G6Zd1Q7T; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f38-v6si10134441plb.44.2018.04.23.05.42.51; Mon, 23 Apr 2018 05:42:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=G6Zd1Q7T; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755207AbeDWMmt (ORCPT + 29 others); Mon, 23 Apr 2018 08:42:49 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:34815 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754994AbeDWMl4 (ORCPT ); Mon, 23 Apr 2018 08:41:56 -0400 Received: by mail-wr0-f196.google.com with SMTP id p18-v6so21674742wrm.1 for ; Mon, 23 Apr 2018 05:41:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=gISxAmx/ETJHVuen3Y/cxb7AXwzejKuk/MupUIcEk0I=; b=G6Zd1Q7T+C48a5ue0U0+8rmM1l2M6dgJoofyUursLaKlMI+VawRpOJNxKr5l/4jpQK TDZtxwXikufmpDoyb5G+UmxlyESN7JUORVWkDeAWutvD7Y6uF60pJcjca27xECo9V84M 8J4SZvkk9m4MAafGlEpXJ8DwEDpXxw+X2v5X+DDco0cF0s40c2NUHtnMq+ctHdlfinrV F45jaGPdMFjK1phqiHnRVRJ9/GTw+esosNkK3pYOGDoTye5OjBM6JsIaqCCCMlikUjBo KojXGobUKrSyw2dDN3s0nZkeewMOqH2GOU5Ihb+tmkLguJlyUCZ3jvcsoPIUAeadgZ7T pJ7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=gISxAmx/ETJHVuen3Y/cxb7AXwzejKuk/MupUIcEk0I=; b=EVoGh0p3d+mlA/vUo6Z5u/9FHJ47fnWeZNcGt5QFd0TMV9ZyKBHbGKb7WP2w8tvf/j qFED0Nx+2bK0GcdoWRTpRfkfRJaVN9+07SaoxMEu1PMPS5XoxVs0GgkVcR+8nE/klfRp Pjh4n+Nh3O4S+kFnGhEohQJTP9pvuRBfj5Xl161wDD9+DSlsRlmdSis+OZpjLGe1K1/H ZRZApgubadoWh4oEo3Wrs5NAEi7L6qV0vzh8uV8vl6cbtDEVCDmOj4kGi4kUrHrDYEAg BfSPezdtmEtYSxK7W0IP4qV1Yibky8z8Ot6Z2kzn9ui0whckCIxUlW2ZImDlnmaEg5Ly fZfQ== X-Gm-Message-State: ALQs6tCkqUyD7YXw5p1cantO0tgahHxGUzwjOQ5x+KM1Z7BEsPctdApM ZRUcbAeogl405P/axO+ghf1emw== X-Received: by 10.28.230.28 with SMTP id d28mr9757396wmh.92.1524487315270; Mon, 23 Apr 2018 05:41:55 -0700 (PDT) Received: from boomer.baylibre.local ([90.63.244.31]) by smtp.googlemail.com with ESMTPSA id e202sm8727927wma.43.2018.04.23.05.41.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Apr 2018 05:41:54 -0700 (PDT) From: Jerome Brunet To: Srinivas Kandagatla , Carlo Caione , Kevin Hilman Cc: Jerome Brunet , linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/3] nvmem: meson-efuse: simplify read callback Date: Mon, 23 Apr 2018 14:41:48 +0200 Message-Id: <20180423124149.3077-3-jbrunet@baylibre.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180423124149.3077-1-jbrunet@baylibre.com> References: <20180423124149.3077-1-jbrunet@baylibre.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Most of the code and variables in the read callback is not necessary. Keep only what is required. Signed-off-by: Jerome Brunet --- drivers/nvmem/meson-efuse.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) -- 2.14.3 diff --git a/drivers/nvmem/meson-efuse.c b/drivers/nvmem/meson-efuse.c index 2df9b0094f45..4623249dfd87 100644 --- a/drivers/nvmem/meson-efuse.c +++ b/drivers/nvmem/meson-efuse.c @@ -24,15 +24,8 @@ static int meson_efuse_read(void *context, unsigned int offset, void *val, size_t bytes) { - u8 *buf = val; - int ret; - - ret = meson_sm_call_read(buf, bytes, SM_EFUSE_READ, offset, - bytes, 0, 0, 0); - if (ret < 0) - return ret; - - return 0; + return meson_sm_call_read((u8 *)val, bytes, SM_EFUSE_READ, offset, + bytes, 0, 0, 0); } static const struct of_device_id meson_efuse_match[] = { From patchwork Mon Apr 23 12:41:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 133995 Delivered-To: patch@linaro.org Received: by 10.46.151.6 with SMTP id r6csp950331lji; Mon, 23 Apr 2018 05:42:24 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/ap2an2xoY3OZXr2XA7/w8ndhOi6iApEiK2Tr0y32IBYtsac1Q8g7/DknA5Bg++qTZSPiA X-Received: by 2002:a17:902:462:: with SMTP id 89-v6mr15156297ple.300.1524487344558; Mon, 23 Apr 2018 05:42:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524487344; cv=none; d=google.com; s=arc-20160816; b=LDpzefrRYva0czvF8tMIFQamD4iIy4ZxOPBR0aalXlhodsotfDhT+pDVUFO42TXzzS YbFOaGHhSoEu/upfGH0sbV4RdWEmHa7w17e9+8ZUh4aBWetRpurF2Vq/PyX7Sllwmbpz OzMHUl0r/rukoM0d1Bncgr69F4R/Bhmwj18vKzFmzEVbzgti9Gq4ROc/2anfbJftYRS8 gJpfR0QA+Fxry4YbxAPXpEc41G5QnLHFFDMkTo9QBhCIPoQYdjK8iCjhsDRwVRXko9E+ H833PSjCMf/Y5RNX1LuN2XaRkAOUyAfvLXLE/Lx5jXvS2rjRZKijcLnEZAqMkDsO9gU3 +5zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=EcqPYNHTIL96uRagP/nyIFajaBILMQX8z2TC4uZBJcY=; b=W4tSuIjcpoDw+l9k4X/LUTxJw3/GSlTPbKOUP5pl7kBttrU906/vbP5/1n8gQzQc/+ vxBx2mZ64+EX2mdH0/9sFnCLtRbckjIW7Oh7iugu94JdDL/2j0G5LDv0wxPvPg6FsrhM 9veuq4I4Bb1zYhcCm6Ny2A9OcoxD5KlFAbf7WVPnCuNkQVqnBOBvXMhGHqBwnBoN0Ffv LTFcKBr9VTVTqVR36qsFB4MShP/h6wImXjtJjwgJZLxEiN+GS+0CyYk0vvvVV+WgFNn0 3Bq6HxcIr/GHVZfgNhwfVXECHl1siV0Y2xagObRhsXFGgHf2ALfh59plAWuVSG/LUYpa UGaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=ZRSaQDOf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h17si11274199pfj.178.2018.04.23.05.42.24; Mon, 23 Apr 2018 05:42:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=ZRSaQDOf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755162AbeDWMmV (ORCPT + 29 others); Mon, 23 Apr 2018 08:42:21 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:46409 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755063AbeDWMl5 (ORCPT ); Mon, 23 Apr 2018 08:41:57 -0400 Received: by mail-wr0-f194.google.com with SMTP id d1-v6so40824159wrj.13 for ; Mon, 23 Apr 2018 05:41:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=EcqPYNHTIL96uRagP/nyIFajaBILMQX8z2TC4uZBJcY=; b=ZRSaQDOfHmTDweVL7ihV1AvVetTK19UIhXW/KP3EZsL3sVgksV9EPqmy/V+CrvkjLq 0Q3wo3jjQuM0fGsFcMhzjTw0Pnad33/Jv9aZ8U4t9B3P1XNiDHTx8Hf4G2VM0o/DQz91 0cfOcWIRcJG+AglpKsjE8sA6DAxiHtMQHszckk2F1xm5UkwqURNFYFbOmCtuCWw3+V+F JUM57yP2pBZwie9ffe6D9d7CK9Vhiup+eDc+EjOpOJrE67OIZnW+8PI4QgHPUlF/W2N6 UizaaddbTgIfnf72zIcouL8A7rrfs2Tdg4gamxs+OhKeTyKpbJBLzwlF77h5fGIAAySN vgDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=EcqPYNHTIL96uRagP/nyIFajaBILMQX8z2TC4uZBJcY=; b=C8oyqjecMUVAalmwA8gLMHvTO/A7U8/EEo1nssNU+gqvz6GBsuRXPfJRoyEeTjuRR+ AjL7347KUcYWlBpyhoWX4RB3tJXlgY0N/rzmJVK6wxgMmyPV/HyFmpwD91j9WSauXFR2 mpn+unFPkTf8bb7VIVpLAXSv0VgPGmBN3T/YsvEeU0UTuhn2If6AUcx27iMLONOT9dkA ArY2VT9qh890tV8tFRapQKKJbXI5Ara2A4A+gZ8hQMZQFg1L/LSwDuZUzOAnjZ/sdyYw j4rOjQOSpSCVlMavzJxNVYI0SS/rJM8T4aENENvLlL3ck3jxBSDm8Pg6TByLrM6khnl4 Po6A== X-Gm-Message-State: ALQs6tBc7AVzybHUaVXRgXoPRQmIw8ICnrjaMqHjn9XBxZJKImwIJcem VX14S/udm7JYqocdAxW2Knec/47e X-Received: by 10.28.54.141 with SMTP id y13mr9969784wmh.126.1524487316263; Mon, 23 Apr 2018 05:41:56 -0700 (PDT) Received: from boomer.baylibre.local ([90.63.244.31]) by smtp.googlemail.com with ESMTPSA id e202sm8727927wma.43.2018.04.23.05.41.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Apr 2018 05:41:55 -0700 (PDT) From: Jerome Brunet To: Srinivas Kandagatla , Carlo Caione , Kevin Hilman Cc: Jerome Brunet , linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/3] nvmem: meson-efuse: add write support Date: Mon, 23 Apr 2018 14:41:49 +0200 Message-Id: <20180423124149.3077-4-jbrunet@baylibre.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180423124149.3077-1-jbrunet@baylibre.com> References: <20180423124149.3077-1-jbrunet@baylibre.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add write support to the meson-gx efuse driver. Beware, this efuse is one time programmable ! Reviewed-by: Kevin Hilman Signed-off-by: Jerome Brunet --- drivers/nvmem/meson-efuse.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) -- 2.14.3 diff --git a/drivers/nvmem/meson-efuse.c b/drivers/nvmem/meson-efuse.c index 4623249dfd87..d769840d1e18 100644 --- a/drivers/nvmem/meson-efuse.c +++ b/drivers/nvmem/meson-efuse.c @@ -28,6 +28,13 @@ static int meson_efuse_read(void *context, unsigned int offset, bytes, 0, 0, 0); } +static int meson_efuse_write(void *context, unsigned int offset, + void *val, size_t bytes) +{ + return meson_sm_call_write((u8 *)val, bytes, SM_EFUSE_WRITE, offset, + bytes, 0, 0, 0); +} + static const struct of_device_id meson_efuse_match[] = { { .compatible = "amlogic,meson-gxbb-efuse", }, { /* sentinel */ }, @@ -52,8 +59,8 @@ static int meson_efuse_probe(struct platform_device *pdev) econfig->name = dev_name(dev); econfig->stride = 1; econfig->word_size = 1; - econfig->read_only = true; econfig->reg_read = meson_efuse_read; + econfig->reg_write = meson_efuse_write; econfig->size = size; nvmem = devm_nvmem_register(&pdev->dev, econfig);