From patchwork Mon Mar 8 15:29:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 395438 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp1805637jai; Mon, 8 Mar 2021 07:30:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJzrqPw11n3/qRQZ9pyakosfz2fi3rcRsmA/VWVY/PQauJ9OB0EIjbgV8KGJpPrQowsKzV9e X-Received: by 2002:a17:906:9bc5:: with SMTP id de5mr12440266ejc.284.1615217420458; Mon, 08 Mar 2021 07:30:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615217420; cv=none; d=google.com; s=arc-20160816; b=oiC2PuoV85zBHrvlTl1bGXW7HrCD58Hw1K8Uni1exgbB/qihWAemPBi/m6hurLqc8f iLaCB6SuBGpmeixQFCsM7mB6Uq2e+A6QHweW+WVVjMwXlp2qfEHcgMheq6tZWcxUmzj/ 81dBsqBL6Au0odHGsMayBNTYBT0bP3MjCMOmvvhl950bVHaX7+9D3++cW0/fD4VVUJQK 7ftl5lvBL7tE2gaJh/YVGgHqnWMT/4N/B6RpZK42mKXCGhk7XmyjREdcC27cyfojF9zL M1fYX8G0+SUA5QhA7pW2Rcb5RsKfuaLdyzGVBXJ+iY5DKrA6kwbjTdedHHda0sDxnpHY hCNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=lV4EQuYDup+j4q231by4Dcf8fUJyRcwbLUv5SJpvXf4=; b=M2XNIKqj1aK7D2VoCyTqV9P/M3aGVsKkqR58up/3cLlzpElbulStnSaMdofC/jH0rL Ryjc40MXfNXk0JmzPvcp+CP++plZgDap+EdLkyNKQmC/kWmUSIh03u0IMnsLaTkRsFjo dk2f7cwtg+aEM0do5z4TwsIpJwA0x1BCjHGPIEzlZRjrg+cZ8uqQxvg4TCkldCrpybb3 FEfKpP75i/CA4VdaijO2RXEB2OIc9m5Q54057yRYHKNekYZ28NXr3kfC5mSxtJZnrAhx oMlvGC6w4mSH4jwjITHiQxbpenXL6hj9Uwa617LUyzj897k8lUghY2Hqg9fMIT6Yqb4+ D+sA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cLML5E8i; spf=pass (google.com: domain of linux-pm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id se15si6878852ejb.204.2021.03.08.07.30.20; Mon, 08 Mar 2021 07:30:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-pm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cLML5E8i; spf=pass (google.com: domain of linux-pm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229757AbhCHP3r (ORCPT + 7 others); Mon, 8 Mar 2021 10:29:47 -0500 Received: from mail.kernel.org ([198.145.29.99]:60000 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229821AbhCHP3l (ORCPT ); Mon, 8 Mar 2021 10:29:41 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6F12C6526A; Mon, 8 Mar 2021 15:29:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615217381; bh=n4ZjPMWSBwDBwg/gyfzEkY2KhR5GTgDq57IHPhhJFfc=; h=From:To:Cc:Subject:Date:From; b=cLML5E8iOaNbsLI26oYs5nz+cTUCNzuGuk8Qjtl+hrGUYaBrnM5a2agn0P1hY+/Dj lXA9eDd+hoAomMEEOts0xtSe0zZLl0E5oYyOnLSbm+UQYyKe66xW3cFcrByuKmIloj YSrW9Sdy+WF08y3JN9Awx6xRbdDxBDRUEOjJvklMnnHA3FCuBVx78+6UnVVsYxE8mr y1czW/oGe1r97x4j9x5GTcczRs+E1++rrwH//pRyVjS1AYbgigCajNjytf1fdFjzBq zbmMH1mZuTt8f8K9/n3LbALcbaAmPN9OYPi9p6YzClAWhJXVQFlGJz9Xsq295xS6EP /DCFjFc1ZqQlg== From: Arnd Bergmann To: Sebastian Reichel , Timon Baetz , Krzysztof Kozlowski Cc: Arnd Bergmann , Matti Vaittinen , Andy Shevchenko , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] power: supply: max8997_charger: make EXTCON dependency unconditional Date: Mon, 8 Mar 2021 16:29:05 +0100 Message-Id: <20210308152935.2263935-1-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org From: Arnd Bergmann Some of the extcon interfaces have a fallback implementation that can be used when EXTCON is disabled, but some others do not, causing a build failure: drivers/power/supply/max8997_charger.c:261:9: error: implicit declaration of function 'devm_extcon_register_notifier_all' [-Werror,-Wimplicit-function-declaration] ret = devm_extcon_register_notifier_all(&pdev->dev, charger->edev, ^ drivers/power/supply/max8997_charger.c:261:9: note: did you mean 'devm_extcon_register_notifier'? include/linux/extcon.h:263:19: note: 'devm_extcon_register_notifier' declared here static inline int devm_extcon_register_notifier(struct device *dev, I assume there is no reason to actually build this driver without extcon support, so a hard dependency is the easiest fix. Alternatively the header file could be extended to provide additional inline stubs. Fixes: f384989e88d4 ("power: supply: max8997_charger: Set CHARGER current limit") Signed-off-by: Arnd Bergmann --- drivers/power/supply/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.29.2 diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig index 006b95eca673..6cce17e1d47a 100644 --- a/drivers/power/supply/Kconfig +++ b/drivers/power/supply/Kconfig @@ -555,7 +555,7 @@ config CHARGER_MAX77693 config CHARGER_MAX8997 tristate "Maxim MAX8997/MAX8966 PMIC battery charger driver" depends on MFD_MAX8997 && REGULATOR_MAX8997 - depends on EXTCON || !EXTCON + depends on EXTCON help Say Y to enable support for the battery charger control sysfs and platform data of MAX8997/LP3974 PMICs.