From patchwork Sun Mar 7 01:39:03 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 395135 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp648776jai; Sat, 6 Mar 2021 17:39:46 -0800 (PST) X-Google-Smtp-Source: ABdhPJyUd68rkZuUWeAI+PUjo4qL7E4mRmRbhdMcgB9uEMWUt3W2kbR9TnIyXW3VHEB5gQRud/lr X-Received: by 2002:a02:294e:: with SMTP id p75mr16813033jap.34.1615081186598; Sat, 06 Mar 2021 17:39:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615081186; cv=none; d=google.com; s=arc-20160816; b=AIjHvYrwqpL3Kf+eZD18m6/zpN484SmjIryXghyQ3TC+xlBwYVcg4GpiivARuWLzhC 5AeKQWxKLoM5yt26Nm2hS1i4bLlXuFFL2X3EIzj0EhZPNJF6fb5BRlfvTi8h3ZykMrI0 3a7S3WulFfiHSeYOXU4x7nAjvC4LN2WYV7CzZvfKjrqtIXUQSU67m+r1gkbF2c1sKZqt LvuWeMUKtoQGBn5hPlf6gpesVOK1CBMRRtJOxMjAnZC/bXmpAI1vnMlmJIJdaVKE1W+w Fmh3PnjN4tZjz/4rU3snb66Pxsv9ElMgKgsmNrkwdnhitQgcaq/mrZpefZ9WG22Bw1Um SV1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=hMi1f8UdwY02crz7tpgFWAoMdF442cRFWG0hh30+F78=; b=LZZaUIHdni1Y0RNkWgVDSa/dDKy1Bj+586iDOVPU/EP7tSVJW3h4xgKQUhr61FFMsQ nZWDvkW2OYVOXb0dPFaQcqljgq4SIy2lDaqIlGtP6UA1VH/dFlEDHkPXuPefyB+Ltq7b rsovq8KxQkDlrrIiqlk1+uUycZZsz2Z+3/46YGU5QqtvXNX/QNo4Zum1KYE3+Tme5Es7 qnvLmjD9b1XnGpfxTlqRDrWDCZXAdf/zPWrmabVUDb826DaM4tCvYG5MRj/FsHQDzG0f 3Cl4ShL6EinqlH0PB8lUUWoE+vRrcNnd4FYMWGQRmh0Q2xjV+hw/yfcGm4Qia3496P0D 2bwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=a2+CF3ch; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id h6si6542087ili.15.2021.03.06.17.39.46 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 06 Mar 2021 17:39:46 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=a2+CF3ch; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:54598 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lIiOY-0002wO-2P for patch@linaro.org; Sat, 06 Mar 2021 20:39:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54804) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lIiNy-0002uz-Cv for qemu-devel@nongnu.org; Sat, 06 Mar 2021 20:39:10 -0500 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]:41890) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lIiNw-0005OL-Ug for qemu-devel@nongnu.org; Sat, 06 Mar 2021 20:39:10 -0500 Received: by mail-pj1-x1029.google.com with SMTP id nh23-20020a17090b3657b02900c0d5e235a8so1206595pjb.0 for ; Sat, 06 Mar 2021 17:39:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hMi1f8UdwY02crz7tpgFWAoMdF442cRFWG0hh30+F78=; b=a2+CF3chh1SyYWC60/BqVZBII+uPIUnK66+Kd+0U+tQs/sVOuSl7MLxbm4IgQt7l/l cYpDVWdARJz/adDBgVwFi0Uk4q7VCpYPNfav4CITdlVhZRrYYq/lVSc0s512tqWhlRwA FUccOik+bgpSye6xZdKu+50w77GeUcxHHtdKpDsQIOMvgkbb0Ce5k6pCOJeIjMcSvvmF MCCb9RbBNGERhE81HLf229Qei8Ov1V+wLFhv6ijWS0QZWYn1M6mybumXyrRDEyrsBC/d DmIup8sLq34983GstintDJ4lTg0/DVGyrAOiFCJjRtTEQncALlYC7Y8EM52CQHWrUlVP qV9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hMi1f8UdwY02crz7tpgFWAoMdF442cRFWG0hh30+F78=; b=tDteRhLemerwNJt5E7kEq+TJr6sMcHf3bVuyJ08l+WLjvAkvpvhsNH75MkzFZ5YBLL /osEPs3OxfWKEN3EDOUhSivx5oY/qXHTPAsGFKNtYIVXR3yIkbpnWajnc6K3AD4yewYi dAehOPZC/E8wb5oEpmsFmXCLrcxk/n0QgN4JpZYf+25pUOkJ0Hg+U3WdvKFZz0kO4SlU y7IVRMGczpRo6gWff4LfbBTqHUw+wjaHrzG4i7glSKTl28AeeyDTkSqsAfxQ6ajR1YEB paQxTcL6N5xunuJqQuCPV2vejv2RtX1en1Rnv8rEcxsOxbfuwmQgLK/vANvhSFqWou6a VgYQ== X-Gm-Message-State: AOAM532/NPZUFqYbysbjVQzOeAY0LMKnsGyjqFb4P4q2mquZtvYDVZBe HlndHwbSSihb5V/WkpuOKBEx1T8mWki4dg== X-Received: by 2002:a17:902:cb0b:b029:e5:b670:d905 with SMTP id c11-20020a170902cb0bb02900e5b670d905mr15397326ply.18.1615081147657; Sat, 06 Mar 2021 17:39:07 -0800 (PST) Received: from localhost.localdomain ([71.212.131.83]) by smtp.gmail.com with ESMTPSA id v14sm6518044pju.19.2021.03.06.17.39.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Mar 2021 17:39:07 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 1/3] exec: Poison Hexagon target-specific definitions Date: Sat, 6 Mar 2021 17:39:03 -0800 Message-Id: <20210307013905.115019-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210307013905.115019-1-richard.henderson@linaro.org> References: <20210307013905.115019-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::1029; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1029.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Taylor Simpson , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé Commit 3e7a84eeccc ("Hexagon build infrastructure") added Hexagon definitions that should be poisoned on target independent device code, but forgot to update "exec/poison.h". Do it now. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Taylor Simpson Message-Id: <20210219135754.1968100-1-f4bug@amsat.org> Signed-off-by: Richard Henderson --- include/exec/poison.h | 2 ++ 1 file changed, 2 insertions(+) -- 2.25.1 diff --git a/include/exec/poison.h b/include/exec/poison.h index d7ae1f23e7..6bb86f6c2f 100644 --- a/include/exec/poison.h +++ b/include/exec/poison.h @@ -10,6 +10,7 @@ #pragma GCC poison TARGET_ALPHA #pragma GCC poison TARGET_ARM #pragma GCC poison TARGET_CRIS +#pragma GCC poison TARGET_HEXAGON #pragma GCC poison TARGET_HPPA #pragma GCC poison TARGET_LM32 #pragma GCC poison TARGET_M68K @@ -73,6 +74,7 @@ #pragma GCC poison CONFIG_CRIS_DIS #pragma GCC poison CONFIG_HPPA_DIS #pragma GCC poison CONFIG_I386_DIS +#pragma GCC poison CONFIG_HEXAGON_DIS #pragma GCC poison CONFIG_LM32_DIS #pragma GCC poison CONFIG_M68K_DIS #pragma GCC poison CONFIG_MICROBLAZE_DIS From patchwork Sun Mar 7 01:39:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 395138 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp649814jai; Sat, 6 Mar 2021 17:42:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJwZSD5Px0VGHBfU35PNQdsGS99OVclx3E/nO0iG3YpLLY0YvnsZK4vUkGpG6DR4wkcyKIuz X-Received: by 2002:a92:d18e:: with SMTP id z14mr15237203ilz.130.1615081346304; Sat, 06 Mar 2021 17:42:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615081346; cv=none; d=google.com; s=arc-20160816; b=L9ydAQF1yz23RHhXFZ1jam+7s+j5GKzErnVdVdzAgpOGTKTBBzV3ERjySdzVb/0T7k wQ/PAvF64Erve8A4nAe0hEph5lmqOv+uwG0TiyKmhczhgMerjtfstgBTzG5O+DEtx14G kKr8CW7toWRl3Wf+4oG8WBdUNdfzvgq4VgLjXsSKcVTuuiK808R3iLHJ1pCR8KQM37qR BYXcjS/TisR3nvV0yDUi304J8Ug1N5AC/mvyKVE/W4XPtSzIcb9IeZeWPwuNxu3DQ8yr LMRkus8Kk8UszLfF4z2yZBzceT52gSn4VbUJUW6ZelsegvE3Te2y2S+Bmy+v2SgaSIDO htaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=Ghpdt26qcrbgy2OSaWqHre3TiZBxfghqLDZzAialyXE=; b=R9WbNvKhWyw1W0r6H5zs+BJfAeEd69wV6FCQlh8xYNeF5kfk2VvAsh+hirKQ9OEPDV 28cZVsZe2+WauIkk5Ot4Gr4Ll4gHYE2raBBMr0fvTTeLRcQdpyPjrW4Q6/76lloiSzuE 2C9BfPeW7hChvasTIU3EseBVimS8ueS6BhHfjhMAPRPMa2GXswOrTkUoHsQkdg2N6JYU j84d0HHKWhh4jxzJ9JgAoE8aIv49zO26cq79wTEzoKYT4PEhgOYv6CoX1SnT6QDAPA4d 4/D8ck7GuT7uP2MzN67+DvmTvNU+2cPeEM9i7/mhpfGUZh2V2orINZQH1q7QZcBZK5pI RhCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MNscHIEQ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id k23si6804339ios.16.2021.03.06.17.42.26 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 06 Mar 2021 17:42:26 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MNscHIEQ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:60776 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lIiR7-0005fK-On for patch@linaro.org; Sat, 06 Mar 2021 20:42:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54824) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lIiNz-0002v8-Lq for qemu-devel@nongnu.org; Sat, 06 Mar 2021 20:39:11 -0500 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]:43878) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lIiNy-0005OR-4F for qemu-devel@nongnu.org; Sat, 06 Mar 2021 20:39:11 -0500 Received: by mail-pj1-x1031.google.com with SMTP id mz6-20020a17090b3786b02900c16cb41d63so1208022pjb.2 for ; Sat, 06 Mar 2021 17:39:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ghpdt26qcrbgy2OSaWqHre3TiZBxfghqLDZzAialyXE=; b=MNscHIEQGcvkYYMLI8SjIicZ2GDIWV0rzHcuu7oc7jr6pCA0dLsS8bQVXQIgzIIsE+ EKKY1G+qxbyVEI2pC4FkTDeF9QlWm6Vi+27ygBnqdq9ilglpZ4ztWRUxZFNKxhSq59bS 9VSx6vNOyvQ75WI4407aAKwjVpg+9UNv9n2VpqT2MkCJDGzR4c8HT4so+JrDu0ZqZ1P8 ljYbs/cp4h6inHbYscth5xcv2edepHl0Lkp9ExebXcUfQVP234h1dzdB9jb734H5p3md hJEa6lPhrq32lxFPJxF5+PWZskHfs2kVk9S9tNCGp4R8QYdA3kFU5LZVj4Fnzj59qzw0 7jWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ghpdt26qcrbgy2OSaWqHre3TiZBxfghqLDZzAialyXE=; b=b4yQysnZMkfvWs284e30wKvtxDri62DEMANi33qcR2Yjucg+er+0ARejWHO/YhhEcd D+ezTCPW52rl3EEU+CUqtqXpaMo9J3Toenjj/R6A+byLhDcYl4JfAx1mwFxkvNV+5z+Y wqjCubwwDEnZSRrkIGeRSq8drn2AuEfe7h8NWalt7Oxal336kuJBJHrSAsedTFXw14Tq KhfvRdRpeZC/hBy9HHzy9M69hs5MQTtYroVPwXzoVYU5N7kZMrfVIjRJzaxaWlmIudgP KpkOBWvItg05xWw1z5f0iYXqDJyDiFSZyL/s+rp6Q5wPCCg1bia3CZoU37GVxMKYVpJ3 rmPA== X-Gm-Message-State: AOAM531m+o7pr6Etv5akxQlv3ngUoAiFNz+oFQ9BpA8lftC1O9wPecC1 cU6S5R/2lrP8dfhIvwmlslqD/r9EVtwLzQ== X-Received: by 2002:a17:90a:d682:: with SMTP id x2mr18564431pju.139.1615081148649; Sat, 06 Mar 2021 17:39:08 -0800 (PST) Received: from localhost.localdomain ([71.212.131.83]) by smtp.gmail.com with ESMTPSA id v14sm6518044pju.19.2021.03.06.17.39.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Mar 2021 17:39:08 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 2/3] target/hexagon: Fix shift amount check in fASHIFTL/fLSHIFTR Date: Sat, 6 Mar 2021 17:39:04 -0800 Message-Id: <20210307013905.115019-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210307013905.115019-1-richard.henderson@linaro.org> References: <20210307013905.115019-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::1031; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1031.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Taylor Simpson Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Taylor Simpson Fixes: a646e99cb90 ("Hexagon (target/hexagon) macros") Eliminate the following Coverity CIDs (Bad bit shift operation) 325227 325292 325425 325526 325561 325564 325578 325637 325736 325748 325786 325815 325837 Signed-off-by: Taylor Simpson Message-Id: <1614879425-9259-1-git-send-email-tsimpson@quicinc.com> Signed-off-by: Richard Henderson --- target/hexagon/macros.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.25.1 diff --git a/target/hexagon/macros.h b/target/hexagon/macros.h index 78c4efb5cb..cfcb8173ba 100644 --- a/target/hexagon/macros.h +++ b/target/hexagon/macros.h @@ -459,7 +459,7 @@ static inline void gen_logical_not(TCGv dest, TCGv src) : (fCAST##REGSTYPE##s(SRC) >> (SHAMT))) #define fASHIFTR(SRC, SHAMT, REGSTYPE) (fCAST##REGSTYPE##s(SRC) >> (SHAMT)) #define fLSHIFTR(SRC, SHAMT, REGSTYPE) \ - (((SHAMT) >= 64) ? 0 : (fCAST##REGSTYPE##u(SRC) >> (SHAMT))) + (((SHAMT) >= (sizeof(SRC) * 8)) ? 0 : (fCAST##REGSTYPE##u(SRC) >> (SHAMT))) #define fROTL(SRC, SHAMT, REGSTYPE) \ (((SHAMT) == 0) ? (SRC) : ((fCAST##REGSTYPE##u(SRC) << (SHAMT)) | \ ((fCAST##REGSTYPE##u(SRC) >> \ @@ -469,7 +469,7 @@ static inline void gen_logical_not(TCGv dest, TCGv src) ((fCAST##REGSTYPE##u(SRC) << \ ((sizeof(SRC) * 8) - (SHAMT)))))) #define fASHIFTL(SRC, SHAMT, REGSTYPE) \ - (((SHAMT) >= 64) ? 0 : (fCAST##REGSTYPE##s(SRC) << (SHAMT))) + (((SHAMT) >= (sizeof(SRC) * 8)) ? 0 : (fCAST##REGSTYPE##s(SRC) << (SHAMT))) #ifdef QEMU_GENERATE #define fLOAD(NUM, SIZE, SIGN, EA, DST) MEM_LOAD##SIZE##SIGN(DST, EA) From patchwork Sun Mar 7 01:39:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 395137 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp649267jai; Sat, 6 Mar 2021 17:41:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJwzxKnC4ixrwCoRp8huJeQYwU1lxKNJxcTlqJ2dAmnCT1QYszUYQLzAlfl8d/StyfP7Ol+Q X-Received: by 2002:a25:c506:: with SMTP id v6mr23845661ybe.266.1615081262151; Sat, 06 Mar 2021 17:41:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615081262; cv=none; d=google.com; s=arc-20160816; b=n6vBXMxYVshJin8buVhEhYgTO7xttLgqgWaTydL00qFM/0cUkvvf3liPW/9xdNPV8i rRmPiKjJo7erftHHn8iBHIHONL+IkN0EuE+rnGbDpPBHpXu9KluIfepxXr0gw8xFbP1H wJW8wdFhyjfgE/GuwaoWC3LYaHAZ+7CNIIGrzjV5Htfdp6cF1DDk0shT+vZ1SV2+vsf1 4LafIbvZVhpHetZOgNY+7rac7rVTT2BJ+ixcOMN5fYIG8nmdoay0rIIqeRsNVdC+g+o/ /4PJbiM33HccQW1R4txen+B4+E8Mo1yG7oDCKLkBjTChLoq2OE205aDjshgzWM/pIg7a RShw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=Sc7rk8ettr+S9MN89G8+BM9vNRym8SS0hmYWdOi7p4w=; b=cDdZIvCERe/PO2y5MOlo2bErc1bLRtDXGUQ1ihKuSN2rt4SFWhm55oLFuudiARF5ey RxGpLfPdLV7UZgq1QRw93+BXI2ZpFQQ95Fevcd6pej1iUGUQrYacC3xxejZIYvIWWGQS 2FY7joPT3FtWOA4PUa3gTC6Y3PeffDvhWZbnrIa1Uro+Intd3pd5ObyZJlOF5G6NDTlk KTDwWUAYV8CK08piojqw5vFkbTJwR//K3ZA07GtwPtlgI0/aGheJNaQKJVxw1+/jt6sG DqeLuR5TRkOBKfhqSaIe+vWAKSYu3Cg3Arjw1Ye7uIoQ9PS5sW/b679h5FNlUO9Fm6dq Ez+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=jRdoDb5e; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id y15si7116442ybr.361.2021.03.06.17.41.02 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 06 Mar 2021 17:41:02 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=jRdoDb5e; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:54778 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lIiPl-00031K-IB for patch@linaro.org; Sat, 06 Mar 2021 20:41:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54828) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lIiO0-0002vq-FL for qemu-devel@nongnu.org; Sat, 06 Mar 2021 20:39:12 -0500 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]:39272) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lIiNz-0005Oe-0I for qemu-devel@nongnu.org; Sat, 06 Mar 2021 20:39:12 -0500 Received: by mail-pl1-x632.google.com with SMTP id j6so3235075plx.6 for ; Sat, 06 Mar 2021 17:39:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Sc7rk8ettr+S9MN89G8+BM9vNRym8SS0hmYWdOi7p4w=; b=jRdoDb5eBA4KuGwJhwmBPMQfPG3SWWnGdFbePc5IFDwgJAysraD9rby/uyJOIpCUx/ VL1Ov6tVC1/gVNyDPAbsl9o0gKg20k+fOzS5WLfGwTcLePqos5iKEPQVfd/KLDhjDt0N XNlReiRiTj6QhabhNU+mGxeozhrUf555sVEQ6Wi2FTFTHHeEZhZFaftmW2RhcHTaeMM7 E8RsuHVeCNNufFzKZ4P0NA7J4oOn3wDo8jUHJ1w1GGCFACwJxXNsJ67yS3HB2DltxLZx IsoLTIQmTMlbw+46v8e7b/Jqfk6YarrFYm1LH3ZZ53BVyH/5L2PMs5pjooqqyHoJ+bsg 5UZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Sc7rk8ettr+S9MN89G8+BM9vNRym8SS0hmYWdOi7p4w=; b=Dmb2bDeIH5G31lk+Dt3GTYA0d960+Pp+G4vfXwlbCcVq8jAOXf7Dcv2/q8odXimQwP fPSuI0TeNXGDeRT3v3R8m7Dp8gJ13hb+7/7TOxJu5RL7fb1SDYaXZicfGlQvJtgmnH1X DiG8vXIkkA0eeDw5adfl3AyK3WbaMOHU9UOGlNnpI0tl1vhnj/eaT4NwDSfMB0HUVv0S Gz//nnppXPVUeObpsrfuFMmvLsxVJuLk8xU73BY9hnk+88fv0lZH8Oi/RYRrveV6Qs0M UoAUOpI7uuwxfc6IkICHzU9j03DEgbCiuMFXg8zo0xxi6nteAPxSwgdnjzWGdainhLIg WjOQ== X-Gm-Message-State: AOAM5303PcB4LiKofChE3qgsfe0rlW7EWilwTYkkaYj5B//BjY0uIkpS dSTQ9fMtT8dQU1bNQhV4F+HIT8AhLcsIow== X-Received: by 2002:a17:90a:5914:: with SMTP id k20mr17623358pji.199.1615081149688; Sat, 06 Mar 2021 17:39:09 -0800 (PST) Received: from localhost.localdomain ([71.212.131.83]) by smtp.gmail.com with ESMTPSA id v14sm6518044pju.19.2021.03.06.17.39.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Mar 2021 17:39:09 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 3/3] target/hexagon/opcodes: Add missing varargs cleanup Date: Sat, 6 Mar 2021 17:39:05 -0800 Message-Id: <20210307013905.115019-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210307013905.115019-1-richard.henderson@linaro.org> References: <20210307013905.115019-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::632; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x632.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Taylor Simpson , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé Fix a trivial incorrect usage of variable argument macros detected by Coverity (missing_va_end: va_end was not called for ap). Fixes: Coverity CID 1446720 (VARARGS) Fixes: e3c00c2ed75 ("Hexagon (target/hexagon) opcode data structures") Signed-off-by: Philippe Mathieu-Daudé Tested-by: Taylor Simpson Reviewed-by: Richard Henderson Reviewed-by: Taylor Simpson Message-Id: <20210223111253.2831285-1-f4bug@amsat.org> Signed-off-by: Richard Henderson --- target/hexagon/opcodes.c | 1 + 1 file changed, 1 insertion(+) -- 2.25.1 diff --git a/target/hexagon/opcodes.c b/target/hexagon/opcodes.c index 4eef5fc40f..35d790cdd5 100644 --- a/target/hexagon/opcodes.c +++ b/target/hexagon/opcodes.c @@ -82,6 +82,7 @@ static void init_attribs(int tag, ...) while ((attr = va_arg(ap, int)) != 0) { set_bit(attr, opcode_attribs[tag]); } + va_end(ap); } const OpcodeEncoding opcode_encodings[] = {