From patchwork Mon Apr 9 00:16:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Levin X-Patchwork-Id: 132997 Delivered-To: patch@linaro.org Received: by 10.46.84.29 with SMTP id i29csp784127ljb; Sun, 8 Apr 2018 21:13:26 -0700 (PDT) X-Google-Smtp-Source: AIpwx48U+jPnfG0hgw0/rQL4OeisNkh01XQzIEKm9c6moL1xLrxfM598b5PoCWHlx1nKVJ8vVKus X-Received: by 2002:a17:902:a50d:: with SMTP id s13-v6mr2502564plq.228.1523247206534; Sun, 08 Apr 2018 21:13:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523247206; cv=none; d=google.com; s=arc-20160816; b=azjBE5vN0Y5x4wVG80+MyZnW4VKSudWgVzoby9U1kVz9vljApxvnTlVG/nvxfGymn3 uZmxrwgEh6oclEPWr0w5g+1WI8GInx5yXlWi8aVbGKcv/wYkCtTDGYcy00nqFdaxJcS3 qA8Ow3mp9Yd8DdzjL/WFTzfjIqThAIAVCwDvMKyqRD4BxRl9ogSnkjYopIy9Fy0amb3/ aSgW6D6cIU9kTesLVBeYv0+Z6b6n1W1/2F+4R7cKy/pp7BX5rh464qUBqZOPN0KXqBeh 4rnQ0DRdGG+J9U2fyX0UzX7euldAs/oRQvuFHdDrSGKwkUMfLQcwT8vbjwOGrumVPDhg O43A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=wpoR6aEFW0THcWHCqIKyaixHijPUtSOlcI7d2SQ8BFs=; b=wO9PuLUBHHGPsrraHdEV91sYO4cYKFnAk3/XzeDTPFu8VyMPI5JZkfH7Av4w/5D+RC wIZk7Fx1i/i5wXs/w7M6xDsHdcBfk+WRoXtOTavHkKCq8ksuRa5JbeRJGxWHcvBLBRbN 5v5i2DpwWzQ1cG7wNStkARK5iwUKIF+NNxhpu3gugmJ7Ib6HCyqUqubXvni8A3e8vp7W LWGqCJ7kp+CTV7lcuZc75vCCLkxT+oyuxs3aGmE2DCeW1i7I8/cg+mk0Znfyp5Ps2Dek 8c+PdpPIrQ8O7Ui5QtsON8v0F/fHXRfOj/UzEF7MMJ7Oa31vR2ORrKdRohoBslydaGQv hI9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=JgwgKLsD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r62si12274578pfe.68.2018.04.08.21.13.26; Sun, 08 Apr 2018 21:13:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=JgwgKLsD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753459AbeDIENW (ORCPT + 29 others); Mon, 9 Apr 2018 00:13:22 -0400 Received: from mail-cys01nam02on0097.outbound.protection.outlook.com ([104.47.37.97]:28800 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751919AbeDIAQu (ORCPT ); Sun, 8 Apr 2018 20:16:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=wpoR6aEFW0THcWHCqIKyaixHijPUtSOlcI7d2SQ8BFs=; b=JgwgKLsDnozJbByi+zeLxLZm659nUieB25g43oDJayy9fen60FoSzw4/F0f2rITohIGpbzNdjKzpoqy05J2R5bdZTEUdgNgg6/f4A5AKgi+qY9eCYjLKuDqYwgRVRA5xfPascD/C6qU+8918p46R0/nd3i6lLBF3NQlbUGpUSSU= Received: from DM5PR2101MB1032.namprd21.prod.outlook.com (52.132.128.13) by DM5PR2101MB0968.namprd21.prod.outlook.com (52.132.133.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.696.0; Mon, 9 Apr 2018 00:16:47 +0000 Received: from DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8109:aef0:a777:7059]) by DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8109:aef0:a777:7059%2]) with mapi id 15.20.0696.003; Mon, 9 Apr 2018 00:16:47 +0000 From: Sasha Levin To: "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" CC: Marek Szyprowski , Guenter Roeck , Sasha Levin Subject: [PATCH AUTOSEL for 4.15 005/189] hwmon: (ina2xx) Fix access to uninitialized mutex Thread-Topic: [PATCH AUTOSEL for 4.15 005/189] hwmon: (ina2xx) Fix access to uninitialized mutex Thread-Index: AQHTz5gM+LNEjWCJgk+hNtVQwGKr6g== Date: Mon, 9 Apr 2018 00:16:47 +0000 Message-ID: <20180409001637.162453-5-alexander.levin@microsoft.com> References: <20180409001637.162453-1-alexander.levin@microsoft.com> In-Reply-To: <20180409001637.162453-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM5PR2101MB0968; 7:1r64KLPY4TikLiONMCmPhSmVwg5EKVZPdGpUJR8+QKEhncXpjjXqad0jT7NGdL2GEQ614veJW9qv9IH/K1MqOlcu36Sw/OD6G7mDbUlST4Wle09immVy58RRv8PyxH2rCss6IjCqmUSBIcgfofcMxMiStyIU6uN+nMIP2T85LsBSxbDrWOdYq+kH9/YKTk0ktvUfN6AG/Rru/AuM0/dfaEKsOe/Nhc78ZCzM0xPWj1AWVkDsBoyLOSOd/78kgrXA; 20:+bvBHvpVwWl/4u0WUD++g5IuZP/cAKhQKjPk7gXZQnzpuNe2ck2oa1gzwJrBkh2nBIkKUrs6t2MyJnKZEpYJgZVwLvrfqvFFJYYzeDpc2dsnGqDcVdmmoxKIOx0+A1+OE5+kNgifGFyVooRuD9K7OAM39sjVO4ffnXsNjEXy2eQ= x-ms-exchange-antispam-srfa-diagnostics: SOS; X-MS-Office365-Filtering-Correlation-Id: 52b8e0e1-2fd6-4421-1dfd-08d59daf2f1b x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(48565401081)(2017052603328)(7193020); SRVR:DM5PR2101MB0968; x-ms-traffictypediagnostic: DM5PR2101MB0968: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(7411616537696); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(61425038)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231221)(944501327)(52105095)(3002001)(10201501046)(6055026)(61426038)(61427038)(6041310)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123560045)(6072148)(201708071742011); SRVR:DM5PR2101MB0968; BCL:0; PCL:0; RULEID:; SRVR:DM5PR2101MB0968; x-forefront-prvs: 0637FCE711 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39860400002)(376002)(366004)(346002)(39380400002)(396003)(189003)(199004)(6486002)(53936002)(107886003)(81156014)(36756003)(10290500003)(6436002)(81166006)(5660300001)(478600001)(8936002)(8676002)(6512007)(106356001)(5890100001)(105586002)(5250100002)(2900100001)(7736002)(305945005)(2501003)(10090500001)(66066001)(25786009)(476003)(3846002)(6116002)(186003)(2616005)(59450400001)(68736007)(6506007)(486006)(14454004)(575784001)(86362001)(99286004)(26005)(102836004)(22452003)(76176011)(11346002)(2906002)(316002)(3660700001)(110136005)(97736004)(86612001)(3280700002)(1076002)(4326008)(446003)(54906003)(72206003)(22906009)(217873001); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR2101MB0968; H:DM5PR2101MB1032.namprd21.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: uL3z+2etXrbx8xfar2naHFRKpYSihHo7iSRda+M3xgMsmRsUC4vGSaOHIFfRKIWKgKCOUl3nt+x7wcL1PPzgcO8obQ2j0bBxHPEEnZDiZBsUJ1PnpSxOl71K12hKvni+AmWWFNgrStYhZ/Y2583XfMkwcmLG0fTD2yHTS2gG2KwJ0/j2+Rqn0WFFYpiU4PzQdbykEaIZvtmlEoaFXv9CzEu6lNmUb84nWuZrz+EwF/X8YOVezAtR7LIDOpfkaSssVgVbSJWeQGG69nryv2ge+L2jJi0i4u+RZRdPz76UECklhbMLLI4MOWG8llVCwajz6Q6twK2dnDiIWN7iaGGyS0dB9GRg7O25gKyFoCCg9t7EgyydQ9qDzNETXvz9XUWh6UMWbXMFGDUOuWTO3vTYyUlTQN0fcc54rL9c3l4p5tM= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 52b8e0e1-2fd6-4421-1dfd-08d59daf2f1b X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Apr 2018 00:16:47.6843 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB0968 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Marek Szyprowski [ Upstream commit 0c4c5860e9983eb3da7a3d73ca987643c3ed034b ] Initialize data->config_lock mutex before it is used by the driver code. This fixes following warning on Odroid XU3 boards: INFO: trying to register non-static key. the code is fine but needs lockdep annotation. turning off the locking correctness validator. CPU: 5 PID: 1 Comm: swapper/0 Not tainted 4.15.0-rc7-next-20180115-00001-gb75575dee3f2 #107 Hardware name: SAMSUNG EXYNOS (Flattened Device Tree) [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [] (show_stack) from [] (dump_stack+0x90/0xc8) [] (dump_stack) from [] (register_lock_class+0x1c0/0x59c) [] (register_lock_class) from [] (__lock_acquire+0x78/0x1850) [] (__lock_acquire) from [] (lock_acquire+0xc8/0x2b8) [] (lock_acquire) from [] (__mutex_lock+0x60/0xa0c) [] (__mutex_lock) from [] (mutex_lock_nested+0x1c/0x24) [] (mutex_lock_nested) from [] (ina2xx_set_shunt+0x70/0xb0) [] (ina2xx_set_shunt) from [] (ina2xx_probe+0x88/0x1b0) [] (ina2xx_probe) from [] (i2c_device_probe+0x1e0/0x2d0) [] (i2c_device_probe) from [] (driver_probe_device+0x2b8/0x4a0) [] (driver_probe_device) from [] (__driver_attach+0xfc/0x120) [] (__driver_attach) from [] (bus_for_each_dev+0x58/0x7c) [] (bus_for_each_dev) from [] (bus_add_driver+0x174/0x250) [] (bus_add_driver) from [] (driver_register+0x78/0xf4) [] (driver_register) from [] (i2c_register_driver+0x38/0xa8) [] (i2c_register_driver) from [] (do_one_initcall+0x48/0x18c) [] (do_one_initcall) from [] (kernel_init_freeable+0x110/0x1d4) [] (kernel_init_freeable) from [] (kernel_init+0x8/0x114) [] (kernel_init) from [] (ret_from_fork+0x14/0x20) Fixes: 5d389b125186 ("hwmon: (ina2xx) Make calibration register value fixed") Signed-off-by: Marek Szyprowski Signed-off-by: Guenter Roeck Signed-off-by: Sasha Levin --- drivers/hwmon/ina2xx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.15.1 diff --git a/drivers/hwmon/ina2xx.c b/drivers/hwmon/ina2xx.c index 62e38fa8cda2..a55823b52b2f 100644 --- a/drivers/hwmon/ina2xx.c +++ b/drivers/hwmon/ina2xx.c @@ -438,6 +438,7 @@ static int ina2xx_probe(struct i2c_client *client, /* set the device type */ data->config = &ina2xx_config[chip]; + mutex_init(&data->config_lock); if (of_property_read_u32(dev->of_node, "shunt-resistor", &val) < 0) { struct ina2xx_platform_data *pdata = dev_get_platdata(dev); @@ -467,8 +468,6 @@ static int ina2xx_probe(struct i2c_client *client, return -ENODEV; } - mutex_init(&data->config_lock); - data->groups[group++] = &ina2xx_group; if (id->driver_data == ina226) data->groups[group++] = &ina226_group; From patchwork Mon Apr 9 00:17:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Levin X-Patchwork-Id: 132943 Delivered-To: patch@linaro.org Received: by 10.46.84.29 with SMTP id i29csp636989ljb; Sun, 8 Apr 2018 17:18:44 -0700 (PDT) X-Google-Smtp-Source: AIpwx48c38Xoz8GbYyNiJFSTE3shX7nZ0ERoPJmWacx8ixXx+xMnsxb+lJpiI29zWjqk4kHjnuY9 X-Received: by 10.99.126.73 with SMTP id o9mr13617302pgn.168.1523233124038; Sun, 08 Apr 2018 17:18:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523233124; cv=none; d=google.com; s=arc-20160816; b=enSNFQRIk34R7s9wW87k5NOfHDfQeYzXINfY0Vz0INcz+z+Z8a3sxg41FPPBQhkEnU uWXY1lDNGivLTCijI14i/HrexLvB55eLB9BS3bm/gl3C3sIg00owT5FBGH7SA/9i+8zG aDv2L1OURlhiyzmgJ8KBYuockrEB+4VRu+6oBckVOkW4rAPfTIjYl1A99Z8dETJ98/Cv Bt8bcZ7BtMue7DSmWuEPESGgpkri6X9ea/6Ne+lQdOUhR2eyDa6FvBgM+ypNedTtms8m K9duJRBjwPqJFI0t45K8CE+GugF0ur8PSuMwL8A/XPdufXTwAauYpgKkatGa5m40NkRt gdaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=JrZlP1LNfCvfcFgx75Yp7WZLD1ONIdpNnq34ca9XnmA=; b=Xc1KaiennfG+ZJpJinwXj8feD+oF4RmZ/ZPctnWOiY9HwqjS1fhbk/L9WDRlmYHMs9 XjOyy9pXSSNKmvMEZjo1ItVzed85+0xf3LDbRij4XdH5Ym7+UO/sbp5UffjKE6aeUUtq Om+tiswMqkYkgVIIsFldTg0CfEStMKDKlBRBMh0p3OMxTrK+eBm5I2Lm0uFW0akZ29JP s6cLak+DE1XdsmoKhclNQbQTY9jfrd96ZBlgC5MSGVAq76BrklKsrD/WogDevdoeF+gZ TYhW1Vtv91sG+s4fqqNAV7zBBxIwqr2cYRLntODWCEEXT/eLmfgjtuoE2TxDECYcXbN5 EIPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=XYu0wb3r; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h23-v6si1201721plr.576.2018.04.08.17.18.43; Sun, 08 Apr 2018 17:18:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=XYu0wb3r; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753721AbeDIASk (ORCPT + 29 others); Sun, 8 Apr 2018 20:18:40 -0400 Received: from mail-bn3nam01on0092.outbound.protection.outlook.com ([104.47.33.92]:62923 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753651AbeDIASg (ORCPT ); Sun, 8 Apr 2018 20:18:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=JrZlP1LNfCvfcFgx75Yp7WZLD1ONIdpNnq34ca9XnmA=; b=XYu0wb3rMpSr588R8bBXcuOBmhEgLFzVHLTvKNaJWwVBfU/8oiBUhzqDL3O7nAkPooDCD0KAgAC5Ue0bAJdy2M+R2bbdm+XcZOnSV8spRX10tR13OMSwvMggWb3o6KJI7uy6p234D4Zsf7rR7Nf0l2IHBeA67EBASx6JHxmMwR8= Received: from DM5PR2101MB1032.namprd21.prod.outlook.com (52.132.128.13) by DM5PR2101MB1128.namprd21.prod.outlook.com (52.132.133.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.696.0; Mon, 9 Apr 2018 00:18:33 +0000 Received: from DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8109:aef0:a777:7059]) by DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8109:aef0:a777:7059%2]) with mapi id 15.20.0696.003; Mon, 9 Apr 2018 00:18:33 +0000 From: Sasha Levin To: "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" CC: Arnd Bergmann , "Martin K . Petersen" , Sasha Levin Subject: [PATCH AUTOSEL for 4.15 071/189] scsi: fas216: fix sense buffer initialization Thread-Topic: [PATCH AUTOSEL for 4.15 071/189] scsi: fas216: fix sense buffer initialization Thread-Index: AQHTz5gs2rk9mt+1K0WTigtL2+2RBA== Date: Mon, 9 Apr 2018 00:17:40 +0000 Message-ID: <20180409001637.162453-71-alexander.levin@microsoft.com> References: <20180409001637.162453-1-alexander.levin@microsoft.com> In-Reply-To: <20180409001637.162453-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM5PR2101MB1128; 7:ZhtAL8ao2esnzUJ030i0GtjVNp44e5UwhegzbnQU0LIrCHTvyqRI3adSoye8TJTUUQtm1/kL71uJnCFA6whWINRFn7cU9JpeYSGM1soyXgf6wwGJ381n+4CqqU42IqM50HacCrgv+Bi26r81BHyseYJCwmBnWeEA7DvQjXsdtG4/gfo2aTQ7iukj96gtCGiiioAJhOBEXyzQpf7Mvt+WngMFGKni0+S2RDkpLXHd8jV5jlIbIjnZogZakK1YoOp0; 20:F6VyFicORVU33qM4VoQVn/GYZsUnb2Kg6qcBtxZm4+VtOrJ/CbFl/J408QSYWLauL4+VoWN8o71FlV8Q3nZWLzftOz8JR6YIWW+L3Y3C+aQRH5Eozy5zmeO7djPr9sp9J6WchVrNFdNRoQO7WuYlN02Cz3Fr+7jNA23cNqHXRbs= x-ms-office365-filtering-ht: Tenant X-MS-Office365-Filtering-Correlation-Id: 0b481ede-335f-4308-6612-08d59daf6e56 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7193020); SRVR:DM5PR2101MB1128; x-ms-traffictypediagnostic: DM5PR2101MB1128: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(146099531331640); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(61425038)(6040522)(2401047)(8121501046)(5005006)(3231221)(944501327)(52105095)(3002001)(93006095)(93001095)(10201501046)(6055026)(61426038)(61427038)(6041310)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:DM5PR2101MB1128; BCL:0; PCL:0; RULEID:; SRVR:DM5PR2101MB1128; x-forefront-prvs: 0637FCE711 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(346002)(39860400002)(396003)(376002)(366004)(39380400002)(199004)(189003)(66066001)(86362001)(59450400001)(3660700001)(3280700002)(2900100001)(25786009)(36756003)(6506007)(76176011)(2906002)(6486002)(86612001)(99286004)(102836004)(1076002)(7736002)(97736004)(2616005)(446003)(486006)(11346002)(476003)(26005)(305945005)(6666003)(6512007)(4326008)(107886003)(478600001)(6436002)(5660300001)(10290500003)(5250100002)(22452003)(316002)(105586002)(186003)(8676002)(110136005)(54906003)(72206003)(53936002)(2501003)(68736007)(14454004)(6116002)(8936002)(3846002)(81156014)(10090500001)(106356001)(81166006)(22906009)(217873001); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR2101MB1128; H:DM5PR2101MB1032.namprd21.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: rwbVFjLdxV1BlPKscujAHKk+TZZQXFIuXE4RSaen42fZSuNN1QhznvBetPlVCJVJRLwAgcTGHaVMVpK8FyOclEiq38g2NCutQEDj/E9rPTPVLXypGyezIbP8TFeZxSEklR+Ql4egsDAEfpeaay5NFZm7KnV0aII9f5EBMwzlEBbFPWZ1SHMt4ZftTJ5YtDdCYVW8p3q9bIxEmRpQaFYMYAG3ZbpI3sQ0cKD+ynY+0l2SEPgDEaURRM+2XWKNRfAtfqmz6mpdtGVJxG5MI8Cma876y2WD08BSN8Lo3mJcdV9DSVeaEQQ2m0Nc71soz/o7WQKcJM1dyGIyiC1rlw7b9RM8yBtg6IDIoJwyQMy1ZFtp+bou+OPgl5y5oGNh7u98AT5utYIRlsEWAKriJdo9rW7xBJ/r4gZz7r53y7v8bQU= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0b481ede-335f-4308-6612-08d59daf6e56 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Apr 2018 00:17:40.9460 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB1128 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann [ Upstream commit 96d5eaa9bb74d299508d811d865c2c41b38b0301 ] While testing with the ARM specific memset() macro removed, I ran into a compiler warning that shows an old bug: drivers/scsi/arm/fas216.c: In function 'fas216_rq_sns_done': drivers/scsi/arm/fas216.c:2014:40: error: argument to 'sizeof' in 'memset' call is the same expression as the destination; did you mean to provide an explicit length? [-Werror=sizeof-pointer-memaccess] It turns out that the definition of the scsi_cmd structure changed back in linux-2.6.25, so now we clear only four bytes (sizeof(pointer)) instead of 96 (SCSI_SENSE_BUFFERSIZE). I did not check whether we actually need to initialize the buffer here, but it's clear that if we do it, we should use the correct size. Fixes: de25deb18016 ("[SCSI] use dynamically allocated sense buffer") Signed-off-by: Arnd Bergmann Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/arm/fas216.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.15.1 diff --git a/drivers/scsi/arm/fas216.c b/drivers/scsi/arm/fas216.c index f4775ca70bab..27bda2b05de6 100644 --- a/drivers/scsi/arm/fas216.c +++ b/drivers/scsi/arm/fas216.c @@ -2011,7 +2011,7 @@ static void fas216_rq_sns_done(FAS216_Info *info, struct scsi_cmnd *SCpnt, * have valid data in the sense buffer that could * confuse the higher levels. */ - memset(SCpnt->sense_buffer, 0, sizeof(SCpnt->sense_buffer)); + memset(SCpnt->sense_buffer, 0, SCSI_SENSE_BUFFERSIZE); //printk("scsi%d.%c: sense buffer: ", info->host->host_no, '0' + SCpnt->device->id); //{ int i; for (i = 0; i < 32; i++) printk("%02x ", SCpnt->sense_buffer[i]); printk("\n"); } /* From patchwork Mon Apr 9 00:18:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Levin X-Patchwork-Id: 132996 Delivered-To: patch@linaro.org Received: by 10.46.84.29 with SMTP id i29csp771174ljb; Sun, 8 Apr 2018 20:53:35 -0700 (PDT) X-Google-Smtp-Source: AIpwx48SKEqzxt+kzCceJRLOXpOzuIaG7gRs5+Ch6aU0cpGXE3V+G8dtoPJkKDVf4FT1VIW3YazW X-Received: by 10.167.129.129 with SMTP id g1mr27869331pfi.224.1523246015303; Sun, 08 Apr 2018 20:53:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523246015; cv=none; d=google.com; s=arc-20160816; b=U7skhYIFa4mG+EfphNWWfXxcOIO82m9KiW+kGlVVrAgABJfQjZu6VBma+Lo0mgKNyr xUyCDrsAI0l8gOuLgsLlMO1M9EKaZsUFUaRKP2a6oFDdT0iXaKC4EdiQaUV+IyKvoX1z Hyryb+iUuQHWQDVp30yLL8muFOeeA5ZYGwW7HmRWy4NOqJU2hjDe3jb38TWUv0OnxqgE hVdYwAHxv6kaSLk0aUX66Q+MYzGnZzeM7ONB4jTWwwyZd8uHRj20ddgXDOX29d6b0NRl kZ+aJC4EiP94AzAP61Hl/1MKAXFs/umtBwcjRwzkq+zcRrM4p2pyTD2QH+mmZiOxZBTs t5Ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=pe3yZLn92ADrupE1vncTN2YIdEgPXkxIC+qmx7csHv4=; b=UC1/wtUl22iFI2iZT+pBvPrp4r/l8uFShohqTJ8jcqKaqK4XmyyE2hLfN5VbDPoDft 8acF3HoRCh74O5GokumwhlLpGpwU21iBRCGN8Z5AgdH8p1pifIz/UuaxTtoyVkudYQAb XWX6RSvKIOJ7mG6YyVwM7CnrOlyZiMgKefHQYHhOtBZcYukPCjz3Y5eOIfnpLGow9Z4U mjL5yOhxWkaBXOdwmEPx7MTZL+cuq+DUZ/REkTb6PsPzkORn0Vv4djhIuPwTNAIRpOol dkTxPtz1sTARG0/Vqwlo2ZJnegItODV/Vx7Ch0pXc1o3qBljW0Yq7nZ+rBN14uqXTf1/ b53A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=CsVgWCIk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b3-v6si13713078plc.329.2018.04.08.20.53.35; Sun, 08 Apr 2018 20:53:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=CsVgWCIk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753990AbeDIATX (ORCPT + 29 others); Sun, 8 Apr 2018 20:19:23 -0400 Received: from mail-bn3nam01on0100.outbound.protection.outlook.com ([104.47.33.100]:20288 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753949AbeDIATU (ORCPT ); Sun, 8 Apr 2018 20:19:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=pe3yZLn92ADrupE1vncTN2YIdEgPXkxIC+qmx7csHv4=; b=CsVgWCIk1+c5V3qm6UV4uqQEj+zG+OLdKEkQIwlileWyizvIq48+sxPjWrybCrkRPN2lfUY7QISfPN6n2mHIeBBXB+GMBA3J0DAgDcYL1mextAJP/d9+Ap4ypnn3RtLeuM3lKP9IS3oKd7+Feeyy7hnjTRR+ldwBAHKc4v8rC98= Received: from DM5PR2101MB1032.namprd21.prod.outlook.com (52.132.128.13) by DM5PR2101MB1063.namprd21.prod.outlook.com (52.132.128.39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.696.0; Mon, 9 Apr 2018 00:19:16 +0000 Received: from DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8109:aef0:a777:7059]) by DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8109:aef0:a777:7059%2]) with mapi id 15.20.0696.003; Mon, 9 Apr 2018 00:19:16 +0000 From: Sasha Levin To: "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" CC: Corentin LABBE , Herbert Xu , Sasha Levin Subject: [PATCH AUTOSEL for 4.15 094/189] crypto: artpec6 - remove select on non-existing CRYPTO_SHA384 Thread-Topic: [PATCH AUTOSEL for 4.15 094/189] crypto: artpec6 - remove select on non-existing CRYPTO_SHA384 Thread-Index: AQHTz5g3I6r2LswkvECDSs+ktZi4qg== Date: Mon, 9 Apr 2018 00:18:00 +0000 Message-ID: <20180409001637.162453-94-alexander.levin@microsoft.com> References: <20180409001637.162453-1-alexander.levin@microsoft.com> In-Reply-To: <20180409001637.162453-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM5PR2101MB1063; 7:5Wu97CBjQAt5qRWEMtULlTWqcaaHJnUEPeOKWuGDmaGaIcwSMOaroyjk+Agz7z2fXrqhyGSvF9HNCO9/JWeMtsDUlrklsx/Jxa23LruNW9YfLn+0R/C2ZH0MLHO/18VA4LEUbOmgp252LhiYLR63gyYKMpr0cHURyPlMqImluHyysdqkjFLdkipup+5StfvoaN++/O+voMQ06nNjrDRI90PfpCATIHE/DVUVwm3l9U4eL4gxeGEv90+kuCvfiGKf; 20:FcspqvbzBS+KD+LDEthZoYSsHUMTwBw553zu8SVHVqg+8jLctCQIxM/im49JrlZfZf1RF0Vsxi7eqJ8frWX9ytfIAV8a/mqGqhGuoXKt4+x/jDPkqqtgIcugi7TD7IJ1i0rvFH0sznk/dUdXYst+tQykN0A+N2SzeXOxSiCX/Qk= x-ms-office365-filtering-ht: Tenant X-MS-Office365-Filtering-Correlation-Id: 88cea7ec-a6fb-432b-edd7-08d59daf87e1 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7193020); SRVR:DM5PR2101MB1063; x-ms-traffictypediagnostic: DM5PR2101MB1063: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(85827821059158); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(61425038)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231221)(944501327)(52105095)(3002001)(10201501046)(6055026)(61426038)(61427038)(6041310)(20161123558120)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011); SRVR:DM5PR2101MB1063; BCL:0; PCL:0; RULEID:; SRVR:DM5PR2101MB1063; x-forefront-prvs: 0637FCE711 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(346002)(39380400002)(39860400002)(376002)(396003)(366004)(189003)(199004)(52314003)(2900100001)(6436002)(7736002)(10090500001)(102836004)(3660700001)(6506007)(76176011)(305945005)(4326008)(5250100002)(97736004)(26005)(25786009)(6512007)(2906002)(81166006)(106356001)(107886003)(68736007)(14454004)(86612001)(66066001)(10290500003)(59450400001)(6666003)(5660300001)(81156014)(478600001)(476003)(486006)(6486002)(72206003)(3280700002)(99286004)(105586002)(36756003)(1076002)(2616005)(11346002)(53936002)(446003)(8676002)(186003)(3846002)(54906003)(6116002)(2501003)(8936002)(316002)(110136005)(86362001)(39060400002)(22452003)(22906009)(217873001); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR2101MB1063; H:DM5PR2101MB1032.namprd21.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 7fKVNRJAjOv8rWSnmIUwfJKoj8nR3TZCy0DfB0hnnhJAGW25dIaBLNliFCoY+M8h4Z4bXyYsV+ckMQTiXpZFMSvtt3ErHec7pMPkdZqta5Lw4ZRBko5XBUD4+jCyVLEkBn9QbGN4qhg7ap1GPfryI8my7eysmDbyj8x8SFxyrqQgp9r4hrt+4eaXE3835iIcrZYG8Tb9v4m+9QRQly9/LMTrTRYYc9ub1hI2/DfEqaYK/ZAIXRwPAtYXb55018SgaVS2rWAO2An7+icpoN17K8cl+tlEntxVnkt3aCThNBsRe3dpEZidrP2Cq8SivEVKmiv+UvnsKcIF96ur3rlLxCBFcOQNM9aOCgdZlHyMc3FqZOIVkvl4ykWUrM/QUePGSZ1ZakiRhzlrXB/rgbioMAD8Vv2R4XNl6IpV8JBE3To= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 88cea7ec-a6fb-432b-edd7-08d59daf87e1 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Apr 2018 00:18:00.1319 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB1063 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Corentin LABBE [ Upstream commit 980b4c95e78e4113cb7b9f430f121dab1c814b6c ] Since CRYPTO_SHA384 does not exists, Kconfig should not select it. Anyway, all SHA384 stuff is in CRYPTO_SHA512 which is already selected. Fixes: a21eb94fc4d3i ("crypto: axis - add ARTPEC-6/7 crypto accelerator driver") Signed-off-by: Corentin Labbe Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin --- drivers/crypto/Kconfig | 1 - 1 file changed, 1 deletion(-) -- 2.15.1 diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig index 47ec920d5b71..4b741b83e23f 100644 --- a/drivers/crypto/Kconfig +++ b/drivers/crypto/Kconfig @@ -723,7 +723,6 @@ config CRYPTO_DEV_ARTPEC6 select CRYPTO_HASH select CRYPTO_SHA1 select CRYPTO_SHA256 - select CRYPTO_SHA384 select CRYPTO_SHA512 help Enables the driver for the on-chip crypto accelerator From patchwork Mon Apr 9 00:18:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Levin X-Patchwork-Id: 132995 Delivered-To: patch@linaro.org Received: by 10.46.84.29 with SMTP id i29csp765575ljb; Sun, 8 Apr 2018 20:43:54 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/67GukbfyRK1jtEWBXk7zFtfSs7GozZaOMdNKN+gTizqw9gKEQb1aDdKjysXM+oPqXEVjo X-Received: by 10.99.100.68 with SMTP id y65mr24300656pgb.257.1523245433898; Sun, 08 Apr 2018 20:43:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523245433; cv=none; d=google.com; s=arc-20160816; b=f3tHyh7vehT56p9VnXTtA/cxxilEFdAl0CRhtv9gDIUWOw3Tq27LHaT2LeCw+ULphR j6hgdbEY28F9snUYCiZCUR8egmcLxkLRxUXm9/SVw+pj2tVqEshxA/XjzOKFmQZXoOt6 Tm6Ab9ayTmXFoe0Sgw4itQqHSHcVYPN497qSzlKkwebdNrcoZvl/Re0rxJkZfSm9nMoH 1/UFYU0nFgGR7K4/mxUfXwO0Cmk3rEFp0dLaoKw2cN/o/mlSYtV6367moARVYPzuY2MP igDNrLV1hHhby37YBIxcpvnrNap/0Eo8Gtl1oIW56JPx/5DwilrTawNXCxJXRtniwsIq FFQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=92LPbcuP1+Nu6hJ7JSAFmsZgtoYGVkr1KtL7T+wJ5YU=; b=jPEixXHV8GgBsDVGyabJ3mpzk1UeEtxKm20YR24SlpEtePEndecm4XJGZ0AeacaTwN sn8bLAj6rjKkj0bM7ZuiEc0TcwTGYKcExN5wWqEBfxT0m/Z7fx5QjfxVgdNn6q0FOLRI V7xQzVzIIRDq5t614tvj0IfW3JWmq4G+JfTr6/8PIP+rwWBFKbW8akVy8ukrFQWGLmwq sfE+WVjSrYvBXNe8xZenLKcwltBkH7sN5CmSs+N/tn6n18FGRNy99pa7Dh4VImqvJes/ ZBEH8fMTs0kOxWdx2lMz349yWLvm9/pewcuel+BSdLjQHzjL6/pGDvNEHT2oJXJ3aTfA KeSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=IJCJfXZ3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m11si10553633pgd.683.2018.04.08.20.43.53; Sun, 08 Apr 2018 20:43:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=IJCJfXZ3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754762AbeDIDns (ORCPT + 29 others); Sun, 8 Apr 2018 23:43:48 -0400 Received: from mail-cys01nam02on0118.outbound.protection.outlook.com ([104.47.37.118]:44776 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754235AbeDIAUb (ORCPT ); Sun, 8 Apr 2018 20:20:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=92LPbcuP1+Nu6hJ7JSAFmsZgtoYGVkr1KtL7T+wJ5YU=; b=IJCJfXZ3vVKkIN02LABs19UxNnng4+IGpBYOn8YO7pDWegfLB9YolzW1bXnBEpwPjjkfvjOaSejGSx18W6CtO7/nHhS2P2yEgWlktm8mzOeqsVs3RNJc83Wr3vz2h5bZT48Lj9wMuxRUcovX1npgMYedmTGOD1oPLMGrWghNgtc= Received: from DM5PR2101MB1032.namprd21.prod.outlook.com (52.132.128.13) by DM5PR2101MB1110.namprd21.prod.outlook.com (52.132.131.167) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.696.0; Mon, 9 Apr 2018 00:20:18 +0000 Received: from DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8109:aef0:a777:7059]) by DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8109:aef0:a777:7059%2]) with mapi id 15.20.0696.003; Mon, 9 Apr 2018 00:20:18 +0000 From: Sasha Levin To: "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" CC: Arnd Bergmann , Thomas Gleixner , Len Brown , Andi Kleen , Nicolas Pitre , "linux-pm@vger.kernel.org" , "Rafael J. Wysocki" , Pavel Machek , Bart Van Assche , Sasha Levin Subject: [PATCH AUTOSEL for 4.15 140/189] x86/power: Fix swsusp_arch_resume prototype Thread-Topic: [PATCH AUTOSEL for 4.15 140/189] x86/power: Fix swsusp_arch_resume prototype Thread-Index: AQHTz5hPI3hswFjA/UizBoQlW/Tn3Q== Date: Mon, 9 Apr 2018 00:18:40 +0000 Message-ID: <20180409001637.162453-140-alexander.levin@microsoft.com> References: <20180409001637.162453-1-alexander.levin@microsoft.com> In-Reply-To: <20180409001637.162453-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM5PR2101MB1110; 7:Xc71B+BMtMc7QBuc2F/KwJYX7vgBog4Wy1nipqUZY2exu2Nyg8Xwh9LVgAMGbICrBMoYDqlxzTx+UL8BSxQFou7CrnMCEm0OvTFn+dxupnt14l9AUOjveWSV9wHKsjNgjqpRQQXymOh/ilOb7gQ+vnUHyVnJRlKTYfKNrlb83GLRwwogyzTVRglsMdEyftKD94cb/30rif29Hv2UN/Xn7rknFCYiJWna4mSPBYWxQykecPTcBoo0I0TSTsZeFeUg; 20:kHFpjO/AxI7IuZNNJ/+gGvVlpeUnA+XD6o7pGl3/Tog5gVCNt8ze304VfI1uSTqWusewuTPeDjHzoToXB4od5eTY9w6jmR40OeCGrjLhgU1wuF4UiKxGAP5Babhmain4HG5DW66wIEiWbcZju0KWlXgGl45GkfoR9O53LZqTX/k= x-ms-office365-filtering-ht: Tenant X-MS-Office365-Filtering-Correlation-Id: 0a3e17fd-a309-4392-c8aa-08d59dafacca x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7193020); SRVR:DM5PR2101MB1110; x-ms-traffictypediagnostic: DM5PR2101MB1110: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(9452136761055)(42068640409301)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(61425038)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231221)(944501327)(52105095)(3002001)(10201501046)(6055026)(61426038)(61427038)(6041310)(20161123558120)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011); SRVR:DM5PR2101MB1110; BCL:0; PCL:0; RULEID:; SRVR:DM5PR2101MB1110; x-forefront-prvs: 0637FCE711 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(376002)(366004)(346002)(396003)(39380400002)(39860400002)(199004)(189003)(5660300001)(7416002)(478600001)(86612001)(3846002)(6116002)(106356001)(6486002)(72206003)(25786009)(10290500003)(8936002)(6436002)(76176011)(2616005)(6506007)(2900100001)(97736004)(486006)(26005)(36756003)(10090500001)(81166006)(8676002)(81156014)(59450400001)(102836004)(2906002)(99286004)(11346002)(476003)(3660700001)(66066001)(6512007)(575784001)(86362001)(6306002)(53936002)(966005)(105586002)(186003)(5250100002)(14454004)(22452003)(6666003)(2501003)(446003)(7736002)(316002)(1076002)(110136005)(3280700002)(54906003)(68736007)(107886003)(4326008)(305945005)(22906009)(217873001); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR2101MB1110; H:DM5PR2101MB1032.namprd21.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: uvaZff6Vft6rNCqIL/JyAlTBIT3IeGuyhgFZfzcIvPQGbCv1DynfMg+WUvidXf6ZTkj8y1X9BcL9/BXjYeozvsdqSUON3Oc7PgzFNvaq/HwTHQO54noksnNoO1e96Z8PB8swnXkBswLPIZ4jBl+Gv++SG4qbBRT2EdNg3M3+mtbrmnD9dZE4JjQM0OesMRimj8wcc0jO+36RsW+XfVhc/kkiCBNZj82IJLfr7ZdFXaa8Xrxymp9OOaXjrH2KPJq0/XfZE8ErgsIzbWElwNDDbMEFi3KQax5+OH5RJExf/PTumwvR3ddeDTbH4/A9bXftcnqCDG5U3gL6fPu38T28zqXnSUI5nXXABvsi+TxswOvfYz5E0tA94UvzMidyTx+DLxL1mienga2JFTKwBT3pD8JBPz9IS/rnfh5P1x1y1aI= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0a3e17fd-a309-4392-c8aa-08d59dafacca X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Apr 2018 00:18:40.3470 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB1110 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann [ Upstream commit 328008a72d38b5bde6491e463405c34a81a65d3e ] The declaration for swsusp_arch_resume marks it as 'asmlinkage', but the definition in x86-32 does not, and it fails to include the header with the declaration. This leads to a warning when building with link-time-optimizations: kernel/power/power.h:108:23: error: type of 'swsusp_arch_resume' does not match original declaration [-Werror=lto-type-mismatch] extern asmlinkage int swsusp_arch_resume(void); ^ arch/x86/power/hibernate_32.c:148:0: note: 'swsusp_arch_resume' was previously declared here int swsusp_arch_resume(void) This moves the declaration into a globally visible header file and fixes up both x86 definitions to match it. Signed-off-by: Arnd Bergmann Signed-off-by: Thomas Gleixner Cc: Len Brown Cc: Andi Kleen Cc: Nicolas Pitre Cc: linux-pm@vger.kernel.org Cc: "Rafael J. Wysocki" Cc: Pavel Machek Cc: Bart Van Assche Link: https://lkml.kernel.org/r/20180202145634.200291-2-arnd@arndb.de Signed-off-by: Sasha Levin --- arch/x86/power/hibernate_32.c | 2 +- arch/x86/power/hibernate_64.c | 2 +- include/linux/suspend.h | 2 ++ kernel/power/power.h | 3 --- 4 files changed, 4 insertions(+), 5 deletions(-) -- 2.15.1 diff --git a/arch/x86/power/hibernate_32.c b/arch/x86/power/hibernate_32.c index c35fdb585c68..afc4ed7b1578 100644 --- a/arch/x86/power/hibernate_32.c +++ b/arch/x86/power/hibernate_32.c @@ -145,7 +145,7 @@ static inline void resume_init_first_level_page_table(pgd_t *pg_dir) #endif } -int swsusp_arch_resume(void) +asmlinkage int swsusp_arch_resume(void) { int error; diff --git a/arch/x86/power/hibernate_64.c b/arch/x86/power/hibernate_64.c index f910c514438f..0ef5e5204968 100644 --- a/arch/x86/power/hibernate_64.c +++ b/arch/x86/power/hibernate_64.c @@ -174,7 +174,7 @@ out: return 0; } -int swsusp_arch_resume(void) +asmlinkage int swsusp_arch_resume(void) { int error; diff --git a/include/linux/suspend.h b/include/linux/suspend.h index d60b0f5c38d5..8544357d92d0 100644 --- a/include/linux/suspend.h +++ b/include/linux/suspend.h @@ -384,6 +384,8 @@ extern int swsusp_page_is_forbidden(struct page *); extern void swsusp_set_page_free(struct page *); extern void swsusp_unset_page_free(struct page *); extern unsigned long get_safe_page(gfp_t gfp_mask); +extern asmlinkage int swsusp_arch_suspend(void); +extern asmlinkage int swsusp_arch_resume(void); extern void hibernation_set_ops(const struct platform_hibernation_ops *ops); extern int hibernate(void); diff --git a/kernel/power/power.h b/kernel/power/power.h index f29cd178df90..9e58bdc8a562 100644 --- a/kernel/power/power.h +++ b/kernel/power/power.h @@ -104,9 +104,6 @@ extern int in_suspend; extern dev_t swsusp_resume_device; extern sector_t swsusp_resume_block; -extern asmlinkage int swsusp_arch_suspend(void); -extern asmlinkage int swsusp_arch_resume(void); - extern int create_basic_memory_bitmaps(void); extern void free_basic_memory_bitmaps(void); extern int hibernate_preallocate_memory(void); From patchwork Mon Apr 9 00:18:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Levin X-Patchwork-Id: 132994 Delivered-To: patch@linaro.org Received: by 10.46.84.29 with SMTP id i29csp765518ljb; Sun, 8 Apr 2018 20:43:48 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+7gA1QUIBm6LeAXYbl9PvEzD7niSOT0EgxX+4BaapVkEQyxLYItxVxsC0jTpFwMoxGxiWn X-Received: by 10.101.65.195 with SMTP id b3mr23895670pgq.118.1523245428638; Sun, 08 Apr 2018 20:43:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523245428; cv=none; d=google.com; s=arc-20160816; b=eFjT5dA9FaG3TQJJ2kJgbZnZSHvmvgwBYtbfDxEjjBCvFBMxuPAde3ZghQHl2xfcoq Do3tJPS/v8ar3AwzIfhzogalsNLiQl8v73w0YwCMdReR0+RHSvFWYlupdaUhLxEcqB4O 7hK+HtyH1onw88A1V4A9lI4JARBve3KyOXPAgAE8jyvo1MWmjEMgtpLTDosd06gS8zkd jwxM6R8I22fh+MXwoakehXjUvAfH64kiK5HnAyFiKVk/BS3NaaQb+cZE4s6ZomTrvKhz gAlkz6jxELri/sVZJ6jV9GCJVbR1In2/8oxcivB+j2ZhvFLMCXFrevBfqdtm929W9Tnk efNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=kEbeKIWgUCGqWIDBLL4m+5ADVnQGu8x9ekPXTk31yvc=; b=sygf9xgeZdcEd0tsRMXR1dcjnjF4k0XlQJDFDrropcHcnre8jtu1Tc6p+IfNzx3sml AMMvEh2Nrk8m6Mt2ZSa7y1Eo2rR/eMu4lk7jtp4UNeuAf+Y7XTYxkQQPb+WK67tGE3tj eyvKq2hAeLcZdG5aXEyNHAv6s30kNv66hCKUzgHVQghxywWsprngjYLoiVxJ3AoOTABi Q6Mbw5UjqWWuyjg6bdqpJwaoe31A9LzZ+eRlMxFRllE2N95xBIO3b0p3rkmTRijPYoc8 noUIu4Woyw9Ix/jTyfRxoJrZWpujCiC6QAoOnHCBnVgxoA7tzXgwL2nvjCQTPCO3kxl3 +Ipw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=HjhCEDxI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a92-v6si16132221pla.107.2018.04.08.20.43.48; Sun, 08 Apr 2018 20:43:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=HjhCEDxI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754744AbeDIDno (ORCPT + 29 others); Sun, 8 Apr 2018 23:43:44 -0400 Received: from mail-cys01nam02on0123.outbound.protection.outlook.com ([104.47.37.123]:10471 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754237AbeDIAUc (ORCPT ); Sun, 8 Apr 2018 20:20:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=kEbeKIWgUCGqWIDBLL4m+5ADVnQGu8x9ekPXTk31yvc=; b=HjhCEDxIRBctTFsIwTA5LFbElR73MZZQC3cKH3Na8r4YFhw6QQ1NK9I9oFv9+gCUQw6MEZQZ5DMW46paYrnsTBnOg6bt0DDIdImCl4IADK8A1e0hKeA9xpC2/w7+WfVIgEGXkHBUuzu9C2w2Xb9/iL/MbBaG/ooS9EYLafN/Vls= Received: from DM5PR2101MB1032.namprd21.prod.outlook.com (52.132.128.13) by DM5PR2101MB1110.namprd21.prod.outlook.com (52.132.131.167) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.696.0; Mon, 9 Apr 2018 00:20:19 +0000 Received: from DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8109:aef0:a777:7059]) by DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8109:aef0:a777:7059%2]) with mapi id 15.20.0696.003; Mon, 9 Apr 2018 00:20:19 +0000 From: Sasha Levin To: "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" CC: Arnd Bergmann , Thomas Gleixner , Andi Kleen , Nicolas Pitre , Peter Zijlstra , Dave Hansen , Andy Lutomirski , Josh Poimboeuf , Borislav Petkov , Vlastimil Babka , Sasha Levin Subject: [PATCH AUTOSEL for 4.15 141/189] x86/dumpstack: Avoid uninitlized variable Thread-Topic: [PATCH AUTOSEL for 4.15 141/189] x86/dumpstack: Avoid uninitlized variable Thread-Index: AQHTz5hQkVxYcYH2SkeekWG29rcgqA== Date: Mon, 9 Apr 2018 00:18:41 +0000 Message-ID: <20180409001637.162453-141-alexander.levin@microsoft.com> References: <20180409001637.162453-1-alexander.levin@microsoft.com> In-Reply-To: <20180409001637.162453-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM5PR2101MB1110; 7:q56VWK8qEWi82wX/ge/P5/1bctzcJNIY0mxw8Q2ZDHrGP8g741eyOHZ7b7DdcdTIewYfUPuX/XzCBagbHRYmO1Xumc0WabPjv+I6fh/SqvTvpKF/QHOGXyA+F1yH7oq5NMvn0N3hpfL4bpds1Ad/Z7GjXt0EhwXDrLDw3FBFCfTidLr3OXSi6nDW/2/JHLxINqym7rVLF7QzZ2B5eKG6BJ/jhUwZP1jZ4+TGJYIOAYwDpQ8I4mG7Hl/S/oUT5UFw; 20:DWegGj13jVKgwt/mjaRMXx0zfwUDjGFXCmgqUFjoq5BaQAv+eToAQmjVG78sp29Hg5hQtdbr4MrNpGaiKzjfRQDu9j1hUGpl/vfAB8VXUcF+E0gELuJqzMee99GmbG8QIvdLKS9SGo1KOAankFxv1xIaP/7jt7PdflVNVfbRggk= x-ms-office365-filtering-ht: Tenant X-MS-Office365-Filtering-Correlation-Id: fcaffa6d-2c1b-4ad1-9b63-08d59dafad3f x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7193020); SRVR:DM5PR2101MB1110; x-ms-traffictypediagnostic: DM5PR2101MB1110: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(42068640409301)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(61425038)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231221)(944501327)(52105095)(3002001)(10201501046)(6055026)(61426038)(61427038)(6041310)(20161123558120)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011); SRVR:DM5PR2101MB1110; BCL:0; PCL:0; RULEID:; SRVR:DM5PR2101MB1110; x-forefront-prvs: 0637FCE711 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(376002)(366004)(346002)(396003)(39380400002)(39860400002)(199004)(189003)(5660300001)(7416002)(478600001)(86612001)(3846002)(6116002)(106356001)(6486002)(72206003)(25786009)(10290500003)(8936002)(6436002)(76176011)(2616005)(6506007)(2900100001)(97736004)(486006)(26005)(36756003)(10090500001)(81166006)(8676002)(81156014)(59450400001)(102836004)(2906002)(99286004)(11346002)(476003)(3660700001)(66066001)(6512007)(575784001)(86362001)(6306002)(53936002)(966005)(105586002)(186003)(5250100002)(14454004)(22452003)(6666003)(2501003)(446003)(7736002)(316002)(1076002)(110136005)(3280700002)(54906003)(68736007)(107886003)(4326008)(305945005)(22906009)(217873001); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR2101MB1110; H:DM5PR2101MB1032.namprd21.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: k6qSu3NdU4WRY0OPAIxU0Hbgu2uuW4TfxOuMmTk+otnsS8aXC6JEt765NRzxZPKTPrjpFPOLTYmA7X+cmEYT8fqAt8mCsNH6MR9ehklMYX9qQujG++Z/DTMN5ITS5nMzeA8ffj2FEhcHiAjZDZodiFbTe7ZEZFXkf7/gBc0oO3yWrJu+8n/N62VDtyBEW/1HARcRzJaR8s45KqMJsfCvjdijbyYoT026D14WC0KPxrOKP4Ok8ozaKMsCOupr8vJS5vGozN/+1MCfivGzN9Mr7yw4IAxfbvpXZj5BYaG1DDRchWMHTXq1Xt6+O/FRP/a3JTWQx0/U/XG5vWYAYOq57AMUscnCZjMcUTHewTGUh+LLZ7/2huOEBHgW9DK7hUEsgMrQpiIkrVDjRY0JmMRwvAPBaP2iJYwVcUDmEdcwY10= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: fcaffa6d-2c1b-4ad1-9b63-08d59dafad3f X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Apr 2018 00:18:41.6282 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB1110 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann [ Upstream commit ebfc15019cfa72496c674ffcb0b8ef10790dcddc ] In some configurations, 'partial' does not get initialized, as shown by this gcc-8 warning: arch/x86/kernel/dumpstack.c: In function 'show_trace_log_lvl': arch/x86/kernel/dumpstack.c:156:4: error: 'partial' may be used uninitialized in this function [-Werror=maybe-uninitialized] show_regs_if_on_stack(&stack_info, regs, partial); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ This initializes it to false, to get the previous behavior in this case. Fixes: a9cdbe72c4e8 ("x86/dumpstack: Fix partial register dumps") Signed-off-by: Arnd Bergmann Signed-off-by: Thomas Gleixner Cc: Andi Kleen Cc: Nicolas Pitre Cc: Peter Zijlstra Cc: Dave Hansen Cc: Andy Lutomirski Cc: Josh Poimboeuf Cc: Borislav Petkov Cc: Vlastimil Babka Link: https://lkml.kernel.org/r/20180202145634.200291-1-arnd@arndb.de Signed-off-by: Sasha Levin --- arch/x86/kernel/dumpstack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.15.1 diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c index afbecff161d1..a2d8a3908670 100644 --- a/arch/x86/kernel/dumpstack.c +++ b/arch/x86/kernel/dumpstack.c @@ -109,7 +109,7 @@ void show_trace_log_lvl(struct task_struct *task, struct pt_regs *regs, struct stack_info stack_info = {0}; unsigned long visit_mask = 0; int graph_idx = 0; - bool partial; + bool partial = false; printk("%sCall Trace:\n", log_lvl); From patchwork Mon Apr 9 00:18:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Levin X-Patchwork-Id: 132993 Delivered-To: patch@linaro.org Received: by 10.46.84.29 with SMTP id i29csp764159ljb; Sun, 8 Apr 2018 20:41:26 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+rK2yAnUW3u5CnX0sCOFSVBkXWdNSg3fFuy2ACsvxrNS4lEueg9svHLxyt5z1vgc1xrl5o X-Received: by 2002:a17:902:5681:: with SMTP id j1-v6mr37239237pli.383.1523245286242; Sun, 08 Apr 2018 20:41:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523245286; cv=none; d=google.com; s=arc-20160816; b=WZcW0GadvocnY6H8FNhY1Frq6he682daw79lyj9LwvTKRLDKzPW3rsQMcajs3vkoV6 RzS/TNOzcV6N1jBPLyL5z/6TjTb2IVyChvV+AtQTe+hwf9ybAoFcd87PPmoWGvABu/UW ut7OSUxGoqqpUpzLsV79iv0Qbe33imlXhnhVrdZ2/m5zjOc9rrFL7fXwbY9gDBzYNX/n F+iUBu5sTdR1dZuMzc3gSYPoOgcFo3u/q8q3k/hYOroC0KZJJexkMPQjYkDP4PiOGzXm SmemY+tSCi5LyGtMmSwa5DuRY/yeID+YVlHF8bZNrS4avhnYNnbCIXzZhMiZPHwkNw0e R6nA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=EI7gpy5sJQCccRlKHxeKKWWWMnOip8HrDdweQE4PcNc=; b=R/lLbEIdOL0IlA4lFivMZfK2Q0Jjypg9ISbHaZWOxMspjsSlUQV6LgS+PROPVOgIi3 FE3Mf5On+wbiTvR3lx/x4ay17kcDH6zxRVSbWMo5p55pr8VUCBPb2Ad4YSvLL5i7SGJs aK0nueKRIn0mZiFLURriV9zKvlMFrAJF7KBP2c0WuMyHCYwnxXjhrHi6JUrIOhXtHqbf YX2AsOYDozyvDyusH1emXp9EB0/3XvNtgDNeH21zialKp/eJBqOpKnh3ANMft2vgw4cE eiUhE2XiHSBO0io8yNLrCtZOcF2CEGajHhv81pcj705KXiG9yYQxK8UEMoCEgeBBRyXh DrOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=XmwsSsUN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q1-v6si13365570plb.349.2018.04.08.20.41.25; Sun, 08 Apr 2018 20:41:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=XmwsSsUN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754529AbeDIDkz (ORCPT + 29 others); Sun, 8 Apr 2018 23:40:55 -0400 Received: from mail-sn1nam01on0130.outbound.protection.outlook.com ([104.47.32.130]:47481 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753095AbeDIAVG (ORCPT ); Sun, 8 Apr 2018 20:21:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=EI7gpy5sJQCccRlKHxeKKWWWMnOip8HrDdweQE4PcNc=; b=XmwsSsUN1EZ3yEdj6RrP5eUxwd/mKpP54pyIkZlQHzj3pgdt1dNDYqM0NhV1vihyTwMkJ/0+3otYqwxl85RAJWLNHhpSOtuhHLBWzbZwiJCAAYQ2K5Kt3hLPa23hJ73xiOzldGsid4gCYrib18n7Ziv2j+c+4laIHQDJNHeip/Q= Received: from DM5PR2101MB1032.namprd21.prod.outlook.com (52.132.128.13) by DM5PR2101MB0920.namprd21.prod.outlook.com (52.132.132.165) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.696.0; Mon, 9 Apr 2018 00:21:00 +0000 Received: from DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8109:aef0:a777:7059]) by DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8109:aef0:a777:7059%2]) with mapi id 15.20.0696.003; Mon, 9 Apr 2018 00:21:00 +0000 From: Sasha Levin To: "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" CC: Will Deacon , Catalin Marinas , Sasha Levin Subject: [PATCH AUTOSEL for 4.15 156/189] arm64: spinlock: Fix theoretical trylock() A-B-A with LSE atomics Thread-Topic: [PATCH AUTOSEL for 4.15 156/189] arm64: spinlock: Fix theoretical trylock() A-B-A with LSE atomics Thread-Index: AQHTz5hXrnHqT7NipEi+j2IpHQkKWQ== Date: Mon, 9 Apr 2018 00:18:53 +0000 Message-ID: <20180409001637.162453-156-alexander.levin@microsoft.com> References: <20180409001637.162453-1-alexander.levin@microsoft.com> In-Reply-To: <20180409001637.162453-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM5PR2101MB0920; 7:KSL+az0CvQISkJdcK3UohJ1kYS+DJNXPsk+F8s2ijjZYt/VngH1vRUDjcqpSV4JlD7E6fzBMmQ1Nx0hG0ckfX2U8IRaEpbHuz6FlJGUou2mpR1Af7uv/6I/JCgY7qZOewYrEjDK/Qm83LJGCcmfKWNcCnn5NvXvGU7zFrEiLEQJRARclwuQyozL87aRcZ4f0u6EqBXLgIQQOhjn9RFBtKkvHRcAKSFeoKg2+8EJVWpvfIP/AEb9seXaCfdi7kJ4w; 20:HlFQHDpy76vi/y81noRsdiR/MGHg1CswWc68oYq6JxKKFchHlOfkxUnNzI+ERMq2Bwjst7RJro9vC5tvGbZsA5QJ/0iv5OWWUDAv9ullZ+XEiCjxHHwfnUap/iaaA4ESKwdm+EMjMw2CvmnqdXwGZMYVqRJZN/J3f4YDdIlR/A8= X-MS-Office365-Filtering-Correlation-Id: f48875b7-4507-4501-b416-08d59dafc5a3 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(48565401081)(2017052603328)(7193020); SRVR:DM5PR2101MB0920; x-ms-traffictypediagnostic: DM5PR2101MB0920: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(180628864354917)(89211679590171); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(61425038)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231221)(944501327)(52105095)(3002001)(10201501046)(6055026)(61426038)(61427038)(6041310)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123560045)(6072148)(201708071742011); SRVR:DM5PR2101MB0920; BCL:0; PCL:0; RULEID:; SRVR:DM5PR2101MB0920; x-forefront-prvs: 0637FCE711 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39860400002)(39380400002)(396003)(366004)(346002)(376002)(199004)(189003)(66066001)(86362001)(59450400001)(3660700001)(3280700002)(25786009)(76176011)(2900100001)(36756003)(6506007)(2906002)(99286004)(86612001)(6486002)(102836004)(305945005)(1076002)(7736002)(575784001)(97736004)(2616005)(446003)(11346002)(476003)(486006)(26005)(6666003)(6512007)(4326008)(107886003)(5660300001)(478600001)(6436002)(105586002)(10290500003)(5250100002)(22452003)(316002)(186003)(8676002)(110136005)(81166006)(54906003)(6116002)(8936002)(72206003)(53936002)(2501003)(3846002)(68736007)(14454004)(81156014)(10090500001)(106356001)(22906009)(217873001); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR2101MB0920; H:DM5PR2101MB1032.namprd21.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: WyjfvOSQtdTAI7yQScZF0qo/5LXZ/4+l3RxFaop5EXBuOBMqoToaCgzUPZm3REhM/QdGf/ksBc8ItkU2Lbyrr6v8f6mNQ3tusTfI23L91FZmv9he92axoWQrFn1FJf4lyZQeAX2rAQRf4hxUWQsKPG/1ZyHCKxHKBsAMboBFmEmed9bvB6nhGZsZkLivkiq084SbYvqFteEzdDXzCMRqTui9ZN1Fm2yc0oCWuJuO6VornsmcP5ZxNVQP6hNVwUKbMzxR5nEQbDkcCSDtuHfi4yru+FoPDlys48M+gUUIT3oRTDRf0f4cCuHPiRTy6GD8Ln6fD9/iNbsN2u6HECpBoJCPD3qZo0MLmC3m/1LWRmgNo7R4oi+PoXbkVuG2pevQWDTAMzdGct4cM64nBCZIYlw+pOXUDesLa+r9e1Kd1SM= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: f48875b7-4507-4501-b416-08d59dafc5a3 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Apr 2018 00:18:53.7214 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB0920 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Will Deacon [ Upstream commit 202fb4ef81e3ec765c23bd1e6746a5c25b797d0e ] If the spinlock "next" ticket wraps around between the initial LDR and the cmpxchg in the LSE version of spin_trylock, then we can erroneously think that we have successfuly acquired the lock because we only check whether the next ticket return by the cmpxchg is equal to the owner ticket in our updated lock word. This patch fixes the issue by performing a full 32-bit check of the lock word when trying to determine whether or not the CASA instruction updated memory. Reported-by: Catalin Marinas Signed-off-by: Will Deacon Signed-off-by: Catalin Marinas Signed-off-by: Sasha Levin --- arch/arm64/include/asm/spinlock.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.15.1 diff --git a/arch/arm64/include/asm/spinlock.h b/arch/arm64/include/asm/spinlock.h index fdb827c7832f..ebdae15d665d 100644 --- a/arch/arm64/include/asm/spinlock.h +++ b/arch/arm64/include/asm/spinlock.h @@ -87,8 +87,8 @@ static inline int arch_spin_trylock(arch_spinlock_t *lock) " cbnz %w1, 1f\n" " add %w1, %w0, %3\n" " casa %w0, %w1, %2\n" - " and %w1, %w1, #0xffff\n" - " eor %w1, %w1, %w0, lsr #16\n" + " sub %w1, %w1, %3\n" + " eor %w1, %w1, %w0\n" "1:") : "=&r" (lockval), "=&r" (tmp), "+Q" (*lock) : "I" (1 << TICKET_SHIFT) From patchwork Mon Apr 9 00:18:55 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Levin X-Patchwork-Id: 132992 Delivered-To: patch@linaro.org Received: by 10.46.84.29 with SMTP id i29csp759842ljb; Sun, 8 Apr 2018 20:34:13 -0700 (PDT) X-Google-Smtp-Source: AIpwx49FpcwLHsjlu458m6KqgxI1ASAiKYA/gQVpTlxO0m1BG8zPAf0AAZoD2dL3CUOF8/EushxS X-Received: by 10.99.7.138 with SMTP id 132mr23923761pgh.45.1523244852835; Sun, 08 Apr 2018 20:34:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523244852; cv=none; d=google.com; s=arc-20160816; b=pOSjBWk6QjXgGck4JjQvjFbGiv+IvfyjEeHTKyurJTrfPHZaHzoMCKWnKTBNbdasIv KkhR/dUzaHTGnkeiaxnF5PQINhhS1s8EDpiMrxrQr3FhzvV1XPkJuvhP2stLRqxOvi3g haqSDRcyS/wPzGOgHmUU1JHB2+69q1ytyyaHj/qMoasksd7QOt1Hs3V19OHCdkADSftF KSUSwW1ut9nUhuefQhqQjt7c5g6+ld0Qc/MB4gQczU1gJ+3YafaqpgFmflTez6atqMzV ATx7KwevH00YTD0i7/5S+5Q5ZG67J4kbtykcBv6bXRGm9Cd78ounX1e6ES4XCfmsk8Sz 2OlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=1mmgCQVKYJ8unkZxMp+zJXj6A4XQ1G7IVwhrwBSjv8Y=; b=EbpJBhhHsBY6kGG23Ol57NN6bNSnjdRNF0kdG5mg6JMEp5Ju/P5S439NRBIrl3pLaP BSSGWEwNNOBtP4vYzzESVk1O0uMIgb3XgMY58UhZrX+izDobo6rD7CUMdbzJuCyd9Hho kbkkZYQw0Xk4JDYQI1q7XcsEFkNbR68JS3IboBcxAOeQ+cA6POgFEQbDcd0Cyxvms5wV +722AugKVdymkcA78CXF7qKJjR7OEK7+9Uz7KgXWzFxVqjN3haHrXa+P2tdZKMUTL79T ue7cFJnk1nqOWDdEEgzKotvMaEXRQ9ofkrtHCumzWlZbUhXGjGDkC44yHoRGTeTGepGt hW6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=J3wIFTqg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m1-v6si16057090plt.363.2018.04.08.20.34.12; Sun, 08 Apr 2018 20:34:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=J3wIFTqg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754440AbeDIAVS (ORCPT + 29 others); Sun, 8 Apr 2018 20:21:18 -0400 Received: from mail-sn1nam01on0114.outbound.protection.outlook.com ([104.47.32.114]:12752 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754377AbeDIAVI (ORCPT ); Sun, 8 Apr 2018 20:21:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=1mmgCQVKYJ8unkZxMp+zJXj6A4XQ1G7IVwhrwBSjv8Y=; b=J3wIFTqgK5Gus52Dl3LPscQp9hTVL1fdU1/W/5g1OHXHomAG8zyIXdNlcfTtdGihCbcc9CMw3ZKvloVRXRISaTihtZHvJgzmgMWQqUIIbPEEFSIVyW0ZLdiiqK6sbJFMxWb/bTFJG7nDmUYom3FwYZpWWBpgAuWUsmOEcLxS5Po= Received: from DM5PR2101MB1032.namprd21.prod.outlook.com (52.132.128.13) by DM5PR2101MB0920.namprd21.prod.outlook.com (52.132.132.165) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.696.0; Mon, 9 Apr 2018 00:21:03 +0000 Received: from DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8109:aef0:a777:7059]) by DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8109:aef0:a777:7059%2]) with mapi id 15.20.0696.003; Mon, 9 Apr 2018 00:21:03 +0000 From: Sasha Levin To: "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" CC: Arnd Bergmann , Steve French , Sasha Levin Subject: [PATCH AUTOSEL for 4.15 159/189] cifs: silence compiler warnings showing up with gcc-8.0.0 Thread-Topic: [PATCH AUTOSEL for 4.15 159/189] cifs: silence compiler warnings showing up with gcc-8.0.0 Thread-Index: AQHTz5hYHpe4hC8FsUadgqu6qzkleA== Date: Mon, 9 Apr 2018 00:18:55 +0000 Message-ID: <20180409001637.162453-159-alexander.levin@microsoft.com> References: <20180409001637.162453-1-alexander.levin@microsoft.com> In-Reply-To: <20180409001637.162453-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM5PR2101MB0920; 7:hnHfhlcAon90pbvBsJEtOLN8lYyz5bocm7CLZImq++McFaHEREM/l5YX8vx/WgVhxK5VD6I17t+eMg5bRVzg5qkdJ5HmYgRa+WrfuOd2aickamUfedPAm5I6H1Q9XTR5epyNyHopnBkNEzrdkU34warHHFS3XQoh+4n9PxvrCHaa3FGuaRh9mQprSgzLIamyg6H7sM+9KuiLnKw/fsHAPG5iHIbOZaPz5Jf/mfxGossUW5VW3vM2aWWa2pwobg4d; 20:iCSPUSajuOjXeoW1BplAPRIfRSf1coMVHhWXJfZe8Y4Kt2/07zzwu+drlctbSiD9+Ryje0VRnEU++qEuZULba5op6BuMmPasSQc+gW7+/yjGlW0t5A36HfIToEAMU+larTAwN8vNkalnqT5sjcT4P7ndtR/uBOVVdpgvFxHlx04= X-MS-Office365-Filtering-Correlation-Id: 56aa3c62-77ee-4823-284f-08d59dafc75f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(48565401081)(2017052603328)(7193020); SRVR:DM5PR2101MB0920; x-ms-traffictypediagnostic: DM5PR2101MB0920: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(85827821059158); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(61425038)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231221)(944501327)(52105095)(3002001)(10201501046)(6055026)(61426038)(61427038)(6041310)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123560045)(6072148)(201708071742011); SRVR:DM5PR2101MB0920; BCL:0; PCL:0; RULEID:; SRVR:DM5PR2101MB0920; x-forefront-prvs: 0637FCE711 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39860400002)(39380400002)(396003)(366004)(346002)(376002)(199004)(189003)(66066001)(86362001)(3660700001)(3280700002)(25786009)(76176011)(2900100001)(36756003)(6506007)(2906002)(99286004)(86612001)(6486002)(102836004)(305945005)(1076002)(7736002)(97736004)(2616005)(446003)(11346002)(476003)(486006)(26005)(39060400002)(6666003)(6512007)(4326008)(107886003)(5660300001)(478600001)(6436002)(105586002)(10290500003)(5250100002)(22452003)(316002)(186003)(8676002)(110136005)(81166006)(54906003)(6116002)(8936002)(72206003)(53936002)(2501003)(3846002)(68736007)(14454004)(81156014)(10090500001)(106356001)(22906009)(217873001); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR2101MB0920; H:DM5PR2101MB1032.namprd21.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: AZzfJG4eXV98LwH7Wivx6I/ytChC/IyLmw1LgTef0W9xnuOQc8ndrAErG4QwFREKIjzRhVtEJL4XvMS72Ijl13Y/7A8/rI6u+5azdzIkEsQz17PVsiYycME+tFuuxCkVpuAEZ5DCK6UZ3WG9i5+uc6Byd28zfRmTtZLtqTnX/G1nn/NyMfHoEoSIqaUM9FQBzah/3CSq+keeOoi1ZiJo6c89lO9/FP7B1tt24KCvz2GVTOESyTJxd5p3PDXCtPevdufxofAE5mT9UaNssgZO0U5lcxTcij7baZ5Pghl160pYBfp3a+od8HCuEtc2FxqU08kn2/+nmC5qHR7yCSIOfGiOXhJnTsaHnWMGT1lPfZKdJyliaitUNncCmjyPDpWNGlXanweqlKi31i6Y2LnbErjMK4TXuj4ty6tHNkp8en0= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 56aa3c62-77ee-4823-284f-08d59dafc75f X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Apr 2018 00:18:55.9401 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB0920 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann [ Upstream commit ade7db991b47ab3016a414468164f4966bd08202 ] This bug was fixed before, but came up again with the latest compiler in another function: fs/cifs/cifssmb.c: In function 'CIFSSMBSetEA': fs/cifs/cifssmb.c:6362:3: error: 'strncpy' offset 8 is out of the bounds [0, 4] [-Werror=array-bounds] strncpy(parm_data->list[0].name, ea_name, name_len); Let's apply the same fix that was used for the other instances. Fixes: b2a3ad9ca502 ("cifs: silence compiler warnings showing up with gcc-4.7.0") Signed-off-by: Arnd Bergmann Signed-off-by: Steve French Signed-off-by: Sasha Levin --- fs/cifs/cifssmb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.15.1 diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c index 35dc5bf01ee2..7fd39ea6e22e 100644 --- a/fs/cifs/cifssmb.c +++ b/fs/cifs/cifssmb.c @@ -6331,9 +6331,7 @@ SetEARetry: pSMB->InformationLevel = cpu_to_le16(SMB_SET_FILE_EA); - parm_data = - (struct fealist *) (((char *) &pSMB->hdr.Protocol) + - offset); + parm_data = (void *)pSMB + offsetof(struct smb_hdr, Protocol) + offset; pSMB->ParameterOffset = cpu_to_le16(param_offset); pSMB->DataOffset = cpu_to_le16(offset); pSMB->SetupCount = 1; From patchwork Mon Apr 9 00:19:18 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Levin X-Patchwork-Id: 132991 Delivered-To: patch@linaro.org Received: by 10.46.84.29 with SMTP id i29csp758077ljb; Sun, 8 Apr 2018 20:31:17 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/sZW/JzWJ0zJKFI8UsWR86GCB/mhBUDmI6OYVS1Akm6niTYR99EqLeGKngpsuFDUu26W9B X-Received: by 10.99.107.8 with SMTP id g8mr14150450pgc.271.1523244677652; Sun, 08 Apr 2018 20:31:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523244677; cv=none; d=google.com; s=arc-20160816; b=XZaYqnPP0OSoe7QtLF+MuMnRzSWXafLRTqWq9U3Thc4HJwArHPlJBfopLdeKwKhWMr Cl5E011IwDxa3efrkmRYTaDquLyl5OSkV6F1jfFgtfdB/4B9wBQ1bUwsMmFaQg/QVcKZ lLE7MQmvl8woF6acJQpNX9YBWxllDwnMpivE/mjeqC7fi8YeQ7KvxpRqHYQCTvcmXMLZ VjI2/D6cYc0mkntBbELDI2g6BX1dvhkgNnlmwFMh0WwHWQDdBfy+Kqhp+fQXBiDmh46N GIMzV7S3/y90CCXddR/jq00BYYLGIChgRvb/yeSGa8nl1NUbxwO8OgTPK0ix/AgJN1U9 g3jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=L6FAVFfdLuyoiD+53t6MQiLkPza4klPuHWuTS7sLyBI=; b=Q8l3cSWuaydAMFvBlswSqjWv6rLqDsOzicEtU/zfnl/xw0OzmAfwfEDOHzdYTKC66I r0H3gPm7OG7i3z60x2+7fUdR6ZDPK971pgSOkvOKVfUSxpN3MvUiwyJ4GMtiKm93h4pU SnG/RPHb0ocdR0GQmpPbuwNNLOyk/D1Wrjy8kn19cT6j0CuN8GIFzVOU32Azuz5jrgci ocBsVNdaGGEUiVPJpLbOAingimCpzIxNbwkv16nXwthvJUh5V0+ZCMlFJoJL9IoYk+0l WPGuR6N7RR4XFl6pedB+0Qmc2ZR3HSlQS7RgZmjcrtAOImXw0MLykvKtJJZoBO9CdWSY TfBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=g+I+6M3w; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w19-v6si13336885plq.156.2018.04.08.20.31.17; Sun, 08 Apr 2018 20:31:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=g+I+6M3w; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754326AbeDIDbL (ORCPT + 29 others); Sun, 8 Apr 2018 23:31:11 -0400 Received: from mail-sn1nam02on0123.outbound.protection.outlook.com ([104.47.36.123]:35872 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754539AbeDIAV4 (ORCPT ); Sun, 8 Apr 2018 20:21:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=L6FAVFfdLuyoiD+53t6MQiLkPza4klPuHWuTS7sLyBI=; b=g+I+6M3wYYXsIbAUnAzcpeC8gJmNAqkFPmsd+7KwCe/ceYnpmqnjer78LhA7XG68/MTKcUdILahESXoJvvFrmwb6ZcJW2GSPBoyRCznYbXVhmu+Xu1BRG1GIjHVGKUYSBZ4+zf1GpFVFw2w9QbsKePsfFSrn1uFiiVLUt6Oj+Hc= Received: from DM5PR2101MB1032.namprd21.prod.outlook.com (52.132.128.13) by DM5PR2101MB0936.namprd21.prod.outlook.com (52.132.131.166) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.696.3; Mon, 9 Apr 2018 00:21:53 +0000 Received: from DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8109:aef0:a777:7059]) by DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8109:aef0:a777:7059%2]) with mapi id 15.20.0696.003; Mon, 9 Apr 2018 00:21:53 +0000 From: Sasha Levin To: "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" CC: Mark Salter , Marc Zyngier , Sasha Levin Subject: [PATCH AUTOSEL for 4.15 189/189] irqchip/gic-v3: Change pr_debug message to pr_devel Thread-Topic: [PATCH AUTOSEL for 4.15 189/189] irqchip/gic-v3: Change pr_debug message to pr_devel Thread-Index: AQHTz5hmQGDu72S6K0K7uBH3TTss2w== Date: Mon, 9 Apr 2018 00:19:18 +0000 Message-ID: <20180409001637.162453-189-alexander.levin@microsoft.com> References: <20180409001637.162453-1-alexander.levin@microsoft.com> In-Reply-To: <20180409001637.162453-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM5PR2101MB0936; 7:bigFZzixCXt1E2rKLHtLQj0qAD+hJiAyQIFtw5v+2fs15UBNIN1+WtAuBpXtMckUV4s3TSSyhIG9iPtORh6xBl/vyiTbr2+DDsy/Q+9rLsK7cEGX9ywCelfgIcusI+v/maO5iEoHFCs5xKgsTQbTNoC5RSj9wO8TJqWMAVpdQ4fjMcD3nYH1oJg3xJUy8hjeM0+lI2bVaxnShMC6KBGp/94lJybGnzkC0Yz4Rwpl3Q6hiJA4xCyRtJybR7MdQu2k; 20:0/c7mjxHafrBZwUV1Z+Lk8l0YukzFYFS2XCoe/JOU4IkNI6SrjvMvFXnjvU6wUj+UrYNnVHjjfMw/htbU/PNIW9luUIc8EcllCWPvPkqQ7gbgAEaztngRjBlqzM8cww82tfxE1mqBHW2CQRiNOpOFUiAUxEbq5LpRaIXFPwF6eY= x-ms-office365-filtering-ht: Tenant X-MS-Office365-Filtering-Correlation-Id: 2fa8a0f8-2d8a-451c-2dfe-08d59dafe57b x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7193020); SRVR:DM5PR2101MB0936; x-ms-traffictypediagnostic: DM5PR2101MB0936: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(180628864354917)(89211679590171); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(61425038)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231221)(944501327)(52105095)(3002001)(10201501046)(6055026)(61426038)(61427038)(6041310)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:DM5PR2101MB0936; BCL:0; PCL:0; RULEID:; SRVR:DM5PR2101MB0936; x-forefront-prvs: 0637FCE711 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(346002)(39380400002)(39860400002)(396003)(376002)(366004)(199004)(189003)(3660700001)(36756003)(2501003)(76176011)(10290500003)(2616005)(5250100002)(3280700002)(478600001)(1076002)(72206003)(6436002)(53936002)(486006)(476003)(4326008)(6486002)(107886003)(5660300001)(54906003)(110136005)(102836004)(2906002)(6116002)(15650500001)(3846002)(86612001)(81156014)(81166006)(6666003)(8936002)(305945005)(8676002)(2900100001)(6506007)(68736007)(14454004)(106356001)(105586002)(25786009)(6512007)(86362001)(99286004)(446003)(59450400001)(10090500001)(11346002)(316002)(26005)(7736002)(66066001)(186003)(22452003)(97736004)(22906009)(217873001); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR2101MB0936; H:DM5PR2101MB1032.namprd21.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: sW5fU8fimFDsHxb4B4ROIcwF9/QoNVMEAO3mzKRPGWlKyLnTsOuQDv/2IGvsZL9wb8tIpfT3+sSunyF2m/IZ+M7FlTWqPpV3sYl0UFuba/bkFHxIXQNxpMlD0crVN2GrJuAv2tmlvHr44qdmgewnZ6bGlNwwu/gr/u5vEWFfbjOArrDsBvFyi18GZ+dbVu9s+fO+qWtkDrFjkm5mmYo8ln+v/0Jrh1PUgJtrMFh2+oUXLfI2s/2oGd4O8eziyENhSxng6Mzj+a2CNoa2o80fNHE3npy1VjAbPegtdALaB0gevY15hvHuODLrMsMvOTXtaJYJ2qOLIDu93dvxFu67fu14VaUkbTH4CjPh1EiMXlv4L7B2DEDET37RNs+JEizhspI/EO6e/pf6Lkw0BjKYFBqLv+eKCbPASwl9XCwvs1A= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2fa8a0f8-2d8a-451c-2dfe-08d59dafe57b X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Apr 2018 00:19:18.7829 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB0936 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mark Salter [ Upstream commit b6dd4d83dc2f78cebc9a7e6e7e4bc2be4d29b94d ] The pr_debug() in gic-v3 gic_send_sgi() can trigger a circular locking warning: GICv3: CPU10: ICC_SGI1R_EL1 5000400 ====================================================== WARNING: possible circular locking dependency detected 4.15.0+ #1 Tainted: G W ------------------------------------------------------ dynamic_debug01/1873 is trying to acquire lock: ((console_sem).lock){-...}, at: [<0000000099c891ec>] down_trylock+0x20/0x4c but task is already holding lock: (&rq->lock){-.-.}, at: [<00000000842e1587>] __task_rq_lock+0x54/0xdc which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&rq->lock){-.-.}: __lock_acquire+0x3b4/0x6e0 lock_acquire+0xf4/0x2a8 _raw_spin_lock+0x4c/0x60 task_fork_fair+0x3c/0x148 sched_fork+0x10c/0x214 copy_process.isra.32.part.33+0x4e8/0x14f0 _do_fork+0xe8/0x78c kernel_thread+0x48/0x54 rest_init+0x34/0x2a4 start_kernel+0x45c/0x488 -> #1 (&p->pi_lock){-.-.}: __lock_acquire+0x3b4/0x6e0 lock_acquire+0xf4/0x2a8 _raw_spin_lock_irqsave+0x58/0x70 try_to_wake_up+0x48/0x600 wake_up_process+0x28/0x34 __up.isra.0+0x60/0x6c up+0x60/0x68 __up_console_sem+0x4c/0x7c console_unlock+0x328/0x634 vprintk_emit+0x25c/0x390 dev_vprintk_emit+0xc4/0x1fc dev_printk_emit+0x88/0xa8 __dev_printk+0x58/0x9c _dev_info+0x84/0xa8 usb_new_device+0x100/0x474 hub_port_connect+0x280/0x92c hub_event+0x740/0xa84 process_one_work+0x240/0x70c worker_thread+0x60/0x400 kthread+0x110/0x13c ret_from_fork+0x10/0x18 -> #0 ((console_sem).lock){-...}: validate_chain.isra.34+0x6e4/0xa20 __lock_acquire+0x3b4/0x6e0 lock_acquire+0xf4/0x2a8 _raw_spin_lock_irqsave+0x58/0x70 down_trylock+0x20/0x4c __down_trylock_console_sem+0x3c/0x9c console_trylock+0x20/0xb0 vprintk_emit+0x254/0x390 vprintk_default+0x58/0x90 vprintk_func+0xbc/0x164 printk+0x80/0xa0 __dynamic_pr_debug+0x84/0xac gic_raise_softirq+0x184/0x18c smp_cross_call+0xac/0x218 smp_send_reschedule+0x3c/0x48 resched_curr+0x60/0x9c check_preempt_curr+0x70/0xdc wake_up_new_task+0x310/0x470 _do_fork+0x188/0x78c SyS_clone+0x44/0x50 __sys_trace_return+0x0/0x4 other info that might help us debug this: Chain exists of: (console_sem).lock --> &p->pi_lock --> &rq->lock Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&rq->lock); lock(&p->pi_lock); lock(&rq->lock); lock((console_sem).lock); *** DEADLOCK *** 2 locks held by dynamic_debug01/1873: #0: (&p->pi_lock){-.-.}, at: [<000000001366df53>] wake_up_new_task+0x40/0x470 #1: (&rq->lock){-.-.}, at: [<00000000842e1587>] __task_rq_lock+0x54/0xdc stack backtrace: CPU: 10 PID: 1873 Comm: dynamic_debug01 Tainted: G W 4.15.0+ #1 Hardware name: GIGABYTE R120-T34-00/MT30-GS2-00, BIOS T48 10/02/2017 Call trace: dump_backtrace+0x0/0x188 show_stack+0x24/0x2c dump_stack+0xa4/0xe0 print_circular_bug.isra.31+0x29c/0x2b8 check_prev_add.constprop.39+0x6c8/0x6dc validate_chain.isra.34+0x6e4/0xa20 __lock_acquire+0x3b4/0x6e0 lock_acquire+0xf4/0x2a8 _raw_spin_lock_irqsave+0x58/0x70 down_trylock+0x20/0x4c __down_trylock_console_sem+0x3c/0x9c console_trylock+0x20/0xb0 vprintk_emit+0x254/0x390 vprintk_default+0x58/0x90 vprintk_func+0xbc/0x164 printk+0x80/0xa0 __dynamic_pr_debug+0x84/0xac gic_raise_softirq+0x184/0x18c smp_cross_call+0xac/0x218 smp_send_reschedule+0x3c/0x48 resched_curr+0x60/0x9c check_preempt_curr+0x70/0xdc wake_up_new_task+0x310/0x470 _do_fork+0x188/0x78c SyS_clone+0x44/0x50 __sys_trace_return+0x0/0x4 GICv3: CPU0: ICC_SGI1R_EL1 12000 This could be fixed with printk_deferred() but that might lessen its usefulness for debugging. So change it to pr_devel to keep it out of production kernels. Developers working on gic-v3 can enable it as needed in their kernels. Signed-off-by: Mark Salter Signed-off-by: Marc Zyngier Signed-off-by: Sasha Levin --- drivers/irqchip/irq-gic-v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.15.1 diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c index 980ae8e7df30..0b73cbae9dae 100644 --- a/drivers/irqchip/irq-gic-v3.c +++ b/drivers/irqchip/irq-gic-v3.c @@ -673,7 +673,7 @@ static void gic_send_sgi(u64 cluster_id, u16 tlist, unsigned int irq) MPIDR_TO_SGI_RS(cluster_id) | tlist << ICC_SGI1R_TARGET_LIST_SHIFT); - pr_debug("CPU%d: ICC_SGI1R_EL1 %llx\n", smp_processor_id(), val); + pr_devel("CPU%d: ICC_SGI1R_EL1 %llx\n", smp_processor_id(), val); gic_write_sgi1r(val); }