From patchwork Thu Feb 18 21:38:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luke Jones X-Patchwork-Id: 384620 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E7F0C433E0 for ; Thu, 18 Feb 2021 21:40:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 48B5B60295 for ; Thu, 18 Feb 2021 21:40:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229752AbhBRVkL (ORCPT ); Thu, 18 Feb 2021 16:40:11 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:51435 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229652AbhBRVkJ (ORCPT ); Thu, 18 Feb 2021 16:40:09 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 3DB9D5C0067; Thu, 18 Feb 2021 16:39:04 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 18 Feb 2021 16:39:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=H0yjNZCCvNE+YgpJN TvaN9hpZllwnD2nL2ItZk1wUyE=; b=XklhjCe7RCq0KzOGFCX4MIpEQ3MfRHS53 +G5HYxK2PNf95j4h575SK9G2Z2I4zWTtOaY4XJ/mAYTC8CwLIgRtN4ofQqGUTMDL /vQDnyhQUkd9JXjECInnHvrksrEfr8Bw+Y/AkOORLGrdKITKVj8giEbUGpMi6djY 8eI8XqVB05KzwZswuQ/36ssIlFaPixGWk4mKGC08z3R84npRcthpSzVH21QErF7U xlm+zxjMhJSr7GGKJigkXbb+YI89r9Na6KT+nz/KTIYDT72TY8NQx2gF3cIiLkLy eEPdS7I+cVPijvOd4Cpusll/w2WPMuiRN5DefWvboGh0Nj7WHIw0A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrjeeggddugeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgggfestdekredtre dttdenucfhrhhomhepnfhukhgvucffucflohhnvghsuceolhhukhgvsehljhhonhgvshdr uggvvheqnecuggftrfgrthhtvghrnhepfffghfehheekgfdttdeihfdugeetkeduiefhvd dujeduiefgtdehieejtedvjedvnecukfhppeduudeirddvhedurdduleefrdduleeinecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheplhhukhgvse hljhhonhgvshdruggvvh X-ME-Proxy: Received: from localhost.localdomain (unknown [116.251.193.196]) by mail.messagingengine.com (Postfix) with ESMTPA id ED7FE24005D; Thu, 18 Feb 2021 16:38:59 -0500 (EST) From: Luke D Jones To: jikos@kernel.org Cc: benjamin.tissoires@redhat.com, rydberg@bitmath.org, linux-input@vger.kernel.org, Luke D Jones Subject: [PATCH] HID: asus: Filter keyboard EC for old ROG keyboard Date: Fri, 19 Feb 2021 10:38:46 +1300 Message-Id: <20210218213846.22504-1-luke@ljones.dev> X-Mailer: git-send-email 2.30.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Older ROG keyboards emit a similar stream of bytes to the new N-Key keyboards and require filtering to prevent a lot of unmapped key warnings showing. As all the ROG keyboards use QUIRK_USE_KBD_BACKLIGHT this is now used to branch to filtering in asus_raw_event. Signed-off-by: Luke D Jones --- drivers/hid/hid-asus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c index 2ab22b925941..1ed1c05c3d54 100644 --- a/drivers/hid/hid-asus.c +++ b/drivers/hid/hid-asus.c @@ -335,7 +335,7 @@ static int asus_raw_event(struct hid_device *hdev, if (drvdata->quirks & QUIRK_MEDION_E1239T) return asus_e1239t_event(drvdata, data, size); - if (drvdata->quirks & QUIRK_ROG_NKEY_KEYBOARD) { + if (drvdata->quirks & QUIRK_USE_KBD_BACKLIGHT) { /* * Skip these report ID, the device emits a continuous stream associated * with the AURA mode it is in which looks like an 'echo'.