From patchwork Tue Feb 16 11:41:18 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Oltean X-Patchwork-Id: 383654 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2F03C433E0 for ; Tue, 16 Feb 2021 11:44:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6448B64E04 for ; Tue, 16 Feb 2021 11:44:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230420AbhBPLoE (ORCPT ); Tue, 16 Feb 2021 06:44:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230429AbhBPLmR (ORCPT ); Tue, 16 Feb 2021 06:42:17 -0500 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE102C06174A for ; Tue, 16 Feb 2021 03:41:27 -0800 (PST) Received: by mail-ej1-x62d.google.com with SMTP id lu16so1124688ejb.9 for ; Tue, 16 Feb 2021 03:41:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KBldjOvO17ApSk77FiyWF1LuIv96yzQ18hN9HI7B+qQ=; b=cwSGtJo1lUPn7cm0zHQv+ZPeaUnLl/7F7WgHBWMiWPWSuVFhhqfOEQuc/Wyg96jxVG gDRQ41iSq8YJ8vv44TZcb+uTbtyVXIcoecFfidV+Rzqm58UNgvWicpMgbYoCUK8eCMcc VA2hXA54kdmGe/pPgEtWooeqZMm0ATu4BHp28szo1lFC8qGSQ4Tv+7YQYyZtjGIlfKcH zAg93/Clrzqnbtv/eBv9LFr7eZE/iE3118+zMN+KPCO/vrxLiS0tpNyCOrHXVR6fMpNF Dps2EEUVtpAWnP0jwZzPaharBsAyRf5i4QUq3zT9D0fDRzsdDu4KeJtTM4BO+1rnkcDu 1bsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KBldjOvO17ApSk77FiyWF1LuIv96yzQ18hN9HI7B+qQ=; b=OzxOMdWjEcCu8zhVOlTrJ2It53dtdNfMTcVgGIlixoOQKpARCFPPQ6DKSK5ppzMQYd HqyEgdy27++DqzKEH7cXg4D/2wvCZa2Bm3D+8fXuFbyf28o+CYp8P3QqKYLFQABV0tfM brb+CwX5deAnf6HRLRGk118yEfcLC6La/KyWnpcpsUNdoAlez+1RtmOcInlvnwzBDG2a biegAQ/fJS5+UAO7PWUYYXMBxahb8ajB7bIrJ6gT5PNNNgrz+GrWjXRy9meOJhHdftPf XAt64ieXzfhDm8SqZ6aU3+UgRFKGMKjWnp87Om/E4YtxXG9WZgd4U6cJ9dyQ52p5NBOi bdvA== X-Gm-Message-State: AOAM530OcV12GvjDr3XwAoISMSPx27G+8CJzHXpGCehcPmfRL2uHGrjo KpsMUrYnc6DtZiUt9xtyv8A= X-Google-Smtp-Source: ABdhPJy6kdxo19VDJlCDzDdBhRCqDWWV6wCMgfJ9BCR3/pp5YtlNnTLSo3/iyKIMYWLjlNfzfQ5H8w== X-Received: by 2002:a17:907:1629:: with SMTP id hb41mr19356402ejc.197.1613475686610; Tue, 16 Feb 2021 03:41:26 -0800 (PST) Received: from localhost.localdomain (5-12-227-87.residential.rdsnet.ro. [5.12.227.87]) by smtp.gmail.com with ESMTPSA id kb25sm13287397ejc.19.2021.02.16.03.41.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Feb 2021 03:41:26 -0800 (PST) From: Vladimir Oltean To: "David S . Miller" , Jakub Kicinski , netdev@vger.kernel.org Cc: Florian Fainelli , Andrew Lunn , Vivien Didelot Subject: [PATCH RESEND net-next 1/2] net: dsa: sja1105: fix configuration of source address learning Date: Tue, 16 Feb 2021 13:41:18 +0200 Message-Id: <20210216114119.2856299-2-olteanv@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210216114119.2856299-1-olteanv@gmail.com> References: <20210216114119.2856299-1-olteanv@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Vladimir Oltean Due to a mistake, the driver always sets the address learning flag to the previously stored value, and not to the currently configured one. The bug is visible only in standalone ports mode, because when the port is bridged, the issue is masked by .port_stp_state_set which overwrites the address learning state to the proper value. Fixes: 4d9423549501 ("net: dsa: sja1105: offload bridge port flags to device") Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli --- drivers/net/dsa/sja1105/sja1105_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/sja1105/sja1105_main.c b/drivers/net/dsa/sja1105/sja1105_main.c index 1dad94540cc9..3d3e2794655d 100644 --- a/drivers/net/dsa/sja1105/sja1105_main.c +++ b/drivers/net/dsa/sja1105/sja1105_main.c @@ -3282,7 +3282,7 @@ static int sja1105_port_set_learning(struct sja1105_private *priv, int port, mac = priv->static_config.tables[BLK_IDX_MAC_CONFIG].entries; - mac[port].dyn_learn = !!(priv->learn_ena & BIT(port)); + mac[port].dyn_learn = enabled; rc = sja1105_dynamic_config_write(priv, BLK_IDX_MAC_CONFIG, port, &mac[port], true); From patchwork Tue Feb 16 11:41:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Oltean X-Patchwork-Id: 383653 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2721C433DB for ; Tue, 16 Feb 2021 11:45:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8815064DA5 for ; Tue, 16 Feb 2021 11:45:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230156AbhBPLpI (ORCPT ); Tue, 16 Feb 2021 06:45:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230431AbhBPLmR (ORCPT ); Tue, 16 Feb 2021 06:42:17 -0500 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDE07C061788 for ; Tue, 16 Feb 2021 03:41:28 -0800 (PST) Received: by mail-ej1-x62d.google.com with SMTP id g5so12488149ejt.2 for ; Tue, 16 Feb 2021 03:41:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uzMcqZmVU8p/WUafrlw6GUYaSwQEpz2AcZTY4aSc314=; b=uQfjJiJnfsoG4kl/9ciTPGsaZPdmRPl7UHPzKaLpqUxyLOUVUxyBCh1PNXfVAV3Jik eTfzd/et+1iC/T49I1qSeUE6+Jk0gekFCEn2oc53hXdr/affctNqyG9XyDdmLB9xUQVX YPGbb0PzPdBq1MwmU8D3wfApZaQdcpHyjlcO4aYEzb1YnUthYvl1+0yrChxdk3gHmLpg CAFHMiZJtcMxypAwdXvg1E7wOCptoi1y4dWtyNtB5cJZGfI2LQ+7aZoLwCC2aMZi6Qyw kg+AcJkwXkw+Rps/P19/AAbBCkItdOy1hrbEjiw0YlJu0c827pZztRElQzEG4Mskr7rK eoKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uzMcqZmVU8p/WUafrlw6GUYaSwQEpz2AcZTY4aSc314=; b=g+tBd264UAhFPzSPCYpRlZrLenCwoSH1Tl5AbM7Wfh8p4SRZ5JQVFX4REHqwzqk1Zh F1qF6MMBQyPvPTAjQwG5ho8RPrsF+YLJ8gMpiklDxDK9JFlQwL6EBTbxpm0F54c0Ehcx oHrH0jljztmd0Oh9FopUizTYQxyHiUW3w+Hhy5QiO9kUNnMzA+POJ3fCgItVral7RPgE M3cTZwNWtt/nneHi5375ZLnQ2z6PIPcJVmPEzIxQlbWRx/oBe3mmRX9uErAP0SaO2zqi VFnlz/MH1PwiO0HpUs7S2MvTIf8DqeAXsGIFlfLU9oeXbPeODUK+2kZSMzUAJwcx6r9H +xMg== X-Gm-Message-State: AOAM530buU/Xdire0eGet5PDbJ+NNEuZOHEe3XlLCXcJSx2wv1wCLItf Fb1BOoYvraADk4o40IMmXSg= X-Google-Smtp-Source: ABdhPJz1RVyBmuL0IdfPEQnYu9FFAtarWLZAGftDKxf8VjZA28qwPsl338WwiCGgNFDYL36LAgXKcA== X-Received: by 2002:a17:906:dbd0:: with SMTP id yc16mr20073950ejb.524.1613475687602; Tue, 16 Feb 2021 03:41:27 -0800 (PST) Received: from localhost.localdomain (5-12-227-87.residential.rdsnet.ro. [5.12.227.87]) by smtp.gmail.com with ESMTPSA id kb25sm13287397ejc.19.2021.02.16.03.41.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Feb 2021 03:41:27 -0800 (PST) From: Vladimir Oltean To: "David S . Miller" , Jakub Kicinski , netdev@vger.kernel.org Cc: Florian Fainelli , Andrew Lunn , Vivien Didelot Subject: [PATCH RESEND net-next 2/2] net: dsa: sja1105: fix leakage of flooded frames outside bridging domain Date: Tue, 16 Feb 2021 13:41:19 +0200 Message-Id: <20210216114119.2856299-3-olteanv@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210216114119.2856299-1-olteanv@gmail.com> References: <20210216114119.2856299-1-olteanv@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Vladimir Oltean Quite embarrasingly, I managed to fool myself into thinking that the flooding domain of sja1105 source ports is restricted by the forwarding domain, which it isn't. Frames which match an FDB entry are forwarded towards that entry's DESTPORTS restricted by REACH_PORT[SRC_PORT], while frames that don't match any FDB entry are forwarded towards FL_DOMAIN[SRC_PORT] or BC_DOMAIN[SRC_PORT]. This means we can't get away with doing the simple thing, and we must manage the flooding domain ourselves such that it is restricted by the forwarding domain. This new function must be called from the .port_bridge_join and .port_bridge_leave methods too, not just from .port_bridge_flags as we did before. Fixes: 4d9423549501 ("net: dsa: sja1105: offload bridge port flags to device") Signed-off-by: Vladimir Oltean --- drivers/net/dsa/sja1105/sja1105.h | 2 + drivers/net/dsa/sja1105/sja1105_main.c | 115 ++++++++++++++++--------- 2 files changed, 76 insertions(+), 41 deletions(-) diff --git a/drivers/net/dsa/sja1105/sja1105.h b/drivers/net/dsa/sja1105/sja1105.h index 15a0893d0ff1..494d17117b94 100644 --- a/drivers/net/dsa/sja1105/sja1105.h +++ b/drivers/net/dsa/sja1105/sja1105.h @@ -206,6 +206,8 @@ struct sja1105_private { bool rgmii_tx_delay[SJA1105_NUM_PORTS]; bool best_effort_vlan_filtering; unsigned long learn_ena; + unsigned long ucast_egress_floods; + unsigned long bcast_egress_floods; const struct sja1105_info *info; struct gpio_desc *reset_gpio; struct spi_device *spidev; diff --git a/drivers/net/dsa/sja1105/sja1105_main.c b/drivers/net/dsa/sja1105/sja1105_main.c index 3d3e2794655d..7eef96fab214 100644 --- a/drivers/net/dsa/sja1105/sja1105_main.c +++ b/drivers/net/dsa/sja1105/sja1105_main.c @@ -50,6 +50,12 @@ sja1105_port_allow_traffic(struct sja1105_l2_forwarding_entry *l2_fwd, l2_fwd[from].reach_port &= ~BIT(to); } +static bool sja1105_can_forward(struct sja1105_l2_forwarding_entry *l2_fwd, + int from, int to) +{ + return !!(l2_fwd[from].reach_port & BIT(to)); +} + /* Structure used to temporarily transport device tree * settings into sja1105_setup */ @@ -408,6 +414,12 @@ static int sja1105_init_l2_forwarding(struct sja1105_private *priv) for (j = 0; j < SJA1105_NUM_TC; j++) l2fwd[i].vlan_pmap[j] = j; + /* All ports start up with egress flooding enabled, + * including the CPU port. + */ + priv->ucast_egress_floods |= BIT(i); + priv->bcast_egress_floods |= BIT(i); + if (i == upstream) continue; @@ -1571,6 +1583,50 @@ static int sja1105_mdb_del(struct dsa_switch *ds, int port, return sja1105_fdb_del(ds, port, mdb->addr, mdb->vid); } +/* Common function for unicast and broadcast flood configuration. + * Flooding is configured between each {ingress, egress} port pair, and since + * the bridge's semantics are those of "egress flooding", it means we must + * enable flooding towards this port from all ingress ports that are in the + * same forwarding domain. + */ +static int sja1105_manage_flood_domains(struct sja1105_private *priv) +{ + struct sja1105_l2_forwarding_entry *l2_fwd; + struct dsa_switch *ds = priv->ds; + int from, to, rc; + + l2_fwd = priv->static_config.tables[BLK_IDX_L2_FORWARDING].entries; + + for (from = 0; from < ds->num_ports; from++) { + u64 fl_domain = 0, bc_domain = 0; + + for (to = 0; to < priv->ds->num_ports; to++) { + if (!sja1105_can_forward(l2_fwd, from, to)) + continue; + + if (priv->ucast_egress_floods & BIT(to)) + fl_domain |= BIT(to); + if (priv->bcast_egress_floods & BIT(to)) + bc_domain |= BIT(to); + } + + /* Nothing changed, nothing to do */ + if (l2_fwd[from].fl_domain == fl_domain && + l2_fwd[from].bc_domain == bc_domain) + continue; + + l2_fwd[from].fl_domain = fl_domain; + l2_fwd[from].bc_domain = bc_domain; + + rc = sja1105_dynamic_config_write(priv, BLK_IDX_L2_FORWARDING, + from, &l2_fwd[from], true); + if (rc < 0) + return rc; + } + + return 0; +} + static int sja1105_bridge_member(struct dsa_switch *ds, int port, struct net_device *br, bool member) { @@ -1608,8 +1664,12 @@ static int sja1105_bridge_member(struct dsa_switch *ds, int port, return rc; } - return sja1105_dynamic_config_write(priv, BLK_IDX_L2_FORWARDING, - port, &l2_fwd[port], true); + rc = sja1105_dynamic_config_write(priv, BLK_IDX_L2_FORWARDING, + port, &l2_fwd[port], true); + if (rc) + return rc; + + return sja1105_manage_flood_domains(priv); } static void sja1105_bridge_stp_state_set(struct dsa_switch *ds, int port, @@ -3297,51 +3357,24 @@ static int sja1105_port_set_learning(struct sja1105_private *priv, int port, return 0; } -/* Common function for unicast and broadcast flood configuration. - * Flooding is configured between each {ingress, egress} port pair, and since - * the bridge's semantics are those of "egress flooding", it means we must - * enable flooding towards this port from all ingress ports that are in the - * same bridge. In practice, we just enable flooding from all possible ingress - * ports regardless of whether they're in the same bridge or not, since the - * reach_port configuration will not allow flooded frames to leak across - * bridging domains anyway. - */ static int sja1105_port_ucast_bcast_flood(struct sja1105_private *priv, int to, struct switchdev_brport_flags flags) { - struct sja1105_l2_forwarding_entry *l2_fwd; - int from, rc; - - l2_fwd = priv->static_config.tables[BLK_IDX_L2_FORWARDING].entries; - - for (from = 0; from < priv->ds->num_ports; from++) { - if (dsa_is_unused_port(priv->ds, from)) - continue; - if (from == to) - continue; - - /* Unicast */ - if (flags.mask & BR_FLOOD) { - if (flags.val & BR_FLOOD) - l2_fwd[from].fl_domain |= BIT(to); - else - l2_fwd[from].fl_domain &= ~BIT(to); - } - /* Broadcast */ - if (flags.mask & BR_BCAST_FLOOD) { - if (flags.val & BR_BCAST_FLOOD) - l2_fwd[from].bc_domain |= BIT(to); - else - l2_fwd[from].bc_domain &= ~BIT(to); - } + if (flags.mask & BR_FLOOD) { + if (flags.val & BR_FLOOD) + priv->ucast_egress_floods |= BIT(to); + else + priv->ucast_egress_floods |= BIT(to); + } - rc = sja1105_dynamic_config_write(priv, BLK_IDX_L2_FORWARDING, - from, &l2_fwd[from], true); - if (rc < 0) - return rc; + if (flags.mask & BR_BCAST_FLOOD) { + if (flags.val & BR_BCAST_FLOOD) + priv->bcast_egress_floods |= BIT(to); + else + priv->bcast_egress_floods |= BIT(to); } - return 0; + return sja1105_manage_flood_domains(priv); } static int sja1105_port_mcast_flood(struct sja1105_private *priv, int to,