From patchwork Tue Feb 16 16:02:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Dejin Zheng X-Patchwork-Id: 383481 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F64BC433E6 for ; Tue, 16 Feb 2021 16:04:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5A8CA64D9F for ; Tue, 16 Feb 2021 16:04:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230393AbhBPQDs (ORCPT ); Tue, 16 Feb 2021 11:03:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230353AbhBPQDq (ORCPT ); Tue, 16 Feb 2021 11:03:46 -0500 Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A900C061756; Tue, 16 Feb 2021 08:03:06 -0800 (PST) Received: by mail-pf1-x42c.google.com with SMTP id b145so6412713pfb.4; Tue, 16 Feb 2021 08:03:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vLYno5aciuzWdkhSYU1ddjoRMBsS1paz+F+v6wPI8Hc=; b=krRQBl1JLay6HNr6hIjHnM54AIGq/vAIjBaq9YbAtVKVxNGzu8E4zfhwqgtZDS+1pt x3gpiUR8q+gLTlW/P1UGuyaYsQFkpSwxHPR3xFrbWc+qGFeWONa5i1ZrNKBfP3+rfHXZ 3oPIyekKvvf5S2HhMQisIKWESRJLvlPXN07gXex7D8PWBPXoGwUQG8Iik+moR1MckGAf mzDHrEdXm1pzlyiTdsFhckV4Kyy10A9YkocU1+wg44nOJ0Nl+Tz3upI6/QXRf8YZ6nLA vxkb4r7p0x5klG4h5xIw1HKSteVzFK7LwqqtBsVqOj51Vw6WNE4E5wWsMct3n1s6tBrt xxbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vLYno5aciuzWdkhSYU1ddjoRMBsS1paz+F+v6wPI8Hc=; b=RT5IA/zLGPuGKlgKBjrNp+goueY+DY3SyAuLiHbOFNIoULiJ4XgQqVoQ/YUWf+59P+ A6lr96P+oIWL/SIVKiB+z3NvnBbDiKC4fs2wSbs8wfsM4hIZ1uIDQCXaCBfAm3no/Dch L+89ZfOAO1AluNVHLSZDtOw62p4KuymJzRRrC02EgdKUuD0iDgmBWMPpEwUgOpjIlhPQ 0DeRGT2HevPFyF/PqssNXobXEEIyDgplw5HKlxCIJ5Gk4fSi4sDR1wtCS5lW+7BZgGA5 Ni85p6PXt2IMcg55L+Oy6m7T2qla76WRjQTyOmckuvI++HqKXwRAgT/89OoNcHgzP3dK 1wVw== X-Gm-Message-State: AOAM531Nc9Ex1EBGG7f03as9Rzexzn8gwK8qjXwSqEqyElSo6cjx5plp zUyV44i0GE88soC05kBsEHE= X-Google-Smtp-Source: ABdhPJxYGWys9szZhDZBKBrk8Fc7ZjUgWYbHqr34rbhGZ2C6OGUU6ANP2huG0CSkTO41JQRuOUxboA== X-Received: by 2002:a62:e804:0:b029:1dd:cf18:bdee with SMTP id c4-20020a62e8040000b02901ddcf18bdeemr20780783pfi.63.1613491385721; Tue, 16 Feb 2021 08:03:05 -0800 (PST) Received: from localhost (185.212.56.4.16clouds.com. [185.212.56.4]) by smtp.gmail.com with ESMTPSA id g8sm3579464pjj.41.2021.02.16.08.03.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Feb 2021 08:03:05 -0800 (PST) From: Dejin Zheng To: corbet@lwn.net, jarkko.nikula@linux.intel.com, andriy.shevchenko@linux.intel.com, mika.westerberg@linux.intel.com, rric@kernel.org, bhelgaas@google.com, wsa@kernel.org, linux-doc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-pci@vger.kernel.org, kw@linux.com Cc: linux-kernel@vger.kernel.org, Dejin Zheng Subject: [PATCH v3 2/4] Documentation: devres: Add pcim_alloc_irq_vectors() Date: Wed, 17 Feb 2021 00:02:47 +0800 Message-Id: <20210216160249.749799-3-zhengdejin5@gmail.com> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20210216160249.749799-1-zhengdejin5@gmail.com> References: <20210216160249.749799-1-zhengdejin5@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Add pcim_alloc_irq_vectors(), a device-managed version of pci_alloc_irq_vectors(). introducing this function can simplify the error handling path in many drivers. Signed-off-by: Dejin Zheng Reviewed-by: Krzysztof Wilczyński --- v2 -> v3: - No change v1 -> v2: - Modify some commit messages. Documentation/driver-api/driver-model/devres.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/driver-api/driver-model/devres.rst b/Documentation/driver-api/driver-model/devres.rst index cd8b6e657b94..a52f65b6352f 100644 --- a/Documentation/driver-api/driver-model/devres.rst +++ b/Documentation/driver-api/driver-model/devres.rst @@ -380,6 +380,7 @@ PCI devm_pci_alloc_host_bridge() : managed PCI host bridge allocation devm_pci_remap_cfgspace() : ioremap PCI configuration space devm_pci_remap_cfg_resource() : ioremap PCI configuration space resource + pcim_alloc_irq_vectors() : managed IRQ vectors allocation pcim_enable_device() : after success, all PCI ops become managed pcim_pin_device() : keep PCI device enabled after release From patchwork Tue Feb 16 16:02:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dejin Zheng X-Patchwork-Id: 383480 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70811C43332 for ; Tue, 16 Feb 2021 16:04:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4E31364D9F for ; Tue, 16 Feb 2021 16:04:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230263AbhBPQDz (ORCPT ); Tue, 16 Feb 2021 11:03:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230264AbhBPQDv (ORCPT ); Tue, 16 Feb 2021 11:03:51 -0500 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D898FC061786; Tue, 16 Feb 2021 08:03:10 -0800 (PST) Received: by mail-pj1-x1031.google.com with SMTP id kr16so1285984pjb.2; Tue, 16 Feb 2021 08:03:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hHuRwf2TdnMlb69qCWHCGaaZJgBzN1vXiSlYH3WgE1I=; b=RTX2JZ0LfFB+vJQkvu8Ry+s8sAaHG2DRIKvxP+DcYQy+ATKBoJxQ2cqoQ6Vhsv0ZPH Ku/FsOrpdSdhdgbI1/uJp3iBhhLPWHcN1Hl6lHlvexvjWSCw6cFlZf+sAwNSOVX0lZ+/ 1JITHXBf1uZlxLnKX7VweTPjDasm8kNeNlXJwAzpv97izrMxzZjDk9VnpvPBx0SpMCuL mVxCfJy3o3068IlsqR9ts/ify76qxephAt/CX2fmjfafPvL8dWhqO8Lgd92NQojpHeLf iRrzms+LFeqeAiVG6SH2iLLls2vgNY8gLfFHYCd81xz0waQk/0nnCFrYEORogFXVMBGA 9BTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hHuRwf2TdnMlb69qCWHCGaaZJgBzN1vXiSlYH3WgE1I=; b=j2Cf7Gaf18pYibGP3/cvMZN0qOs56fE9sm0OVQ9feuS5AXwVeoRq+LxMdhHSjRKhNm d3+aBdgRUiocVbJ+lLTpUh9+qPeIn660bJU88v/ZJPi8NGDlGoAK9YpH/N/rIcpxisPu yFc31eUttPbxj2v6KXJb3De811MVMDx8zwwauZUh8HneGPqF4E0Go2+8kBLy415hjtw0 6Da9kUqMsHXJJD5Zx/ZkA+aj7UTgDunPAjld58KvUmQ+0hKAKr+kA16S8GrHKXu37BpA GjwQyST7y5AJdYVPXuXif1i5596m2FkUMDFKDREY64PsEJ35cPvL3E+UeavVmBKmQcRL aZ8g== X-Gm-Message-State: AOAM530WByOBEkPM9gVIHdcOXzEIYK7wpTjFdXz+ka1yIuromnxNQ0zA ccHtjJy55mTr6eKZ7CiImeI= X-Google-Smtp-Source: ABdhPJwYdmqIcde3VGwF41I/uukrGzb1eKNviqwJLoZTUw0NI0c24qLxgqGPQmGPDZ36D50BCBY6nQ== X-Received: by 2002:a17:90a:7e0a:: with SMTP id i10mr4754761pjl.152.1613491390486; Tue, 16 Feb 2021 08:03:10 -0800 (PST) Received: from localhost (185.212.56.4.16clouds.com. [185.212.56.4]) by smtp.gmail.com with ESMTPSA id t21sm23457321pfc.92.2021.02.16.08.03.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Feb 2021 08:03:10 -0800 (PST) From: Dejin Zheng To: corbet@lwn.net, jarkko.nikula@linux.intel.com, andriy.shevchenko@linux.intel.com, mika.westerberg@linux.intel.com, rric@kernel.org, bhelgaas@google.com, wsa@kernel.org, linux-doc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-pci@vger.kernel.org, kw@linux.com Cc: linux-kernel@vger.kernel.org, Dejin Zheng Subject: [PATCH v3 4/4] i2c: thunderx: Use the correct name of device-managed function Date: Wed, 17 Feb 2021 00:02:49 +0800 Message-Id: <20210216160249.749799-5-zhengdejin5@gmail.com> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20210216160249.749799-1-zhengdejin5@gmail.com> References: <20210216160249.749799-1-zhengdejin5@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Use the new function pcim_alloc_irq_vectors() to allocate IRQ vectors, the pcim_alloc_irq_vectors() function, an explicit device-managed version of pci_alloc_irq_vectors(). If pcim_enable_device() has been called before, then pci_alloc_irq_vectors() is actually a device-managed function. It is used here as a device-managed function, So replace it with pcim_alloc_irq_vectors(). Signed-off-by: Dejin Zheng --- v2 -> v3: - No change. v1 -> v2: - Modify some commit messages. drivers/i2c/busses/i2c-thunderx-pcidrv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-thunderx-pcidrv.c b/drivers/i2c/busses/i2c-thunderx-pcidrv.c index 12c90aa0900e..63354e9fb726 100644 --- a/drivers/i2c/busses/i2c-thunderx-pcidrv.c +++ b/drivers/i2c/busses/i2c-thunderx-pcidrv.c @@ -192,7 +192,7 @@ static int thunder_i2c_probe_pci(struct pci_dev *pdev, i2c->hlc_int_enable = thunder_i2c_hlc_int_enable; i2c->hlc_int_disable = thunder_i2c_hlc_int_disable; - ret = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_MSIX); + ret = pcim_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_MSIX); if (ret < 0) goto error;