From patchwork Thu Feb 11 10:44:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Oltean X-Patchwork-Id: 381591 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C875C433DB for ; Thu, 11 Feb 2021 10:50:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 63C5A64EAA for ; Thu, 11 Feb 2021 10:50:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229775AbhBKKtw (ORCPT ); Thu, 11 Feb 2021 05:49:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230453AbhBKKqd (ORCPT ); Thu, 11 Feb 2021 05:46:33 -0500 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61540C0613D6 for ; Thu, 11 Feb 2021 02:45:27 -0800 (PST) Received: by mail-ej1-x62a.google.com with SMTP id i8so9311935ejc.7 for ; Thu, 11 Feb 2021 02:45:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=a9d0mkerRNl4TBDpLP0t7ZBBEkZC40UZpwzZPwQ0FXE=; b=oD9aeOs8h7tP/ZFVTMLBNLHCl5G/TfopWWM5PXJKXCz4taoSXBiEF5D6BytNIhhWmV CAxcK+ulT22vxFQJQ62kRBvzlzNi/ZFQsb3wuGOz7jhtnQneMuhENKfv2H7SPWJs0opc MwgrJEbhKcPXItaKjZW0BF1zqTrDh6y04z7Zy8nQkX/2u0/nlt2vrGkjCSn3ubuG3E8H 18cdjefuwpEiK+PYO8qq9VcuKjk4sOZtBXugKjXUQPws6ocMbOtkxnazL3HI+CXmD+Zv kq+JGgBFZSxUHy6OqA6at3apwhGGU8ifQmOkLNhWkdltc+Q5bAmqXj0ed69ppEld0BAE mCRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=a9d0mkerRNl4TBDpLP0t7ZBBEkZC40UZpwzZPwQ0FXE=; b=LoeSh9h14py2K+Uk0pQo4/cvPAzT7q95nYUaLsJswjHplItOQJg7HjNIhv00KOwgwb lMLj9mTJWuFAdE7SBL51aNcr6y76kB4vHDjj6sfClQsGrASryBTbg1EB4QEAdcFmrQMh RtuSb12SwZDZFf9Q++CpppPoUWKfzucP72svZMLdLX5M+naJv5qI0/Q4GC2FqI1T5B+f yZm+JHAE1tSV5oRmox6i12ucxbGvoxWWwsC2hrx2hqGtT5xxBRRJAoywuz8trFxBijdp EbtQY3w3SrBSsGdVJAH/aAesGEAXMHixqWtAfm42Np/LQGLQ2bSJmGht4TUTYvqnY6JE jSKQ== X-Gm-Message-State: AOAM532h9SC+5sXI5I8+6/CJdKDC2BjrjA+IK59Dz0DDBYw7/GDxVvbT LUPk4Fl6FAQy3sHudIpxLC8= X-Google-Smtp-Source: ABdhPJyKw9xS62VlMyNQUiaYr2PfjjMouA5zUQF3Ge7hC3Gmpa926BCAzmpaIHnqW3ciFm8mHHbJ1A== X-Received: by 2002:a17:906:16d0:: with SMTP id t16mr7601347ejd.259.1613040326044; Thu, 11 Feb 2021 02:45:26 -0800 (PST) Received: from localhost.localdomain (5-12-227-87.residential.rdsnet.ro. [5.12.227.87]) by smtp.gmail.com with ESMTPSA id l1sm3815458eje.12.2021.02.11.02.45.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Feb 2021 02:45:25 -0800 (PST) From: Vladimir Oltean To: David Ahern , netdev@vger.kernel.org Cc: Andrew Lunn , Florian Fainelli , Vivien Didelot , Jiri Pirko , Ido Schimmel , DENG Qingfang , Tobias Waldekranz , Roopa Prabhu , Nikolay Aleksandrov , Stephen Hemminger Subject: [PATCH iproute2 1/6] man8/bridge.8: document the "permanent" flag for "bridge fdb add" Date: Thu, 11 Feb 2021 12:44:57 +0200 Message-Id: <20210211104502.2081443-2-olteanv@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210211104502.2081443-1-olteanv@gmail.com> References: <20210211104502.2081443-1-olteanv@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Vladimir Oltean The bridge program parses "local" and "permanent" in just the same way, so it makes sense to tell that to users: fdb_modify: } else if (matches(*argv, "local") == 0 || matches(*argv, "permanent") == 0) { req.ndm.ndm_state |= NUD_PERMANENT; Signed-off-by: Vladimir Oltean --- man/man8/bridge.8 | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/man/man8/bridge.8 b/man/man8/bridge.8 index b3414ae31faf..12c09a56563d 100644 --- a/man/man8/bridge.8 +++ b/man/man8/bridge.8 @@ -517,6 +517,10 @@ the interface to which this address is associated. - is a local permanent fdb entry .sp +.B permanent +- this is a synonym for "local" +.sp + .B static - is a static (no arp) fdb entry .sp From patchwork Thu Feb 11 10:44:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Oltean X-Patchwork-Id: 382350 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6966FC433DB for ; Thu, 11 Feb 2021 10:52:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D72464E23 for ; Thu, 11 Feb 2021 10:52:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230433AbhBKKvQ (ORCPT ); Thu, 11 Feb 2021 05:51:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230463AbhBKKqd (ORCPT ); Thu, 11 Feb 2021 05:46:33 -0500 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64696C061786 for ; Thu, 11 Feb 2021 02:45:28 -0800 (PST) Received: by mail-ej1-x632.google.com with SMTP id f14so9312648ejc.8 for ; Thu, 11 Feb 2021 02:45:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Q0x8reR+y8VY9XBx3PtPCY7fqMs2lXRuHU5JVxtfCBc=; b=EpkkpDkbPM6yqlUUEemRBXhP/iGDJX6I9odjD5O/btmAvAR0dPkyhmbe88jWKAUrbT c8gMzf3cGuadT5n+je2qi7s81AtH68k+Jb7m179PLNUDT54gJYRsL9U1pO0FGgEhIpKN PbrI6aqavJal5yyBd3coIA2QrCHKEtTKTZSQ4pdBN0qjtmXkkpSawNx3pmbjx4BMOWdC QAnVfj2C0MaSaWjqKeuHHEMgCIkqL+V9m55MxHXF1sdplXQeZsCIWiB5x9yqv1fasCNl Xv2Dt2dzySFQGIX4lF39Om5BtKl85Iax1C4JpM/iFewdCzl/6x3GHuTFiRN82jhr/H4w ELzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Q0x8reR+y8VY9XBx3PtPCY7fqMs2lXRuHU5JVxtfCBc=; b=LxmcBbxhzc/a2RltQQ2OcWY3Yn4YXuSpog77VX5Vz10vX22kCN/uQAqba+kIDzi+ZU 0FRdzCQAtvGqdEczJD7uxDSVmoj1A6+HBMYlJ1tWv4XGA3lg9QS1/bOS3m2a+6gf5yGx dHDyd8YDY125Q6SY8/ZZDtun9TNhs9fKBoOQJ+W5kQSrlOT9haT/KEXmhO/E239/gQLY kk4YxmL3IxB02GDhXArBEzrZMGtsMGFnInXkQ935njWQKE9VhHaqIjWRLw5IyIGaJUz3 mRWRUN20jmhIKvKf0qz1isQ3X2XEgPydDu/gVKjiap//MlvN0fNQa9YwaaLuc2yemucy B4iw== X-Gm-Message-State: AOAM530LxCb4zHRupQbkE+Z10gc+RKEnMYxRioKHuUFIVbY7XWIQZbKc n6dJ0aNv6gzt4uUK48z0j8I= X-Google-Smtp-Source: ABdhPJy/KtVcKkkCpVJ7XhgLn5jkI+Y8yn59maxYjddDP0Gkn6i4JhUZnBz7x5EWZFuw3+pLnrlCtg== X-Received: by 2002:a17:906:9bf8:: with SMTP id de56mr7796151ejc.425.1613040327152; Thu, 11 Feb 2021 02:45:27 -0800 (PST) Received: from localhost.localdomain (5-12-227-87.residential.rdsnet.ro. [5.12.227.87]) by smtp.gmail.com with ESMTPSA id l1sm3815458eje.12.2021.02.11.02.45.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Feb 2021 02:45:26 -0800 (PST) From: Vladimir Oltean To: David Ahern , netdev@vger.kernel.org Cc: Andrew Lunn , Florian Fainelli , Vivien Didelot , Jiri Pirko , Ido Schimmel , DENG Qingfang , Tobias Waldekranz , Roopa Prabhu , Nikolay Aleksandrov , Stephen Hemminger Subject: [PATCH iproute2 2/6] man8/bridge.8: document that "local" is default for "bridge fdb add" Date: Thu, 11 Feb 2021 12:44:58 +0200 Message-Id: <20210211104502.2081443-3-olteanv@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210211104502.2081443-1-olteanv@gmail.com> References: <20210211104502.2081443-1-olteanv@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Vladimir Oltean The bridge does this: fdb_modify: /* Assume permanent */ if (!(req.ndm.ndm_state&(NUD_PERMANENT|NUD_REACHABLE))) req.ndm.ndm_state |= NUD_PERMANENT; So let's make the user aware of the fact that if they don't want local entries, they need to specify some other flag like "static". Signed-off-by: Vladimir Oltean --- man/man8/bridge.8 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/man/man8/bridge.8 b/man/man8/bridge.8 index 12c09a56563d..223e65d64757 100644 --- a/man/man8/bridge.8 +++ b/man/man8/bridge.8 @@ -514,7 +514,8 @@ the Ethernet MAC address. the interface to which this address is associated. .B local -- is a local permanent fdb entry +- is a local permanent fdb entry. This flag is default unless "static" or + "dynamic" are explicitly specified. .sp .B permanent From patchwork Thu Feb 11 10:44:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Oltean X-Patchwork-Id: 381590 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CD12C433DB for ; Thu, 11 Feb 2021 10:51:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3BE9464E7E for ; Thu, 11 Feb 2021 10:51:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229963AbhBKKuj (ORCPT ); Thu, 11 Feb 2021 05:50:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230465AbhBKKqd (ORCPT ); Thu, 11 Feb 2021 05:46:33 -0500 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7279CC061788 for ; Thu, 11 Feb 2021 02:45:29 -0800 (PST) Received: by mail-ej1-x634.google.com with SMTP id y9so9264411ejp.10 for ; Thu, 11 Feb 2021 02:45:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XMRInG8YduALFgGWZAULvLD9JmzWOSKsqMn1CgAioHo=; b=alXI3bTKlqQHRWHWTThap8QF2iUxW7hsjnUbBL0QFKyN12T6akfuuX53VOSfbPJlpf d2AP1/TrRMN7P5pzPi0GIDOHkH/F3a0uPcYsYaz3cZt0bFFS3mO5pEFvt5oNcSb4ClPC kDKDiritpJDu+mmaB6Yfqa9csxeyi+VAE5cN1sZv8jPOtm+hLkEND/f2Hqc1sZpYGfBl ytS0FXUbx5iaja9U9WwLlPhzy4MzIhMiCcKrYG4jA8UXgM75coTFkcQcXUeAwbvQ0MPg SfAFdDrlyKjobhzSAlg9UciCZkOrTP73KU3VbKl8bLiuqRP1uelgrxnXACVe5hJ1PixZ JxCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XMRInG8YduALFgGWZAULvLD9JmzWOSKsqMn1CgAioHo=; b=gUlDjwCXq6b1+50rceroYEirxfipVgL0sv2DbClMMk+RSeGXgAGFNupZRCJMJIf62w HeM30DD7W1cZwAUDG2FhoKDD55Yr7p3Gqb9938ehoQ9BS6pjomI4aLOXytAxWLW76ieC GMw0+ZqJ87PZb7RX3ZRvQwGk+q08iwb3B8BE5lBHfOD5kiI7tmC3uHkAlg7ouL5m3TDa TRDd7110iIT9cRQahs18sB47eaOBY2imZXNiCPubKf5sxVpIxvdJ+wfN258ZJnrEfuCC 3Bsyrr/tNlct6looEhKSuCuBrzgVz+/j21HLxjZuthpZU37XgqCufTwVnF6idCb9gWeL cw1Q== X-Gm-Message-State: AOAM53065EdwLLtnGZSpk6ki3X89KoHBoT288+H4cWEB2/A/8ENcsWe9 I5w8EQjRoS1VItGwQsIlUE8= X-Google-Smtp-Source: ABdhPJyPtypliSVhvaLkOrdFODgX0GpLywhwEEYHEl9zDLIhYQFam2bxWm+ufCmyW9U7YmvyPuCBgQ== X-Received: by 2002:a17:906:3883:: with SMTP id q3mr7820509ejd.160.1613040328222; Thu, 11 Feb 2021 02:45:28 -0800 (PST) Received: from localhost.localdomain (5-12-227-87.residential.rdsnet.ro. [5.12.227.87]) by smtp.gmail.com with ESMTPSA id l1sm3815458eje.12.2021.02.11.02.45.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Feb 2021 02:45:27 -0800 (PST) From: Vladimir Oltean To: David Ahern , netdev@vger.kernel.org Cc: Andrew Lunn , Florian Fainelli , Vivien Didelot , Jiri Pirko , Ido Schimmel , DENG Qingfang , Tobias Waldekranz , Roopa Prabhu , Nikolay Aleksandrov , Stephen Hemminger Subject: [PATCH iproute2 3/6] man8/bridge.8: explain what a local FDB entry is Date: Thu, 11 Feb 2021 12:44:59 +0200 Message-Id: <20210211104502.2081443-4-olteanv@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210211104502.2081443-1-olteanv@gmail.com> References: <20210211104502.2081443-1-olteanv@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Vladimir Oltean Explaining the "local" flag by saying that it is "a local permanent fdb entry" is not very helpful, be more specific. Signed-off-by: Vladimir Oltean --- man/man8/bridge.8 | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/man/man8/bridge.8 b/man/man8/bridge.8 index 223e65d64757..b629c52b8341 100644 --- a/man/man8/bridge.8 +++ b/man/man8/bridge.8 @@ -514,8 +514,10 @@ the Ethernet MAC address. the interface to which this address is associated. .B local -- is a local permanent fdb entry. This flag is default unless "static" or - "dynamic" are explicitly specified. +- is a local permanent fdb entry, which means that the bridge will not forward +frames with this destination MAC address and VLAN ID, but terminate them +locally. This flag is default unless "static" or "dynamic" are explicitly +specified. .sp .B permanent From patchwork Thu Feb 11 10:45:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Oltean X-Patchwork-Id: 382351 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84B49C43381 for ; Thu, 11 Feb 2021 10:50:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 651F564E30 for ; Thu, 11 Feb 2021 10:50:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230474AbhBKKuI (ORCPT ); Thu, 11 Feb 2021 05:50:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230468AbhBKKqd (ORCPT ); Thu, 11 Feb 2021 05:46:33 -0500 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7FEE1C06178A for ; Thu, 11 Feb 2021 02:45:30 -0800 (PST) Received: by mail-ej1-x635.google.com with SMTP id i8so9312124ejc.7 for ; Thu, 11 Feb 2021 02:45:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JPhnCoGgJ5HsL07+WIpZ2VAVa8xMb9ssCIEdiBXb2HM=; b=Q4pwV6qLqRpbI+INpT3umC4BLNutFCLtcWuH/68u4Y6nLYM9YFL8IfyorSwT+SsEO5 LwGCj7B34ZWk0SkMHtENSoBSkjS0PKR2Mz3HHVZjmFAZcM7s3FP4qmS/dQiQK1TlsNcb ppWcRDWq0odKURh+7e7wZiMD2ot7koFQLSsWKoVlZssEAfIxmgPD3tHYkNZZzYvYXGW2 eySOeui32IkelFHAVotULKc2BJC/dk3r2MVkjg+uTP1k0OUIVVmT8M4rZjiEtg9bx1ho zlsl6LflwzKf+UY04F+D3F9LGTATBwCCzZRn6BgzS/mpd2zbzA5X/Uu8iCb2TbUfw1gA +RHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JPhnCoGgJ5HsL07+WIpZ2VAVa8xMb9ssCIEdiBXb2HM=; b=HyWWOFKcQTv27nTBmoNgp6XLLSmAyFJtCuuX5dDhjWKnbcf+AiUFEeNGHczb1QQsnD DRTSx8GYBQM/CPTKKhrbfGluBtp8N/GXWBkyU9DFSIWxCaDxrqu2TeN+HQr3cBtQORV2 ARYO1U/l/TZ1nvPasSieC3U649Wov3rIvjdtaH3u87DsGoa1/iDurLA50d9/QigON6Jx W5xA7AY+Op3u8pgIO20lzuAuci/7xx03VmfgfBemWi/kK30+vSLLl/+haAQIA5gQr8U7 CSh8/6wkIBJLlZA+yf1kos1MGcmUZ2QpVTrXEUOQR06hXaZE7ErXnJC/oS1GpM19hMBQ aQCA== X-Gm-Message-State: AOAM531Z9sL7rdL2KGSsiHZPqL4a8xsjAk26PKc+sSFRR44+bZYxe+x3 9mto1CeyZs9gk7QudHmSY1e90hHWLc8= X-Google-Smtp-Source: ABdhPJyoo5FT+XhlLNRxzKBzPmgltJKCFvz+ygKkRp54JHnoBomcSN05Xd2HEJ8O8kxkxkFmQ+zQ8g== X-Received: by 2002:a17:907:7605:: with SMTP id jx5mr8085554ejc.340.1613040329285; Thu, 11 Feb 2021 02:45:29 -0800 (PST) Received: from localhost.localdomain (5-12-227-87.residential.rdsnet.ro. [5.12.227.87]) by smtp.gmail.com with ESMTPSA id l1sm3815458eje.12.2021.02.11.02.45.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Feb 2021 02:45:28 -0800 (PST) From: Vladimir Oltean To: David Ahern , netdev@vger.kernel.org Cc: Andrew Lunn , Florian Fainelli , Vivien Didelot , Jiri Pirko , Ido Schimmel , DENG Qingfang , Tobias Waldekranz , Roopa Prabhu , Nikolay Aleksandrov , Stephen Hemminger Subject: [PATCH iproute2 4/6] man8/bridge.8: fix which one of self/master is default for "bridge fdb" Date: Thu, 11 Feb 2021 12:45:00 +0200 Message-Id: <20210211104502.2081443-5-olteanv@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210211104502.2081443-1-olteanv@gmail.com> References: <20210211104502.2081443-1-olteanv@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Vladimir Oltean The bridge program does: fdb_modify: /* Assume self */ if (!(req.ndm.ndm_flags&(NTF_SELF|NTF_MASTER))) req.ndm.ndm_flags |= NTF_SELF; which is clearly against the documented behavior. The only thing we can do, sadly, is update the documentation. Signed-off-by: Vladimir Oltean --- man/man8/bridge.8 | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/man/man8/bridge.8 b/man/man8/bridge.8 index b629c52b8341..1dc0aec83f09 100644 --- a/man/man8/bridge.8 +++ b/man/man8/bridge.8 @@ -533,11 +533,12 @@ specified. .sp .B self -- the address is associated with the port drivers fdb. Usually hardware. +- the address is associated with the port drivers fdb. Usually hardware + (default). .sp .B master -- the address is associated with master devices fdb. Usually software (default). +- the address is associated with master devices fdb. Usually software. .sp .B router From patchwork Thu Feb 11 10:45:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Oltean X-Patchwork-Id: 382352 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D886AC433E6 for ; Thu, 11 Feb 2021 10:49:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 96F6664E30 for ; Thu, 11 Feb 2021 10:49:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230386AbhBKKst (ORCPT ); Thu, 11 Feb 2021 05:48:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230469AbhBKKqd (ORCPT ); Thu, 11 Feb 2021 05:46:33 -0500 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 937C0C06178B for ; Thu, 11 Feb 2021 02:45:31 -0800 (PST) Received: by mail-ed1-x52e.google.com with SMTP id t5so6402317eds.12 for ; Thu, 11 Feb 2021 02:45:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ffIX1Q9gvmYguUHbVNgZRrb4xzzJo83lCHTV+IvAs+s=; b=UBUJvi2zi6Qb/FOFKlSmYdKoWGMXf9tN07BdchV1gH6gUHJCtHkXeZe6RMxJcebI3f IXi7UXRSCJCnHsaxmrFyYqeU1WRJdWisXneZowDcCLZxkNjVaa3z1Qi57aH4YBd9eNCk 2b+s37zWuBFxBWIzGWJEv9jqvXPQq1vK3abiBDXig+4urvqmeVlu8Ik4Jy9/RWzGdaqY +7OApFZF1ZeTT+P9z3Zfgtf4zcUO5XdI1hzxYfNRFBt0qwOTHAWO23CB+u0eee/tPR8h SHEjZyt680NK8nYhHjU9PkC9fLLfu0PuoyXQDk6nHQpgURwn3kWsJ7ms8IM2IT0e4tnN KfTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ffIX1Q9gvmYguUHbVNgZRrb4xzzJo83lCHTV+IvAs+s=; b=EBfvqYd1i14zV4Fe7VAUUcit9ekGlpDuoV7I8JFM3sDwx2audQIkqgEY4LUAip06b1 Wb+GpBwmWMFQ/arZu3KlmbaYipSEAurRKGw59cRg3N7hE0tbOT7POoad5pPwFgLAIqbq EzUAMZ60HUQ4GT3bgCqfvtf/+5jMAwjrwPC/6dFru99l9p2+vlkN2410JriUC3JKd6va I/e6/ntostcDkKaf0zqdfWkjs0fYrdyChVtg/XYt9BjeaO+Bybeyy+aIQcbHG6NEOXXC hR6JHOaFsJOc90+9gWKh1Js4UIhIWd9pC3vEUgGQxRAVMm7eKwXf2lbHRUnOWGm/N1Re HIIg== X-Gm-Message-State: AOAM533AFnwxana1zfuCcPZpfImbn4eFlqW4dkCr6eIXczVTrMdoBjrG adIYO7GFYkhFxDggibMvxdE= X-Google-Smtp-Source: ABdhPJwad9D3MEcnPdmzoE8K+2kSqtpMy20cYcoHR69S3YNpDeTf5SsCDIKgWU/HvONGTK6A/1L+0Q== X-Received: by 2002:a05:6402:21c3:: with SMTP id bi3mr6102236edb.68.1613040330321; Thu, 11 Feb 2021 02:45:30 -0800 (PST) Received: from localhost.localdomain (5-12-227-87.residential.rdsnet.ro. [5.12.227.87]) by smtp.gmail.com with ESMTPSA id l1sm3815458eje.12.2021.02.11.02.45.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Feb 2021 02:45:30 -0800 (PST) From: Vladimir Oltean To: David Ahern , netdev@vger.kernel.org Cc: Andrew Lunn , Florian Fainelli , Vivien Didelot , Jiri Pirko , Ido Schimmel , DENG Qingfang , Tobias Waldekranz , Roopa Prabhu , Nikolay Aleksandrov , Stephen Hemminger Subject: [PATCH iproute2 5/6] man8/bridge.8: explain self vs master for "bridge fdb add" Date: Thu, 11 Feb 2021 12:45:01 +0200 Message-Id: <20210211104502.2081443-6-olteanv@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210211104502.2081443-1-olteanv@gmail.com> References: <20210211104502.2081443-1-olteanv@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Vladimir Oltean The "usually hardware" and "usually software" distinctions make no sense, try to clarify what these do based on the actual kernel behavior. Signed-off-by: Vladimir Oltean --- man/man8/bridge.8 | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/man/man8/bridge.8 b/man/man8/bridge.8 index 1dc0aec83f09..d0bcd708bb61 100644 --- a/man/man8/bridge.8 +++ b/man/man8/bridge.8 @@ -533,12 +533,21 @@ specified. .sp .B self -- the address is associated with the port drivers fdb. Usually hardware - (default). +- the operation is fulfilled directly by the driver for the specified network +device. If the network device belongs to a master like a bridge, then the +bridge is bypassed and not notified of this operation (and if the device does +notify the bridge, it is driver-specific behavior and not mandated by this +flag, check the driver for more details). The "bridge fdb add" command can also +be used on the bridge device itself, and in this case, the added fdb entries +will be locally terminated (not forwarded). In the latter case, the "self" flag +is mandatory. The flag is set by default if "master" is not specified. .sp .B master -- the address is associated with master devices fdb. Usually software. +- if the specified network device is a port that belongs to a master device +such as a bridge, the operation is fulfilled by the master device's driver, +which may in turn notify the port driver too of the address. If the specified +device is a master itself, such as a bridge, this flag is invalid. .sp .B router From patchwork Thu Feb 11 10:45:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Oltean X-Patchwork-Id: 381589 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95673C433E9 for ; Thu, 11 Feb 2021 10:52:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6378760238 for ; Thu, 11 Feb 2021 10:52:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230109AbhBKKvz (ORCPT ); Thu, 11 Feb 2021 05:51:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230473AbhBKKqm (ORCPT ); Thu, 11 Feb 2021 05:46:42 -0500 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF279C06178C for ; Thu, 11 Feb 2021 02:45:32 -0800 (PST) Received: by mail-ed1-x530.google.com with SMTP id s5so6416451edw.8 for ; Thu, 11 Feb 2021 02:45:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/lonPnqVhgTPFxyiJp5qGibeqEG71soSjMN8+ZgR8g4=; b=quwE8MQDaoqtoTFwnpifaMKStGTI8uzJFldSG91r42y+eUAvcmgi1waJbAGnhI0YvZ dez/5L9lpa2ehI5Rq2OxrIDb6RqFnz0maJ1VAfniFizxqbZEGBGzrGXgOJUx0pFddfY+ 28iCZqDPro2+gHwk/i9sjgEiJ5BkthZSbDrJ/7cNh488LqKtoyciKmVY7TO31aaUFrK3 vVAdvJFG/iA3sJjnglyFaQO6Zqpn3Eu3zHfe3Ih8tjcpa70Ipwn4p67EanfaoOSXW5Bw zjfhGte1PdptlsvzstskfJ9dnsXOa3pyyYbXzb3hhezx3/eJ8KZJk8rKnxshe1aOkSLN cHCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/lonPnqVhgTPFxyiJp5qGibeqEG71soSjMN8+ZgR8g4=; b=UgA0kD1qnj1dmUnf5LeGC4hpmcAODqQo+rNLFnKhyCAsjHVNEzR9xuTgzsqGP6YJ1T kU7Fe19hnFcCYJQ+f1w5ff0Kr5t1bIvLxev35T/CLDruCJFztyDiVi1+1h+e4ILH01al h5tFgQHnyvHOjfphDE8si/mgFHYLpeORRTEersj/iRerc818j4qT2Ie+q4upxwu8Olg0 eIJZr8uYZUhANlKQHBPvJV6368StOT68bVtBx4MQPeMxTuqRsxEV3WFfNbVDnxPv/SY/ lTEIGSRkx8TQekPsp3ck6I5kP02CzGnoCSj3MyCL6KHnl93CEOcD8E67wWjp6qJeZDVX 1irg== X-Gm-Message-State: AOAM530QBVU2HY3DHFZkZK7x5S2ojf4FyjWZsu5+5GRp56KISFiToLYQ beKrnxXhuRG/839eaF+T2TM= X-Google-Smtp-Source: ABdhPJzQBEvvnTNYNFDzkTv0UKX/U3K1LJ3JhFf7uBmFXqc9l+ijHHzbUMkjOHn7RMjCMW0Z/hCo0w== X-Received: by 2002:a50:fa93:: with SMTP id w19mr7849527edr.211.1613040331454; Thu, 11 Feb 2021 02:45:31 -0800 (PST) Received: from localhost.localdomain (5-12-227-87.residential.rdsnet.ro. [5.12.227.87]) by smtp.gmail.com with ESMTPSA id l1sm3815458eje.12.2021.02.11.02.45.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Feb 2021 02:45:31 -0800 (PST) From: Vladimir Oltean To: David Ahern , netdev@vger.kernel.org Cc: Andrew Lunn , Florian Fainelli , Vivien Didelot , Jiri Pirko , Ido Schimmel , DENG Qingfang , Tobias Waldekranz , Roopa Prabhu , Nikolay Aleksandrov , Stephen Hemminger Subject: [PATCH iproute2 6/6] man8/bridge.8: be explicit that "flood" is an egress setting Date: Thu, 11 Feb 2021 12:45:02 +0200 Message-Id: <20210211104502.2081443-7-olteanv@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210211104502.2081443-1-olteanv@gmail.com> References: <20210211104502.2081443-1-olteanv@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Vladimir Oltean Talking to varios people, it became apparent that there is a certain ambiguity in the description of these flags. They refer to egress flooding, which should perhaps be stated more clearly. Signed-off-by: Vladimir Oltean --- man/man8/bridge.8 | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/man/man8/bridge.8 b/man/man8/bridge.8 index d0bcd708bb61..9d8663bd23cc 100644 --- a/man/man8/bridge.8 +++ b/man/man8/bridge.8 @@ -397,7 +397,8 @@ bridge FDB. .TP .BR "flood on " or " flood off " -Controls whether a given port will flood unicast traffic for which there is no FDB entry. By default this flag is on. +Controls whether unicast traffic for which there is no FDB entry will be +flooded towards this given port. By default this flag is on. .TP .B hwmode @@ -413,8 +414,8 @@ switch. .TP .BR "mcast_flood on " or " mcast_flood off " -Controls whether a given port will flood multicast traffic for which -there is no MDB entry. By default this flag is on. +Controls whether multicast traffic for which there is no MDB entry will be +flooded towards this given port. By default this flag is on. .TP .BR "mcast_to_unicast on " or " mcast_to_unicast off "