From patchwork Wed Feb 10 17:21:06 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 380544 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2FBBC433DB for ; Wed, 10 Feb 2021 17:22:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD0F064E7E for ; Wed, 10 Feb 2021 17:22:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231987AbhBJRVy (ORCPT ); Wed, 10 Feb 2021 12:21:54 -0500 Received: from mail.kernel.org ([198.145.29.99]:43568 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230263AbhBJRVx (ORCPT ); Wed, 10 Feb 2021 12:21:53 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id D84C864E7E; Wed, 10 Feb 2021 17:21:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612977674; bh=oi52NGlFNqNCCDTyPgjBQebaWnixIVhZEGbGu5Pid9A=; h=From:To:Subject:Date:From; b=EkRfWXtT6a/l9KhePFhdWLBdlF/k1U6A0sEAuQidBeRpaF5bo8UT/6nJ7me6Lddm+ w5jlkH5jBdeAjWz+vBDRedDK1KnfwTfeSrrdSrUJeKgH5q23lEGfNKJUuSKBUzAxsP E6iCnq8k7p+yUfnviu03aP1C4AJuxWT89g0Pv0xQ6LgWBc2DVzuGviwIUqsEOSWecA a59r9thS3acScYLygUFnrk1up4cWVmKb7s2vlcED3glbbh9nWbKmnmAgc2nwOwQ3UE JJZyQ9OJBVIDOChJgU0A3BX1T89mPUr6TQtaAme6PSNvqSQ/B1Uy8iK/3aLZeBTHJy ah3NYeP2PUpbg== From: Krzysztof Kozlowski To: Krzysztof Kozlowski , Sebastian Reichel , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH 1/3] MAINTAINERS: power: supply: add entry for S3C ADC battery driver Date: Wed, 10 Feb 2021 18:21:06 +0100 Message-Id: <20210210172108.334896-1-krzk@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org The S3C ADC battery driver is a very old piece of code but still used by (very old as well) S3C24xx platforms (iPAQ h1930/h1940/rx1950). Currently the header file is not covered by maintainers file, so it might look abandoned. Add a new entry for entire S3C ADC battery driver with Krzysztof Kozlowski as maintainer (as Krzysztof maintains still Samsung S3C24xx platform) to indicate that some basic review can take place. However considering that the S3C24xx platform is quite old with only few users currently and Krzysztof does not have the actual hardware, let's mark the driver as "Odd fixes". Cc: Sebastian Reichel Signed-off-by: Krzysztof Kozlowski --- MAINTAINERS | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5f7aa507b812..6abf7cc513df 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -15614,6 +15614,13 @@ S: Supported W: http://www.ibm.com/developerworks/linux/linux390/ F: drivers/s390/scsi/zfcp_* +S3C ADC BATTERY DRIVER +M: Krzysztof Kozlowski +L: linux-samsung-soc@vger.kernel.org +S: Odd Fixes +F: drivers/power/supply/s3c_adc_battery.c +F: include/linux/s3c_adc_battery.h + S3C24XX SD/MMC Driver M: Ben Dooks L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) From patchwork Wed Feb 10 17:21:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 381401 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C6CFC43381 for ; Wed, 10 Feb 2021 17:22:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D32D264DE3 for ; Wed, 10 Feb 2021 17:22:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232101AbhBJRV4 (ORCPT ); Wed, 10 Feb 2021 12:21:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:43580 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231695AbhBJRVy (ORCPT ); Wed, 10 Feb 2021 12:21:54 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5F2E064EAA; Wed, 10 Feb 2021 17:21:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612977675; bh=6gU2hr0ySWdL4EzqNvCcJ94uNlFU8d5EdszufVd6c+M=; h=From:To:Subject:Date:In-Reply-To:References:From; b=afHBZThxamSYcna41fA4y/Ug6lI480lRsUQyNIiSrnwf77jvPxidSjmgh1aEF3zao Qbzb41Iga3anrTiXfpsvqPhthjB15GDvBU0SAidDD0a2P6t2uvUEtNHj6XRj9WHlId N+wYl+BZgsPw9k4f2uuleM7Oao5igNYkkVGCYLfFjnqgUPa+PR+fGs4ySFtvol+392 4NGeks3IAljVqjOHF+Nj6AiRoV4OI4mSM51FsOBzp63W9xdyHhryx9NnjYuY+DL4b9 lT0Y1QNctV0JkEQXME/MQ+3URxCiadllDQycSna0udvhYRCACuRAll5I4mWHXCnKRp XV778QfAsC2ZQ== From: Krzysztof Kozlowski To: Krzysztof Kozlowski , Sebastian Reichel , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH 2/3] power: supply: s3c_adc_battery: add SPDX license identifier Date: Wed, 10 Feb 2021 18:21:07 +0100 Message-Id: <20210210172108.334896-2-krzk@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210210172108.334896-1-krzk@kernel.org> References: <20210210172108.334896-1-krzk@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Add SPDX license identifier and replace license boilerplate. Signed-off-by: Krzysztof Kozlowski --- drivers/power/supply/s3c_adc_battery.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/power/supply/s3c_adc_battery.c b/drivers/power/supply/s3c_adc_battery.c index a2addc24ee8b..de98aea53a24 100644 --- a/drivers/power/supply/s3c_adc_battery.c +++ b/drivers/power/supply/s3c_adc_battery.c @@ -1,13 +1,8 @@ -/* - * iPAQ h1930/h1940/rx1950 battery controller driver - * Copyright (c) Vasily Khoruzhick - * Based on h1940_battery.c by Arnaud Patard - * - * This file is subject to the terms and conditions of the GNU General Public - * License. See the file COPYING in the main directory of this archive for - * more details. - * - */ +// SPDX-License-Identifier: GPL-2.0 +// +// iPAQ h1930/h1940/rx1950 battery controller driver +// Copyright (c) Vasily Khoruzhick +// Based on h1940_battery.c by Arnaud Patard #include #include From patchwork Wed Feb 10 17:21:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 381400 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E3B2C4332E for ; Wed, 10 Feb 2021 17:22:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 57F5E64E7E for ; Wed, 10 Feb 2021 17:22:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232138AbhBJRV5 (ORCPT ); Wed, 10 Feb 2021 12:21:57 -0500 Received: from mail.kernel.org ([198.145.29.99]:43590 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232097AbhBJRV4 (ORCPT ); Wed, 10 Feb 2021 12:21:56 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id D5E8764EC7; Wed, 10 Feb 2021 17:21:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612977677; bh=3XsRZ7GaXx8P2kZhXGx8Nf98E9I8mJO0HBDDnM97tTI=; h=From:To:Subject:Date:In-Reply-To:References:From; b=fVMn/+wSlxJDfg8IIIAwSZ3aB/5/73hoMqc177Y6KIUTjK2aEvxqKbxFm1g8yxstH SFfvtWT0YCA8iOxmhdBh4ZbbNexcYtiUx5KHG8sq5niB0nfC03/TZD9UCtU49bd7Xa 2PWr+uCLshusoY43a99IIflIONLDO9NoAvPN1rAS3ky9rPIfZniAZePooEuE4BzZ/j pP5eCNNr/s5yCqECttj1H8tIjLE+WAnq7GlvTo2bGNHiTT4YTk4AHQIVHz7gbtwCe+ b+/OdeWdPdEyklKJXnYa5CJmPWkQsSZpoG2GiNr27Jfkj7SuCcmBsELRTagiYX6mu5 l3kwv2NzKSL/A== From: Krzysztof Kozlowski To: Krzysztof Kozlowski , Sebastian Reichel , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH 3/3] power: supply: s3c_adc_battery: remove unused pdata in suspend/resume Date: Wed, 10 Feb 2021 18:21:08 +0100 Message-Id: <20210210172108.334896-3-krzk@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210210172108.334896-1-krzk@kernel.org> References: <20210210172108.334896-1-krzk@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org The "pdata" local variable is not used in suspend/resume handlers since commit 7776bcd241e0 ("power: supply: s3c-adc-battery: Convert to GPIO descriptors"): drivers/power/supply/s3c_adc_battery.c: In function ‘s3c_adc_bat_suspend’: drivers/power/supply/s3c_adc_battery.c:405:28: warning: unused variable ‘pdata’ [-Wunused-variable] drivers/power/supply/s3c_adc_battery.c: In function ‘s3c_adc_bat_resume’: drivers/power/supply/s3c_adc_battery.c:422:28: warning: unused variable ‘pdata’ [-Wunused-variable] Signed-off-by: Krzysztof Kozlowski --- drivers/power/supply/s3c_adc_battery.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/power/supply/s3c_adc_battery.c b/drivers/power/supply/s3c_adc_battery.c index de98aea53a24..dc700066d7bc 100644 --- a/drivers/power/supply/s3c_adc_battery.c +++ b/drivers/power/supply/s3c_adc_battery.c @@ -402,8 +402,6 @@ static int s3c_adc_bat_remove(struct platform_device *pdev) static int s3c_adc_bat_suspend(struct platform_device *pdev, pm_message_t state) { - struct s3c_adc_bat_pdata *pdata = pdev->dev.platform_data; - if (main_bat.charge_finished) { if (device_may_wakeup(&pdev->dev)) enable_irq_wake( @@ -419,8 +417,6 @@ static int s3c_adc_bat_suspend(struct platform_device *pdev, static int s3c_adc_bat_resume(struct platform_device *pdev) { - struct s3c_adc_bat_pdata *pdata = pdev->dev.platform_data; - if (main_bat.charge_finished) { if (device_may_wakeup(&pdev->dev)) disable_irq_wake(