From patchwork Sun Feb 7 23:21:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin King X-Patchwork-Id: 378222 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1ED4C433E0 for ; Sun, 7 Feb 2021 23:22:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A114964DE7 for ; Sun, 7 Feb 2021 23:22:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229564AbhBGXWE (ORCPT ); Sun, 7 Feb 2021 18:22:04 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:36875 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229537AbhBGXWE (ORCPT ); Sun, 7 Feb 2021 18:22:04 -0500 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1l8tMm-00013l-9Z; Sun, 07 Feb 2021 23:21:20 +0000 From: Colin King To: Jiri Kosina , Benjamin Tissoires , Nestor Lopez Casado , linux-input@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] HID: logitech-dj: fix unintentional integer overflow on left shift Date: Sun, 7 Feb 2021 23:21:20 +0000 Message-Id: <20210207232120.8885-1-colin.king@canonical.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org From: Colin Ian King Shifting the integer value 1 is evaluated using 32-bit rithmetic and then used in an expression that expects a 64-bit value, so there is potentially an integer overflow. Fix this by using th BIT_ULL macro to perform the shift and avoid the overflow. Addresses-Coverity: ("Uninitentional integer overflow") Fixes: 534a7b8e10ec ("HID: Add full support for Logitech Unifying receivers") Signed-off-by: Colin Ian King --- drivers/hid/hid-logitech-dj.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c index 45e7e0bdd382..747f41be0603 100644 --- a/drivers/hid/hid-logitech-dj.c +++ b/drivers/hid/hid-logitech-dj.c @@ -1035,7 +1035,7 @@ static void logi_dj_recv_forward_null_report(struct dj_receiver_dev *djrcv_dev, memset(reportbuffer, 0, sizeof(reportbuffer)); for (i = 0; i < NUMBER_OF_HID_REPORTS; i++) { - if (djdev->reports_supported & (1 << i)) { + if (djdev->reports_supported & BIT_ULL(i)) { reportbuffer[0] = i; if (hid_input_report(djdev->hdev, HID_INPUT_REPORT,