From patchwork Tue Mar 5 13:32:40 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 159654 Delivered-To: patch@linaro.org Received: by 2002:a02:5cc1:0:0:0:0:0 with SMTP id w62csp4974843jad; Tue, 5 Mar 2019 05:33:04 -0800 (PST) X-Google-Smtp-Source: APXvYqyxI0H9QYtVK5Flyf6DzessQLQRmpkOxz/OSCdqZ1Vu5dWpASIkRrr7YL1hYXtJiR0PAQAl X-Received: by 2002:a63:4607:: with SMTP id t7mr1415580pga.306.1551792784514; Tue, 05 Mar 2019 05:33:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551792784; cv=none; d=google.com; s=arc-20160816; b=wOjbVJeigtsrC7oydFTXAjtsEJJ8CDGbAsLzHv4JFEZuAp8juEYsST+WVIuNFCtq5t tNWBdNBcXUiebauYW6racskXRN3wwKJU2ZL8XusnHKtwF8BmNO2h/zVSPNaUBE7FxFSn TkSjK5bXXlNS3wOu/qJ+Liq1FOOaO2bXWDZr14O9Ez66zzgXTTz0vmrWf6AzNzqxuuMu 2tOTXcOfh/mdP8lu93w7dUPhuDyOHf1soQ+yOWoShNQ0Z9J/Kd/cBm0qJADBdrcpLbYg x1sHmW/anLnXE/oRp506kcdIKDIJEP33KRUqdXxcWq9F4IVw2apbRK4XpNouEFRHFWHv RvgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=7i5gD5Lofh1yfKqiJiBbaMaIwdReuRN+twn639r6a6c=; b=JuqWzbGBrH1Z6uuMMcplXOPbCS1OmgB6XI0V4nQJyvSN2PzcCrT9sNwHKF96OHku+w LSI/5uyAxt/q9OfumImVmJqZ+qgE/MI3wI7FIVEtSyjjzm9YkILArtreutXf6GPQTVLf v1M9H8M9xitFqrjcEi6emoiKikWpC76zrNCvJ2to2JL3KOCojHdYTlslgMiLLEjdIJRm 29oCWD/KNnuY1mO5ivtlogxspd+lfuyr1MF5A9wKrvKrSdhzJ/mWt9K4/zSUMoIznlX+ chAQSpTni86crJIP8ee8b7EdlFYcXxEoydOAXkVMGowQ4qDcg7Q0LdSZpI7Ku1SJFqA3 /axQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=GSgcDOrd; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id d9si8906189pln.403.2019.03.05.05.33.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Mar 2019 05:33:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=GSgcDOrd; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 4BF6F211D5054; Tue, 5 Mar 2019 05:33:02 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::442; helo=mail-wr1-x442.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5A87C2194EB70 for ; Tue, 5 Mar 2019 05:33:00 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id l5so9465394wrw.6 for ; Tue, 05 Mar 2019 05:33:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fBTPKjFBnThj3wqCC4pkNHEAK/9TzFnuRMlvF9maxoc=; b=GSgcDOrdIboM5lHuDXDSutF6UcDhqORjbXlnX1ApvCxt0XEjwqbvj9ymF5FsbBPUaL SDBj9poT2dFmLtsgUc5q6mnik0EHzJq0kI1MchuvlrBCDXL6VOmlIM2s0i4FzfvcJRuk JRYpNo5lTRK9GcgQQa1wE8T8gZmp/G5xHv+fTUdYsl5RKfLcqk1NPC2g0zyolqgmcqNC RWDsvnYNxd32VGk38AtzYqhfZulNyPDf/L2HgjNgJdWz2CZD7TErlt6H6H/3i/GAaWrL 71qodh21jSkOyDy3FrWuI937OfVVAQQvvMSDOTiZR9XpHE2IdnTFKUgxeDTpH+yW+CIu udng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fBTPKjFBnThj3wqCC4pkNHEAK/9TzFnuRMlvF9maxoc=; b=nTDv3/3ZKY5kqITtRGbQXykKuXO6+mqQnhEWpzvHIGHSjU3yqRF6g2F3h9U4oAdVmi Oxg3tQGODMncbrtRYJtHr++kjK7eapVo4X0JP9D1YhKDj/srFXYFZro9y8XMdKpTImrR 5e1DiZm94q3I5Y0FvglXJqWy0fThoZxASsA7hcpEpUEs6CqLpkMUxZI0NMyIxQNFqpCT HYoOisFfft+BjNcczRqfHRs1l2PQY4EoX/e++1/4nKqR9CAOlWdMPZ6mBFStT3sGtc02 rITcTph48Pn3UjAKD5fLVG9B0gEY200njUOMWuO/SGmBmkk3HrXJA4n3iewrDeCbx1LM Tv8Q== X-Gm-Message-State: APjAAAUdsl5CbvlN1/mN/YHSfyUEyBbxZSJFuvZWJNrzA9yPYGlg7Zg9 mV341PrS6C8fMU4bOMLBZ9+V1jT7Q3U= X-Received: by 2002:adf:ba84:: with SMTP id p4mr16569026wrg.156.1551792778336; Tue, 05 Mar 2019 05:32:58 -0800 (PST) Received: from localhost.localdomain (aputeaux-684-1-18-114.w90-86.abo.wanadoo.fr. [90.86.221.114]) by smtp.gmail.com with ESMTPSA id i4sm8370097wrw.19.2019.03.05.05.32.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Mar 2019 05:32:57 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Tue, 5 Mar 2019 14:32:40 +0100 Message-Id: <20190305133248.4828-3-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190305133248.4828-1-ard.biesheuvel@linaro.org> References: <20190305133248.4828-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Subject: [edk2] [PATCH 02/10] StandaloneMmPkg: drop unused PCD PcdStandaloneMmEnable X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jiewen Yao Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" The PCD PcdStandaloneMmEnable is unused, and shouldn't exist in the first place since the value is implied by the context (it is never valid to set it to FALSE for standalone MM or TRUE for traditional MM). So drop it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- StandaloneMmPkg/StandaloneMmPkg.dec | 3 --- StandaloneMmPkg/StandaloneMmPkg.dsc | 3 --- StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneMmPeCoffExtraActionLib.inf | 3 --- 3 files changed, 9 deletions(-) -- 2.20.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: jiewen.yao@intel.com Reviewed-by: achin.gupta@arm.com diff --git a/StandaloneMmPkg/StandaloneMmPkg.dec b/StandaloneMmPkg/StandaloneMmPkg.dec index 0b5fbf9e1767..2d178c5e20a6 100644 --- a/StandaloneMmPkg/StandaloneMmPkg.dec +++ b/StandaloneMmPkg/StandaloneMmPkg.dec @@ -39,6 +39,3 @@ [Guids] gEfiStandaloneMmNonSecureBufferGuid = { 0xf00497e3, 0xbfa2, 0x41a1, { 0x9d, 0x29, 0x54, 0xc2, 0xe9, 0x37, 0x21, 0xc5 }} gEfiArmTfCpuDriverEpDescriptorGuid = { 0x6ecbd5a1, 0xc0f8, 0x4702, { 0x83, 0x01, 0x4f, 0xc2, 0xc5, 0x47, 0x0a, 0x51 }} -[PcdsFeatureFlag] - gStandaloneMmPkgTokenSpaceGuid.PcdStandaloneMmEnable|FALSE|BOOLEAN|0x00000001 - diff --git a/StandaloneMmPkg/StandaloneMmPkg.dsc b/StandaloneMmPkg/StandaloneMmPkg.dsc index e8d71ad56f52..f279d9e7e5c7 100644 --- a/StandaloneMmPkg/StandaloneMmPkg.dsc +++ b/StandaloneMmPkg/StandaloneMmPkg.dsc @@ -78,9 +78,6 @@ [LibraryClasses.AARCH64] # Pcd Section - list of all EDK II PCD Entries defined by this Platform # ################################################################################ -[PcdsFeatureFlag] - gStandaloneMmPkgTokenSpaceGuid.PcdStandaloneMmEnable|TRUE - [PcdsFixedAtBuild] gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x800000CF gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0xff diff --git a/StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneMmPeCoffExtraActionLib.inf b/StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneMmPeCoffExtraActionLib.inf index eef3d7c6e253..181c15b9345a 100644 --- a/StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneMmPeCoffExtraActionLib.inf +++ b/StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneMmPeCoffExtraActionLib.inf @@ -37,9 +37,6 @@ [Packages] MdePkg/MdePkg.dec StandaloneMmPkg/StandaloneMmPkg.dec -[FeaturePcd] - gStandaloneMmPkgTokenSpaceGuid.PcdStandaloneMmEnable - [LibraryClasses] StandaloneMmMmuLib PcdLib