From patchwork Mon Jun 18 20:49:18 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 139066 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp4396076lji; Mon, 18 Jun 2018 13:49:26 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLIg09xY/x5v8J07O/5HHRhYtQVHn9YCpunqC759cBLauELJVqt7eOui5F3ZtMUcoC96ff9 X-Received: by 2002:a63:842:: with SMTP id 63-v6mr12654880pgi.406.1529354965925; Mon, 18 Jun 2018 13:49:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529354965; cv=none; d=google.com; s=arc-20160816; b=Vb+O+UO7FjH18yiCZz/7jiL3jThC4Jeygcc+q+H7PJKER/CHn+F7S3oEj0JflnmIMg X1iFR8NzQ2FEiC4jlhPMei6I7FkdWlbnFaUclK4mb77qpY2126WDzmcrgB60ojy65/ke cUY6oXN75l5I0H/mvXA9RDwxeOWpXFcT8dtRDERzQWHW+xGfD+Cji1p1eIQQ2SHoWd7t Q6iGXkFz6n9o6p+ozIBH/Od5M+gy3gcXQRe+2+mYovhfh0RNv61Nt+0yF4Df5s9vFyAz 90NR5ZI/PF94tf1dyBwJxSq7XqGdXhLGXbMOChqBuWFwryXxIHdltSRqJegg2lzHc1aT o7TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:dkim-signature :delivered-to:arc-authentication-results; bh=fAvO4nosZXpxdCJeA5NYKbee4RgzNDMrjHdMqL+kmVs=; b=bZKqA4V7K3o7xDfn6NYqL2tFA/rRzxUt9AUuIdQIQTmHTYxCkB433Ja/gfqSr1owtP /j38RuZVx123MdzSC7ayipiyagu4jvv/Bu+SDd7cvfjSHTqf8g2+4IlZIlBnti65F5En JoJ/iq6o3VJjMGDdOLH0rhaopoAMxMt6+3dSvkJIqVnyrK+G3y8h6Tj163snczg0Ohb8 Y5+29/YPrWkYFWY9MrjqfwvNYauAyteqDIMNeTCVSlpM+LjVhZEu21+cka8iJB1ux4JU 4g1PvTYsmZPjDALXChtUYSuIPlCrYgO8z52zNcawz312RnO4cEUeYneY8StL+DcJ84TK kedA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=eU1q3iPl; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id 9-v6si15840173plb.30.2018.06.18.13.49.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Jun 2018 13:49:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=eU1q3iPl; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 3F25721103DCD; Mon, 18 Jun 2018 13:49:25 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::242; helo=mail-wr0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x242.google.com (mail-wr0-x242.google.com [IPv6:2a00:1450:400c:c0c::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A6A82210FC361 for ; Mon, 18 Jun 2018 13:49:23 -0700 (PDT) Received: by mail-wr0-x242.google.com with SMTP id e18-v6so18236111wrs.5 for ; Mon, 18 Jun 2018 13:49:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=M+yksFsRvSv6WIoSuWp7TArclNAyv1Op3UW0ccwIdqs=; b=eU1q3iPl83xuhZ9ipukfxkwRGylUpih0wF3kHD2ztIXlZzgSkB1QHoInieoNPaMBG/ 1NX1Oxy1OK2nyiZ5boqtVXkkaPrD+3cDfSm7PU3qPm44meHWjhp5MgOpldlodqfFV/g3 P6bSid57Ix4Bz0eeN7kk0+nd5FLi2w9a+eugk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=M+yksFsRvSv6WIoSuWp7TArclNAyv1Op3UW0ccwIdqs=; b=oQYMrXzE0JhNyMF439EiD8XrfJMxp7AlehTyCriWN0LgMcpBYIEm3oaRI2BKYKWJGe EWzbFUnX5zsS7SEyvr2O9W+i6HP5skZAdH9x6xyOmpLxABcXdM1sG0vN8c1q+tbQxZNR H5t44zc1L0CNuU7T54rD6NNp0BCEUvA5zhSYv7vgTMcZlOr6rV46wnxaO+ChHOFpk12Z XG89TR6rKsKSnS2nStmnO9/MncmQVtNBXOrR7fsNI2EmYu3Cd63zdo1fsRNDL/JPigY9 lJ7mDj5a2jnjVbJKiG4KGVjC20LoQfzZNORvtb4/gfaA4SnJ6naRzc3YMn6PGZtb4Sjv 8jug== X-Gm-Message-State: APt69E1ooJx8R1aQzaT62HgGWRLIx6FwG0GVs5i+FwSqA6sNFoueDBhc XXSmbLJquYcXBH21Zx6c8G5LeGpc4ns= X-Received: by 2002:adf:ba8f:: with SMTP id p15-v6mr12381751wrg.139.1529354961762; Mon, 18 Jun 2018 13:49:21 -0700 (PDT) Received: from dogfood.home ([2a01:cb1d:112:6f00:50d8:cb10:b6d:abf0]) by smtp.gmail.com with ESMTPSA id t10-v6sm15130164wrq.74.2018.06.18.13.49.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Jun 2018 13:49:20 -0700 (PDT) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Mon, 18 Jun 2018 22:49:18 +0200 Message-Id: <20180618204918.31835-1-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.17.1 Subject: [edk2] [PATCH] EmbeddedPkg/GdbSerialLib: avoid left shift of negative quantity X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: leif.lindholm@linaro.org, Ard Biesheuvel MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" Clang complains about left shifting a negative value being undefined. EmbeddedPkg/Library/GdbSerialLib/GdbSerialLib.c:151:30: error: shifting a negative signed value is undefined [-Werror,-Wshift-negative-value] OutputData = (UINT8)((~DLAB<<7)|((BreakSet<<6)|((Parity<<3)|((StopBits<<2)| Data)))); Redefine all bit pattern constants as unsigned to work around this. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- EmbeddedPkg/Library/GdbSerialLib/GdbSerialLib.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) -- 2.17.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Leif Lindholm diff --git a/EmbeddedPkg/Library/GdbSerialLib/GdbSerialLib.c b/EmbeddedPkg/Library/GdbSerialLib/GdbSerialLib.c index 069d87ca780d..7931d1ac4e2b 100644 --- a/EmbeddedPkg/Library/GdbSerialLib/GdbSerialLib.c +++ b/EmbeddedPkg/Library/GdbSerialLib/GdbSerialLib.c @@ -40,11 +40,11 @@ //--------------------------------------------- // UART Register Bit Defines //--------------------------------------------- -#define LSR_TXRDY 0x20 -#define LSR_RXDA 0x01 -#define DLAB 0x01 -#define ENABLE_FIFO 0x01 -#define CLEAR_FIFOS 0x06 +#define LSR_TXRDY 0x20U +#define LSR_RXDA 0x01U +#define DLAB 0x01U +#define ENABLE_FIFO 0x01U +#define CLEAR_FIFOS 0x06U