From patchwork Wed May 23 14:14:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 136668 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp953510lji; Wed, 23 May 2018 07:15:07 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoWqm29ggiOKvtFC99+4Zm7OtzP+zMe5Qnd3g0B3/zUbU8JkW8NjLd9ze6Wx8FT5ywZ9YUa X-Received: by 2002:a63:43c6:: with SMTP id q189-v6mr2574912pga.123.1527084907766; Wed, 23 May 2018 07:15:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527084907; cv=none; d=google.com; s=arc-20160816; b=kiHy031jY1P4WzttKpy1l6A2u9RJ7xYTIA+mC415vmBc+IdQ4TfbZvgTGuXxa6IN1B E9C8BgoY8Jps5lrF6Szw7VaTJ6v021rRoWFF6N6y2uoMNt/Dx+OEsjwy+5KKwOlPkXei wzXhUKFL1ky0xGHjybpt1NUtqfEaEvztlBxB0cKB8TPw1MNlvx7SitNb9nxzQwY2y2m/ 5wmrUlWXbtjnoXmYx5+Lg8odNiImh7jtkfKRrcXzGgK0iCSsVsqMX+11mNql8pQI/pSD fr+yLOSvPuXFx7PgZgjsNChPJqv+ZiWAJyFvHNMPDR6v7/viEbIjHaNlX28eUoG4pL9c dZNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to:arc-authentication-results; bh=Lm3xuB1bVlB6rOeBkzNS+z9gdbVmi6TgociwZloX9KM=; b=wpbEc7wQThiXybkCrMKpxhADc1BQ6FUpNSrHJZJaSAh0N6boj6HTUF7gu3IK2GesqW gm6pCY1a15mvTwrGUXioqgERK6pZtCEMUDbV7rUlS7Ceb9gOIF1oZlCVJzXO0y3MtkjZ P73EEabOaHLLSqrKa9FfS4aDHNugjIAIl9qK6D7Tyluk8oqvtW25ALTViw6f3aPpJm4Q oTVi88nel6yI3q9KYyDEovmjCCZaluYl/ILQjvZm6hMqEue/Tl8UobUmFM7SpyaeXxCP 9okcT1ydYqZ/xWRPin6/kr64aBKLgycyD3nfxTR+WVFlUVsI9pZm4Xhzd4/BnxRjShSm 5Cqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=iNKcaKix; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id m7-v6si17874439pfh.92.2018.05.23.07.15.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 May 2018 07:15:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=iNKcaKix; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 89D53207E4DF9; Wed, 23 May 2018 07:14:58 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::243; helo=mail-wm0-x243.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AE15121BADAB3 for ; Wed, 23 May 2018 07:14:56 -0700 (PDT) Received: by mail-wm0-x243.google.com with SMTP id j4-v6so9495106wme.1 for ; Wed, 23 May 2018 07:14:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=zylwOThWLC6+BZg2zQj0xxj/D1VVPY1uE9KFH0QRV2Q=; b=iNKcaKix5yluU+frkSHflYf+uAN1wv+2N4ILjvzbZ07G0CzkkZbd6xLEcTrvl9VVzc cvF5Aoji4o4prEIJb0o4HZZOw/OzzXHUz0IqwPLNvzZ/msk49sZY/1kHzJbvsZyWOaKW zcAqQEPq9IK3uEebgxbV6RA19IfAWiuWmyQIA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=zylwOThWLC6+BZg2zQj0xxj/D1VVPY1uE9KFH0QRV2Q=; b=KygbN8ma+KZuQ9f3Er3tVYnhWgMG3OADeiu1bVHI3x+f/c7xklqbPHVy9udNJKyZNn JAlN/VmWxrhE+vc+HHs61cPKqOViXcIcTPJWof70uDJUH0mqGOMSpUOxNRhMMCAxFpJ8 D1tOShdNXoEYZuPjqeloyjclhzXEZEB6OL74KDuNzgLKeJH31pOPPv1JTJNPPYUlzfgT GFXN+FiL/eb4Sz2GestwHz7SU6fbgAfkkyOuS6WbOIntN5QfBYcisjAz07QTT5n3L/yK XgG1QCCeJnnxmJKFueBsrHUYuO5PoXDAbjDAP8eRbn0BZ5W9IRTINk3XFsXoz84py9Eu o3yw== X-Gm-Message-State: ALKqPwcbkdDWaSIPr6LaLz40EX/lQKUqP6nKgtIrnvA67qGprk2EpCtY Wxhjj9ICnL7KM+a/xTOTirIZ6FzCsvw= X-Received: by 2002:a1c:7a0b:: with SMTP id v11-v6mr4723447wmc.58.1527084894896; Wed, 23 May 2018 07:14:54 -0700 (PDT) Received: from localhost.localdomain ([2a01:e35:3995:5470:200:1aff:fe1b:b328]) by smtp.gmail.com with ESMTPSA id o12-v6sm27347774wrf.31.2018.05.23.07.14.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 May 2018 07:14:54 -0700 (PDT) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Wed, 23 May 2018 16:14:44 +0200 Message-Id: <20180523141444.20033-5-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180523141444.20033-1-ard.biesheuvel@linaro.org> References: <20180523141444.20033-1-ard.biesheuvel@linaro.org> Subject: [edk2] [PATCH edk2-platforms 4/4] Silicon/Socionext/SynQuacerPciHostBridgeLib: DEPEX on variable protocol X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: leif.lindholm@linaro.org, Ard Biesheuvel MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" As discussed on-list [0], dynamic HII PCDs are backed by EFI variables, but having PcdDxe DEPEXing on gEfiVariableArchProtocolGuid in general is too restrictive, and so it is up to the platforms themselves to DEPEX on gEfiVariableArchProtocolGuid in modules that use PCDs that the platform may declare as dynamic HII. This also applies to the PCD gSynQuacerTokenSpaceGuid.PcdPlatformSettings on the SynQuacer platform, which is used by its PciHostBridgeLib implementation. So add the DEPEX to make this dependency explicit. [0] https://lists.01.org/pipermail/edk2-devel/2018-April/023700.html Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Silicon/Socionext/SynQuacer/Library/SynQuacerPciHostBridgeLib/SynQuacerPciHostBridgeLib.inf | 5 +++++ 1 file changed, 5 insertions(+) -- 2.17.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel diff --git a/Silicon/Socionext/SynQuacer/Library/SynQuacerPciHostBridgeLib/SynQuacerPciHostBridgeLib.inf b/Silicon/Socionext/SynQuacer/Library/SynQuacerPciHostBridgeLib/SynQuacerPciHostBridgeLib.inf index e475529eaf58..8b8bb5df57d3 100644 --- a/Silicon/Socionext/SynQuacer/Library/SynQuacerPciHostBridgeLib/SynQuacerPciHostBridgeLib.inf +++ b/Silicon/Socionext/SynQuacer/Library/SynQuacerPciHostBridgeLib/SynQuacerPciHostBridgeLib.inf @@ -54,3 +54,8 @@ [FixedPcd] [Pcd] gSynQuacerTokenSpaceGuid.PcdPcieEnableMask gSynQuacerTokenSpaceGuid.PcdPlatformSettings + +[Depex] + # gSynQuacerTokenSpaceGuid.PcdPlatformSettings may be of the dynamic HII + # variety, which are backed by EFI variables + gEfiVariableArchProtocolGuid