From patchwork Thu Feb 8 19:30:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leif Lindholm X-Patchwork-Id: 127741 Delivered-To: patch@linaro.org Received: by 10.46.124.24 with SMTP id x24csp1798114ljc; Thu, 8 Feb 2018 11:30:28 -0800 (PST) X-Google-Smtp-Source: AH8x227uwayf0iE2oSopqknJHLFJ+tRslNbxuRXmWkY/VlasZpzlso8AodWYMEVOVxpNCMOJf585 X-Received: by 10.98.75.218 with SMTP id d87mr136498pfj.11.1518118227976; Thu, 08 Feb 2018 11:30:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518118227; cv=none; d=google.com; s=arc-20160816; b=nSiGF4OG0sY3t/bkMeXIoR+cgnMyYEAS+18ugDoFF56ZB2h4yY7Lz9SChIBvCnmFMp 0nZUfWRd+XKvy+bjIeJ7gGFykA7uHusyyvL3G+Oqg2xw1kYYyjTnSnOmjZqOVMZyNgfL N4Qgb6bKxjBLQNiNW1Arm03Z9rdQOvou2jHzIi2xMpJtxrwxChPEj6XyqAwZJMquXNSN zRvARA+QGdLnYs/W1cdeYTTnXJqLFv56qoHbqovWD0EdpPvpgnBkkUCF4TIeB1P7XzXy /mPYLsD4UKARKZSo5xJh2G5Fr4AM4J0MM/Xy9fpQS1bkNQA0z73DdKHN6Jqh+rKxAxMT iVFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:dkim-signature :delivered-to:arc-authentication-results; bh=pGFRT8K67zRcY25GNnVFBUlzVyFKbwh/jTc84oQ8byo=; b=i6hkKkC+nfm1JGbQuQsVdng/HS+L2DWJK9gW/Hn7nR5ofkUm5Zv6DBuTh84Y9wMv8o HNni8MJsO26B/Wf8QGda8xe6GLStHctYBpkQo8k7n8AI3gPmVQ19aqxO72IsudTPwDOs ohz9doz2vTTZXRCqMHaepKkDShHostu/6svFDhwHuGs1LzGLsaFxb1lT04J7Xq9UUbgs 5WIgSM6jgIjxTPNP4eTqqRRVnZvpzh1bWfuf/DkYWzUnCrYD3lOu+vmObOk1KfAqPLJU ocCEvHghA1mlRHLXzMWoJotqBiIyL3cb8ywXARNGW2ZL6E4Oz2g3bIlbltP8IzPJm4Az Yo7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=HlpvUuhF; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id k4-v6si386626pls.182.2018.02.08.11.30.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Feb 2018 11:30:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=HlpvUuhF; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id CAA5B222DE155; Thu, 8 Feb 2018 11:24:41 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::241; helo=mail-wm0-x241.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 18718222DE133 for ; Thu, 8 Feb 2018 11:24:39 -0800 (PST) Received: by mail-wm0-x241.google.com with SMTP id v71so12088688wmv.2 for ; Thu, 08 Feb 2018 11:30:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=/zhUUGqqH8vCOKLcRHFN+YFR2mB0A4O7SUVzUbesihA=; b=HlpvUuhFzcUmmDlGHynRmu5MHi3gSHNDfqrAXPxUso5RWw4uRW6x7N+l2rtWu01SMq uo8ADsOOpX5n5CjHIELmXhWvORrIfb6YttwcUtJzmJ532zYXREpq0cSlpbxVWOw2twc9 toK5KL+/O8GeubhCQ4RpPZvFAlN0o3+JIds0U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=/zhUUGqqH8vCOKLcRHFN+YFR2mB0A4O7SUVzUbesihA=; b=c3JbgRl7t9YkYD4aoea1z1nNZfgukw/cVFqYao0qBmuEOHoKo76WCfyjc68KL7Ul/D jUrefesYDw2hprRUe7c4ePw7wRUrqXT6VFZWsM9as8VaFVtW/0hPZlAln4/TZEfc9NX/ GwuNBt1kdVQYhUkCVliKXzFCr4NgAON46E6NqE/A5ZQM2Otn3WGFw0Srnicc1ccQAJTS 8LNFm4Fiooii9d3z0rymgRXuehAj7/U22KU9E4wW5TxbfZHxJ+lQUbSxhMY4QrEaJK0o 8woou5dAi1+XyBYFsuH6j1bwmVwA0+wj/6p4w98Po8NQem+Xsci1kj7jbfp09agoGezq n39A== X-Gm-Message-State: APf1xPAhjeBOfEI991JrEjWBliUgK9z2BJcK0gf0jkZRxKskZ/Uy6SS7 ov5/si7ICUexJrnxDq8wHInle0NHcI0= X-Received: by 10.28.46.88 with SMTP id u85mr116506wmu.12.1518118223405; Thu, 08 Feb 2018 11:30:23 -0800 (PST) Received: from vanye.hemma.eciton.net (cpc92316-cmbg19-2-0-cust118.5-4.cable.virginm.net. [82.12.0.119]) by smtp.gmail.com with ESMTPSA id s9sm805758wra.4.2018.02.08.11.30.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Feb 2018 11:30:22 -0800 (PST) From: Leif Lindholm To: edk2-devel@lists.01.org Date: Thu, 8 Feb 2018 19:30:19 +0000 Message-Id: <20180208193021.24524-1-leif.lindholm@linaro.org> X-Mailer: git-send-email 2.11.0 Subject: [edk2] [PATCH edk2-platforms 1/3] Platform/(AMD|LeMaker|SoftIron), Silicon/AMD: drop unused PcdCacheEnabled X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ard.biesheuvel@linaro.org MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" PcdCacheEnabled was never useful for these platforms, but they copied it over from other platforms used as templates. Delete it here to keep the platforms building once the Pcd is removed from EmbeddedPkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Leif Lindholm --- Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 3 --- Platform/LeMaker/CelloBoard/CelloBoard.dsc | 3 --- Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 3 --- Silicon/AMD/Styx/Library/AmdStyxLib/AmdStyxLib.inf | 3 --- Silicon/AMD/Styx/Library/AmdStyxLib/AmdStyxLibSec.inf | 3 --- Silicon/AMD/Styx/Library/AmdStyxLib/StyxMem.c | 6 +----- 6 files changed, 1 insertion(+), 20 deletions(-) -- 2.11.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Ard Biesheuvel diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc index 21edcc8798..48018abc69 100644 --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc @@ -282,9 +282,6 @@ [BuildOptions.common.EDKII.DXE_DRIVER,BuildOptions.common.EDKII.UEFI_DRIVER,Buil ################################################################################ [PcdsFeatureFlag.common] - # All pages are cached by default - gEmbeddedTokenSpaceGuid.PcdCacheEnable|TRUE - # Use the Vector Table location in CpuDxe. We will not copy the Vector Table at PcdCpuVectorBaseAddress gArmTokenSpaceGuid.PcdRelocateVectorTable|FALSE diff --git a/Platform/LeMaker/CelloBoard/CelloBoard.dsc b/Platform/LeMaker/CelloBoard/CelloBoard.dsc index cf3df86514..2468583c0d 100644 --- a/Platform/LeMaker/CelloBoard/CelloBoard.dsc +++ b/Platform/LeMaker/CelloBoard/CelloBoard.dsc @@ -270,9 +270,6 @@ [BuildOptions.common.EDKII.DXE_DRIVER,BuildOptions.common.EDKII.UEFI_DRIVER,Buil ################################################################################ [PcdsFeatureFlag.common] - # All pages are cached by default - gEmbeddedTokenSpaceGuid.PcdCacheEnable|TRUE - # Use the Vector Table location in CpuDxe. We will not copy the Vector Table at PcdCpuVectorBaseAddress gArmTokenSpaceGuid.PcdRelocateVectorTable|FALSE diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc index 0abec8120a..f0a7e97941 100644 --- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc +++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc @@ -272,9 +272,6 @@ [BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER] ################################################################################ [PcdsFeatureFlag.common] - # All pages are cached by default - gEmbeddedTokenSpaceGuid.PcdCacheEnable|TRUE - # Use the Vector Table location in CpuDxe. We will not copy the Vector Table at PcdCpuVectorBaseAddress gArmTokenSpaceGuid.PcdRelocateVectorTable|FALSE diff --git a/Silicon/AMD/Styx/Library/AmdStyxLib/AmdStyxLib.inf b/Silicon/AMD/Styx/Library/AmdStyxLib/AmdStyxLib.inf index 6b7481ec6d..3a38f294eb 100644 --- a/Silicon/AMD/Styx/Library/AmdStyxLib/AmdStyxLib.inf +++ b/Silicon/AMD/Styx/Library/AmdStyxLib/AmdStyxLib.inf @@ -53,9 +53,6 @@ [Guids] [Ppis] gArmMpCoreInfoPpiGuid -[FeaturePcd] - gEmbeddedTokenSpaceGuid.PcdCacheEnable - [Pcd] gArmTokenSpaceGuid.PcdSystemMemoryBase gArmTokenSpaceGuid.PcdSystemMemorySize diff --git a/Silicon/AMD/Styx/Library/AmdStyxLib/AmdStyxLibSec.inf b/Silicon/AMD/Styx/Library/AmdStyxLib/AmdStyxLibSec.inf index b313d4baad..b24ffd469a 100644 --- a/Silicon/AMD/Styx/Library/AmdStyxLib/AmdStyxLibSec.inf +++ b/Silicon/AMD/Styx/Library/AmdStyxLib/AmdStyxLibSec.inf @@ -49,9 +49,6 @@ [Sources.AARCH64] [Guids] gAmdStyxMpCoreInfoGuid ## CONSUMER -[FeaturePcd] - gEmbeddedTokenSpaceGuid.PcdCacheEnable - [Ppis] gArmMpCoreInfoPpiGuid diff --git a/Silicon/AMD/Styx/Library/AmdStyxLib/StyxMem.c b/Silicon/AMD/Styx/Library/AmdStyxLib/StyxMem.c index 3b82132d08..479a40627d 100644 --- a/Silicon/AMD/Styx/Library/AmdStyxLib/StyxMem.c +++ b/Silicon/AMD/Styx/Library/AmdStyxLib/StyxMem.c @@ -78,11 +78,7 @@ ArmPlatformGetVirtualMemoryMap ( return; } - if (FeaturePcdGet(PcdCacheEnable) == TRUE) { - CacheAttributes = DDR_ATTRIBUTES_CACHED; - } else { - CacheAttributes = DDR_ATTRIBUTES_UNCACHED; - } + CacheAttributes = DDR_ATTRIBUTES_CACHED; DEBUG ((EFI_D_ERROR, " Memory Map\n------------------------------------------------------------------------\n")); DEBUG ((EFI_D_ERROR, "Description : START - END [ SIZE ] { ATTR }\n"));