From patchwork Mon Mar 12 06:53:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: gary guo X-Patchwork-Id: 131366 Delivered-To: patch@linaro.org Received: by 10.46.84.17 with SMTP id i17csp393573ljb; Sun, 11 Mar 2018 23:54:29 -0700 (PDT) X-Google-Smtp-Source: AG47ELvP6mMRBgCbNXJ1RjvQ51MmS/SGwWu/dMU4o9FLE9mjXrJV9sdosGLoNfokOVXSjEWdMd8H X-Received: by 2002:a17:902:8a4:: with SMTP id 33-v6mr7375816pll.274.1520837669297; Sun, 11 Mar 2018 23:54:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1520837669; cv=none; d=google.com; s=arc-20160816; b=YQz9WofYpqVQcCRiVhscT2qpDwEiaYQEnlTOYYKl2S6EEmWTqVycJdV6g32sEojiZ5 6xKj5PtJxC8Z5+dIsBeBWF7VH/tNyZ2gnOBnkPPCxk16QxO1qIqeUlgFPbtSCuTCECQt frSW/vUnk/WMXaN/DwYVgesPe0XFTrBImAPkX6NMZFrzMHiyQLQdyFW39HQXbHnt8dJN s/CQq1e7VwYWrIrIhRA2S03KdMdh6X4o0O5Wd2b4c/xgCLXgJ3DOYkXispThndxK0RZi 56CzvoC7wwkyvEJOR8sOHulMJT40wCkbyanXz+9jCLzEX0IWpsI/gtEe6Y9J0KCpTyTI oRvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to:arc-authentication-results; bh=0LUHn4fGEpBYdpZp43vEYgMu7052uwK+EFd1MhKh00Y=; b=CmtNDJVMMctpreDxg+OEdbAASxADXTw8C2GarCSPZAHTDbTVxryh2PT/38kbi00Pxi QYdk1ksGAeNg+QqSg0ohW1HcHxd85ucV+g4KrzV/I2W+6pmTmGdAvYj5rDupKER3tr4f 9ayhbX2fIXHhDSUz8Yom0FE/BsUU/AjbHJ0L5yjvdjSzwJyp9FzIBYiWVquz+2eyMU4a PrQBaUdBBcnsE3Rtelx76xP6K+v0ij6TEGNt3Xvb4SO4HSGYOuVdJTDn8f4N6rq99Qda 5IVyqqHXDRUcioRW0sg0WOHAVAe6wCXQf+k1zU7f1db76uII/GfA8SvZ+npQuLjlz/cf UVKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=LvbQp4yq; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id i131si1393555pgc.347.2018.03.11.23.54.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 11 Mar 2018 23:54:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=LvbQp4yq; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 2DC392258AF1E; Sun, 11 Mar 2018 23:48:08 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:400e:c01::241; helo=mail-pl0-x241.google.com; envelope-from=heyi.guo@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pl0-x241.google.com (mail-pl0-x241.google.com [IPv6:2607:f8b0:400e:c01::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 83563224C0F46 for ; Sun, 11 Mar 2018 23:48:06 -0700 (PDT) Received: by mail-pl0-x241.google.com with SMTP id 93-v6so8818305plc.9 for ; Sun, 11 Mar 2018 23:54:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=73MVuz/I8F5bExhzBr3cZuLr//4GS/KVrV/WwLsB/hU=; b=LvbQp4yqwdA7zvGi2E/A5lRSnF5OyctsqZ7xqciGTOWtmN1eHjr1USIlMHtasEeYCx erwZNazCCTgoM9TeVSBvo7I+AlQO6mOvI2cIyVL07vQw5+/uESagENV60tqVZ+9DAKDE vWNQqDgZd29jGvoHWLmt1w9GNrgJk/xIrjAD4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=73MVuz/I8F5bExhzBr3cZuLr//4GS/KVrV/WwLsB/hU=; b=kK7IH/mlrxZ7aSZshUEFBsXmEr4ZwBx7U+DkoYMFbI4Dw+tBGajEkpZmqKGt8HxTmc 57bQDTh2Kt+VLnTcPsPOG9+KcOUY/T6zooieHSMf9H09ZiucgfvjGOJILXjsw4fYl/4h AwIAwo3kvLpRd0imB2JdrzHX9PqFZ1luB9xftVISg5+nCBbf78vcf0MG7nYdLvHGEZbW tcwCpKw1+c0QSy7nRYFWPIyu7AloGY+1pNURHjesHEH4dK7FH3c6E2ui2q+CmTPSceRQ Wy/LkwozlaSoV/fJWBS0qVgbuE2UZOvFUVAJ4Ndwn45nShhhkT6RSp8jx9QdPeT9ykrf zAeg== X-Gm-Message-State: AElRT7F8SHDnNXpgXWKj/RjAnWcTmbAZxdoVDekjGnmcVL1UyjH58JJT wCAb5XuOSm8WLefziUIuiC0rDiPT4Kg= X-Received: by 2002:a17:902:20c9:: with SMTP id v9-v6mr7295420plg.41.1520837666409; Sun, 11 Mar 2018 23:54:26 -0700 (PDT) Received: from localhost.localdomain ([45.56.152.76]) by smtp.gmail.com with ESMTPSA id m9sm15357348pff.143.2018.03.11.23.54.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 11 Mar 2018 23:54:25 -0700 (PDT) From: Heyi Guo To: edk2-devel@lists.01.org Date: Mon, 12 Mar 2018 14:53:31 +0800 Message-Id: <1520837611-94728-2-git-send-email-heyi.guo@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1520837611-94728-1-git-send-email-heyi.guo@linaro.org> References: <1520837611-94728-1-git-send-email-heyi.guo@linaro.org> Subject: [edk2] [PATCH 1/1] ArmPkg/TimerDxe: Add DSB for timer compare value reload X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marc Zyngier , Heyi Guo , Yi Li , Leif Lindholm , Ard Biesheuvel MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" Resetting timer compare register has a side effect of clearing GIC pending status, if timer interrupt is level sensitive, so a "DSB SY" is needed to make sure this change effect is synchronized. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Heyi Guo Signed-off-by: Yi Li Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Marc Zyngier --- ArmPkg/Drivers/TimerDxe/TimerDxe.c | 1 + 1 file changed, 1 insertion(+) -- 2.7.4 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel diff --git a/ArmPkg/Drivers/TimerDxe/TimerDxe.c b/ArmPkg/Drivers/TimerDxe/TimerDxe.c index 33d7c922221f..b732a2ac1b64 100644 --- a/ArmPkg/Drivers/TimerDxe/TimerDxe.c +++ b/ArmPkg/Drivers/TimerDxe/TimerDxe.c @@ -337,6 +337,7 @@ TimerInterruptHandler ( // Set next compare value ArmGenericTimerSetCompareVal (CompareValue); + ArmDataSynchronizationBarrier (); ArmGenericTimerEnableTimer (); }