From patchwork Wed Mar 7 03:03:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: gary guo X-Patchwork-Id: 130837 Delivered-To: patch@linaro.org Received: by 10.46.66.2 with SMTP id p2csp4683515lja; Tue, 6 Mar 2018 19:04:23 -0800 (PST) X-Google-Smtp-Source: AG47ELuerojf7BHPM4KIftrbn7dHtVgxwkaftxzr79/wvXCvOIzWs/BJfw+64bcguze6S6nIeRjD X-Received: by 2002:a17:902:6c47:: with SMTP id h7-v6mr9059566pln.445.1520391862998; Tue, 06 Mar 2018 19:04:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520391862; cv=none; d=google.com; s=arc-20160816; b=K4jmnaAk310h9jqQ0y4hehoQNJjljjgmLfrEWoXQeaI72NtyrEW/8lAYcth/3X3Yhq t6OwL2d+9D06KyJKAeADz0SMLTDHVZz6ZBS7PDZY3YZrO7MgZH1tuXzU1/8nAydDWl6h agjq/fRPU/ECGfzy3uZqQFEFL/MxGjBvo4r1Vr+RHStWMIUWP5pFP1x2619xA/RLgjyE D4zG2mE5NeRomHV5m7FvpyjgPU0A6CvDpWOf4Pw896L6Ux8CpvMvA/Sj/y0MgviY0bVT BhyYCdlfoAgyt66ODNFcbAhy9IiMRR12t92pT8PY9R+80KvsLwLB8GNTO3bWHV8RZlNz S68Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:dkim-signature :delivered-to:arc-authentication-results; bh=y25seGmZlsi+MNtmujVTaTBCVWHSaJqdvCCgOTP9Wrw=; b=ehZuhDakJ+eRwoHkJ+YVmCWTYsizmbsZ5behnesyjRQgJPxGNnPP87zlM4nSMw1iBR lSwVaTvtAuEsnISc4Ep4V6/By5BcqwtIRnPAvDWhqwF7WTdWatT/6NScPSwwr/7WQPKn HXL7iJp6YDTQZ59cAwdtsxG6v296Jp/bVlwDgemCeAbudm/yH8dIETHvkV50LUHlkVTk jfO74Dlo5gWtadg1jDnl69nqrt1igXOdTZISEWK25Gv0CmdNrUQI7O6YU/uWE5rPvkw1 G1tFLMOeX5c3NEKlx+Vp9DVD6X8sntKjwGbpvXVPtRKuorFk/XIHzV459j/E2+jrq9wz 6pqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=ax1hb+qe; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id m16si10738148pgn.290.2018.03.06.19.04.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Mar 2018 19:04:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=ax1hb+qe; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 713ED2235229E; Tue, 6 Mar 2018 18:58:06 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:400e:c01::243; helo=mail-pl0-x243.google.com; envelope-from=heyi.guo@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pl0-x243.google.com (mail-pl0-x243.google.com [IPv6:2607:f8b0:400e:c01::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E638022135D3B for ; Tue, 6 Mar 2018 18:58:04 -0800 (PST) Received: by mail-pl0-x243.google.com with SMTP id u13-v6so555295plq.1 for ; Tue, 06 Mar 2018 19:04:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=+DZ1oYw5H0YGzYhP7WhF/l49jEN3o+/EbgjHCFRUt5Q=; b=ax1hb+qedQKbBjxln7vD2Oxr1DyoIC42C1CsocUKJQnVGImvbG8245VV4gimXTjjZ2 0185WyuDVrFvkTsxDRFNBCpyvvfP/jafyOpJtCeT+2oJttRiQX8kl35Mjm7L0uyvambY YWVhFMy45J5sdsBVNBozcl7VmT4A0r5rYDZIY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=+DZ1oYw5H0YGzYhP7WhF/l49jEN3o+/EbgjHCFRUt5Q=; b=WzUFxhwVcuCXRirMNMWy11ZdiHVg0ivz6vF0pGUwbvk1VyIahsd4z6o2oxU7EWhmE+ IgIxD+uIK7FwXtDuuly/BVd8xp2mzhfm64PNbwjM3ZX+iwO9JOK4pxQzdQJNRftscuvl EIymEh/4ADq2HcvoLsLNUAJD1uAMskOzVUs45rc5zhDD14RDXCWHLXOMCMcVakpdlvAO 5ut5ibNaRKbLdfdZn4cX88UIZpZIvKqTKf9QuvT6405W070eQcbnwBZ6Qbx7puwBaGfQ /iVMl0svctazZmuKjZq++I2A1qof03QxKV+UNtcmhYGHUDl+MR+LlTo+3z5RiXEoO6NU pRtA== X-Gm-Message-State: APf1xPBOmXeg8Lef7OWqToRQrhtPa0j5c0Xc4K29qCmCVFBr/wARCz+h /inN/ep5ftgWD/W6B81VR2bZ5cT8fmI= X-Received: by 2002:a17:902:4222:: with SMTP id g31-v6mr18324361pld.335.1520391858892; Tue, 06 Mar 2018 19:04:18 -0800 (PST) Received: from localhost.localdomain ([45.56.152.76]) by smtp.gmail.com with ESMTPSA id c188sm25742972pga.14.2018.03.06.19.04.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 06 Mar 2018 19:04:18 -0800 (PST) From: Heyi Guo To: edk2-devel@lists.01.org Date: Wed, 7 Mar 2018 11:03:52 +0800 Message-Id: <1520391833-9344-1-git-send-email-heyi.guo@linaro.org> X-Mailer: git-send-email 2.7.4 Subject: [edk2] [PATCH 1/2] Hisilicon/D0x: fix tftp command init failure X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heyi Guo , Leif Lindholm , Ard Biesheuvel MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" We need to set PcdShellLibAutoInitialize to FALSE for TftpDynamicCommand, or else we will get initialization failure when loading TftpDynamicCommand module, for EFI Shell has not been started at this moment. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Heyi Guo Cc: Ard Biesheuvel Cc: Leif Lindholm --- Platform/Hisilicon/D03/D03.dsc | 5 ++++- Platform/Hisilicon/D05/D05.dsc | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) -- 2.7.4 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Leif Lindholm diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc index c4963063794b..cb0669d639d1 100644 --- a/Platform/Hisilicon/D03/D03.dsc +++ b/Platform/Hisilicon/D03/D03.dsc @@ -517,5 +517,8 @@ [Components.common] gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize|8000 } !ifdef $(INCLUDE_TFTP_COMMAND) - ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf + ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf { + + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE + } !endif #$(INCLUDE_TFTP_COMMAND) diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc index 0792b0814ea1..8373a821a496 100644 --- a/Platform/Hisilicon/D05/D05.dsc +++ b/Platform/Hisilicon/D05/D05.dsc @@ -675,5 +675,8 @@ [Components.common] gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize|8000 } !ifdef $(INCLUDE_TFTP_COMMAND) - ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf + ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf { + + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE + } !endif #$(INCLUDE_TFTP_COMMAND)