From patchwork Mon Sep 25 01:51:55 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcin Wojtas X-Patchwork-Id: 114164 Delivered-To: patch@linaro.org Received: by 10.140.106.117 with SMTP id d108csp2068389qgf; Sun, 24 Sep 2017 18:46:22 -0700 (PDT) X-Received: by 10.84.137.129 with SMTP id 1mr5446281pln.376.1506303982685; Sun, 24 Sep 2017 18:46:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1506303982; cv=none; d=google.com; s=arc-20160816; b=g1XgROkKJ7kZHTkT+bGVlQTjG/qsEtPnBrdGDcbrVfGbENkZu4G9w5njpGKRa75MZb FUzv/USKaxBw9x3jZn+P/HThLqRMTgF3TwZBHFosZmQPSrcazAJ9jvR+AHwedeR1ovBM CIqmuwcWLkPluPRUzFblnZxPBOYHZbrbGjvjr0+xz+t9u1lsp2XOo3A64vqvswAygCOD sMFPu1frZllDE08j1QqZ1k2Vxpwn+eOQXznUppp5t2MMQa/5vD3U1ru13jgZj9oEev7q R6S+Bb9+p9+5w15ZL233GUWJJ4Mp/eIAsabx1fNl12oJ5neBbyYA+Q2SU0bTgmlz0FmQ 00gA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to:arc-authentication-results; bh=/KPS1pEwLsZA5EShKNUKvtWgdhPr7e5IoIOhvRSCnxY=; b=zUCZEOIQ4oCJZk8jToS8pFVi+/yr/FS5vQsHD4P3aW444ePZnYOzNa9qHMsErOhFCa mYY9mZvIavm4AhPj3O0DdksAnHzPUm4MxariUCerJHNoIXWikwIyqwggQ9WPM9zJFEye +2vZKvqwnCezPYD6VcczaJ1tXSUm+yOYAmpZrwe3jLXls34tht8TLC/jOn5dneVfED6q idvYzd5eo8CAUv1seuKE8kyvAQDOn2BJDUKDfRKg6hho+AtWQRDVljPIdZB4JANlrO1u yrMtNN3/q/TUxVl/8S0+1h+dK/ar9grSE6gyYJ/Pe6nqj//ruseg//WbnduLs+d/OCNt s+bQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@semihalf-com.20150623.gappssmtp.com header.s=20150623 header.b=LaozhhWK; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id o25si1324463pgn.807.2017.09.24.18.46.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 24 Sep 2017 18:46:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@semihalf-com.20150623.gappssmtp.com header.s=20150623 header.b=LaozhhWK; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 7DDAE21E43B5C; Sun, 24 Sep 2017 18:43:01 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2a00:1450:400c:c0c::22d; helo=mail-wr0-x22d.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x22d.google.com (mail-wr0-x22d.google.com [IPv6:2a00:1450:400c:c0c::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 35E9921E43B4E for ; Sun, 24 Sep 2017 18:42:59 -0700 (PDT) Received: by mail-wr0-x22d.google.com with SMTP id 108so5233157wra.5 for ; Sun, 24 Sep 2017 18:46:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=uqJpvjrOOSyYcnagMvKkRjOCmPLv71Ofcl2VUYLrWM8=; b=LaozhhWKtp4XbJcObqrOncJhHwTaRU1rKIa2uwJHHl0rwT31rWhitt7gU+p1tFQQnf eJYA4fP0rM7tZVmBn3WUubKFC43Pt06y5eyODTqvRNN8utE6um6u9mxoBhiLDzc2t64G 9NDA97Q0ZZG553e8Epi8v966tslPuyOCNnwbTlPE4mqSA6rYC6Wwbe7mLPPzph/6eMPF zbzTpOMixR1kCKyZjmBORPrauw3B9yczO+uiTYns29lmuiXg69YDvBd7anD7XYrn+QGp Og5z4lef2CmhykX0OLxJdr7zN+6bRZXps76sqFwcsq3XwOuK7PTV8nqTJc7XMcW+Gef3 tDeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=uqJpvjrOOSyYcnagMvKkRjOCmPLv71Ofcl2VUYLrWM8=; b=ODqpVD7MuuuCOWmVUKxX9LknqcfSOeS8vFGWGWAE0lMuynqeqTlFqDbvPnMhaOEt4R t3eHotH56cruO4DZBWtbw2np7xSwU/j2Fc/Lh2NKhg2ZT6fkoYK4Ep0abh4E6SEHmn8Y GJ6MoDrcGrR981BeS8xzaU7mwaVqvRZFuMZ4lpq58/nBGMlH997S0b7yyBWQmAFW3WvQ Y2ok5gRQC9byhMjQWhQJXW4WG4WkdbHxH636oRLl/h8EVYQfNny46lAeuRoeZQcZHm1h PjZSd4SWecmXadmxeBGmhm9Jkh2PVxyewrwsmYRcvWu73sy8t51+XDi4V9PXM3f2vzr6 ezzg== X-Gm-Message-State: AHPjjUghD8XeQdSrhnvXAbEZDEFqldbAjAa/sj/oHH6+H/74mrpUwK3k t1Oql8ZS2vEU2EPPDHRFrvfOOeDMJM4= X-Google-Smtp-Source: AOwi7QBORHJdY/B1Ls5UFq0tLgrf685KrWTOEns14jan30RxZvXR14olS2FaVPTPBcTZtI3qRHO3+A== X-Received: by 10.46.15.26 with SMTP id 26mr178312ljp.69.1506303968519; Sun, 24 Sep 2017 18:46:08 -0700 (PDT) Received: from enkidu.local (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id f16sm809520lfe.66.2017.09.24.18.46.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 24 Sep 2017 18:46:07 -0700 (PDT) From: Marcin Wojtas To: edk2-devel@lists.01.org Date: Mon, 25 Sep 2017 03:51:55 +0200 Message-Id: <1506304319-8620-7-git-send-email-mw@semihalf.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1506304319-8620-1-git-send-email-mw@semihalf.com> References: <1506304319-8620-1-git-send-email-mw@semihalf.com> Subject: [edk2] [platforms: PATCH 06/10] Marvell/Applications/SpiTool: Fix bug in error test X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jinghua@marvell.com, ard.biesheuvel@linaro.org, agraf@suse.de, leif.lindholm@linaro.org, nadavh@marvell.com, neta@marvell.com, kostap@marvell.com MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" From: Ard Biesheuvel Fix a misplaced closing parenthesis. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel Signed-off-by: Marcin Wojtas Reviewed-by: Leif Lindholm --- Platform/Marvell/Applications/SpiTool/SpiFlashCmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.8.3.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel diff --git a/Platform/Marvell/Applications/SpiTool/SpiFlashCmd.c b/Platform/Marvell/Applications/SpiTool/SpiFlashCmd.c index b6dc54f..e6e1007 100644 --- a/Platform/Marvell/Applications/SpiTool/SpiFlashCmd.c +++ b/Platform/Marvell/Applications/SpiTool/SpiFlashCmd.c @@ -378,7 +378,7 @@ EFI_STATUS Status; FilePath = (CHAR16 *) FileStr; Status = ShellIsFile (FilePath); // When read file into flash, file doesn't have to exist - if (EFI_ERROR(Status && !(Flag & READ_FILE))) { + if (EFI_ERROR (Status) && !(Flag & READ_FILE)) { Print (L"sf: Wrong FilePath parameter!\n"); return SHELL_ABORTED; }