diff mbox series

[edk2,edk2-platforms,v3,08/11] Hisilicon/D03: Disable the function of PerfTuning

Message ID 1505991597-52989-16-git-send-email-heyi.guo@linaro.org
State New
Headers show
Series Update D03/D05 binary for edk2 update and bug fix. | expand

Commit Message

gary guo Sept. 21, 2017, 10:59 a.m. UTC
From: Chenhui Sun <chenhui.sun@linaro.org>


The PerTuning function is not stable, it will cause the
3008/3108 crash, disable this function first.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Chenhui Sun <chenhui.sun@linaro.org>

---
 Platform/Hisilicon/D03/D03.dsc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.9.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Leif Lindholm Sept. 21, 2017, 1:07 p.m. UTC | #1
On Thu, Sep 21, 2017 at 06:59:54PM +0800, Heyi Guo wrote:
> From: Chenhui Sun <chenhui.sun@linaro.org>

> 

> The PerTuning function is not stable, it will cause the

> 3008/3108 crash, disable this function first.

> 

> Contributed-under: TianoCore Contribution Agreement 1.1

> Signed-off-by: Chenhui Sun <chenhui.sun@linaro.org>


I do not see any of my comments from previous revision addressed, and
I received no reply. Feedback was:
---
Should this not also delete the PciPerfTuning() function from
PcieInitLib.c, and the declaration of
gHisiTokenSpaceGuid.PcdIsPciPerfTuningEnable from HisiPkg.dec?
---

/
    Leif

> ---

>  Platform/Hisilicon/D03/D03.dsc | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc

> index fca6781..ac880d9 100644

> --- a/Platform/Hisilicon/D03/D03.dsc

> +++ b/Platform/Hisilicon/D03/D03.dsc

> @@ -112,7 +112,7 @@

>    #  It could be set FALSE to save size.

>    gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE

>    gHisiTokenSpaceGuid.PcdIsItsSupported|TRUE

> -  gHisiTokenSpaceGuid.PcdIsPciPerfTuningEnable|TRUE

> +  gHisiTokenSpaceGuid.PcdIsPciPerfTuningEnable|FALSE

>  

>  [PcdsFixedAtBuild.common]

>    gEmbeddedTokenSpaceGuid.PcdEmbeddedPrompt|"D03"

> -- 

> 1.9.1

> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
diff mbox series

Patch

diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc
index fca6781..ac880d9 100644
--- a/Platform/Hisilicon/D03/D03.dsc
+++ b/Platform/Hisilicon/D03/D03.dsc
@@ -112,7 +112,7 @@ 
   #  It could be set FALSE to save size.
   gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
   gHisiTokenSpaceGuid.PcdIsItsSupported|TRUE
-  gHisiTokenSpaceGuid.PcdIsPciPerfTuningEnable|TRUE
+  gHisiTokenSpaceGuid.PcdIsPciPerfTuningEnable|FALSE
 
 [PcdsFixedAtBuild.common]
   gEmbeddedTokenSpaceGuid.PcdEmbeddedPrompt|"D03"