From patchwork Fri Oct 28 10:44:33 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 79892 Delivered-To: patch@linaro.org Received: by 10.140.97.247 with SMTP id m110csp1103686qge; Fri, 28 Oct 2016 03:45:00 -0700 (PDT) X-Received: by 10.98.71.215 with SMTP id p84mr23654832pfi.59.1477651500628; Fri, 28 Oct 2016 03:45:00 -0700 (PDT) Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id h26si12857934pfa.56.2016.10.28.03.45.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Oct 2016 03:45:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 7716681D54; Fri, 28 Oct 2016 03:44:58 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received: from mail-wm0-x234.google.com (mail-wm0-x234.google.com [IPv6:2a00:1450:400c:c09::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AC19281CD0 for ; Fri, 28 Oct 2016 03:44:55 -0700 (PDT) Received: by mail-wm0-x234.google.com with SMTP id n67so105690584wme.1 for ; Fri, 28 Oct 2016 03:44:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Cnz6YVk2zj29KdMXmbrtCnPLknwTG6PmaQuCb8F8m7Q=; b=Vy/TSJp84meqBVKpwxsQUaSSKz/Eydw/O4g4Df4db3JEtY47yLNKv/32v6I6vR6wve r+QwpzjYES/nHRc3a3F0az8rmVHvpJRN/d1enh/bSeyqg6v9nqLQyBgjlbnM2p/Qla5v cftpxPTBnvrkP1E6pFav3H03eKPCnBjIi9m8Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Cnz6YVk2zj29KdMXmbrtCnPLknwTG6PmaQuCb8F8m7Q=; b=lQz4w0GBMMLiWVHRAF3xOFTr0tgZMm7wkmJJ1wwqK/Am9WY00d0yHcv5NT9wR4G5/b 0kh5LX5ZV9kMB5oC+6yRdAI7RF6VLsWK3zXN6KEjxpDZqlNK70MSvkcRTBu+noMp5sdX PJwsXHNfR5vfeWlzlzO5DSP3pLsunogLDrzkTRJri05eEyiZcpSbaNL8Llr+UB7L14q7 QFrubgXCFbLLYlxW9D1u8Ju01j6iXE1Ck9g6DMujNLcyKigG9SsVMVDDHn1pth3ljOOP fQ8Vk+7zxCrKc5aHMe8oYOAEfsO3cFzvZ+gqRns25cVpbBNZw4yKDZmWwfozpXZ4csVl BIKw== X-Gm-Message-State: ABUngve04p4b/dglU5rOddr0wreylFdBWoAvjUU1OhdBpRFWuBZEiNvA5o+yVeX70hU1xm2r X-Received: by 10.194.108.105 with SMTP id hj9mr10997941wjb.194.1477651494762; Fri, 28 Oct 2016 03:44:54 -0700 (PDT) Received: from localhost.localdomain ([105.150.227.229]) by smtp.gmail.com with ESMTPSA id 184sm57730wms.4.2016.10.28.03.44.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 28 Oct 2016 03:44:54 -0700 (PDT) From: Ard Biesheuvel To: edk2-devel@lists.01.org, leif.lindholm@linaro.org Date: Fri, 28 Oct 2016 11:44:33 +0100 Message-Id: <1477651478-16830-5-git-send-email-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1477651478-16830-1-git-send-email-ard.biesheuvel@linaro.org> References: <1477651478-16830-1-git-send-email-ard.biesheuvel@linaro.org> Subject: [edk2] [PATCH v2 4/9] EmbeddedPkg/GdbDebugAgent: fix VOID* cast of incorrect size X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ryan.harkin@linaro.org, lersek@redhat.com, Ard Biesheuvel MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" The result of PcdGet64() can only be cast to VOID* on 64-bit platforms, so add an intermediate UINTN cast to make this code build again on 32 bit. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel Reviewed-by: Laszlo Ersek --- EmbeddedPkg/Library/GdbDebugAgent/Arm/Processor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Leif Lindholm diff --git a/EmbeddedPkg/Library/GdbDebugAgent/Arm/Processor.c b/EmbeddedPkg/Library/GdbDebugAgent/Arm/Processor.c index 8226c80ab466..a43ff95d03a3 100644 --- a/EmbeddedPkg/Library/GdbDebugAgent/Arm/Processor.c +++ b/EmbeddedPkg/Library/GdbDebugAgent/Arm/Processor.c @@ -657,7 +657,7 @@ InitializeDebugAgent ( *(UINTN *) (((UINT8 *)VectorBase) + Offset) = (UINTN)AsmCommonExceptionEntry; // Flush Caches since we updated executable stuff - InvalidateInstructionCacheRange ((VOID *)PcdGet64(PcdCpuVectorBaseAddress), Length); + InvalidateInstructionCacheRange ((VOID *)(UINTN)PcdGet64(PcdCpuVectorBaseAddress), Length); // setup a timer so gdb can break in via ctrl-c DebugAgentTimerIntialize ();