From patchwork Mon Oct 24 17:41:42 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 79020 Delivered-To: patch@linaro.org Received: by 10.140.97.247 with SMTP id m110csp2703238qge; Mon, 24 Oct 2016 10:42:17 -0700 (PDT) X-Received: by 10.99.150.10 with SMTP id c10mr25301959pge.94.1477330937288; Mon, 24 Oct 2016 10:42:17 -0700 (PDT) Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id e5si16540361pgg.122.2016.10.24.10.42.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Oct 2016 10:42:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 4AFEB1A1E8D; Mon, 24 Oct 2016 10:42:14 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received: from mail-wm0-x231.google.com (mail-wm0-x231.google.com [IPv6:2a00:1450:400c:c09::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E548D1A1E77 for ; Mon, 24 Oct 2016 10:42:12 -0700 (PDT) Received: by mail-wm0-x231.google.com with SMTP id c78so116622585wme.0 for ; Mon, 24 Oct 2016 10:42:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=yyAr9xHPIeWuXIWomIKnta0VMjRkbVlgr3G4u7scMqQ=; b=YXawdjgyyybpeZ+ksB3FDCOjL/VhloqbyiPkF79VhJE7SdejnnBWCGi3T2N7iylR+1 +daVzTE3R+luzSrupb1G3dEyZIehw8Q+KE1x60boGwAy5da+0lHPzOI9ygtb7gN23SU4 hHGqScBLczmkm1hDTMBw5WO2ka1owe3MB/2zM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=yyAr9xHPIeWuXIWomIKnta0VMjRkbVlgr3G4u7scMqQ=; b=ThijPiLniBQxJvo3HKWtLdXn5ypESxeAjY/IRj8KJjI/psZUZBH6qGtU5s4cnT22/7 Ef3N4y7aSBNeMPzeoTqiN9oKGQrEIHYg/qTGuVctBvrujIJI401Lv22eRsKDveC8lroZ nYIDPZ1bZYc0VBseog4H3OmzcjMtCsKQCPud1foMVsyEVLt/k7lzfIZWpCsYT078vMON klg5FKK5w+kE3sTzop1Le+qFj0Jbxmq7dOWMgty9+bBe9QLcjPs9jY0Rw/1fiOsFo59c 1fhtkxD6axpZJm5ReoN6m7WKsNORiR+ZiOzIs6UF+cF+wLNbkKQLNA5Osx5Lz6ZRdN1d DRWw== X-Gm-Message-State: AA6/9RkzJS8q6i9eEmxGLLOC3LNA+wvYtpvJNQj3idDweyuMwqw5e6fxvkZou9zsb6lkRKG2 X-Received: by 10.28.185.137 with SMTP id j131mr15309711wmf.73.1477330931462; Mon, 24 Oct 2016 10:42:11 -0700 (PDT) Received: from localhost.localdomain ([105.146.229.54]) by smtp.gmail.com with ESMTPSA id 194sm15894873wmj.20.2016.10.24.10.42.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 24 Oct 2016 10:42:10 -0700 (PDT) From: Ard Biesheuvel To: edk2-devel@lists.01.org, leif.lindholm@linaro.org, lersek@redhat.com Date: Mon, 24 Oct 2016 18:41:42 +0100 Message-Id: <1477330907-13733-5-git-send-email-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1477330907-13733-1-git-send-email-ard.biesheuvel@linaro.org> References: <1477330907-13733-1-git-send-email-ard.biesheuvel@linaro.org> Subject: [edk2] [PATCH 4/9] EmbeddedPkg/GdbDebugAgent: fix VOID* cast of incorrect size X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ard Biesheuvel MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" The result of PcdGet64() can only be cast to VOID* on 64-bit platforms, so add an intermediate UINTN cast to make this code build again on 32 bit. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- EmbeddedPkg/Library/GdbDebugAgent/Arm/Processor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Laszlo Ersek diff --git a/EmbeddedPkg/Library/GdbDebugAgent/Arm/Processor.c b/EmbeddedPkg/Library/GdbDebugAgent/Arm/Processor.c index 8226c80ab466..a43ff95d03a3 100644 --- a/EmbeddedPkg/Library/GdbDebugAgent/Arm/Processor.c +++ b/EmbeddedPkg/Library/GdbDebugAgent/Arm/Processor.c @@ -657,7 +657,7 @@ InitializeDebugAgent ( *(UINTN *) (((UINT8 *)VectorBase) + Offset) = (UINTN)AsmCommonExceptionEntry; // Flush Caches since we updated executable stuff - InvalidateInstructionCacheRange ((VOID *)PcdGet64(PcdCpuVectorBaseAddress), Length); + InvalidateInstructionCacheRange ((VOID *)(UINTN)PcdGet64(PcdCpuVectorBaseAddress), Length); // setup a timer so gdb can break in via ctrl-c DebugAgentTimerIntialize ();