From patchwork Thu Mar 24 10:37:22 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laszlo Ersek X-Patchwork-Id: 64330 Delivered-To: patch@linaro.org Received: by 10.112.199.169 with SMTP id jl9csp550178lbc; Thu, 24 Mar 2016 03:39:07 -0700 (PDT) X-Received: by 10.98.75.214 with SMTP id d83mr11575768pfj.22.1458815939878; Thu, 24 Mar 2016 03:38:59 -0700 (PDT) Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id v8si11471144pfi.16.2016.03.24.03.38.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Mar 2016 03:38:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 6D1CB1A1F33; Thu, 24 Mar 2016 03:38:45 -0700 (PDT) X-Original-To: edk2-devel@ml01.01.org Delivered-To: edk2-devel@ml01.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2F2921A1F33 for ; Thu, 24 Mar 2016 03:38:44 -0700 (PDT) Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 8C9B83B71B; Thu, 24 Mar 2016 10:38:18 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-47.phx2.redhat.com [10.3.113.47]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2OAbRfu032425; Thu, 24 Mar 2016 06:38:17 -0400 From: Laszlo Ersek To: edk2-devel-01 Date: Thu, 24 Mar 2016 11:37:22 +0100 Message-Id: <1458815844-24793-34-git-send-email-lersek@redhat.com> In-Reply-To: <1458815844-24793-1-git-send-email-lersek@redhat.com> References: <1458815844-24793-1-git-send-email-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 Subject: [edk2] [PATCH 33/35] UefiCpuPkg: PiSmmCpuDxeSmm: remove set but unused variables X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Michael Kinney , Jeff Fan MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" Cc: Jeff Fan Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c | 34 +++++++------------- 1 file changed, 11 insertions(+), 23 deletions(-) -- 1.8.3.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c index 2078421a1243..71fff0e5b0b6 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c @@ -342,7 +342,6 @@ InitProtectedMemRange ( UINTN NumberOfSpliteRange; EFI_GCD_MEMORY_SPACE_DESCRIPTOR *MemorySpaceMap; UINTN TotalSize; - EFI_STATUS Status; EFI_PHYSICAL_ADDRESS ProtectBaseAddress; EFI_PHYSICAL_ADDRESS ProtectEndAddress; EFI_PHYSICAL_ADDRESS Top2MBAlignedAddress; @@ -358,10 +357,10 @@ InitProtectedMemRange ( // // Get MMIO ranges from GCD and add them into protected memory ranges. // - Status = gDS->GetMemorySpaceMap ( - &NumberOfDescriptors, - &MemorySpaceMap - ); + gDS->GetMemorySpaceMap ( + &NumberOfDescriptors, + &MemorySpaceMap + ); for (Index = 0; Index < NumberOfDescriptors; Index++) { if (MemorySpaceMap[Index].GcdMemoryType == EfiGcdMemoryTypeMemoryMappedIo) { NumberOfMmioDescriptors++; @@ -776,18 +775,16 @@ InitSmmProfileCallBack ( IN EFI_HANDLE Handle ) { - EFI_STATUS Status; - // // Save to variable so that SMM profile data can be found. // - Status = gRT->SetVariable ( - SMM_PROFILE_NAME, - &gEfiCallerIdGuid, - EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS, - sizeof(mSmmProfileBase), - &mSmmProfileBase - ); + gRT->SetVariable ( + SMM_PROFILE_NAME, + &gEfiCallerIdGuid, + EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS, + sizeof(mSmmProfileBase), + &mSmmProfileBase + ); // // Get Software SMI from FADT @@ -1311,7 +1308,6 @@ SmmProfilePFHandler ( SMM_PROFILE_ENTRY *SmmProfileEntry; UINT64 SmiCommand; EFI_STATUS Status; - UINTN SwSmiCpuIndex; UINT8 SoftSmiValue; EFI_SMM_SAVE_STATE_IO_INFO IoInfo; @@ -1355,10 +1351,6 @@ SmmProfilePFHandler ( } // - // Try to find which CPU trigger SWSMI - // - SwSmiCpuIndex = 0; - // // Indicate it is not software SMI // SmiCommand = 0xFFFFFFFFFFFFFFFFULL; @@ -1369,10 +1361,6 @@ SmmProfilePFHandler ( } if (IoInfo.IoPort == mSmiCommandPort) { // - // Great! Find it. - // - SwSmiCpuIndex = Index; - // // A software SMI triggered by SMI command port has been found, get SmiCommand from SMI command port. // SoftSmiValue = IoRead8 (mSmiCommandPort);