From patchwork Thu Mar 24 10:37:17 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laszlo Ersek X-Patchwork-Id: 64325 Delivered-To: patch@linaro.org Received: by 10.112.199.169 with SMTP id jl9csp550069lbc; Thu, 24 Mar 2016 03:38:53 -0700 (PDT) X-Received: by 10.67.14.138 with SMTP id fg10mr11453418pad.145.1458815926484; Thu, 24 Mar 2016 03:38:46 -0700 (PDT) Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id l2si11455415pfi.44.2016.03.24.03.38.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Mar 2016 03:38:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 159771A1EF6; Thu, 24 Mar 2016 03:38:39 -0700 (PDT) X-Original-To: edk2-devel@ml01.01.org Delivered-To: edk2-devel@ml01.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 781251A1F7F for ; Thu, 24 Mar 2016 03:38:37 -0700 (PDT) Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id D626D711CD; Thu, 24 Mar 2016 10:38:11 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-47.phx2.redhat.com [10.3.113.47]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2OAbRfp032425; Thu, 24 Mar 2016 06:38:10 -0400 From: Laszlo Ersek To: edk2-devel-01 Date: Thu, 24 Mar 2016 11:37:17 +0100 Message-Id: <1458815844-24793-29-git-send-email-lersek@redhat.com> In-Reply-To: <1458815844-24793-1-git-send-email-lersek@redhat.com> References: <1458815844-24793-1-git-send-email-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 24 Mar 2016 10:38:11 +0000 (UTC) Subject: [edk2] [PATCH 28/35] QuarkSocPkg: Ohci/Dxe: remove set but unused variables X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Michael D Kinney MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" Cc: Michael D Kinney Cc: Kelly Steele Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- QuarkSocPkg/QuarkSouthCluster/Usb/Ohci/Dxe/Ohci.c | 9 --------- QuarkSocPkg/QuarkSouthCluster/Usb/Ohci/Dxe/OhciReg.c | 5 +---- 2 files changed, 1 insertion(+), 13 deletions(-) -- 1.8.3.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel diff --git a/QuarkSocPkg/QuarkSouthCluster/Usb/Ohci/Dxe/Ohci.c b/QuarkSocPkg/QuarkSouthCluster/Usb/Ohci/Dxe/Ohci.c index f73a09bf4cea..e19d4d825312 100644 --- a/QuarkSocPkg/QuarkSouthCluster/Usb/Ohci/Dxe/Ohci.c +++ b/QuarkSocPkg/QuarkSouthCluster/Usb/Ohci/Dxe/Ohci.c @@ -637,13 +637,11 @@ OhciBulkTransfer( USB_OHCI_HC_DEV *Ohc; ED_DESCRIPTOR *HeadEd; ED_DESCRIPTOR *Ed; - UINT8 EdDir; UINT32 DataPidDir; TD_DESCRIPTOR *HeadTd; TD_DESCRIPTOR *DataTd; TD_DESCRIPTOR *EmptyTd; EFI_STATUS Status; - EFI_USB_DATA_DIRECTION TransferDirection; UINT8 EndPointNum; UINTN TimeCount; OHCI_ED_RESULT EdResult; @@ -672,13 +670,9 @@ OhciBulkTransfer( Ohc = USB_OHCI_HC_DEV_FROM_THIS (This); if ((EndPointAddress & 0x80) != 0) { - TransferDirection = EfiUsbDataIn; - EdDir = ED_IN_DIR; DataPidDir = TD_IN_PID; MapOp = EfiPciIoOperationBusMasterWrite; } else { - TransferDirection = EfiUsbDataOut; - EdDir = ED_OUT_DIR; DataPidDir = TD_OUT_PID; MapOp = EfiPciIoOperationBusMasterRead; } @@ -941,7 +935,6 @@ OhciInterruptTransfer ( EFI_STATUS Status; UINT8 EndPointNum; UINT32 DataPidDir; - EFI_USB_DATA_DIRECTION TransferDirection; INTERRUPT_CONTEXT_ENTRY *Entry; EFI_TPL OldTpl; BOOLEAN FirstTD; @@ -959,11 +952,9 @@ OhciInterruptTransfer ( } if ((EndPointAddress & 0x80) != 0) { - TransferDirection = EfiUsbDataIn; EdDir = ED_IN_DIR; DataPidDir = TD_IN_PID; } else { - TransferDirection = EfiUsbDataOut; EdDir = ED_OUT_DIR; DataPidDir = TD_OUT_PID; } diff --git a/QuarkSocPkg/QuarkSouthCluster/Usb/Ohci/Dxe/OhciReg.c b/QuarkSocPkg/QuarkSouthCluster/Usb/Ohci/Dxe/OhciReg.c index 09f591d85865..ae6412ad6590 100644 --- a/QuarkSocPkg/QuarkSouthCluster/Usb/Ohci/Dxe/OhciReg.c +++ b/QuarkSocPkg/QuarkSouthCluster/Usb/Ohci/Dxe/OhciReg.c @@ -33,9 +33,8 @@ OhciGetOperationalReg ( ) { UINT32 Value; - EFI_STATUS Status; - Status = PciIo->Mem.Read(PciIo, EfiPciIoWidthUint32, OHC_BAR_INDEX, Offset, 1, &Value); + PciIo->Mem.Read(PciIo, EfiPciIoWidthUint32, OHC_BAR_INDEX, Offset, 1, &Value); return Value; } @@ -102,10 +101,8 @@ OhciSetHcReset ( IN UINT32 Value ) { - EFI_STATUS Status; HcRESET Reset; - Status = EFI_SUCCESS; *(UINT32 *) &Reset = OhciGetOperationalReg (Ohc->PciIo, USBHOST_OFFSET_UHCHR); if (Field & RESET_SYSTEM_BUS) {