From patchwork Thu Mar 24 10:37:03 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laszlo Ersek X-Patchwork-Id: 64311 Delivered-To: patch@linaro.org Received: by 10.112.199.169 with SMTP id jl9csp549812lbc; Thu, 24 Mar 2016 03:38:16 -0700 (PDT) X-Received: by 10.98.10.133 with SMTP id 5mr11523918pfk.75.1458815888085; Thu, 24 Mar 2016 03:38:08 -0700 (PDT) Return-Path: Received: from ml01.01.org (ml01.01.org. [198.145.21.10]) by mx.google.com with ESMTPS id fl1si11448524pad.15.2016.03.24.03.38.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Mar 2016 03:38:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 883461A1EFD; Thu, 24 Mar 2016 03:38:19 -0700 (PDT) X-Original-To: edk2-devel@ml01.01.org Delivered-To: edk2-devel@ml01.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 666E71A1F33 for ; Thu, 24 Mar 2016 03:38:18 -0700 (PDT) Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id C6B21804EB; Thu, 24 Mar 2016 10:37:52 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-47.phx2.redhat.com [10.3.113.47]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2OAbRfb032425; Thu, 24 Mar 2016 06:37:51 -0400 From: Laszlo Ersek To: edk2-devel-01 Date: Thu, 24 Mar 2016 11:37:03 +0100 Message-Id: <1458815844-24793-15-git-send-email-lersek@redhat.com> In-Reply-To: <1458815844-24793-1-git-send-email-lersek@redhat.com> References: <1458815844-24793-1-git-send-email-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 Subject: [edk2] [PATCH 14/35] MdeModulePkg: UfsPassThruDxe: remove set but unused variables X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Ruiyu Ni , Feng Tian , Star Zeng MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" Cc: Feng Tian Cc: Star Zeng Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.c | 4 ---- MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c | 7 +------ 2 files changed, 1 insertion(+), 10 deletions(-) -- 1.8.3.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel diff --git a/MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.c b/MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.c index bfba7aafe854..7c831e92d015 100644 --- a/MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.c +++ b/MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.c @@ -605,10 +605,6 @@ UfsPassThruGetNextTarget ( IN OUT UINT8 **Target ) { - UFS_PASS_THRU_PRIVATE_DATA *Private; - - Private = UFS_PASS_THRU_PRIVATE_DATA_FROM_THIS (This); - if (Target == NULL || *Target == NULL) { return EFI_INVALID_PARAMETER; } diff --git a/MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c b/MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c index a9fde3066fa2..26986cbf26dc 100644 --- a/MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c +++ b/MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c @@ -1431,7 +1431,6 @@ UfsExecScsiCmds ( UINTN MapLength; EDKII_UFS_HOST_CONTROLLER_PROTOCOL *UfsHc; EDKII_UFS_HOST_CONTROLLER_OPERATION Flag; - UFS_DATA_DIRECTION DataDirection; UTP_TR_PRD *PrdtBase; EFI_TPL OldTpl; UFS_PASS_THRU_TRANS_REQ *TransReq; @@ -1475,18 +1474,14 @@ UfsExecScsiCmds ( if (Packet->DataDirection == EFI_EXT_SCSI_DATA_DIRECTION_READ) { DataBuf = Packet->InDataBuffer; DataLen = Packet->InTransferLength; - DataDirection = UfsDataIn; Flag = EdkiiUfsHcOperationBusMasterWrite; } else { DataBuf = Packet->OutDataBuffer; DataLen = Packet->OutTransferLength; - DataDirection = UfsDataOut; Flag = EdkiiUfsHcOperationBusMasterRead; } - if (DataLen == 0) { - DataDirection = UfsNoData; - } else { + if (DataLen != 0) { MapLength = DataLen; Status = UfsHc->Map ( UfsHc,