From patchwork Thu Mar 17 14:36:53 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: gary guo X-Patchwork-Id: 64004 Delivered-To: patch@linaro.org Received: by 10.112.199.169 with SMTP id jl9csp507884lbc; Thu, 17 Mar 2016 07:38:13 -0700 (PDT) X-Received: by 10.66.146.39 with SMTP id sz7mr15617006pab.76.1458225491918; Thu, 17 Mar 2016 07:38:11 -0700 (PDT) Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id q14si3602135par.57.2016.03.17.07.38.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Mar 2016 07:38:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dkim=neutral (body hash did not verify) header.i=@linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 865A71A1E4C; Thu, 17 Mar 2016 07:38:31 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received: from mail-pf0-x22c.google.com (mail-pf0-x22c.google.com [IPv6:2607:f8b0:400e:c00::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7AB891A1E47 for ; Thu, 17 Mar 2016 07:38:30 -0700 (PDT) Received: by mail-pf0-x22c.google.com with SMTP id u190so123654041pfb.3 for ; Thu, 17 Mar 2016 07:38:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=F303KnkZiZhyAdltDQy7BaAE+8CU7zyl96BO8slS95Y=; b=bTiTS0xk4RrnXMsbItSo2/mSFDuSRiQkmQYKvRhH8AJ5vGZra/G2622xsBe2IuxzeZ ue98aGECxQNBD/KatjpiViH+zTaPYc1X8KjbWT/lCwumbMACf+WQdarr8EWw4F5piG7w 4Cb4MrnRn9+5uBDEWXO26RnYydB3Ig4pgks2Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=F303KnkZiZhyAdltDQy7BaAE+8CU7zyl96BO8slS95Y=; b=fudBsp3oUYbwQmBYuLJ1nwmndkDcYODl1S5O+GC25AEQeqqiLYCa6q0IcQiiXiZSWI UatP/htvc9LgHb+Hy0TMpT72wHf/W0zP6LwbDTGnUD2nN1GILZjznfOsQO2EqxVy058y U/B4vBduCA7KflG+k4TvyJADvJbdW6nNu1uLXhnhIPFVVancUzwF4E7+CY1klPuQ6uQE 4E3zdC+om+ZMo6QwJgnTlwLea/UmR5NktszcFT2g5VdziXFq9I0WM/NPvgXBF6/IYgT8 QOHC2VYjuS42/TvRImogT4OmCt9Jgfo3u1d59T/afG1JCRmGuc+pb96g97OGwpN43jlL SWJQ== X-Gm-Message-State: AD7BkJLtSTHZKlj6q8Ypan8lQOcaVsQPplvQpAYLK4e2oM4gpRBObpdGN26gabF8KtM3Htob X-Received: by 10.66.171.169 with SMTP id av9mr15490643pac.36.1458225490213; Thu, 17 Mar 2016 07:38:10 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.211]) by smtp.gmail.com with ESMTPSA id 87sm13933748pfq.93.2016.03.17.07.38.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 17 Mar 2016 07:38:09 -0700 (PDT) From: Heyi Guo To: edk2-devel@lists.01.org Date: Thu, 17 Mar 2016 22:36:53 +0800 Message-Id: <1458225414-19812-3-git-send-email-heyi.guo@linaro.org> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1458225414-19812-1-git-send-email-heyi.guo@linaro.org> References: <1458225414-19812-1-git-send-email-heyi.guo@linaro.org> Subject: [edk2] [PATCH v2 2/3] MdeModulePkg/SerialDxe: Set FIFO depth with PCD X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Heyi Guo , Feng Tian , Star Zeng MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" Set UART receive FIFO depth with PCD instead of fixed number "1". The default value of PCD is also 1, so it makes no difference for platforms which do not explicitly set this PCD. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo Cc: Feng Tian Cc: Star Zeng --- MdeModulePkg/Universal/SerialDxe/SerialDxe.inf | 9 +++++---- MdeModulePkg/Universal/SerialDxe/SerialIo.c | 3 ++- 2 files changed, 7 insertions(+), 5 deletions(-) -- 2.7.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel diff --git a/MdeModulePkg/Universal/SerialDxe/SerialDxe.inf b/MdeModulePkg/Universal/SerialDxe/SerialDxe.inf index 164060b..a1453bd 100644 --- a/MdeModulePkg/Universal/SerialDxe/SerialDxe.inf +++ b/MdeModulePkg/Universal/SerialDxe/SerialDxe.inf @@ -41,10 +41,11 @@ gEfiDevicePathProtocolGuid ## PRODUCES [Pcd] - gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate ## CONSUMES - gEfiMdePkgTokenSpaceGuid.PcdUartDefaultDataBits ## CONSUMES - gEfiMdePkgTokenSpaceGuid.PcdUartDefaultParity ## CONSUMES - gEfiMdePkgTokenSpaceGuid.PcdUartDefaultStopBits ## CONSUMES + gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate ## CONSUMES + gEfiMdePkgTokenSpaceGuid.PcdUartDefaultDataBits ## CONSUMES + gEfiMdePkgTokenSpaceGuid.PcdUartDefaultParity ## CONSUMES + gEfiMdePkgTokenSpaceGuid.PcdUartDefaultStopBits ## CONSUMES + gEfiMdePkgTokenSpaceGuid.PcdUartDefaultReceiveFifoDepth ## CONSUMES [Depex] TRUE diff --git a/MdeModulePkg/Universal/SerialDxe/SerialIo.c b/MdeModulePkg/Universal/SerialDxe/SerialIo.c index f5b3064..d2383e5 100644 --- a/MdeModulePkg/Universal/SerialDxe/SerialIo.c +++ b/MdeModulePkg/Universal/SerialDxe/SerialIo.c @@ -236,7 +236,7 @@ SerialReset ( // // Set the Serial I/O mode // - This->Mode->ReceiveFifoDepth = 1; + This->Mode->ReceiveFifoDepth = PcdGet16 (PcdUartDefaultReceiveFifoDepth); This->Mode->Timeout = 1000 * 1000; This->Mode->BaudRate = PcdGet64 (PcdUartDefaultBaudRate); This->Mode->DataBits = (UINT32) PcdGet8 (PcdUartDefaultDataBits); @@ -508,6 +508,7 @@ SerialDxeInitialize ( mSerialIoMode.DataBits = (UINT32) PcdGet8 (PcdUartDefaultDataBits); mSerialIoMode.Parity = (UINT32) PcdGet8 (PcdUartDefaultParity); mSerialIoMode.StopBits = (UINT32) PcdGet8 (PcdUartDefaultStopBits); + mSerialIoMode.ReceiveFifoDepth = PcdGet16 (PcdUartDefaultReceiveFifoDepth); mSerialDevicePath.Uart.BaudRate = PcdGet64 (PcdUartDefaultBaudRate); mSerialDevicePath.Uart.DataBits = PcdGet8 (PcdUartDefaultDataBits); mSerialDevicePath.Uart.Parity = PcdGet8 (PcdUartDefaultParity);