From patchwork Thu Dec 20 17:31:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 154348 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp6456620ljp; Thu, 20 Dec 2018 09:31:13 -0800 (PST) X-Google-Smtp-Source: AFSGD/UffMpQLys2AdazwvFPUuGqbimXJ6FHxCHCGDp4+TauWoaCyi6mwmcGvylV2LBPIVxH5a4D X-Received: by 2002:a63:5252:: with SMTP id s18mr7404613pgl.326.1545327073789; Thu, 20 Dec 2018 09:31:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545327073; cv=none; d=google.com; s=arc-20160816; b=QwprJmZPOKPnUz3gE1F6+OsOsHBPn157ymsCRKAhU+Ws2cEbqVE3ABsW5G8AvOs8Sx PfyQckBxvlk60dity/2eMm6nvjqL5yQEb3RBc/Bhvesm/baLBB7NP5H7Vus0HBqb1c4+ LbCf3Q1rKA+voMEkEEHuJpHg/8sIIpiNsCuHs78AWfij21QnAVVKazDLpGTz9CKm4o/x ud6Nv4dl3MsCRfXEL7pc4mpkIOULWbcEd2cCZMDXqSXf6H8kRVGriE8JRbNV9gwBfEeU elxLvyjsTj5ORmOjO6lmMKsD7Dwvy2YFF7ji1YyCTRI+ZZ9aqo29Fxw23zgaSPvEkSSM RnIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=SUya6q7mCmsZjcjbonqL35VQd2vRiPecUVdMSUpzwZ4=; b=hiu5FO1C4ny7IpX3yLTC+vYvFw+AfzxuUFjZ/qZSRf/c2mtaaPkPvRrh2KpJ1IjMW9 YMDk5rts8psZ8QT+kylvYhguQ12HGpU1cUYAisLf8uDjd8D6aq3EqLaohAyp/I1hy2lJ cAJFhAk0DChXV+QKOc7IhZqw8jg+hDH+IHnZk7Z0AFuuQ/Evo1Sq6ZijEKufrVLU5Lmn hJVOK0TGhuP2+FURA4bGcVZC18JTHU7M6M7YQdQZmZMlZJugqIyWULoxgTdWgWKHDeKI YXi0MszmCRBcA6S58R7Ofw6PHnfbGFdeKvnPUfgU7fWj2EYxONIowf1m1a4AAPhNUyy/ ysNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=ek7mbyem; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id z10si19910880pfm.37.2018.12.20.09.31.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Dec 2018 09:31:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=ek7mbyem; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id C547B211A43DF; Thu, 20 Dec 2018 09:31:11 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::343; helo=mail-wm1-x343.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 43D9F211A207D for ; Thu, 20 Dec 2018 09:31:10 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id f188so3095177wmf.5 for ; Thu, 20 Dec 2018 09:31:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=k98lrUe7HzvTSxJ/Mox4GyG1jVnIdA1nKMOxX/Hjrwg=; b=ek7mbyemNMm6Vd9MD3KSnlI6gXezShJUS6/CQJwql4PANv2T0zJNRHXKMW64h7k36H 13yNdBU/G+N5SU2VoDGtayX96Jpbu+82P8H1/16nBInFlzlGM+Higvm03BMDbpHFoMni WfDYcy87ljvgueqmkaf5wmIdAPtSq4983ytaQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=k98lrUe7HzvTSxJ/Mox4GyG1jVnIdA1nKMOxX/Hjrwg=; b=jjRA/WpFRwaNtSP4yfYKIVS0toWQ5/6Q2ZKE1VuGByhSYiJ8O1ceRMafrdZ0kMNS/G 0AW4VHgmH6k3+nxfDowFJTv7XhrXHdtmwLg/eqvZSHsijC5dLYfTm8KtUdviGdCmoqm0 yZX7h5L0DBaiyrW/mT+ZoE/i7e8jCcwmKqYEoGxOkPnId9yqKo2tJNvMMncRVhlQzTrb jn/MxE7zGDiEoKfYKufUR25XjDmUMtsz7nFMfbgZGNDFNXph/veqHOnZVjJWlVR82sPm pkUropdeYJf7piHVw4jTh3OvYQmQYVGgu34CepJ7/nIfgu26gQEekobNzYlmhILQOLl/ xDRA== X-Gm-Message-State: AA+aEWY1m7vmKQcGoGLru4mmHJaupSqJFl0YCegYOTuhGCckuhllzoHK kyJJTz4oK2FZboC6Pssdb+3RtWlUvlPwuA== X-Received: by 2002:a1c:a6c2:: with SMTP id p185mr11151642wme.133.1545327067775; Thu, 20 Dec 2018 09:31:07 -0800 (PST) Received: from localhost.localdomain (aputeaux-683-1-2-211.w90-86.abo.wanadoo.fr. [90.86.101.211]) by smtp.gmail.com with ESMTPSA id x12sm6826131wrt.20.2018.12.20.09.31.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Dec 2018 09:31:06 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Thu, 20 Dec 2018 18:31:00 +0100 Message-Id: <20181220173104.11481-1-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.19.2 MIME-Version: 1.0 Subject: [edk2] [PATCH 0/4] ArmPkg: use console for minimal 'exception occurred' message X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lersek@redhat.com Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" When running with a graphical console, no message whatsoever is printed when the systems hits an unexpected exception and hangs, because even the minimal 'exception occurred' message is only sent to the serial port. So let's fix that, by updating DefaultExceptionHandlerLib to take the availability of a console into account. (#4) This requires some preparatory decruftication so that we can safely refer to the system table and console (#1 .. #3). Ard Biesheuvel (4): ArmPkg/DebugAgentSymbolsBaseLib: remove exception handling ArmPkg/DefaultExceptionHandlerLib: declare the permitted usage context ArmPkg/DefaultExceptionHandlerLib: drop BASE variant ArmPkg/DefaultExceptionHandlerLib: use console if available ArmPkg/ArmPkg.dsc | 1 - .../AArch64/DebugAgentException.S | 96 ------ .../Arm/DebugAgentException.S | 277 ------------------ .../Arm/DebugAgentException.asm | 273 ----------------- .../DebugAgentSymbolsBaseLib.c | 7 - .../DebugAgentSymbolsBaseLib.inf | 9 - .../AArch64/DefaultExceptionHandler.c | 16 +- .../Arm/DefaultExceptionHandler.c | 7 +- .../DefaultExceptionHandlerBase.c | 35 --- .../DefaultExceptionHandlerLib.inf | 5 +- .../DefaultExceptionHandlerLibBase.inf | 45 --- ArmVirtPkg/ArmVirt.dsc.inc | 1 - 12 files changed, 22 insertions(+), 750 deletions(-) delete mode 100644 ArmPkg/Library/DebugAgentSymbolsBaseLib/AArch64/DebugAgentException.S delete mode 100644 ArmPkg/Library/DebugAgentSymbolsBaseLib/Arm/DebugAgentException.S delete mode 100644 ArmPkg/Library/DebugAgentSymbolsBaseLib/Arm/DebugAgentException.asm delete mode 100644 ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerBase.c delete mode 100644 ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLibBase.inf -- 2.19.2 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Leif Lindholm