[edk2,edk2-platforms,v1,0/2] Modify following Switch generic PciHostBridge

Message ID	20180805023855.10732-1-ming.huang@linaro.org
Headers	show Delivered-To: patch@linaro.org Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 198.145.21.10 as permitted sender) client-ip=198.145.21.10; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::543; helo=mail-pg1-x543.google.com; envelope-from=ming.huang@linaro.org; receiver=edk2-devel@lists.01.org From: Ming Huang <ming.huang@linaro.org> To: leif.lindholm@linaro.org, linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org Date: Sun, 5 Aug 2018 10:38:53 +0800 Message-Id: <20180805023855.10732-1-ming.huang@linaro.org> Subject: [edk2] [PATCH edk2-platforms v1 0/2] Modify following Switch generic PciHostBridge Precedence: list Cc: huangming23@huawei.com, xinliang.liu@linaro.org, john.garry@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, guoheyi@huawei.com, wanghuiqiang@huawei.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" <edk2-devel-bounces@lists.01.org>
Series	Modify following Switch generic PciHostBridge \| expand [edk2,edk2-platforms,v1,0/2] Modify following Switch generic PciHostBridge [edk2,edk2-platforms,v1,1/2] Hisilicon/D02: Remove D02 platform [edk2,edk2-platforms,v1,2/2] Platform/Hisilicon/D03: Fix PlatformPciLib path wrong issue

Message ID

20180805023855.10732-1-ming.huang@linaro.org

Headers

Received-SPF: pass (google.com: best guess record for domain of
	edk2-devel-bounces@lists.01.org designates 198.145.21.10 as
	permitted sender) client-ip=198.145.21.10; 
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
	client-ip=2607:f8b0:4864:20::543; helo=mail-pg1-x543.google.com;
	envelope-from=ming.huang@linaro.org; receiver=edk2-devel@lists.01.org 
From: Ming Huang <ming.huang@linaro.org>
To: leif.lindholm@linaro.org, linaro-uefi@lists.linaro.org,
	edk2-devel@lists.01.org, graeme.gregory@linaro.org
Date: Sun,  5 Aug 2018 10:38:53 +0800
Message-Id: <20180805023855.10732-1-ming.huang@linaro.org>
Subject: [edk2] [PATCH edk2-platforms v1 0/2] Modify following Switch
	generic PciHostBridge
Precedence: list
Cc: huangming23@huawei.com, xinliang.liu@linaro.org, john.garry@huawei.com, 
	zhangjinsong2@huawei.com, huangdaode@hisilicon.com, guoheyi@huawei.com, 
	wanghuiqiang@huawei.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: edk2-devel-bounces@lists.01.org
Sender: "edk2-devel" <edk2-devel-bounces@lists.01.org>

Series

Modify following Switch generic PciHostBridge | expand

Message

Ming Huang Aug. 5, 2018, 2:38 a.m. UTC

The major features of this patchset include:
1. Remove D02 platform;
2. Fix a D03 issue about switch generic PciHostBridge;

Code can also be found in github: https://github.com/hisilicon/OpenPlatformPkg.git
branch: rm-D02

Ming Huang (2):
  Hisilicon/D02: Remove D02 platform
  Platform/Hisilicon/D03: Fix PlatformPciLib path wrong issue

 Platform/Hisilicon/D02/Pv660D02.dec           |  44 --
 Platform/Hisilicon/D02/Pv660D02.dsc           | 425 ------------------
 Platform/Hisilicon/D03/D03.dsc                |   4 +-
 Platform/Hisilicon/D02/Pv660D02.fdf           | 321 -------------
 .../D02/EarlyConfigPeim/EarlyConfigPeim.inf   |  53 ---
 .../D02/FdtUpdateLibD02/FdtUpdateLib.inf      |  43 --
 .../Library/OemMiscLibD02/OemMiscLibD02.inf   |  45 --
 .../Library/PlatformPciLib/PlatformPciLib.inf | 182 --------
 .../D02/OemNicConfigD02/OemNicConfigD02.inf   |  50 ---
 .../Hisilicon/D02/Include/Library/CpldD02.h   |  34 --
 .../D02/OemNicConfigD02/OemNicConfig.h        |  31 --
 .../D02/EarlyConfigPeim/EarlyConfigPeim.c     |  94 ----
 .../D02/FdtUpdateLibD02/FdtUpdateLib.c        | 341 --------------
 .../Library/OemMiscLibD02/BoardFeatureD02.c   | 105 -----
 .../D02/Library/OemMiscLibD02/OemMiscLibD02.c |  77 ----
 .../Library/PlatformPciLib/PlatformPciLib.c   | 147 ------
 .../D02/OemNicConfigD02/OemNicConfigD02.c     | 173 -------
 .../Drivers/AcpiPlatformDxe/EthMac.c          |   4 +-
 .../OemMiscLibD02/BoardFeatureD02Strings.uni  | Bin 1796 -> 0 bytes
 19 files changed, 3 insertions(+), 2170 deletions(-)
 delete mode 100644 Platform/Hisilicon/D02/Pv660D02.dec
 delete mode 100644 Platform/Hisilicon/D02/Pv660D02.dsc
 delete mode 100644 Platform/Hisilicon/D02/Pv660D02.fdf
 delete mode 100644 Platform/Hisilicon/D02/EarlyConfigPeim/EarlyConfigPeim.inf
 delete mode 100644 Platform/Hisilicon/D02/FdtUpdateLibD02/FdtUpdateLib.inf
 delete mode 100644 Platform/Hisilicon/D02/Library/OemMiscLibD02/OemMiscLibD02.inf
 delete mode 100644 Platform/Hisilicon/D02/Library/PlatformPciLib/PlatformPciLib.inf
 delete mode 100644 Platform/Hisilicon/D02/OemNicConfigD02/OemNicConfigD02.inf
 delete mode 100644 Platform/Hisilicon/D02/Include/Library/CpldD02.h
 delete mode 100644 Platform/Hisilicon/D02/OemNicConfigD02/OemNicConfig.h
 delete mode 100644 Platform/Hisilicon/D02/EarlyConfigPeim/EarlyConfigPeim.c
 delete mode 100644 Platform/Hisilicon/D02/FdtUpdateLibD02/FdtUpdateLib.c
 delete mode 100644 Platform/Hisilicon/D02/Library/OemMiscLibD02/BoardFeatureD02.c
 delete mode 100644 Platform/Hisilicon/D02/Library/OemMiscLibD02/OemMiscLibD02.c
 delete mode 100644 Platform/Hisilicon/D02/Library/PlatformPciLib/PlatformPciLib.c
 delete mode 100644 Platform/Hisilicon/D02/OemNicConfigD02/OemNicConfigD02.c
 delete mode 100644 Platform/Hisilicon/D02/Library/OemMiscLibD02/BoardFeatureD02Strings.uni

-- 
2.17.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Leif Lindholm Aug. 6, 2018, 10:57 a.m. UTC | #1

On Sun, Aug 05, 2018 at 10:38:53AM +0800, Ming Huang wrote:
> The major features of this patchset include:

> 1. Remove D02 platform;

> 2. Fix a D03 issue about switch generic PciHostBridge;

> 

> Code can also be found in github: https://github.com/hisilicon/OpenPlatformPkg.git

> branch: rm-D02


This looks fine, but I think we also need a companion patch to delete
items only used by D02 from edk2-non-osi.

/
    Leif

> Ming Huang (2):

>   Hisilicon/D02: Remove D02 platform

>   Platform/Hisilicon/D03: Fix PlatformPciLib path wrong issue

> 

>  Platform/Hisilicon/D02/Pv660D02.dec           |  44 --

>  Platform/Hisilicon/D02/Pv660D02.dsc           | 425 ------------------

>  Platform/Hisilicon/D03/D03.dsc                |   4 +-

>  Platform/Hisilicon/D02/Pv660D02.fdf           | 321 -------------

>  .../D02/EarlyConfigPeim/EarlyConfigPeim.inf   |  53 ---

>  .../D02/FdtUpdateLibD02/FdtUpdateLib.inf      |  43 --

>  .../Library/OemMiscLibD02/OemMiscLibD02.inf   |  45 --

>  .../Library/PlatformPciLib/PlatformPciLib.inf | 182 --------

>  .../D02/OemNicConfigD02/OemNicConfigD02.inf   |  50 ---

>  .../Hisilicon/D02/Include/Library/CpldD02.h   |  34 --

>  .../D02/OemNicConfigD02/OemNicConfig.h        |  31 --

>  .../D02/EarlyConfigPeim/EarlyConfigPeim.c     |  94 ----

>  .../D02/FdtUpdateLibD02/FdtUpdateLib.c        | 341 --------------

>  .../Library/OemMiscLibD02/BoardFeatureD02.c   | 105 -----

>  .../D02/Library/OemMiscLibD02/OemMiscLibD02.c |  77 ----

>  .../Library/PlatformPciLib/PlatformPciLib.c   | 147 ------

>  .../D02/OemNicConfigD02/OemNicConfigD02.c     | 173 -------

>  .../Drivers/AcpiPlatformDxe/EthMac.c          |   4 +-

>  .../OemMiscLibD02/BoardFeatureD02Strings.uni  | Bin 1796 -> 0 bytes

>  19 files changed, 3 insertions(+), 2170 deletions(-)

>  delete mode 100644 Platform/Hisilicon/D02/Pv660D02.dec

>  delete mode 100644 Platform/Hisilicon/D02/Pv660D02.dsc

>  delete mode 100644 Platform/Hisilicon/D02/Pv660D02.fdf

>  delete mode 100644 Platform/Hisilicon/D02/EarlyConfigPeim/EarlyConfigPeim.inf

>  delete mode 100644 Platform/Hisilicon/D02/FdtUpdateLibD02/FdtUpdateLib.inf

>  delete mode 100644 Platform/Hisilicon/D02/Library/OemMiscLibD02/OemMiscLibD02.inf

>  delete mode 100644 Platform/Hisilicon/D02/Library/PlatformPciLib/PlatformPciLib.inf

>  delete mode 100644 Platform/Hisilicon/D02/OemNicConfigD02/OemNicConfigD02.inf

>  delete mode 100644 Platform/Hisilicon/D02/Include/Library/CpldD02.h

>  delete mode 100644 Platform/Hisilicon/D02/OemNicConfigD02/OemNicConfig.h

>  delete mode 100644 Platform/Hisilicon/D02/EarlyConfigPeim/EarlyConfigPeim.c

>  delete mode 100644 Platform/Hisilicon/D02/FdtUpdateLibD02/FdtUpdateLib.c

>  delete mode 100644 Platform/Hisilicon/D02/Library/OemMiscLibD02/BoardFeatureD02.c

>  delete mode 100644 Platform/Hisilicon/D02/Library/OemMiscLibD02/OemMiscLibD02.c

>  delete mode 100644 Platform/Hisilicon/D02/Library/PlatformPciLib/PlatformPciLib.c

>  delete mode 100644 Platform/Hisilicon/D02/OemNicConfigD02/OemNicConfigD02.c

>  delete mode 100644 Platform/Hisilicon/D02/Library/OemMiscLibD02/BoardFeatureD02Strings.uni

> 

> -- 

> 2.17.0

> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Ming Huang Aug. 7, 2018, 3:31 p.m. UTC | #2

在 8/6/2018 6:57 PM, Leif Lindholm 写道:
> On Sun, Aug 05, 2018 at 10:38:53AM +0800, Ming Huang wrote:
>> The major features of this patchset include:
>> 1. Remove D02 platform;
>> 2. Fix a D03 issue about switch generic PciHostBridge;
>>
>> Code can also be found in github: https://github.com/hisilicon/OpenPlatformPkg.git
>> branch: rm-D02
> 
> This looks fine, but I think we also need a companion patch to delete
> items only used by D02 from edk2-non-osi.
> 
> /
>     Leif
> 

I have sent the companion patch out.

Ming

>> Ming Huang (2):
>>   Hisilicon/D02: Remove D02 platform
>>   Platform/Hisilicon/D03: Fix PlatformPciLib path wrong issue
>>
>>  Platform/Hisilicon/D02/Pv660D02.dec           |  44 --
>>  Platform/Hisilicon/D02/Pv660D02.dsc           | 425 ------------------
>>  Platform/Hisilicon/D03/D03.dsc                |   4 +-
>>  Platform/Hisilicon/D02/Pv660D02.fdf           | 321 -------------
>>  .../D02/EarlyConfigPeim/EarlyConfigPeim.inf   |  53 ---
>>  .../D02/FdtUpdateLibD02/FdtUpdateLib.inf      |  43 --
>>  .../Library/OemMiscLibD02/OemMiscLibD02.inf   |  45 --
>>  .../Library/PlatformPciLib/PlatformPciLib.inf | 182 --------
>>  .../D02/OemNicConfigD02/OemNicConfigD02.inf   |  50 ---
>>  .../Hisilicon/D02/Include/Library/CpldD02.h   |  34 --
>>  .../D02/OemNicConfigD02/OemNicConfig.h        |  31 --
>>  .../D02/EarlyConfigPeim/EarlyConfigPeim.c     |  94 ----
>>  .../D02/FdtUpdateLibD02/FdtUpdateLib.c        | 341 --------------
>>  .../Library/OemMiscLibD02/BoardFeatureD02.c   | 105 -----
>>  .../D02/Library/OemMiscLibD02/OemMiscLibD02.c |  77 ----
>>  .../Library/PlatformPciLib/PlatformPciLib.c   | 147 ------
>>  .../D02/OemNicConfigD02/OemNicConfigD02.c     | 173 -------
>>  .../Drivers/AcpiPlatformDxe/EthMac.c          |   4 +-
>>  .../OemMiscLibD02/BoardFeatureD02Strings.uni  | Bin 1796 -> 0 bytes
>>  19 files changed, 3 insertions(+), 2170 deletions(-)
>>  delete mode 100644 Platform/Hisilicon/D02/Pv660D02.dec
>>  delete mode 100644 Platform/Hisilicon/D02/Pv660D02.dsc
>>  delete mode 100644 Platform/Hisilicon/D02/Pv660D02.fdf
>>  delete mode 100644 Platform/Hisilicon/D02/EarlyConfigPeim/EarlyConfigPeim.inf
>>  delete mode 100644 Platform/Hisilicon/D02/FdtUpdateLibD02/FdtUpdateLib.inf
>>  delete mode 100644 Platform/Hisilicon/D02/Library/OemMiscLibD02/OemMiscLibD02.inf
>>  delete mode 100644 Platform/Hisilicon/D02/Library/PlatformPciLib/PlatformPciLib.inf
>>  delete mode 100644 Platform/Hisilicon/D02/OemNicConfigD02/OemNicConfigD02.inf
>>  delete mode 100644 Platform/Hisilicon/D02/Include/Library/CpldD02.h
>>  delete mode 100644 Platform/Hisilicon/D02/OemNicConfigD02/OemNicConfig.h
>>  delete mode 100644 Platform/Hisilicon/D02/EarlyConfigPeim/EarlyConfigPeim.c
>>  delete mode 100644 Platform/Hisilicon/D02/FdtUpdateLibD02/FdtUpdateLib.c
>>  delete mode 100644 Platform/Hisilicon/D02/Library/OemMiscLibD02/BoardFeatureD02.c
>>  delete mode 100644 Platform/Hisilicon/D02/Library/OemMiscLibD02/OemMiscLibD02.c
>>  delete mode 100644 Platform/Hisilicon/D02/Library/PlatformPciLib/PlatformPciLib.c
>>  delete mode 100644 Platform/Hisilicon/D02/OemNicConfigD02/OemNicConfigD02.c
>>  delete mode 100644 Platform/Hisilicon/D02/Library/OemMiscLibD02/BoardFeatureD02Strings.uni
>>
>> -- 
>> 2.17.0
>>

Leif Lindholm Aug. 8, 2018, 8:59 a.m. UTC | #3

On Sun, Aug 05, 2018 at 10:38:53AM +0800, Ming Huang wrote:
> The major features of this patchset include:

> 1. Remove D02 platform;

> 2. Fix a D03 issue about switch generic PciHostBridge;

> 

> Code can also be found in github: https://github.com/hisilicon/OpenPlatformPkg.git

> branch: rm-D02

> 

> Ming Huang (2):

>   Hisilicon/D02: Remove D02 platform

>   Platform/Hisilicon/D03: Fix PlatformPciLib path wrong issue

> 

>  Platform/Hisilicon/D02/Pv660D02.dec           |  44 --

>  Platform/Hisilicon/D02/Pv660D02.dsc           | 425 ------------------

>  Platform/Hisilicon/D03/D03.dsc                |   4 +-

>  Platform/Hisilicon/D02/Pv660D02.fdf           | 321 -------------

>  .../D02/EarlyConfigPeim/EarlyConfigPeim.inf   |  53 ---

>  .../D02/FdtUpdateLibD02/FdtUpdateLib.inf      |  43 --

>  .../Library/OemMiscLibD02/OemMiscLibD02.inf   |  45 --

>  .../Library/PlatformPciLib/PlatformPciLib.inf | 182 --------

>  .../D02/OemNicConfigD02/OemNicConfigD02.inf   |  50 ---

>  .../Hisilicon/D02/Include/Library/CpldD02.h   |  34 --

>  .../D02/OemNicConfigD02/OemNicConfig.h        |  31 --

>  .../D02/EarlyConfigPeim/EarlyConfigPeim.c     |  94 ----

>  .../D02/FdtUpdateLibD02/FdtUpdateLib.c        | 341 --------------

>  .../Library/OemMiscLibD02/BoardFeatureD02.c   | 105 -----

>  .../D02/Library/OemMiscLibD02/OemMiscLibD02.c |  77 ----

>  .../Library/PlatformPciLib/PlatformPciLib.c   | 147 ------

>  .../D02/OemNicConfigD02/OemNicConfigD02.c     | 173 -------

>  .../Drivers/AcpiPlatformDxe/EthMac.c          |   4 +-

>  .../OemMiscLibD02/BoardFeatureD02Strings.uni  | Bin 1796 -> 0 bytes


I see you've added the orderfile - excellent!
In future, please follow the --stat and --stat-grap-width of the
instructions from
https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-23
as well please :)

For the series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

Pushed as d346a222df..478282ea28.
NOTE: I changed the order of the patches so that the one that fixed a
problem in a remaining platform comes first.

/
    Leif

>  19 files changed, 3 insertions(+), 2170 deletions(-)

>  delete mode 100644 Platform/Hisilicon/D02/Pv660D02.dec

>  delete mode 100644 Platform/Hisilicon/D02/Pv660D02.dsc

>  delete mode 100644 Platform/Hisilicon/D02/Pv660D02.fdf

>  delete mode 100644 Platform/Hisilicon/D02/EarlyConfigPeim/EarlyConfigPeim.inf

>  delete mode 100644 Platform/Hisilicon/D02/FdtUpdateLibD02/FdtUpdateLib.inf

>  delete mode 100644 Platform/Hisilicon/D02/Library/OemMiscLibD02/OemMiscLibD02.inf

>  delete mode 100644 Platform/Hisilicon/D02/Library/PlatformPciLib/PlatformPciLib.inf

>  delete mode 100644 Platform/Hisilicon/D02/OemNicConfigD02/OemNicConfigD02.inf

>  delete mode 100644 Platform/Hisilicon/D02/Include/Library/CpldD02.h

>  delete mode 100644 Platform/Hisilicon/D02/OemNicConfigD02/OemNicConfig.h

>  delete mode 100644 Platform/Hisilicon/D02/EarlyConfigPeim/EarlyConfigPeim.c

>  delete mode 100644 Platform/Hisilicon/D02/FdtUpdateLibD02/FdtUpdateLib.c

>  delete mode 100644 Platform/Hisilicon/D02/Library/OemMiscLibD02/BoardFeatureD02.c

>  delete mode 100644 Platform/Hisilicon/D02/Library/OemMiscLibD02/OemMiscLibD02.c

>  delete mode 100644 Platform/Hisilicon/D02/Library/PlatformPciLib/PlatformPciLib.c

>  delete mode 100644 Platform/Hisilicon/D02/OemNicConfigD02/OemNicConfigD02.c

>  delete mode 100644 Platform/Hisilicon/D02/Library/OemMiscLibD02/BoardFeatureD02Strings.uni

> 

> -- 

> 2.17.0

> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel