mbox series

[edk2,edk2-platforms,0/5] Seattle spring cleaning

Message ID 20180515173736.29639-1-ard.biesheuvel@linaro.org
Headers show
Series Seattle spring cleaning | expand

Message

Ard Biesheuvel May 15, 2018, 5:37 p.m. UTC
Some cleanup patches for Seattle, removing the unused code that deals
with configurations where the SCP, ARM-TF or PSCI support are absent,
which is rather pointless for a platform that is no longer under
development.

Ard Biesheuvel (5):
  Silicon/AMD/Styx: make ARM-TF and PSCI dependencies unconditional
  Silicon/AMD/Styx: remove MpBootDxe driver
  Silicon/AMD/Styx: remove support for the ACPI parking protocol
  Silicon/AMD/Styx: make ISCP dependency unconditional
  Platform/AMD/Overdrive: enable support for NVME PCIe devices

 .../AMD/OverdriveBoard/OverdriveBoard.dsc     |  20 +--
 .../AMD/OverdriveBoard/OverdriveBoard.fdf     |   6 +-
 Platform/LeMaker/CelloBoard/CelloBoard.dsc    |   3 -
 .../Overdrive1000Board/Overdrive1000Board.dsc |  19 --
 .../Overdrive1000Board/Overdrive1000Board.fdf |   5 -
 Silicon/AMD/Styx/AcpiTables/AcpiTables.inf    |   3 -
 Silicon/AMD/Styx/AcpiTables/Fadt.c            |   5 +-
 Silicon/AMD/Styx/AcpiTables/Madt.c            |  24 +--
 Silicon/AMD/Styx/AmdStyx.dec                  |  12 --
 Silicon/AMD/Styx/Common/Protocol/AmdMpBoot.h  |  39 ----
 .../AMD/Styx/Common/Protocol/AmdMpCoreInfo.h  |   7 -
 .../AMD/Styx/Drivers/MpBootDxe/MpBootDxe.c    | 170 ------------------
 .../AMD/Styx/Drivers/MpBootDxe/MpBootDxe.inf  |  53 ------
 .../AMD/Styx/Drivers/MpBootDxe/MpBootHelper.S |  87 ---------
 .../Styx/Drivers/PlatInitDxe/PlatInitDxe.c    |  91 ----------
 .../Styx/Drivers/PlatInitDxe/PlatInitDxe.inf  |   6 -
 .../Styx/Drivers/PlatInitPei/PlatInitPei.c    | 120 ++++++-------
 .../Styx/Drivers/PlatInitPei/PlatInitPei.inf  |   2 -
 .../PlatformSmbiosDxe/PlatformSmbiosDxe.c     |  40 -----
 .../PlatformSmbiosDxe/PlatformSmbiosDxe.inf   |   1 -
 .../Library/MemoryInitPei/MemoryInitPeiLib.c  |  58 +++---
 .../MemoryInitPei/MemoryInitPeiLib.inf        |   3 -
 .../RealTimeClockLib/RealTimeClockLib.c       |  16 +-
 .../RealTimeClockLib/RealTimeClockLib.inf     |   3 -
 .../Library/ResetSystemLib/ResetSystemLib.inf |   3 -
 .../StyxDtbLoaderLib/StyxDtbLoaderLib.inf     |   2 -
 26 files changed, 89 insertions(+), 709 deletions(-)
 delete mode 100644 Silicon/AMD/Styx/Common/Protocol/AmdMpBoot.h
 delete mode 100644 Silicon/AMD/Styx/Drivers/MpBootDxe/MpBootDxe.c
 delete mode 100644 Silicon/AMD/Styx/Drivers/MpBootDxe/MpBootDxe.inf
 delete mode 100644 Silicon/AMD/Styx/Drivers/MpBootDxe/MpBootHelper.S

-- 
2.17.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Leif Lindholm May 22, 2018, 2:56 p.m. UTC | #1
On Tue, May 15, 2018 at 07:37:31PM +0200, Ard Biesheuvel wrote:
> Some cleanup patches for Seattle, removing the unused code that deals

> with configurations where the SCP, ARM-TF or PSCI support are absent,

> which is rather pointless for a platform that is no longer under

> development.

> 

> Ard Biesheuvel (5):

>   Silicon/AMD/Styx: make ARM-TF and PSCI dependencies unconditional

>   Silicon/AMD/Styx: remove MpBootDxe driver

>   Silicon/AMD/Styx: remove support for the ACPI parking protocol

>   Silicon/AMD/Styx: make ISCP dependency unconditional

>   Platform/AMD/Overdrive: enable support for NVME PCIe devices


For the series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>



>  .../AMD/OverdriveBoard/OverdriveBoard.dsc     |  20 +--

>  .../AMD/OverdriveBoard/OverdriveBoard.fdf     |   6 +-

>  Platform/LeMaker/CelloBoard/CelloBoard.dsc    |   3 -

>  .../Overdrive1000Board/Overdrive1000Board.dsc |  19 --

>  .../Overdrive1000Board/Overdrive1000Board.fdf |   5 -

>  Silicon/AMD/Styx/AcpiTables/AcpiTables.inf    |   3 -

>  Silicon/AMD/Styx/AcpiTables/Fadt.c            |   5 +-

>  Silicon/AMD/Styx/AcpiTables/Madt.c            |  24 +--

>  Silicon/AMD/Styx/AmdStyx.dec                  |  12 --

>  Silicon/AMD/Styx/Common/Protocol/AmdMpBoot.h  |  39 ----

>  .../AMD/Styx/Common/Protocol/AmdMpCoreInfo.h  |   7 -

>  .../AMD/Styx/Drivers/MpBootDxe/MpBootDxe.c    | 170 ------------------

>  .../AMD/Styx/Drivers/MpBootDxe/MpBootDxe.inf  |  53 ------

>  .../AMD/Styx/Drivers/MpBootDxe/MpBootHelper.S |  87 ---------

>  .../Styx/Drivers/PlatInitDxe/PlatInitDxe.c    |  91 ----------

>  .../Styx/Drivers/PlatInitDxe/PlatInitDxe.inf  |   6 -

>  .../Styx/Drivers/PlatInitPei/PlatInitPei.c    | 120 ++++++-------

>  .../Styx/Drivers/PlatInitPei/PlatInitPei.inf  |   2 -

>  .../PlatformSmbiosDxe/PlatformSmbiosDxe.c     |  40 -----

>  .../PlatformSmbiosDxe/PlatformSmbiosDxe.inf   |   1 -

>  .../Library/MemoryInitPei/MemoryInitPeiLib.c  |  58 +++---

>  .../MemoryInitPei/MemoryInitPeiLib.inf        |   3 -

>  .../RealTimeClockLib/RealTimeClockLib.c       |  16 +-

>  .../RealTimeClockLib/RealTimeClockLib.inf     |   3 -

>  .../Library/ResetSystemLib/ResetSystemLib.inf |   3 -

>  .../StyxDtbLoaderLib/StyxDtbLoaderLib.inf     |   2 -

>  26 files changed, 89 insertions(+), 709 deletions(-)

>  delete mode 100644 Silicon/AMD/Styx/Common/Protocol/AmdMpBoot.h

>  delete mode 100644 Silicon/AMD/Styx/Drivers/MpBootDxe/MpBootDxe.c

>  delete mode 100644 Silicon/AMD/Styx/Drivers/MpBootDxe/MpBootDxe.inf

>  delete mode 100644 Silicon/AMD/Styx/Drivers/MpBootDxe/MpBootHelper.S

> 

> -- 

> 2.17.0

> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Ard Biesheuvel May 22, 2018, 4:40 p.m. UTC | #2
On 22 May 2018 at 16:56, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Tue, May 15, 2018 at 07:37:31PM +0200, Ard Biesheuvel wrote:

>> Some cleanup patches for Seattle, removing the unused code that deals

>> with configurations where the SCP, ARM-TF or PSCI support are absent,

>> which is rather pointless for a platform that is no longer under

>> development.

>>

>> Ard Biesheuvel (5):

>>   Silicon/AMD/Styx: make ARM-TF and PSCI dependencies unconditional

>>   Silicon/AMD/Styx: remove MpBootDxe driver

>>   Silicon/AMD/Styx: remove support for the ACPI parking protocol

>>   Silicon/AMD/Styx: make ISCP dependency unconditional

>>   Platform/AMD/Overdrive: enable support for NVME PCIe devices

>

> For the series:

> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

>


Thanks

Pushed as 735e517fefbf..e174fc77d3bb


>

>>  .../AMD/OverdriveBoard/OverdriveBoard.dsc     |  20 +--

>>  .../AMD/OverdriveBoard/OverdriveBoard.fdf     |   6 +-

>>  Platform/LeMaker/CelloBoard/CelloBoard.dsc    |   3 -

>>  .../Overdrive1000Board/Overdrive1000Board.dsc |  19 --

>>  .../Overdrive1000Board/Overdrive1000Board.fdf |   5 -

>>  Silicon/AMD/Styx/AcpiTables/AcpiTables.inf    |   3 -

>>  Silicon/AMD/Styx/AcpiTables/Fadt.c            |   5 +-

>>  Silicon/AMD/Styx/AcpiTables/Madt.c            |  24 +--

>>  Silicon/AMD/Styx/AmdStyx.dec                  |  12 --

>>  Silicon/AMD/Styx/Common/Protocol/AmdMpBoot.h  |  39 ----

>>  .../AMD/Styx/Common/Protocol/AmdMpCoreInfo.h  |   7 -

>>  .../AMD/Styx/Drivers/MpBootDxe/MpBootDxe.c    | 170 ------------------

>>  .../AMD/Styx/Drivers/MpBootDxe/MpBootDxe.inf  |  53 ------

>>  .../AMD/Styx/Drivers/MpBootDxe/MpBootHelper.S |  87 ---------

>>  .../Styx/Drivers/PlatInitDxe/PlatInitDxe.c    |  91 ----------

>>  .../Styx/Drivers/PlatInitDxe/PlatInitDxe.inf  |   6 -

>>  .../Styx/Drivers/PlatInitPei/PlatInitPei.c    | 120 ++++++-------

>>  .../Styx/Drivers/PlatInitPei/PlatInitPei.inf  |   2 -

>>  .../PlatformSmbiosDxe/PlatformSmbiosDxe.c     |  40 -----

>>  .../PlatformSmbiosDxe/PlatformSmbiosDxe.inf   |   1 -

>>  .../Library/MemoryInitPei/MemoryInitPeiLib.c  |  58 +++---

>>  .../MemoryInitPei/MemoryInitPeiLib.inf        |   3 -

>>  .../RealTimeClockLib/RealTimeClockLib.c       |  16 +-

>>  .../RealTimeClockLib/RealTimeClockLib.inf     |   3 -

>>  .../Library/ResetSystemLib/ResetSystemLib.inf |   3 -

>>  .../StyxDtbLoaderLib/StyxDtbLoaderLib.inf     |   2 -

>>  26 files changed, 89 insertions(+), 709 deletions(-)

>>  delete mode 100644 Silicon/AMD/Styx/Common/Protocol/AmdMpBoot.h

>>  delete mode 100644 Silicon/AMD/Styx/Drivers/MpBootDxe/MpBootDxe.c

>>  delete mode 100644 Silicon/AMD/Styx/Drivers/MpBootDxe/MpBootDxe.inf

>>  delete mode 100644 Silicon/AMD/Styx/Drivers/MpBootDxe/MpBootHelper.S

>>

>> --

>> 2.17.0

>>

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel