| Message ID | 20180423150057.13515-1-ard.biesheuvel@linaro.org |
|---|---|
| Headers | show |
| Series | Reenable timer mask quirk for Xen | expand |
On Mon, Apr 23, 2018 at 05:00:55PM +0200, Ard Biesheuvel wrote: > Reinstate the timer mask quirk for Xen that we recently removed under the > assumption that only ancient KVM host implementations still needed it. From my point of view, for the series: Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> But I'd like Julien's R-b as well. / Leif > Ard Biesheuvel (2): > ArmPkg: add reenable hook to ArmGenericTimerCounterLib > ArmVirtPkg: reinstate timer unmask quirk for Xen > > ArmPkg/Drivers/TimerDxe/TimerDxe.c | 1 + > .../Library/ArmGenericTimerCounterLib.h | 6 + > .../ArmGenericTimerPhyCounterLib.c | 8 + > .../ArmGenericTimerVirtCounterLib.c | 8 + > ArmVirtPkg/ArmVirtXen.dsc | 1 + > .../XenArmGenericTimerVirtCounterLib.c | 146 ++++++++++++++++++ > .../XenArmGenericTimerVirtCounterLib.inf | 33 ++++ > 7 files changed, 203 insertions(+) > create mode 100644 ArmVirtPkg/Library/XenArmGenericTimerVirtCounterLib/XenArmGenericTimerVirtCounterLib.c > create mode 100644 ArmVirtPkg/Library/XenArmGenericTimerVirtCounterLib/XenArmGenericTimerVirtCounterLib.inf > > -- > 2.17.0 > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
On 04/23/18 17:00, Ard Biesheuvel wrote: > Reinstate the timer mask quirk for Xen that we recently removed under the > assumption that only ancient KVM host implementations still needed it. > > Ard Biesheuvel (2): > ArmPkg: add reenable hook to ArmGenericTimerCounterLib > ArmVirtPkg: reinstate timer unmask quirk for Xen > > ArmPkg/Drivers/TimerDxe/TimerDxe.c | 1 + > .../Library/ArmGenericTimerCounterLib.h | 6 + > .../ArmGenericTimerPhyCounterLib.c | 8 + > .../ArmGenericTimerVirtCounterLib.c | 8 + > ArmVirtPkg/ArmVirtXen.dsc | 1 + > .../XenArmGenericTimerVirtCounterLib.c | 146 ++++++++++++++++++ > .../XenArmGenericTimerVirtCounterLib.inf | 33 ++++ > 7 files changed, 203 insertions(+) > create mode 100644 ArmVirtPkg/Library/XenArmGenericTimerVirtCounterLib/XenArmGenericTimerVirtCounterLib.c > create mode 100644 ArmVirtPkg/Library/XenArmGenericTimerVirtCounterLib/XenArmGenericTimerVirtCounterLib.inf > For the series: Reviewed-by: Laszlo Ersek <lersek@redhat.com> Thanks Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Hi Ard, Thank you for the series, I confirm it fixes EDK2 boot in Xen guest. Tested-by: Julien Grall <julien.grall@arm.com> Acked-by: Julien Grall <julien.grall@arm.com> Cheers, On 23/04/18 16:00, Ard Biesheuvel wrote: > Reinstate the timer mask quirk for Xen that we recently removed under the > assumption that only ancient KVM host implementations still needed it. > > Ard Biesheuvel (2): > ArmPkg: add reenable hook to ArmGenericTimerCounterLib > ArmVirtPkg: reinstate timer unmask quirk for Xen > > ArmPkg/Drivers/TimerDxe/TimerDxe.c | 1 + > .../Library/ArmGenericTimerCounterLib.h | 6 + > .../ArmGenericTimerPhyCounterLib.c | 8 + > .../ArmGenericTimerVirtCounterLib.c | 8 + > ArmVirtPkg/ArmVirtXen.dsc | 1 + > .../XenArmGenericTimerVirtCounterLib.c | 146 ++++++++++++++++++ > .../XenArmGenericTimerVirtCounterLib.inf | 33 ++++ > 7 files changed, 203 insertions(+) > create mode 100644 ArmVirtPkg/Library/XenArmGenericTimerVirtCounterLib/XenArmGenericTimerVirtCounterLib.c > create mode 100644 ArmVirtPkg/Library/XenArmGenericTimerVirtCounterLib/XenArmGenericTimerVirtCounterLib.inf > -- Julien Grall _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
On 25 April 2018 at 19:26, Julien Grall <julien.grall@arm.com> wrote: > Hi Ard, > > Thank you for the series, I confirm it fixes EDK2 boot in Xen guest. > > Tested-by: Julien Grall <julien.grall@arm.com> > Acked-by: Julien Grall <julien.grall@arm.com> > Pushed as 1eb72acddd61..ef42ef7e6dd7 Thanks all. > On 23/04/18 16:00, Ard Biesheuvel wrote: >> >> Reinstate the timer mask quirk for Xen that we recently removed under the >> assumption that only ancient KVM host implementations still needed it. >> >> Ard Biesheuvel (2): >> ArmPkg: add reenable hook to ArmGenericTimerCounterLib >> ArmVirtPkg: reinstate timer unmask quirk for Xen >> >> ArmPkg/Drivers/TimerDxe/TimerDxe.c | 1 + >> .../Library/ArmGenericTimerCounterLib.h | 6 + >> .../ArmGenericTimerPhyCounterLib.c | 8 + >> .../ArmGenericTimerVirtCounterLib.c | 8 + >> ArmVirtPkg/ArmVirtXen.dsc | 1 + >> .../XenArmGenericTimerVirtCounterLib.c | 146 ++++++++++++++++++ >> .../XenArmGenericTimerVirtCounterLib.inf | 33 ++++ >> 7 files changed, 203 insertions(+) >> create mode 100644 >> ArmVirtPkg/Library/XenArmGenericTimerVirtCounterLib/XenArmGenericTimerVirtCounterLib.c >> create mode 100644 >> ArmVirtPkg/Library/XenArmGenericTimerVirtCounterLib/XenArmGenericTimerVirtCounterLib.inf >> > > -- > Julien Grall _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel