| Message ID | 20171212190747.15742-1-ard.biesheuvel@linaro.org |
|---|---|
| Headers | show |
| Series | ArmPlatformPkg PCD cleanup | expand |
On Tue, Dec 12, 2017 at 07:07:45PM +0000, Ard Biesheuvel wrote: > Remove lots and lots of PCD assignments of obsolete PCDs that are about > to be removed from ArmPlatformPkg. For the series: Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> > v3: Don't replace instances of gArmPlatformTokenSpaceGuid.PcdFirmwareVendor > with gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor. First of all, the > latter expects a Unicode string, but blindly replacing them would result > in user visible changes in the firmware vendor reported by the OS. > Instead, replace the only meaningful reference with a dedicated new PCD > (for fastboot), and just drop all other assignments. > Patch #2 is therefore modified as well, so I dropped Leif's R-b > > Ard Biesheuvel (2): > Platform/ARM/VExpressPkg: use dedicated PCD for fastboot product name > Platform Silicon: remove obsolete ArmPlatformPkg PCD assignments > > Platform/ARM/JunoPkg/ArmJuno.dsc | 13 ------------- > Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf | 3 --- > Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc | 15 +-------------- > Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc | 17 ----------------- > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 10 ---------- > Platform/ARM/VExpressPkg/ArmVExpressPkg.dec | 1 + > Platform/ARM/VExpressPkg/Drivers/ArmVExpressFastBootDxe/ArmVExpressFastBoot.c | 2 +- > Platform/ARM/VExpressPkg/Drivers/ArmVExpressFastBootDxe/ArmVExpressFastBootDxe.inf | 2 +- > Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLib.inf | 1 - > Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLibSec.inf | 1 - > Platform/Hisilicon/D02/Pv660D02.dsc | 20 -------------------- > Platform/Hisilicon/D03/D03.dsc | 20 -------------------- > Platform/Hisilicon/D05/D05.dsc | 12 ------------ > Platform/Hisilicon/HiKey/HiKey.dsc | 1 - > Silicon/AMD/Styx/Library/AmdStyxLib/AmdStyxLib.inf | 1 - > Silicon/AMD/Styx/Library/AmdStyxLib/AmdStyxLibSec.inf | 1 - > Silicon/Hisilicon/Hisilicon.dsc.inc | 14 -------------- > Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLib.inf | 1 - > Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLibSec.inf | 1 - > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 5 ----- > 20 files changed, 4 insertions(+), 137 deletions(-) > > -- > 2.11.0 > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
\\On 12 December 2017 at 19:13, Leif Lindholm <leif.lindholm@linaro.org> wrote: > On Tue, Dec 12, 2017 at 07:07:45PM +0000, Ard Biesheuvel wrote: >> Remove lots and lots of PCD assignments of obsolete PCDs that are about >> to be removed from ArmPlatformPkg. > > For the series: > Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> > Thanks. Pushed as 054921cef0f1..dfacf5057f3 >> v3: Don't replace instances of gArmPlatformTokenSpaceGuid.PcdFirmwareVendor >> with gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor. First of all, the >> latter expects a Unicode string, but blindly replacing them would result >> in user visible changes in the firmware vendor reported by the OS. >> Instead, replace the only meaningful reference with a dedicated new PCD >> (for fastboot), and just drop all other assignments. >> Patch #2 is therefore modified as well, so I dropped Leif's R-b >> >> Ard Biesheuvel (2): >> Platform/ARM/VExpressPkg: use dedicated PCD for fastboot product name >> Platform Silicon: remove obsolete ArmPlatformPkg PCD assignments >> >> Platform/ARM/JunoPkg/ArmJuno.dsc | 13 ------------- >> Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf | 3 --- >> Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc | 15 +-------------- >> Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc | 17 ----------------- >> Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 10 ---------- >> Platform/ARM/VExpressPkg/ArmVExpressPkg.dec | 1 + >> Platform/ARM/VExpressPkg/Drivers/ArmVExpressFastBootDxe/ArmVExpressFastBoot.c | 2 +- >> Platform/ARM/VExpressPkg/Drivers/ArmVExpressFastBootDxe/ArmVExpressFastBootDxe.inf | 2 +- >> Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLib.inf | 1 - >> Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLibSec.inf | 1 - >> Platform/Hisilicon/D02/Pv660D02.dsc | 20 -------------------- >> Platform/Hisilicon/D03/D03.dsc | 20 -------------------- >> Platform/Hisilicon/D05/D05.dsc | 12 ------------ >> Platform/Hisilicon/HiKey/HiKey.dsc | 1 - >> Silicon/AMD/Styx/Library/AmdStyxLib/AmdStyxLib.inf | 1 - >> Silicon/AMD/Styx/Library/AmdStyxLib/AmdStyxLibSec.inf | 1 - >> Silicon/Hisilicon/Hisilicon.dsc.inc | 14 -------------- >> Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLib.inf | 1 - >> Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLibSec.inf | 1 - >> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 5 ----- >> 20 files changed, 4 insertions(+), 137 deletions(-) >> >> -- >> 2.11.0 >> _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Remove lots and lots of PCD assignments of obsolete PCDs that are about to be removed from ArmPlatformPkg. v3: Don't replace instances of gArmPlatformTokenSpaceGuid.PcdFirmwareVendor with gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor. First of all, the latter expects a Unicode string, but blindly replacing them would result in user visible changes in the firmware vendor reported by the OS. Instead, replace the only meaningful reference with a dedicated new PCD (for fastboot), and just drop all other assignments. Patch #2 is therefore modified as well, so I dropped Leif's R-b Ard Biesheuvel (2): Platform/ARM/VExpressPkg: use dedicated PCD for fastboot product name Platform Silicon: remove obsolete ArmPlatformPkg PCD assignments Platform/ARM/JunoPkg/ArmJuno.dsc | 13 ------------- Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf | 3 --- Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc | 15 +-------------- Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc | 17 ----------------- Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 10 ---------- Platform/ARM/VExpressPkg/ArmVExpressPkg.dec | 1 + Platform/ARM/VExpressPkg/Drivers/ArmVExpressFastBootDxe/ArmVExpressFastBoot.c | 2 +- Platform/ARM/VExpressPkg/Drivers/ArmVExpressFastBootDxe/ArmVExpressFastBootDxe.inf | 2 +- Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLib.inf | 1 - Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLibSec.inf | 1 - Platform/Hisilicon/D02/Pv660D02.dsc | 20 -------------------- Platform/Hisilicon/D03/D03.dsc | 20 -------------------- Platform/Hisilicon/D05/D05.dsc | 12 ------------ Platform/Hisilicon/HiKey/HiKey.dsc | 1 - Silicon/AMD/Styx/Library/AmdStyxLib/AmdStyxLib.inf | 1 - Silicon/AMD/Styx/Library/AmdStyxLib/AmdStyxLibSec.inf | 1 - Silicon/Hisilicon/Hisilicon.dsc.inc | 14 -------------- Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLib.inf | 1 - Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLibSec.inf | 1 - Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 5 ----- 20 files changed, 4 insertions(+), 137 deletions(-) -- 2.11.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel