mbox series

[edk2,v2,0/3] MdeModulePkg/SerialDxe: Do not fail reset when SetAttributes is not supported

Message ID 20171124162030.31156-1-julien.grall@linaro.org
Headers show
Series MdeModulePkg/SerialDxe: Do not fail reset when SetAttributes is not supported | expand

Message

Julien Grall Nov. 24, 2017, 4:20 p.m. UTC 
Hi all,

This is another attempt to fix the console issue when using UEFI in Xen guest.
This new series is based on Laszlo suggestions on the previous version
(see [1]).

Cheers,

[1] https://lists.01.org/pipermail/edk2-devel/2017-October/016181.html


Julien Grall (3):
  MdeModulePkg/SerialDxe: Describe correctly EFI_DEVICE_ERROR for
    SetAttributes
  MdeModulePkg/SerialDxe: Fix return valued in SerialSetAttributes
  MdeModulePkg/SerialDxe: Do not fail reset when SetAttributes is not
    supported

 MdeModulePkg/Universal/SerialDxe/SerialIo.c | 18 +++++++++++++++---
 1 file changed, 15 insertions(+), 3 deletions(-)

-- 
2.11.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Zeng, Star Nov. 27, 2017, 1:46 a.m. UTC | #1 
Reviewed-by: Star Zeng <star.zeng@intel.com> with some minor comments in the separated patches.


Thanks,
Star
-----Original Message-----
From: Julien Grall [mailto:julien.grall@linaro.org] 

Sent: Saturday, November 25, 2017 12:20 AM
To: Zeng, Star <star.zeng@intel.com>; Dong, Eric <eric.dong@intel.com>; pankaj.bansal@nxp.com; lersek@redhat.com; leif.lindholm@linaro.org
Cc: edk2-devel@lists.01.org; Julien Grall <julien.grall@linaro.org>
Subject: [PATCH v2 0/3] MdeModulePkg/SerialDxe: Do not fail reset when SetAttributes is not supported

Hi all,

This is another attempt to fix the console issue when using UEFI in Xen guest.
This new series is based on Laszlo suggestions on the previous version (see [1]).

Cheers,

[1] https://lists.01.org/pipermail/edk2-devel/2017-October/016181.html


Julien Grall (3):
  MdeModulePkg/SerialDxe: Describe correctly EFI_DEVICE_ERROR for
    SetAttributes
  MdeModulePkg/SerialDxe: Fix return valued in SerialSetAttributes
  MdeModulePkg/SerialDxe: Do not fail reset when SetAttributes is not
    supported

 MdeModulePkg/Universal/SerialDxe/SerialIo.c | 18 +++++++++++++++---
 1 file changed, 15 insertions(+), 3 deletions(-)

--
2.11.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Julien Grall Nov. 27, 2017, 10:39 a.m. UTC | #2 
Hi Star,

On 27/11/17 01:46, Zeng, Star wrote:
> Reviewed-by: Star Zeng <star.zeng@intel.com> with some minor comments in the separated patches.


Thank you for the review. I will resend the series with updating the 
description in the corresponding headers. Would you mind if I keep you 
reviewed-by?

Regards,

> 

> Thanks,

> Star

> -----Original Message-----

> From: Julien Grall [mailto:julien.grall@linaro.org]

> Sent: Saturday, November 25, 2017 12:20 AM

> To: Zeng, Star <star.zeng@intel.com>; Dong, Eric <eric.dong@intel.com>; pankaj.bansal@nxp.com; lersek@redhat.com; leif.lindholm@linaro.org

> Cc: edk2-devel@lists.01.org; Julien Grall <julien.grall@linaro.org>

> Subject: [PATCH v2 0/3] MdeModulePkg/SerialDxe: Do not fail reset when SetAttributes is not supported

> 

> Hi all,

> 

> This is another attempt to fix the console issue when using UEFI in Xen guest.

> This new series is based on Laszlo suggestions on the previous version (see [1]).

> 

> Cheers,

> 

> [1] https://lists.01.org/pipermail/edk2-devel/2017-October/016181.html

> 

> 

> Julien Grall (3):

>    MdeModulePkg/SerialDxe: Describe correctly EFI_DEVICE_ERROR for

>      SetAttributes

>    MdeModulePkg/SerialDxe: Fix return valued in SerialSetAttributes

>    MdeModulePkg/SerialDxe: Do not fail reset when SetAttributes is not

>      supported

> 

>   MdeModulePkg/Universal/SerialDxe/SerialIo.c | 18 +++++++++++++++---

>   1 file changed, 15 insertions(+), 3 deletions(-)

> 

> --

> 2.11.0

> 


-- 
Julien Grall
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Zeng, Star Nov. 27, 2017, 10:47 a.m. UTC | #3 
Sure. :)


Thanks,
Star
-----Original Message-----
From: Julien Grall [mailto:julien.grall@linaro.org] 

Sent: Monday, November 27, 2017 6:39 PM
To: Zeng, Star <star.zeng@intel.com>; Dong, Eric <eric.dong@intel.com>; pankaj.bansal@nxp.com; lersek@redhat.com; leif.lindholm@linaro.org
Cc: edk2-devel@lists.01.org; Ni, Ruiyu <ruiyu.ni@intel.com>
Subject: Re: [PATCH v2 0/3] MdeModulePkg/SerialDxe: Do not fail reset when SetAttributes is not supported

Hi Star,

On 27/11/17 01:46, Zeng, Star wrote:
> Reviewed-by: Star Zeng <star.zeng@intel.com> with some minor comments in the separated patches.


Thank you for the review. I will resend the series with updating the description in the corresponding headers. Would you mind if I keep you reviewed-by?

Regards,

> 

> Thanks,

> Star

> -----Original Message-----

> From: Julien Grall [mailto:julien.grall@linaro.org]

> Sent: Saturday, November 25, 2017 12:20 AM

> To: Zeng, Star <star.zeng@intel.com>; Dong, Eric 

> <eric.dong@intel.com>; pankaj.bansal@nxp.com; lersek@redhat.com; 

> leif.lindholm@linaro.org

> Cc: edk2-devel@lists.01.org; Julien Grall <julien.grall@linaro.org>

> Subject: [PATCH v2 0/3] MdeModulePkg/SerialDxe: Do not fail reset when 

> SetAttributes is not supported

> 

> Hi all,

> 

> This is another attempt to fix the console issue when using UEFI in Xen guest.

> This new series is based on Laszlo suggestions on the previous version (see [1]).

> 

> Cheers,

> 

> [1] https://lists.01.org/pipermail/edk2-devel/2017-October/016181.html

> 

> 

> Julien Grall (3):

>    MdeModulePkg/SerialDxe: Describe correctly EFI_DEVICE_ERROR for

>      SetAttributes

>    MdeModulePkg/SerialDxe: Fix return valued in SerialSetAttributes

>    MdeModulePkg/SerialDxe: Do not fail reset when SetAttributes is not

>      supported

> 

>   MdeModulePkg/Universal/SerialDxe/SerialIo.c | 18 +++++++++++++++---

>   1 file changed, 15 insertions(+), 3 deletions(-)

> 

> --

> 2.11.0

> 


--
Julien Grall
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Zeng, Star Nov. 27, 2017, 10:51 a.m. UTC | #4 
I mean not mind.

-----Original Message-----
From: Zeng, Star 

Sent: Monday, November 27, 2017 6:47 PM
To: Julien Grall <julien.grall@linaro.org>; Dong, Eric <eric.dong@intel.com>; pankaj.bansal@nxp.com; lersek@redhat.com; leif.lindholm@linaro.org
Cc: edk2-devel@lists.01.org; Ni, Ruiyu <ruiyu.ni@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: RE: [PATCH v2 0/3] MdeModulePkg/SerialDxe: Do not fail reset when SetAttributes is not supported

Sure. :)


Thanks,
Star
-----Original Message-----
From: Julien Grall [mailto:julien.grall@linaro.org]

Sent: Monday, November 27, 2017 6:39 PM
To: Zeng, Star <star.zeng@intel.com>; Dong, Eric <eric.dong@intel.com>; pankaj.bansal@nxp.com; lersek@redhat.com; leif.lindholm@linaro.org
Cc: edk2-devel@lists.01.org; Ni, Ruiyu <ruiyu.ni@intel.com>
Subject: Re: [PATCH v2 0/3] MdeModulePkg/SerialDxe: Do not fail reset when SetAttributes is not supported

Hi Star,

On 27/11/17 01:46, Zeng, Star wrote:
> Reviewed-by: Star Zeng <star.zeng@intel.com> with some minor comments in the separated patches.


Thank you for the review. I will resend the series with updating the description in the corresponding headers. Would you mind if I keep you reviewed-by?

Regards,

> 

> Thanks,

> Star

> -----Original Message-----

> From: Julien Grall [mailto:julien.grall@linaro.org]

> Sent: Saturday, November 25, 2017 12:20 AM

> To: Zeng, Star <star.zeng@intel.com>; Dong, Eric 

> <eric.dong@intel.com>; pankaj.bansal@nxp.com; lersek@redhat.com; 

> leif.lindholm@linaro.org

> Cc: edk2-devel@lists.01.org; Julien Grall <julien.grall@linaro.org>

> Subject: [PATCH v2 0/3] MdeModulePkg/SerialDxe: Do not fail reset when 

> SetAttributes is not supported

> 

> Hi all,

> 

> This is another attempt to fix the console issue when using UEFI in Xen guest.

> This new series is based on Laszlo suggestions on the previous version (see [1]).

> 

> Cheers,

> 

> [1] https://lists.01.org/pipermail/edk2-devel/2017-October/016181.html

> 

> 

> Julien Grall (3):

>    MdeModulePkg/SerialDxe: Describe correctly EFI_DEVICE_ERROR for

>      SetAttributes

>    MdeModulePkg/SerialDxe: Fix return valued in SerialSetAttributes

>    MdeModulePkg/SerialDxe: Do not fail reset when SetAttributes is not

>      supported

> 

>   MdeModulePkg/Universal/SerialDxe/SerialIo.c | 18 +++++++++++++++---

>   1 file changed, 15 insertions(+), 3 deletions(-)

> 

> --

> 2.11.0

> 


--
Julien Grall
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel