mbox series

[edk2,RFC,0/2] quirks handling for SDHCI controllers

Message ID 20171110135847.361-1-ard.biesheuvel@linaro.org
Headers show
Series quirks handling for SDHCI controllers | expand

Message

Ard Biesheuvel Nov. 10, 2017, 1:58 p.m. UTC
Many SDHCI implementations exist that are almost spec complicant, and
could be driver by the generic SD/MMC host controller driver except
for some minimal necessary init time tweaks.

Adding such tweaks to the generic driver is undesirable. On the other
hand, forking the driver for every platform that has such a SDHCI
controller is problematic when it comes to upstreaming and ongoing
maintenance (which is arguably the point of upstreaming in the first
place).

So these patches propose a workaround that is minimally invasive on the
EDK2 side, but gives platforms a lot of leeway when it comes to applying
SDHCI quirks.

Ard Biesheuvel (2):
  MdeModulePkg: introduce SD/MMC override protocol
  MdeModulePkg/SdMmcPciHcDxe: allow HC capabilities to be overridden

 MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c   | 111 +++++++++++++++++++-
 MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h   |   6 ++
 MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf |   2 +
 MdeModulePkg/Include/Protocol/SdMmcOverride.h        |  95 +++++++++++++++++
 MdeModulePkg/MdeModulePkg.dec                        |   3 +
 5 files changed, 212 insertions(+), 5 deletions(-)
 create mode 100644 MdeModulePkg/Include/Protocol/SdMmcOverride.h

-- 
2.11.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Zeng, Star Nov. 13, 2017, 3:31 a.m. UTC | #1
Hao,

Could you help do the evaluation on this RFC?


Thanks,
Star
-----Original Message-----
From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] 

Sent: Friday, November 10, 2017 9:59 PM
To: edk2-devel@lists.01.org; leif.lindholm@linaro.org; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: Gao, Liming <liming.gao@intel.com>; Zeng, Star <star.zeng@intel.com>; Tian, Feng <feng.tian@intel.com>; Dong, Eric <eric.dong@intel.com>; Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: [RFC PATCH 0/2] quirks handling for SDHCI controllers

Many SDHCI implementations exist that are almost spec complicant, and could be driver by the generic SD/MMC host controller driver except for some minimal necessary init time tweaks.

Adding such tweaks to the generic driver is undesirable. On the other hand, forking the driver for every platform that has such a SDHCI controller is problematic when it comes to upstreaming and ongoing maintenance (which is arguably the point of upstreaming in the first place).

So these patches propose a workaround that is minimally invasive on the
EDK2 side, but gives platforms a lot of leeway when it comes to applying SDHCI quirks.

Ard Biesheuvel (2):
  MdeModulePkg: introduce SD/MMC override protocol
  MdeModulePkg/SdMmcPciHcDxe: allow HC capabilities to be overridden

 MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c   | 111 +++++++++++++++++++-
 MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h   |   6 ++
 MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf |   2 +
 MdeModulePkg/Include/Protocol/SdMmcOverride.h        |  95 +++++++++++++++++
 MdeModulePkg/MdeModulePkg.dec                        |   3 +
 5 files changed, 212 insertions(+), 5 deletions(-)  create mode 100644 MdeModulePkg/Include/Protocol/SdMmcOverride.h

--
2.11.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Wu, Hao A Nov. 13, 2017, 3:37 a.m. UTC | #2
> -----Original Message-----

> From: Zeng, Star

> Sent: Monday, November 13, 2017 11:32 AM

> To: Wu, Hao A; Ard Biesheuvel; edk2-devel@lists.01.org;

> leif.lindholm@linaro.org; Kinney, Michael D

> Cc: Gao, Liming; Tian, Feng; Dong, Eric; Zeng, Star

> Subject: RE: [RFC PATCH 0/2] quirks handling for SDHCI controllers

> 

> Hao,

> 

> Could you help do the evaluation on this RFC?


Sure, I will take a look on this.

Best Regards,
Hao Wu

> 

> 

> Thanks,

> Star

> -----Original Message-----

> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]

> Sent: Friday, November 10, 2017 9:59 PM

> To: edk2-devel@lists.01.org; leif.lindholm@linaro.org; Kinney, Michael D

> <michael.d.kinney@intel.com>

> Cc: Gao, Liming <liming.gao@intel.com>; Zeng, Star <star.zeng@intel.com>;

> Tian, Feng <feng.tian@intel.com>; Dong, Eric <eric.dong@intel.com>; Ard

> Biesheuvel <ard.biesheuvel@linaro.org>

> Subject: [RFC PATCH 0/2] quirks handling for SDHCI controllers

> 

> Many SDHCI implementations exist that are almost spec complicant, and could

> be driver by the generic SD/MMC host controller driver except for some

> minimal necessary init time tweaks.

> 

> Adding such tweaks to the generic driver is undesirable. On the other hand,

> forking the driver for every platform that has such a SDHCI controller is

> problematic when it comes to upstreaming and ongoing maintenance (which is

> arguably the point of upstreaming in the first place).

> 

> So these patches propose a workaround that is minimally invasive on the

> EDK2 side, but gives platforms a lot of leeway when it comes to applying SDHCI

> quirks.

> 

> Ard Biesheuvel (2):

>   MdeModulePkg: introduce SD/MMC override protocol

>   MdeModulePkg/SdMmcPciHcDxe: allow HC capabilities to be overridden

> 

>  MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c   | 111

> +++++++++++++++++++-

>  MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h   |   6 ++

>  MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf |   2 +

>  MdeModulePkg/Include/Protocol/SdMmcOverride.h        |  95

> +++++++++++++++++

>  MdeModulePkg/MdeModulePkg.dec                        |   3 +

>  5 files changed, 212 insertions(+), 5 deletions(-)  create mode 100644

> MdeModulePkg/Include/Protocol/SdMmcOverride.h

> 

> --

> 2.11.0


_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Ard Biesheuvel Nov. 23, 2017, 10:10 a.m. UTC | #3
On 13 November 2017 at 03:37, Wu, Hao A <hao.a.wu@intel.com> wrote:
>> -----Original Message-----

>> From: Zeng, Star

>> Sent: Monday, November 13, 2017 11:32 AM

>> To: Wu, Hao A; Ard Biesheuvel; edk2-devel@lists.01.org;

>> leif.lindholm@linaro.org; Kinney, Michael D

>> Cc: Gao, Liming; Tian, Feng; Dong, Eric; Zeng, Star

>> Subject: RE: [RFC PATCH 0/2] quirks handling for SDHCI controllers

>>

>> Hao,

>>

>> Could you help do the evaluation on this RFC?

>

> Sure, I will take a look on this.

>


Any feedback?

Thanks,
Ard.
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Wu, Hao A Nov. 23, 2017, 12:55 p.m. UTC | #4
> -----Original Message-----

> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]

> Sent: Thursday, November 23, 2017 6:11 PM

> To: Wu, Hao A

> Cc: Zeng, Star; edk2-devel@lists.01.org; leif.lindholm@linaro.org; Kinney,

> Michael D; Gao, Liming; Tian, Feng; Dong, Eric

> Subject: Re: [RFC PATCH 0/2] quirks handling for SDHCI controllers

> 

> On 13 November 2017 at 03:37, Wu, Hao A <hao.a.wu@intel.com> wrote:

> >> -----Original Message-----

> >> From: Zeng, Star

> >> Sent: Monday, November 13, 2017 11:32 AM

> >> To: Wu, Hao A; Ard Biesheuvel; edk2-devel@lists.01.org;

> >> leif.lindholm@linaro.org; Kinney, Michael D

> >> Cc: Gao, Liming; Tian, Feng; Dong, Eric; Zeng, Star

> >> Subject: RE: [RFC PATCH 0/2] quirks handling for SDHCI controllers

> >>

> >> Hao,

> >>

> >> Could you help do the evaluation on this RFC?

> >

> > Sure, I will take a look on this.

> >

> 

> Any feedback?

> 


Hi Ard,

Sorry for the delayed response.

I am still collecting feedbacks internally to see if there are additional hook
points needed or other features/services that can be added to the SD/MMC
override protocol.

I think it would be better for this protocol to be general when it is
introduced, which might avoid changing the protocol frequently later.

What is your thought on this? Thanks in advance.

Best Regards,
Hao Wu

> Thanks,

> Ard.

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Ard Biesheuvel Nov. 23, 2017, 12:56 p.m. UTC | #5
On 23 November 2017 at 12:55, Wu, Hao A <hao.a.wu@intel.com> wrote:
>> -----Original Message-----

>> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]

>> Sent: Thursday, November 23, 2017 6:11 PM

>> To: Wu, Hao A

>> Cc: Zeng, Star; edk2-devel@lists.01.org; leif.lindholm@linaro.org; Kinney,

>> Michael D; Gao, Liming; Tian, Feng; Dong, Eric

>> Subject: Re: [RFC PATCH 0/2] quirks handling for SDHCI controllers

>>

>> On 13 November 2017 at 03:37, Wu, Hao A <hao.a.wu@intel.com> wrote:

>> >> -----Original Message-----

>> >> From: Zeng, Star

>> >> Sent: Monday, November 13, 2017 11:32 AM

>> >> To: Wu, Hao A; Ard Biesheuvel; edk2-devel@lists.01.org;

>> >> leif.lindholm@linaro.org; Kinney, Michael D

>> >> Cc: Gao, Liming; Tian, Feng; Dong, Eric; Zeng, Star

>> >> Subject: RE: [RFC PATCH 0/2] quirks handling for SDHCI controllers

>> >>

>> >> Hao,

>> >>

>> >> Could you help do the evaluation on this RFC?

>> >

>> > Sure, I will take a look on this.

>> >

>>

>> Any feedback?

>>

>

> Hi Ard,

>

> Sorry for the delayed response.

>

> I am still collecting feedbacks internally to see if there are additional hook

> points needed or other features/services that can be added to the SD/MMC

> override protocol.

>

> I think it would be better for this protocol to be general when it is

> introduced, which might avoid changing the protocol frequently later.

>

> What is your thought on this?


Thank you for bringing this up internally. I agree that we should
carefully consider potential use cases now and not later.

Thanks,
Ard.
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Wu, Hao A Nov. 30, 2017, 2:10 a.m. UTC | #6
> -----Original Message-----

> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]

> Sent: Thursday, November 23, 2017 8:57 PM

> To: Wu, Hao A

> Cc: Zeng, Star; edk2-devel@lists.01.org; leif.lindholm@linaro.org; Kinney,

> Michael D; Gao, Liming; Tian, Feng; Dong, Eric

> Subject: Re: [RFC PATCH 0/2] quirks handling for SDHCI controllers

> 

> On 23 November 2017 at 12:55, Wu, Hao A <hao.a.wu@intel.com> wrote:

> >> -----Original Message-----

> >> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]

> >> Sent: Thursday, November 23, 2017 6:11 PM

> >> To: Wu, Hao A

> >> Cc: Zeng, Star; edk2-devel@lists.01.org; leif.lindholm@linaro.org; Kinney,

> >> Michael D; Gao, Liming; Tian, Feng; Dong, Eric

> >> Subject: Re: [RFC PATCH 0/2] quirks handling for SDHCI controllers

> >>

> >> On 13 November 2017 at 03:37, Wu, Hao A <hao.a.wu@intel.com> wrote:

> >> >> -----Original Message-----

> >> >> From: Zeng, Star

> >> >> Sent: Monday, November 13, 2017 11:32 AM

> >> >> To: Wu, Hao A; Ard Biesheuvel; edk2-devel@lists.01.org;

> >> >> leif.lindholm@linaro.org; Kinney, Michael D

> >> >> Cc: Gao, Liming; Tian, Feng; Dong, Eric; Zeng, Star

> >> >> Subject: RE: [RFC PATCH 0/2] quirks handling for SDHCI controllers

> >> >>

> >> >> Hao,

> >> >>

> >> >> Could you help do the evaluation on this RFC?

> >> >

> >> > Sure, I will take a look on this.

> >> >

> >>

> >> Any feedback?

> >>

> >

> > Hi Ard,

> >

> > Sorry for the delayed response.

> >

> > I am still collecting feedbacks internally to see if there are additional hook

> > points needed or other features/services that can be added to the SD/MMC

> > override protocol.

> >

> > I think it would be better for this protocol to be general when it is

> > introduced, which might avoid changing the protocol frequently later.

> >

> > What is your thought on this?

> 

> Thank you for bringing this up internally. I agree that we should

> carefully consider potential use cases now and not later.


Hi Ard,

Could you help to share an code example of the consumer of this protocol
for reference?

Also, we think that it might be helpful to pass the pointer of the
EFI_SD_MMC_PASS_THRU_PROTOCOL to the SD_MMC_OVERRIDE_INVOKE_HOOK service
as an additional input parameter:

typedef
EFI_STATUS
(EFIAPI * SD_MMC_OVERRIDE_INVOKE_HOOK) (
  IN      EFI_HANDLE                       ControllerHandle,
  IN      UINT8                            Slot,
  IN      SD_MMC_OVERRIDE_HOOK             HookType,
  IN      EFI_SD_MMC_PASS_THRU_PROTOCOL    PassThru
  );

The implementation of the service can decide whether to use the PassThru
protocol.

If more hook points will be later added to the SDHCI override protocol,
they may use the EFI_SD_MMC_PASS_THRU_PROTOCOL to send additional commands
to the host controller during initialization.

Best Regards,
Hao Wu

> 

> Thanks,

> Ard.

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Wu, Hao A Nov. 30, 2017, 2:14 a.m. UTC | #7
Fix one typo in previous reply.

Best Regards,
Hao Wu

> -----Original Message-----

> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Wu,

> Hao A

> Sent: Thursday, November 30, 2017 10:11 AM

> To: Ard Biesheuvel

> Cc: Tian, Feng; Dong, Eric; edk2-devel@lists.01.org; Gao, Liming;

> leif.lindholm@linaro.org; Kinney, Michael D; Zeng, Star

> Subject: Re: [edk2] [RFC PATCH 0/2] quirks handling for SDHCI controllers

> 

> > -----Original Message-----

> > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]

> > Sent: Thursday, November 23, 2017 8:57 PM

> > To: Wu, Hao A

> > Cc: Zeng, Star; edk2-devel@lists.01.org; leif.lindholm@linaro.org; Kinney,

> > Michael D; Gao, Liming; Tian, Feng; Dong, Eric

> > Subject: Re: [RFC PATCH 0/2] quirks handling for SDHCI controllers

> >

> > On 23 November 2017 at 12:55, Wu, Hao A <hao.a.wu@intel.com> wrote:

> > >> -----Original Message-----

> > >> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]

> > >> Sent: Thursday, November 23, 2017 6:11 PM

> > >> To: Wu, Hao A

> > >> Cc: Zeng, Star; edk2-devel@lists.01.org; leif.lindholm@linaro.org; Kinney,

> > >> Michael D; Gao, Liming; Tian, Feng; Dong, Eric

> > >> Subject: Re: [RFC PATCH 0/2] quirks handling for SDHCI controllers

> > >>

> > >> On 13 November 2017 at 03:37, Wu, Hao A <hao.a.wu@intel.com> wrote:

> > >> >> -----Original Message-----

> > >> >> From: Zeng, Star

> > >> >> Sent: Monday, November 13, 2017 11:32 AM

> > >> >> To: Wu, Hao A; Ard Biesheuvel; edk2-devel@lists.01.org;

> > >> >> leif.lindholm@linaro.org; Kinney, Michael D

> > >> >> Cc: Gao, Liming; Tian, Feng; Dong, Eric; Zeng, Star

> > >> >> Subject: RE: [RFC PATCH 0/2] quirks handling for SDHCI controllers

> > >> >>

> > >> >> Hao,

> > >> >>

> > >> >> Could you help do the evaluation on this RFC?

> > >> >

> > >> > Sure, I will take a look on this.

> > >> >

> > >>

> > >> Any feedback?

> > >>

> > >

> > > Hi Ard,

> > >

> > > Sorry for the delayed response.

> > >

> > > I am still collecting feedbacks internally to see if there are additional hook

> > > points needed or other features/services that can be added to the SD/MMC

> > > override protocol.

> > >

> > > I think it would be better for this protocol to be general when it is

> > > introduced, which might avoid changing the protocol frequently later.

> > >

> > > What is your thought on this?

> >

> > Thank you for bringing this up internally. I agree that we should

> > carefully consider potential use cases now and not later.

> 

> Hi Ard,

> 

> Could you help to share an code example of the consumer of this protocol


Producer (not consumer) of the protocol actually.

> for reference?

> 

> Also, we think that it might be helpful to pass the pointer of the

> EFI_SD_MMC_PASS_THRU_PROTOCOL to the

> SD_MMC_OVERRIDE_INVOKE_HOOK service

> as an additional input parameter:

> 

> typedef

> EFI_STATUS

> (EFIAPI * SD_MMC_OVERRIDE_INVOKE_HOOK) (

>   IN      EFI_HANDLE                       ControllerHandle,

>   IN      UINT8                            Slot,

>   IN      SD_MMC_OVERRIDE_HOOK             HookType,

>   IN      EFI_SD_MMC_PASS_THRU_PROTOCOL    PassThru

>   );

> 

> The implementation of the service can decide whether to use the PassThru

> protocol.

> 

> If more hook points will be later added to the SDHCI override protocol,

> they may use the EFI_SD_MMC_PASS_THRU_PROTOCOL to send additional

> commands

> to the host controller during initialization.

> 

> Best Regards,

> Hao Wu

> 

> >

> > Thanks,

> > Ard.

> _______________________________________________

> edk2-devel mailing list

> edk2-devel@lists.01.org

> https://lists.01.org/mailman/listinfo/edk2-devel

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Zeng, Star Nov. 30, 2017, 2:15 a.m. UTC | #8
Hao,

  IN      EFI_SD_MMC_PASS_THRU_PROTOCOL    *PassThru

Right?

Thanks,
Star
-----Original Message-----
From: Wu, Hao A 

Sent: Thursday, November 30, 2017 10:11 AM
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Zeng, Star <star.zeng@intel.com>; edk2-devel@lists.01.org; leif.lindholm@linaro.org; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Tian, Feng <feng.tian@intel.com>; Dong, Eric <eric.dong@intel.com>
Subject: RE: [RFC PATCH 0/2] quirks handling for SDHCI controllers

> -----Original Message-----

> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]

> Sent: Thursday, November 23, 2017 8:57 PM

> To: Wu, Hao A

> Cc: Zeng, Star; edk2-devel@lists.01.org; leif.lindholm@linaro.org; 

> Kinney, Michael D; Gao, Liming; Tian, Feng; Dong, Eric

> Subject: Re: [RFC PATCH 0/2] quirks handling for SDHCI controllers

> 

> On 23 November 2017 at 12:55, Wu, Hao A <hao.a.wu@intel.com> wrote:

> >> -----Original Message-----

> >> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]

> >> Sent: Thursday, November 23, 2017 6:11 PM

> >> To: Wu, Hao A

> >> Cc: Zeng, Star; edk2-devel@lists.01.org; leif.lindholm@linaro.org; 

> >> Kinney, Michael D; Gao, Liming; Tian, Feng; Dong, Eric

> >> Subject: Re: [RFC PATCH 0/2] quirks handling for SDHCI controllers

> >>

> >> On 13 November 2017 at 03:37, Wu, Hao A <hao.a.wu@intel.com> wrote:

> >> >> -----Original Message-----

> >> >> From: Zeng, Star

> >> >> Sent: Monday, November 13, 2017 11:32 AM

> >> >> To: Wu, Hao A; Ard Biesheuvel; edk2-devel@lists.01.org; 

> >> >> leif.lindholm@linaro.org; Kinney, Michael D

> >> >> Cc: Gao, Liming; Tian, Feng; Dong, Eric; Zeng, Star

> >> >> Subject: RE: [RFC PATCH 0/2] quirks handling for SDHCI 

> >> >> controllers

> >> >>

> >> >> Hao,

> >> >>

> >> >> Could you help do the evaluation on this RFC?

> >> >

> >> > Sure, I will take a look on this.

> >> >

> >>

> >> Any feedback?

> >>

> >

> > Hi Ard,

> >

> > Sorry for the delayed response.

> >

> > I am still collecting feedbacks internally to see if there are 

> > additional hook points needed or other features/services that can be 

> > added to the SD/MMC override protocol.

> >

> > I think it would be better for this protocol to be general when it 

> > is introduced, which might avoid changing the protocol frequently later.

> >

> > What is your thought on this?

> 

> Thank you for bringing this up internally. I agree that we should 

> carefully consider potential use cases now and not later.


Hi Ard,

Could you help to share an code example of the consumer of this protocol for reference?

Also, we think that it might be helpful to pass the pointer of the EFI_SD_MMC_PASS_THRU_PROTOCOL to the SD_MMC_OVERRIDE_INVOKE_HOOK service as an additional input parameter:

typedef
EFI_STATUS
(EFIAPI * SD_MMC_OVERRIDE_INVOKE_HOOK) (
  IN      EFI_HANDLE                       ControllerHandle,
  IN      UINT8                            Slot,
  IN      SD_MMC_OVERRIDE_HOOK             HookType,
  IN      EFI_SD_MMC_PASS_THRU_PROTOCOL    PassThru
  );

The implementation of the service can decide whether to use the PassThru protocol.

If more hook points will be later added to the SDHCI override protocol, they may use the EFI_SD_MMC_PASS_THRU_PROTOCOL to send additional commands to the host controller during initialization.

Best Regards,
Hao Wu

> 

> Thanks,

> Ard.

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Wu, Hao A Nov. 30, 2017, 2:16 a.m. UTC | #9
> -----Original Message-----

> From: Zeng, Star

> Sent: Thursday, November 30, 2017 10:15 AM

> To: Wu, Hao A; Ard Biesheuvel

> Cc: edk2-devel@lists.01.org; leif.lindholm@linaro.org; Kinney, Michael D; Gao,

> Liming; Tian, Feng; Dong, Eric; Zeng, Star

> Subject: RE: [RFC PATCH 0/2] quirks handling for SDHCI controllers

> 

> Hao,

> 

>   IN      EFI_SD_MMC_PASS_THRU_PROTOCOL    *PassThru

> 

> Right?


Yes. Sorry for the typo.

Best Regards,
Hao Wu

> 

> Thanks,

> Star

> -----Original Message-----

> From: Wu, Hao A

> Sent: Thursday, November 30, 2017 10:11 AM

> To: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> Cc: Zeng, Star <star.zeng@intel.com>; edk2-devel@lists.01.org;

> leif.lindholm@linaro.org; Kinney, Michael D <michael.d.kinney@intel.com>;

> Gao, Liming <liming.gao@intel.com>; Tian, Feng <feng.tian@intel.com>; Dong,

> Eric <eric.dong@intel.com>

> Subject: RE: [RFC PATCH 0/2] quirks handling for SDHCI controllers

> 

> > -----Original Message-----

> > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]

> > Sent: Thursday, November 23, 2017 8:57 PM

> > To: Wu, Hao A

> > Cc: Zeng, Star; edk2-devel@lists.01.org; leif.lindholm@linaro.org;

> > Kinney, Michael D; Gao, Liming; Tian, Feng; Dong, Eric

> > Subject: Re: [RFC PATCH 0/2] quirks handling for SDHCI controllers

> >

> > On 23 November 2017 at 12:55, Wu, Hao A <hao.a.wu@intel.com> wrote:

> > >> -----Original Message-----

> > >> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]

> > >> Sent: Thursday, November 23, 2017 6:11 PM

> > >> To: Wu, Hao A

> > >> Cc: Zeng, Star; edk2-devel@lists.01.org; leif.lindholm@linaro.org;

> > >> Kinney, Michael D; Gao, Liming; Tian, Feng; Dong, Eric

> > >> Subject: Re: [RFC PATCH 0/2] quirks handling for SDHCI controllers

> > >>

> > >> On 13 November 2017 at 03:37, Wu, Hao A <hao.a.wu@intel.com> wrote:

> > >> >> -----Original Message-----

> > >> >> From: Zeng, Star

> > >> >> Sent: Monday, November 13, 2017 11:32 AM

> > >> >> To: Wu, Hao A; Ard Biesheuvel; edk2-devel@lists.01.org;

> > >> >> leif.lindholm@linaro.org; Kinney, Michael D

> > >> >> Cc: Gao, Liming; Tian, Feng; Dong, Eric; Zeng, Star

> > >> >> Subject: RE: [RFC PATCH 0/2] quirks handling for SDHCI

> > >> >> controllers

> > >> >>

> > >> >> Hao,

> > >> >>

> > >> >> Could you help do the evaluation on this RFC?

> > >> >

> > >> > Sure, I will take a look on this.

> > >> >

> > >>

> > >> Any feedback?

> > >>

> > >

> > > Hi Ard,

> > >

> > > Sorry for the delayed response.

> > >

> > > I am still collecting feedbacks internally to see if there are

> > > additional hook points needed or other features/services that can be

> > > added to the SD/MMC override protocol.

> > >

> > > I think it would be better for this protocol to be general when it

> > > is introduced, which might avoid changing the protocol frequently later.

> > >

> > > What is your thought on this?

> >

> > Thank you for bringing this up internally. I agree that we should

> > carefully consider potential use cases now and not later.

> 

> Hi Ard,

> 

> Could you help to share an code example of the consumer of this protocol for

> reference?

> 

> Also, we think that it might be helpful to pass the pointer of the

> EFI_SD_MMC_PASS_THRU_PROTOCOL to the

> SD_MMC_OVERRIDE_INVOKE_HOOK service as an additional input parameter:

> 

> typedef

> EFI_STATUS

> (EFIAPI * SD_MMC_OVERRIDE_INVOKE_HOOK) (

>   IN      EFI_HANDLE                       ControllerHandle,

>   IN      UINT8                            Slot,

>   IN      SD_MMC_OVERRIDE_HOOK             HookType,

>   IN      EFI_SD_MMC_PASS_THRU_PROTOCOL    PassThru

>   );

> 

> The implementation of the service can decide whether to use the PassThru

> protocol.

> 

> If more hook points will be later added to the SDHCI override protocol, they

> may use the EFI_SD_MMC_PASS_THRU_PROTOCOL to send additional

> commands to the host controller during initialization.

> 

> Best Regards,

> Hao Wu

> 

> >

> > Thanks,

> > Ard.

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Ard Biesheuvel Nov. 30, 2017, 6:45 a.m. UTC | #10
On 30 November 2017 at 02:16, Wu, Hao A <hao.a.wu@intel.com> wrote:
>> -----Original Message-----

>> From: Zeng, Star

>> Sent: Thursday, November 30, 2017 10:15 AM

>> To: Wu, Hao A; Ard Biesheuvel

>> Cc: edk2-devel@lists.01.org; leif.lindholm@linaro.org; Kinney, Michael D; Gao,

>> Liming; Tian, Feng; Dong, Eric; Zeng, Star

>> Subject: RE: [RFC PATCH 0/2] quirks handling for SDHCI controllers

>>

>> Hao,

>>

>>   IN      EFI_SD_MMC_PASS_THRU_PROTOCOL    *PassThru

>>

>> Right?

>

> Yes. Sorry for the typo.

>

> Best Regards,

> Hao Wu

>

>>

>> Thanks,

>> Star


Hello Hao, Star,

Please check the link for an example producer of the SD/MMC override protocol

https://lists.01.org/pipermail/edk2-devel/2017-November/017672.html

Thanks,
Ard.

>> -----Original Message-----

>> From: Wu, Hao A

>> Sent: Thursday, November 30, 2017 10:11 AM

>> To: Ard Biesheuvel <ard.biesheuvel@linaro.org>

>> Cc: Zeng, Star <star.zeng@intel.com>; edk2-devel@lists.01.org;

>> leif.lindholm@linaro.org; Kinney, Michael D <michael.d.kinney@intel.com>;

>> Gao, Liming <liming.gao@intel.com>; Tian, Feng <feng.tian@intel.com>; Dong,

>> Eric <eric.dong@intel.com>

>> Subject: RE: [RFC PATCH 0/2] quirks handling for SDHCI controllers

>>

>> > -----Original Message-----

>> > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]

>> > Sent: Thursday, November 23, 2017 8:57 PM

>> > To: Wu, Hao A

>> > Cc: Zeng, Star; edk2-devel@lists.01.org; leif.lindholm@linaro.org;

>> > Kinney, Michael D; Gao, Liming; Tian, Feng; Dong, Eric

>> > Subject: Re: [RFC PATCH 0/2] quirks handling for SDHCI controllers

>> >

>> > On 23 November 2017 at 12:55, Wu, Hao A <hao.a.wu@intel.com> wrote:

>> > >> -----Original Message-----

>> > >> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]

>> > >> Sent: Thursday, November 23, 2017 6:11 PM

>> > >> To: Wu, Hao A

>> > >> Cc: Zeng, Star; edk2-devel@lists.01.org; leif.lindholm@linaro.org;

>> > >> Kinney, Michael D; Gao, Liming; Tian, Feng; Dong, Eric

>> > >> Subject: Re: [RFC PATCH 0/2] quirks handling for SDHCI controllers

>> > >>

>> > >> On 13 November 2017 at 03:37, Wu, Hao A <hao.a.wu@intel.com> wrote:

>> > >> >> -----Original Message-----

>> > >> >> From: Zeng, Star

>> > >> >> Sent: Monday, November 13, 2017 11:32 AM

>> > >> >> To: Wu, Hao A; Ard Biesheuvel; edk2-devel@lists.01.org;

>> > >> >> leif.lindholm@linaro.org; Kinney, Michael D

>> > >> >> Cc: Gao, Liming; Tian, Feng; Dong, Eric; Zeng, Star

>> > >> >> Subject: RE: [RFC PATCH 0/2] quirks handling for SDHCI

>> > >> >> controllers

>> > >> >>

>> > >> >> Hao,

>> > >> >>

>> > >> >> Could you help do the evaluation on this RFC?

>> > >> >

>> > >> > Sure, I will take a look on this.

>> > >> >

>> > >>

>> > >> Any feedback?

>> > >>

>> > >

>> > > Hi Ard,

>> > >

>> > > Sorry for the delayed response.

>> > >

>> > > I am still collecting feedbacks internally to see if there are

>> > > additional hook points needed or other features/services that can be

>> > > added to the SD/MMC override protocol.

>> > >

>> > > I think it would be better for this protocol to be general when it

>> > > is introduced, which might avoid changing the protocol frequently later.

>> > >

>> > > What is your thought on this?

>> >

>> > Thank you for bringing this up internally. I agree that we should

>> > carefully consider potential use cases now and not later.

>>

>> Hi Ard,

>>

>> Could you help to share an code example of the consumer of this protocol for

>> reference?

>>

>> Also, we think that it might be helpful to pass the pointer of the

>> EFI_SD_MMC_PASS_THRU_PROTOCOL to the

>> SD_MMC_OVERRIDE_INVOKE_HOOK service as an additional input parameter:

>>

>> typedef

>> EFI_STATUS

>> (EFIAPI * SD_MMC_OVERRIDE_INVOKE_HOOK) (

>>   IN      EFI_HANDLE                       ControllerHandle,

>>   IN      UINT8                            Slot,

>>   IN      SD_MMC_OVERRIDE_HOOK             HookType,

>>   IN      EFI_SD_MMC_PASS_THRU_PROTOCOL    PassThru

>>   );

>>

>> The implementation of the service can decide whether to use the PassThru

>> protocol.

>>

>> If more hook points will be later added to the SDHCI override protocol, they

>> may use the EFI_SD_MMC_PASS_THRU_PROTOCOL to send additional

>> commands to the host controller during initialization.

>>

>> Best Regards,

>> Hao Wu

>>

>> >

>> > Thanks,

>> > Ard.

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel