From patchwork Thu Mar 15 07:17:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: gary guo X-Patchwork-Id: 131753 Delivered-To: patch@linaro.org Received: by 10.46.84.17 with SMTP id i17csp758801ljb; Thu, 15 Mar 2018 00:18:11 -0700 (PDT) X-Google-Smtp-Source: AG47ELuTTUnQWaCWzWWgCyp1TIUS9/NFHlq91p2fR7l3hKkjwci4QZfiT6+46N6LLlZo45N9wn21 X-Received: by 10.99.167.6 with SMTP id d6mr2888139pgf.408.1521098291107; Thu, 15 Mar 2018 00:18:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521098291; cv=none; d=google.com; s=arc-20160816; b=XlxuQ8DbH97AC5NYDivSzGSGFQWkn8JMPTbRhBIqaNXapX4cmi60lj6pObehywmjhH DrAatacxbK0j0a/bwLSBQcTyZXko4P+Mo26ehV16PswTea12HJK7gq5eInyhIRX3xmU4 Y+ZXtZ8W66GuDMtCrE2CsstfyQbO7P00g+i5uGeEAqIp8lfYRE2lwrArsLtD4IGoS3r+ 58KBOXExTu2ZaA8kYmuISZCNKjK+8iQCzfYg6DjWzjGeamoy4vu2+2rqcJygCcsv7P6O rj8UEkO08WImfqjCRKdowyuh18s64nIPDPVLBaaDBQCRLNB2aZFjinIZztE0b1XLGsmL Z96w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:dkim-signature :delivered-to:arc-authentication-results; bh=/NAViIJUoJQVbL4t9/yMrbNorOvHghUq8AJS3LSc00Y=; b=KopD2VvSOHDYxsoIK/+m4Y5PbpQO7GQfWQkGTFu2dTjXE44fEY/odqMBTL6SfZcKcV rleAcBrKuqhGp386E9MVaEZ/c8UIgJ6Jkt7bjTuU6oeTwRj/eHoG4n++KpCviDZb/W+x pTkg+JO/Ke3mOwaS4D+yX/lt864l0GBRzqVZ/KxDxS5UqKYBz3Tj9cL6GpBcBq2O7DO7 T/IjKQbcpRTN1PCdLiCNUTJ4BoIqEQ7Y0FyLLmvEhDWZYG0bHvxz/t47Xlz4ioDh1oCo Fh1QNWL8+Qw8O+v0EK2WrM8PE4dbya+f1SgkkC2D3SVnB7LhJpJabL0UcybtAo/68t8i dN4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=F5yrcqkd; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id l59-v6si3457342plb.77.2018.03.15.00.18.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Mar 2018 00:18:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=F5yrcqkd; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 71D042202E4BA; Thu, 15 Mar 2018 00:11:46 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:400e:c01::233; helo=mail-pl0-x233.google.com; envelope-from=heyi.guo@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pl0-x233.google.com (mail-pl0-x233.google.com [IPv6:2607:f8b0:400e:c01::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D68A62202E48B for ; Thu, 15 Mar 2018 00:11:44 -0700 (PDT) Received: by mail-pl0-x233.google.com with SMTP id w15-v6so3235180plq.9 for ; Thu, 15 Mar 2018 00:18:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=yzN+E7QCsnxIR7TKvr2EOcemtWKYwI6S9XDUUxUig1M=; b=F5yrcqkdfNhoNCl6o6IBGLgbFeWaH581g73VrNfDUF5I8+KQBpVbJkB45NjCRGLeD0 /JiSUZ85lOh6WD16KsM+am14d12U1yXdkY2jnJGxIXa105PkfuAp6uVm7ptbUK/SDF4R TPPB1dgR41RrCbMuFo7QmK/TPweO7WlB5jKKA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=yzN+E7QCsnxIR7TKvr2EOcemtWKYwI6S9XDUUxUig1M=; b=dB7/tX8s0D9ffzziFAMs0LbNJ41njb3WyBWwGkZR9D5OoEbRebRcc2uDS3a4BrgaJv CLxKE4vF2qZ2thrm5A2fEgfU7WzAVQ9QK/6YhSPri4f6YNAyoKW1rosoNQAsGuXeMPb1 oWKr7qtg6cUFzy1bzzCwAwhnqs05xNJ9yz9maR6YXmr5cp52drxkqFQZ24rKHi+rFFEm epbXhL7NnpK4koJH3m74bhR7WKQuszW9VczzxCrY210F8+JNW9B1I3X4zje2pZlCRhUd /TddJ4lSsQQ0DI7T9ugGxp6f4UOS+tAV7pyYN32/vY8mqDc4VjP+17xszvEGaFVdxAeE ZW9Q== X-Gm-Message-State: AElRT7Ghic5bakYam2OmMSZ0RZh+cKTMSjUxa0cq0UivVRVYB1X+CcjZ EfQLzuv9JW5n4LiKgqVZZREytzWz5PM= X-Received: by 2002:a17:902:ab89:: with SMTP id f9-v6mr6900366plr.369.1521098288001; Thu, 15 Mar 2018 00:18:08 -0700 (PDT) Received: from localhost.localdomain ([45.56.152.100]) by smtp.gmail.com with ESMTPSA id i186sm9026113pfg.25.2018.03.15.00.18.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 15 Mar 2018 00:18:07 -0700 (PDT) From: Heyi Guo To: edk2-devel@lists.01.org Date: Thu, 15 Mar 2018 15:17:42 +0800 Message-Id: <1521098263-52823-1-git-send-email-heyi.guo@linaro.org> X-Mailer: git-send-email 2.7.4 Subject: [edk2] [PATCH v3 0/1] ArmPkg/TimerDxe: Add ISB for timer compare value reload X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marc Zyngier , Heyi Guo , Leif Lindholm , Ard Biesheuvel MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" After rebasing to edk2 commit 5e3719a, we found D05 would hang after printing a lot of "Spurious interrupt" messages. The issue would gone away if we restored the removal of "enable interrupt source": gInterrupt->EnableInterruptSource (gInterrupt, Source); It can also be fixed if we add a "ISB" after reloading timer compare value, and we agree that it makes sense to do that. v3: - Implement 1 comment from Marc. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Marc Zyngier Heyi Guo (1): ArmPkg/TimerDxe: Add ISB for timer compare value reload ArmPkg/Drivers/TimerDxe/TimerDxe.c | 1 + 1 file changed, 1 insertion(+) -- 2.7.4 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel